From d947ec1113b10276e522a4e29be303d61a688299 Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Sat, 10 Oct 2026 00:48:23 -0500 Subject: [PATCH] queue: revs 298-301, row 51 round 1 in review (dewey) Rev 299 is a failed first request: no credential file was set, so nothing was sent. Rev 301 posted the request as comment 27068. Co-Authored-By: Claude Opus 5.5 --- docs/plans/QUEUE.md | 4 +- docs/plans/queue.json | 155 ++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 152 insertions(+), 7 deletions(-) diff --git a/docs/plans/QUEUE.md b/docs/plans/QUEUE.md index 89017f55..cdee5f1f 100644 --- a/docs/plans/QUEUE.md +++ b/docs/plans/QUEUE.md @@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here. -Generated from `docs/plans/queue.json` revision 297 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. +Generated from `docs/plans/queue.json` revision 301 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. | # | Piece | Owner | Issues | State | After | Gate | Brief | Note | |---|---|---|---|---|---|---|---|---| @@ -87,7 +87,7 @@ Generated from `docs/plans/queue.json` revision 297 by `queue render`. Do not ed | 48 | Test hygiene: commit.test exit wait and test-task Docker skip | sage; reviewers darkwing, filbert | #1534 | briefed | — | darkwing and filbert approve on #1534; queue node suite and every test-*.sh green, test-task shown with and without Docker (sage) | `docs/plans/2026-10-10_s5-follow-up-and-hygiene.md` § Test hygiene: commit.test exit wait and test-task Docker skip | Filbert's row 41 round 1 notes | | 49 | Bus comment cursor across restarts | sage; reviewers darkwing, filbert | #1535 | queued | 41 done | darkwing and filbert approve on #1535; bus, tasks and every test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-10_s5-follow-up-and-hygiene.md` § Bus comment cursor across restarts | found in Q14 cutover planning; after S6 | | 50 | Cohort scope release after a force stop | dewey; reviewers darkwing, filbert | #1536 | done | 47 done | darkwing and filbert approve on #1536; conversation, webui and every test-*.sh green on Sage's gate rerun; no mosaic-chat scope left after the suites (sage) | `docs/plans/2026-10-10_cohort-scope-release.md` § Cohort scope release after a force stop | Dewey's row 47 finding, comment 27037 | -| 51 | Cohort release follow-ups: engine exit, crash window and close | dewey; reviewers darkwing, filbert | #1537 | in-progress | 50 done | darkwing and filbert approve on #1537; conversation, webui and every test-*.sh green on Sage's gate rerun; no mosaic-chat scope left after the suites (sage) | `docs/plans/2026-10-10_cohort-release-follow-ups.md` § Cohort release follow-ups: engine exit, crash window and close | Row 50 deviation and review follow-ups, comment 27054 | +| 51 | Cohort release follow-ups: engine exit, crash window and close | dewey; reviewers darkwing, filbert | #1537 | in-review, round 1, request posted | 50 done | darkwing and filbert approve on #1537; conversation, webui and every test-*.sh green on Sage's gate rerun; no mosaic-chat scope left after the suites (sage) | `docs/plans/2026-10-10_cohort-release-follow-ups.md` § Cohort release follow-ups: engine exit, crash window and close | Row 50 deviation and review follow-ups, comment 27054 | | 52 | CHAT-01 engine-exit stop and release at engine exit | dewey; reviewers darkwing, filbert | #1538 | briefed | 51 done | darkwing and filbert approve on #1538 naming the four CHAT-01 hashes; chat-01 check.mjs passes; conversation, webui and every test-*.sh green on Sage's gate rerun; no mosaic-chat scope left after the suites (sage) | `docs/plans/2026-10-10_cohort-release-follow-ups.md` § CHAT-01 engine-exit stop and release at engine exit | Decision 79, split from row 51 | diff --git a/docs/plans/queue.json b/docs/plans/queue.json index 46f320b6..7f28ae72 100644 --- a/docs/plans/queue.json +++ b/docs/plans/queue.json @@ -1,7 +1,7 @@ { "version": 1, "canonicalRoot": "/mnt/storage/src/mosaic-stack", - "revision": 297, + "revision": 301, "rows": [ { "id": 1, @@ -3302,7 +3302,7 @@ "closes": [ 1537 ], - "state": "in-progress", + "state": "in-review", "previousState": null, "required": false, "requiredSince": null, @@ -3323,7 +3323,55 @@ "darkwing", "filbert" ], - "review": null, + "review": { + "rounds": [ + { + "n": 1, + "op": "dewey-51-review-1", + "by": "dewey", + "at": "2026-10-10T05:47:20.077Z", + "issue": 1537, + "candidate": { + "kind": "manifest", + "digest": "2da94e3bcb64afbc5f70fe1cc888393a32b7988afd1cf2cd977d762b47c6ebf3", + "text": "a12797977726884c3a45da034d513e7868608b63f55299e7190cd0b88a718022 agents/dewey/work/queue-51/evidence.md\ne3d4fadcbeebf0759f53521b58de10ef8c5c9e282e4894db1a99ac1b228046c1 packages/conversation/README.md\ncec736c520a8c59008e5f75e7cfa5563915bdffae7221a688fa489c75be31826 packages/conversation/src/controller.mjs\nd6f1662554eabf14c12624a76f5283989ae06d057165df32e6886eadc75b8c47 packages/conversation/tests/cohort.test.mjs\n3409fcce6ebb0281b5e018983a005b0c23b8641ba69cd25ea8aec6c161870d3b packages/conversation/tests/ctrl-child.mjs\n" + }, + "request": "comment", + "attempts": [ + { + "op": "dewey-51-review-1", + "by": "dewey", + "at": "2026-10-10T05:47:20.077Z", + "state": "failed", + "comment": null, + "transport": { + "outcome": "failed", + "status": null, + "comment": null, + "detail": "pre-send: the credential or account check failed" + }, + "resolutions": [] + }, + { + "op": "dewey-51-review-1b", + "by": "dewey", + "at": "2026-10-10T05:47:29.849Z", + "state": "posted", + "comment": 27068, + "transport": { + "outcome": "posted", + "status": 201, + "comment": 27068, + "detail": "created" + }, + "resolutions": [] + } + ], + "duplicateRisk": false, + "receipts": [] + } + ] + }, "claim": { "seat": "dewey", "op": "dewey-r51-start" @@ -3331,8 +3379,8 @@ "note": "Row 50 deviation and review follow-ups, comment 27054", "blockedReason": null, "createdAt": "2026-10-10T05:14:40.739Z", - "updatedAt": "2026-10-10T05:24:35.943Z", - "updatedBy": "sage" + "updatedAt": "2026-10-10T05:47:31.403Z", + "updatedBy": "dewey" }, { "id": 52, @@ -12067,6 +12115,103 @@ "receipt": "ok sage-r52-brief-repin-2 rev 297 row 52 brief: docs/plans/2026-10-10_cohort-release-follow-ups.md § CHAT-01 engine-exit stop and release at engine exit @42a963a7f2aa→docs/plans/2026-10-10_cohort-release-follow-ups.md § CHAT-01 engine-exit stop and release at engine exit @4a1240c2bf48" }, "viewSha": "c7579caaf91f0b724179e782993cbc04e78a393ec83ac8701c5998e13b3a2212" + }, + { + "rev": 298, + "op": "dewey-51-review-1", + "verb": "move", + "args": { + "id": 51, + "to": "in-review", + "reason": null, + "candidate": "agents/dewey/work/queue-51/candidate-manifest.sha256", + "evidence": null, + "issue": null + }, + "by": "dewey", + "at": "2026-10-10T05:47:20.077Z", + "semantics": 2, + "result": { + "row": 51, + "from": "in-progress", + "to": "in-review", + "round": 1, + "issue": 1537, + "candidate": { + "kind": "manifest", + "digest": "2da94e3bcb64afbc5f70fe1cc888393a32b7988afd1cf2cd977d762b47c6ebf3", + "text": "a12797977726884c3a45da034d513e7868608b63f55299e7190cd0b88a718022 agents/dewey/work/queue-51/evidence.md\ne3d4fadcbeebf0759f53521b58de10ef8c5c9e282e4894db1a99ac1b228046c1 packages/conversation/README.md\ncec736c520a8c59008e5f75e7cfa5563915bdffae7221a688fa489c75be31826 packages/conversation/src/controller.mjs\nd6f1662554eabf14c12624a76f5283989ae06d057165df32e6886eadc75b8c47 packages/conversation/tests/cohort.test.mjs\n3409fcce6ebb0281b5e018983a005b0c23b8641ba69cd25ea8aec6c161870d3b packages/conversation/tests/ctrl-child.mjs\n" + }, + "receipt": "ok dewey-51-review-1 rev 298 row 51 in-progress→in-review round 1 on #1537; request dewey-51-review-1 requesting" + }, + "viewSha": "7edfb0e7b706d24cea605bd5728e64cefbcec39ab2ae619c70df5a5aff821dcc" + }, + { + "rev": 299, + "op": "dewey-51-review-1.outcome", + "verb": "review-outcome", + "args": { + "id": 51, + "attempt": "dewey-51-review-1", + "outcome": "failed", + "status": null, + "comment": null, + "detail": "pre-send: the credential or account check failed" + }, + "by": "dewey", + "at": "2026-10-10T05:47:20.493Z", + "semantics": 2, + "result": { + "row": 51, + "round": 1, + "attempt": "dewey-51-review-1", + "state": "failed", + "receipt": "ok dewey-51-review-1.outcome rev 299 row 51 round 1 request dewey-51-review-1 failed" + }, + "viewSha": "db71e0ba4620dde3ddccc9477ef4028157ff845d723cc844106368cd47fdd739" + }, + { + "rev": 300, + "op": "dewey-51-review-1b", + "verb": "review-request", + "args": { + "id": 51 + }, + "by": "dewey", + "at": "2026-10-10T05:47:29.849Z", + "semantics": 2, + "result": { + "row": 51, + "round": 1, + "attempt": "dewey-51-review-1b", + "state": "requesting", + "receipt": "ok dewey-51-review-1b rev 300 row 51 round 1 request dewey-51-review-1b requesting" + }, + "viewSha": "5aca1290801caf0f3d4c5910c77559386652d320ae7623bf4d2eade7cdd537e1" + }, + { + "rev": 301, + "op": "dewey-51-review-1b.outcome", + "verb": "review-outcome", + "args": { + "id": 51, + "attempt": "dewey-51-review-1b", + "outcome": "posted", + "status": 201, + "comment": 27068, + "detail": "created" + }, + "by": "dewey", + "at": "2026-10-10T05:47:31.403Z", + "semantics": 2, + "result": { + "row": 51, + "round": 1, + "attempt": "dewey-51-review-1b", + "state": "posted", + "receipt": "ok dewey-51-review-1b.outcome rev 301 row 51 round 1 request dewey-51-review-1b posted comment 27068" + }, + "viewSha": "0e023a9b55d8613b3f700601b83c01770542f27a2d76699ea688efca27621f68" } ] }