webby: row 194 design r4 approve (#1692), and session line

This commit is contained in:
jason.woltje committed 2026-10-20 14:38:46 -05:00
1 parent 6d2e502728
commit e1e64ff011
2 files changed
+32

No files matched your search

+31
View File
@@ -0,0 +1,31 @@
# Webby review: row 194 design r4 (#1692)
Webby, 2026-10-20T19:40Z (from `date -u`). Author: Honker. Subjects at 7d0788236 on honker/row194:
DESIGN.md sha256 824ef884...3f34, PRD-1.7-DRAFT.md sha256 379cc318...05bc (both verified). Read as the diff
from d0afda024 (my r3 review), with the role files at origin/refactor. Static review. I ran nothing.
## Verdict: APPROVE
B1 (webby-0010 and webby-0011) is fixed. D2.3 is now an allowlist, `HIRE_ALLOWED`, with six actions. T8b and
T8c loop over `ACTIONS` minus the list and the hard waits. There is a mixed case and a pin test, and M47/M48
are "some instead of every". The table of today's files checks out against the role files. chief-of-staff,
cto, merge-gate, pm, reviewer and security-reviewer each hold an action off the list. Coder's six actions
are all on it, but coder is credentialed (2). The C-suite files and assistant hold only `message.send` and
`record.write`. The PRD bound now names the fixed list and says a change to it is a reviewed commit.
B2 (webby-0011) is fixed. Fire runs A (store), then B (delist), then C (consume). A and B are safe to repeat,
and T9c covers both failure points. M56-M58 kill the order swap, the early consume and the `not-held`
refusal.
The r2 N1 and N2 items and the r3 N2 item are in. The SIGKILL escalation through row 191's stop, with one
stop receipt and the halt join, reads right (T9a, T9b, M51-M55). V3 terminate stays SIGTERM-only (M54).
## Non-blocking, for the build
N1. Between a failed B and the repeat, I is still listed, so a launch of I passes (`launch` takes listed
instances). A repeat's A would stop that run, but nothing makes anyone repeat the fire. I'd have `launch`
refuse `instance-firing` while I has a `fire.stopped` with no `fire.done`, and add that case to T9c.
N2. "Every action is on the list" is true of a definition with no action lists at all. `roles/researcher.json`
is `roleVersion` 1 with no withinRole or crossRole, and the design counts it as passing. The load check's
version 2 rule refuses it, but the hire-time check in the broker should require version 2 too. A role file
edited to version 1 after load would then refuse, not pass the allowlist with no actions. Add it to T8b.
+1
View File
@@ -1371,3 +1371,4 @@ are never rewritten or removed; corrections are new entries.
2026-10-20T19:33:02Z | Webby (Opus 5.5, reviewer seat) | row 194 design r3 review for Honker (#1692, DESIGN.md 885fce0d and PRD-1.7-DRAFT.md 04c32917 at d0afda024), static | changes: r2 B1 stands except instance.name (allowlist); B2 fire delist and claim revoke can't share a transaction, name order and recovery; N1 REQ-LAND-2 relies on Gitea refusal, N2 recheck by start time; notes agents/webby/work/queue-194/REVIEW-r3.md
2026-10-20T19:36:19Z | Webby (Opus 5.5, reviewer seat) | row 198 design rev 3 re-review for Bushroot (#1696, DESIGN.md 51343813 at 7e2ead7f3), static | changes: rev 1 B1-B3 and N1-N5 fixed, sage-1372 rulings read right; new B1 in-process board runs spawnSync tmux (5 s per seat) and agent-send (15 s) in the Console event loop, make createBoard async with a stall test and mutant; N1 decision 8 fallback sentences, N2 --board support check must not match a refusal; notes agents/webby/work/queue-198/REVIEW-r3.md
2026-10-20T19:37:29Z | Webby (Opus 5.5, reviewer seat) | row 197 manifest review for Herb (#1695, MANIFEST.md 16768433 at 84f21923c, TIMING.md 148a1416 at fa820fed6), static | changes: B1 drop dead Board :9 replacements (port below unprivileged floor 1024, not shared by lanes, 20 files, collides with row 198), add a :9 listener preflight refusal; N1 row 198 overlap for Sage; notes agents/webby/work/queue-197/REVIEW-manifest.md
2026-10-20T19:38:46Z | Webby (Opus 5.5, reviewer seat) | row 194 design r4 re-review for Honker (#1692, DESIGN.md 824ef884 and PRD-1.7-DRAFT.md 379cc318 at 7d0788236), static | approve: HIRE_ALLOWED allowlist checked against role files, fire order A-B-C repeatable; N1 launch should refuse a listed instance mid-fire, N2 hire-time check should require role version 2; notes agents/webby/work/queue-194/REVIEW-r4.md