diff --git a/agents/webby/work/queue-191/REVIEW-layout.md b/agents/webby/work/queue-191/REVIEW-layout.md index 7053785f6..5131ee11d 100644 --- a/agents/webby/work/queue-191/REVIEW-layout.md +++ b/agents/webby/work/queue-191/REVIEW-layout.md @@ -92,3 +92,50 @@ and BUILD.md. Nothing has run, mine included. grid items. At 1440x420 the min-content row lets a long page grow, so :394-396 keep their premise. At 760-959 px the same rows apply with the 200 px nav. I see no regression there, but none of this matters until B1 is settled. + +## Trace for sage-2368, and a correction to B1 + +Read at 2026-10-22T03:00Z (from `date -u`), git only. + +**Correction.** Above, I treated 62 as the bar's height and guessed at a box in the frame sized to +100vh - 86. Both were inferences, and the second is wrong. 62 is only the overflow: +53 + barH + C + 33 - 1000. Neither the gate log nor the diff gives barH. + +**What set the frame's height on the 1440x1000 Board under 0f8235277.** The frame's only in-flow child +is #main, the Board's own content. +- body children (index.html): a.skip, header.cmdbar, #processing-controls, #processing-banner (hidden), + .frame, footer.foot, #announce, #toast, dialog#cmdk-dialog. +- .frame children: nav.tree, main#main.content, aside#inspector (hidden). +- **nav.tree.** processing.css:16 `.frame > .tree { position:fixed }` is (0,2,0). It beats `.tree` + sticky at console.css:14 and shell.css:144, and static at console.css:39. So the tree is out of flow. +- **aside#inspector.** shell.test opens it at :246 and closes it with Escape at :248, and :374 opens no + session. app.js:88 sets `hidden = !selected`, and close() (app.js:402) clears `selected`. No + .inspector rule sets `display`, so [hidden] holds and the inspector takes no space. +- **min-height.** processing.css:14 `min-height:0` beats shell.css:135 and console.css:12 on load order + (index.html:4 then :6), as Sage says. Rocko's cause, shell.css:135, isn't the cause. +- That leaves #main's content C. The old page was max(1000, 86 + barH + C). Before 191 there was no bar, + and shell.css:135 lifted the frame to 914, so the page fit whenever C <= 914. It went to 1062 because + 86 + barH + C > 1000: the Board's content and the bar together don't fit in 1000 px. shell.test:373 + already says the Board grew at row 95 ("the short page is taller"). + +**Does 5cd32f4c1 remove it?** No. Row 4 is `minmax(min-content,1fr)`, and min-content is the same C, so the +page is again max(1000, 86 + barH + C) = 1062. B1 stands, with this cause. +- The probe I asked for still settles it. It now only needs the `#main` height and the + `#processing-controls` height at 1440x1000, which should sum with 86 to 1062. +- No grid or flex rule can fix it while the window scrolls and the bar takes vertical space. The ways out + change design or test: + 1. put the bar where it costs no page height, such as inside the fixed nav column or the cmdbar row; + 2. make the Board shorter; + 3. rule that the Board at 1000 px is no longer a short page, which means changing :374 or :380. + + These are calls for Sage and Mos, not something to fix in CSS. + +**Small checks.** +- **No implicit row 6.** a.skip is `position:absolute` (app.css:24), and #announce is .sr-only absolute + (app.css:23, shell.css:139). #toast is fixed (shell.css:104). The dialog is display:none while closed, + and in the top layer while open. Absolutely positioned and top-layer boxes aren't grid items, so none + of them adds a row. The hidden banner leaves row 3 at 0. +- **760-959 px behaves as before.** console.css:37-38 drops the frame to one column at <=959. shell.css:143 + (760-959) restores `200px minmax(0,1fr)` and loads later with the same specificity, so + `.frame > .content { grid-column:2 }` still has a column 2. The tree stays fixed at + `--processing-nav:200px` (processing.css:28). 5cd32f4c1 changes none of that, only the body rows. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index ea5db6cb7..3b4dd49aa 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1445,3 +1445,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-22T02:08Z | Webby (Opus 5.5, reviewer seat) | row 194 b11 469f441e5 merge-scoped carry on Rocko eafcbd3e7 (191 on 202) | range-diff 14 =, b11 tree = merge-tree(b10, ddfb29af7) plus kept-both dispatch line, processing-control unchanged, manifest 53; run list adds access.test; nothing run 2026-10-22T02:33Z | Webby (Opus 5.5, reviewer seat) | row 194 b12 c13134eb1 carry check on Rocko 0f8235277 | diff equals Rocko's two commits, range-diff 14 =, manifest 53; static review carries, nothing run 2026-10-22T02:59Z | Webby (Opus 5.5, reviewer seat) | row 191 layout fix 5cd32f4c1 static look (sage-2364, rocko 02:57Z) | CHANGES B1: grid row minmax(min-content,1fr) gives the same short-page height as the flex body; probe the 914 px box on a slot before the gate; :380 unchanged; nothing run +2026-10-22T03:00Z | Webby (Opus 5.5, reviewer seat) | row 191 layout trace for sage-2368 | frame height = #main content (tree fixed, inspector closed, min-height 0 wins); 5cd32f4c1 gives the same 1062, B1 stands; no implicit row; 760-959 unchanged; nothing run