review r1 fix: sole-authoring-path precision; storage transport/adapter disposition recorded in code and inventory doc

packages/brain/src/mission-tasks.spec.ts

@@ -2,11 +2,13 @@ import { describe, it, expect, vi } from 'vitest';
 import { createMissionTasksRepo } from './mission-tasks.js';
 
 /**
- * SHARED-CONTRACT §5.5 "mission_tasks.status write prohibition": the repo is
- * the sole write path, and it must never forward a caller-supplied status to
- * the database on create or update. Callers keep working (the field is
- * accepted and ignored), so these tests assert on what reaches the Drizzle
- * chain, not on rejection.
+ * SHARED-CONTRACT §5.5 "mission_tasks.status write prohibition": this repo is
+ * the sole path that authors mission_tasks.status from caller input (storage
+ * tier migration is row transport and preserves stored values; the generic
+ * storage adapters have no mission_tasks caller), and it must never forward a
+ * caller-supplied status to the database on create or update. Callers keep
+ * working (the field is accepted and ignored), so these tests assert on what
+ * reaches the Drizzle chain, not on rejection.
  */
 
 function makeInsertDb(returned: unknown[]) {

packages/brain/src/mission-tasks.ts

@@ -4,11 +4,17 @@ export type MissionTask = typeof missionTasks.$inferSelect;
 export type NewMissionTask = typeof missionTasks.$inferInsert;
 
 // SHARED-CONTRACT §5.1 phase 1 / §5.4: mission_tasks.status is prohibited as a
-// write source through the N-1 window. This repo is the sole write path, so the
-// field is stripped here — accepted and ignored rather than rejected, because
-// the legacy surface is frozen with existing consumers kept working
-// (tool-gateway-mapping.md §3.2). The column keeps its DB default, stays
-// declared and readable, and is retired only after no readers remain.
+// write source through the N-1 window. This repo is the sole path that authors
+// status from caller input, so the field is stripped here — accepted and
+// ignored rather than rejected, because the legacy surface is frozen with
+// existing consumers kept working (tool-gateway-mapping.md §3.2). Two other
+// surfaces touch the column and are deliberately NOT stripped:
+// packages/storage/migrate-tier.ts copies whole rows between storage tiers and
+// must preserve the stored value verbatim, and the generic table-keyed storage
+// adapters register mission_tasks but have no caller that targets it (runtime
+// callers use fixed collection constants). Neither authors a new status. The
+// column keeps its DB default, stays declared and readable, and is retired
+// only after no readers remain.
 function stripStatus<T extends { status?: unknown }>(data: T): Omit<T, 'status'> {
   const rest = { ...data };
   delete rest.status;