No threads yet.
'; + return rows.length ? `Threads unavailable.
' : 'No threads yet.
'; } const sessionPath = (thread, session) => `#/chat/threads/${thread}/sessions/${session}`; const countLabel = value => !value ? 'unavailable (count collector not installed)' : @@ -102,7 +103,7 @@ const c = current, selected = c.sessions.find(r => r.id === c.session), f = form('session:' + t.id); const clear = form('clear:' + c.key); const reason = !Number.isSafeInteger(selected?.revision) ? 'Safe clear is unavailable until its dependency is installed.' : ''; - return `Compactions: ${txt(countLabel(selected?.compactions))}
${txt(selected?.state ?? 'Session status unavailable')}${UUID.test(selected?.successor) ? ` · Open fresh successor` : ''}
${reason ? `${txt(reason)}
` : ''}${txt(clear.receipt)}
Compactions: ${txt(countLabel(selected?.compactions))}
${txt(selected?.state ?? 'Session status unavailable')}${UUID.test(selected?.successor) ? ` · Open fresh successor` : ''}
${reason ? `${txt(reason)}
` : ''}${txt(clear.receipt)}
${link('projects', t.project, current.projects.find(p => p.id === t.project)?.name ?? 'Project')} / ${txt(t.instance)}
${heading(t.name)}${libraryLine(libraryOf(current, t))}${sessionControls(t)}${sharing(t)}Reading never wakes the assistant. An accepted message is not an answer.
${threadWrites() ? `` : ''}Showing earlier history. Read forward to reach the current conversation.
' : 'Caught up to the last read.
'}${txt(receipt)}
${link('projects', t.project, current.projects.find(p => p.id === t.project)?.name ?? 'Project')} / ${txt(t.instance)}
${heading(t.name)}${libraryLine(libraryOf(current, t))}${sessionControls(t)}${sharing(t)}Reading never wakes the assistant. An accepted message is not an answer.
${threadWrites() ? `` : ''}Showing earlier history. Read forward to reach the current conversation.
' : 'Caught up to the last read.
'}${txt(receipt)}
${txt(f.receipt)}
${txt(f.receipt)}
${link('projects', c.id, p?.name ?? 'Project')}
${heading((p?.name ?? 'Project') + ' room')}${roomOpenControl(c.id)}${libraryLine(libraryOf(c))}Room members: ${(c.members ?? []).map(m => `${txt(m.name)} (@${txt(m.instance)})`).join(', ') || 'unavailable'}
Caught up to the last read.
'}${txt(s.receipt)}
${link('projects', c.id, p?.name ?? 'Project')}
${heading((p?.name ?? 'Project') + ' room')}${roomOpenControl(c.id)}${libraryLine(libraryOf(c))}Room members: ${(c.members ?? []).map(m => `${txt(m.name)} (@${txt(m.instance)})`).join(', ') || 'unavailable'}
Caught up to the last read.
'}${txt(s.receipt)}
Showing previously read chat content; it may be out of date.
'; if (c.kind === 'room') { html += c.refused ? heading('Room unavailable') : roomConversation(); } else if (c.kind === 'thread') { @@ -385,7 +392,7 @@ if (p && !c.refused) html += roomOpenControl(c.id) + threads(c.threads.filter(t => !t.shared)) + 'Business projects and your named assistant threads.
Repository: ${txt(p.repo)}
` : ''}${threads(c.threads.filter(t => t.project === p.id && !t.shared))}No projects yet.
') + 'Repository: ${txt(p.repo)}
` : ''}${threads(c.threads.filter(t => t.project === p.id && !t.shared))}Projects unavailable.
' : 'No projects yet.
') + 'Creating and sending require signed-in send mode. This Console only reads.
'; c.container.innerHTML = html + ''; @@ -408,7 +415,7 @@ updateRoomCompletion(); } function readError(err) { - return err.code === 'thread-not-owned' ? 'This thread is not available to this user.' : + return err.code === 'channel-disabled' ? channelMessage : err.code === 'thread-not-owned' ? 'This thread is not available to this user.' : err.code === 'thread-not-found' ? 'Thread not found.' : err.code === 'session-not-found' ? 'Session not found in this thread.' : 'Chat could not be read. Refresh to try again; your draft is kept.'; } @@ -425,7 +432,7 @@ paint(); return; } const old = current; - current = { container, kind, id, canSend, user, tester, chatGrants: [], thread: old && old.id === id ? old.thread : null, shared: old && old.id === id ? old.shared : false, projects: old?.projects ?? [], threads: old?.threads ?? [], repos: old?.repos ?? [], instances: old?.instances ?? [], instanceError: kind === 'project' ? 'Reading thread instances…' : '', error: '', refused: false, legacyDefault: false, sessions: old && old.id === id ? old.sessions ?? [] : [], session: match[3] ?? (old && old.id === id ? old.session : null), key: match[3] ? id + '/' + match[3] : old && old.id === id ? old.key : id }; + current = { container, kind, id, canSend, user, tester, chatGrants: [], thread: old && old.id === id ? old.thread : null, shared: old && old.id === id ? old.shared : false, projects: old?.projects ?? [], threads: old?.threads ?? [], repos: old?.repos ?? [], instances: old?.instances ?? [], instanceError: kind === 'project' ? 'Reading thread instances…' : '', error: '', readFailed: false, channelDisabled: old?.channelDisabled ?? false, refused: false, legacyDefault: old && old.id === id ? old.legacyDefault : false, sessions: old && old.id === id ? old.sessions ?? [] : [], session: match[3] ?? (old && old.id === id ? old.session : null), key: match[3] ? id + '/' + match[3] : old && old.id === id ? old.key : id }; if (navigated || !old) container.innerHTML = 'Reading chat…
'; try { if (user) { @@ -443,11 +450,12 @@ request('projects', undefined, signal), request('threads' + (kind === 'project' ? '?project=' + id : ''), undefined, signal), tester ? { rows: [] } : request('threads?shared=true' + (kind === 'project' ? '&project=' + id : ''), undefined, signal).catch(err => { - if (['signed-out', 'access-revoked'].includes(err.code)) throw err; - return { rows: [] }; + if (err.code !== 'access-revoked') err.sharedRead = true; + throw err; }), ]); if (g !== generation || out()) return; + current.channelDisabled = false; current.projects = projects.rows; const own = new Set(listed.rows.map(t => t.id)); current.threads = [...listed.rows, ...shared.rows.filter(t => !own.has(t.id)).map(t => ({ ...t, shared: true }))]; @@ -493,12 +501,13 @@ clear.record = receipt; clear.receipt = clearText(receipt); } catch (err) { if (g !== generation || out() || err.name === 'AbortError') return; - clear.receipt = `Status unavailable (${inert(err.code)}). Operation ${clear.op}; no write was retried.`; + clear.receipt = err.code === 'channel-disabled' ? `${channelMessage} Operation ${clear.op}; no write was retried.` : `Status unavailable (${inert(err.code)}). Operation ${clear.op}; no write was retried.`; } } } if (s) { if (typeof page.hasMore !== 'boolean' || !(page.after === null || UUID.test(page.after))) throw new ChatError('invalid-response'); + if (catalog) current.legacyDefault = false; const rows = after ? [...s.rows, ...page.rows] : page.rows; s.rows = [...new Map(rows.map(m => [m.id, m])).values()].slice(-200); s.after = page.after ?? s.after; s.more = page.hasMore; s.loaded = true; @@ -522,7 +531,8 @@ } catch (err) { if (err.name === 'AbortError' || out() || g !== generation) return; current.instances = []; - current.instanceError = "Couldn't read the thread instances; reload to try again"; + current.instanceError = err.code === 'channel-disabled' ? channelMessage : "Couldn't read the thread instances; reload to try again"; + if (err.code === 'channel-disabled') current.channelDisabled = true; } } // Repository choices are optional metadata; an unavailable read must not block unlinked chat. @@ -545,13 +555,15 @@ } catch (err) { if (g !== generation || out() || err.name === 'AbortError' || err.code === 'signed-out') return; current.error = readError(err); + current.readFailed = true; + if (err.code === 'channel-disabled') current.channelDisabled = true; // A bad session selector is local to that read. Only a thread-level refusal // invalidates all sibling drafts, receipts and recovery operation keys. - if (['thread-not-owned', 'thread-not-found', 'access-refused'].includes(err.code)) { + if (!err.sharedRead && ['thread-not-owned', 'thread-not-found', 'access-refused'].includes(err.code)) { for (const key of states.keys()) if (key === id || key.startsWith(id + '/')) states.delete(key); for (const key of forms.keys()) if (key.includes(id)) forms.delete(key); } - if (err.status === 403 || err.status === 404) { + if (!err.sharedRead && (err.status === 403 || err.status === 404)) { current.projects = []; current.threads = []; current.thread = null; current.shared = false; current.refused = true; } paint(navigated); @@ -583,7 +595,7 @@ } }, true); async function write(action, key, value, path) { - if (!current || !current.canSend || out()) return; + if (!current || !current.canSend || out() || current.channelDisabled) return; const isThread = action === 'send' || action === 'open'; if ((isThread || action === 'createSession') && !threadWrites()) return; if (action === 'createProject' && current.user || action === 'createThread' && !scopeWrites(value.project, value.instance)) return; @@ -611,8 +623,9 @@ } } catch (err) { if (out() || err.code === 'signed-out') return; - s.receipt = err.sent === false ? `Not sent (${inert(err.code)}). Your draft is kept.` : - 'Outcome unknown. Read the current list or conversation before trying again. Nothing was retried; your draft is kept.'; + s.receipt = err.sent === false ? (err.code === 'channel-disabled' ? `Not sent. ${channelMessage} Your draft is kept.` : `Not sent (${inert(err.code)}). Your draft is kept.`) : + `${err.code === 'channel-disabled' ? channelMessage + ' ' : ''}Outcome unknown. Read the current list or conversation before trying again. Nothing was retried; your draft is kept.`; + if (err.code === 'channel-disabled' && current) current.channelDisabled = true; if (action === 'createSession' && err.sent === false) { s.op = null; s.payload = null; } if (err.status === 403 && ['thread-not-owned', 'access-refused'].includes(err.code)) { states.delete(key); @@ -680,7 +693,7 @@ f.receipt = op === 'share' ? 'Shared read-only.' : 'Share ended.'; if (op === 'share') f.to = ''; } catch (e) { - f.receipt = e.sent === false ? `Share refused (${inert(e.code)}).` : 'Outcome unknown. Read shares before trying again; nothing was retried.'; + f.receipt = e.sent === false ? (e.code === 'channel-disabled' ? `Share refused. ${channelMessage}` : `Share refused (${inert(e.code)}).`) : `${e.code === 'channel-disabled' ? channelMessage + ' ' : ''}Outcome unknown. Read shares before trying again; nothing was retried.`; } finally { f.pending = false; if (!out() && current?.id === id) { await refresh(); paint(); } @@ -695,7 +708,7 @@ if (out() || f.op !== op) return; f.record = r; f.receipt = clearText(r); if (current?.key === key) await refresh(); - } catch (e) { if (!out()) f.receipt = `Status unavailable (${inert(e.code)}). Operation ${f.op}; no write was retried.`; } + } catch (e) { if (!out()) f.receipt = e.code === 'channel-disabled' ? `${channelMessage} Operation ${f.op}; no write was retried.` : `Status unavailable (${inert(e.code)}). Operation ${f.op}; no write was retried.`; } if (current?.key === key) paint(); } async function cancelClear() { @@ -710,7 +723,7 @@ f.record = r; f.receipt = clearText(r); } catch (e) { if (out()) return; - f.receipt = e.sent === false ? `Cancel refused (${inert(e.code)}).` : `Outcome unknown. Check operation ${op}; cancel was not retried.`; + f.receipt = e.sent === false ? (e.code === 'channel-disabled' ? `Cancel refused. ${channelMessage}` : `Cancel refused (${inert(e.code)}).`) : `${e.code === 'channel-disabled' ? channelMessage + ' ' : ''}Outcome unknown. Check operation ${op}; cancel was not retried.`; } finally { f.pending = false; if (!out() && current?.key === key) { await refresh(); paint(); } @@ -729,7 +742,7 @@ f.record = r; f.receipt = clearText(r); } catch (e) { if (out()) return; - f.receipt = e.sent === false ? `Clear refused (${inert(e.code)}).` : `Outcome unknown. Check operation ${f.op}; nothing was retried.`; + f.receipt = e.sent === false ? (e.code === 'channel-disabled' ? `Clear refused. ${channelMessage}` : `Clear refused (${inert(e.code)}).`) : `${e.code === 'channel-disabled' ? channelMessage + ' ' : ''}Outcome unknown. Check operation ${f.op}; nothing was retried.`; if (e.sent === false) f.op = null; } finally { f.pending = false; diff --git a/packages/webui/tests/chat-browser.test.mjs b/packages/webui/tests/chat-browser.test.mjs index b020fc29f..f1eabe21f 100644 --- a/packages/webui/tests/chat-browser.test.mjs +++ b/packages/webui/tests/chat-browser.test.mjs @@ -35,7 +35,7 @@ const stub = `(() => { } window.__reads.push(path); if(window.__holdRead && path.includes(window.__holdRead)){window.__heldSignal=init.signal;await new Promise(r=>window.__releaseRead=r);} - if(window.__readFailure)return new Response(JSON.stringify({error:window.__readFailure}),{status:window.__readFailure==='thread-not-owned'?403:503}); + if(window.__readFailure && (!window.__failurePath || path.includes(window.__failurePath)))return new Response(JSON.stringify({error:window.__readFailure}),{status:['thread-not-owned','access-refused'].includes(window.__readFailure)?403:503}); if(path==='/api/chat/instances')return window.__instanceFailure ? new Response(JSON.stringify({error:'not-configured'}),{status:503}) : data({rows:window.__instances}); if(path==='/api/chat/projects')return data({rows:window.__projects}); if(path.endsWith('/sessions')){const t=path.split('/')[4];return data({rows:window.__sessions[t]||[{id:t,name:'default',default:true}]});} @@ -45,11 +45,12 @@ const stub = `(() => { return data({rows:[],after:null,hasMore:false}); }; })();`; -async function setup(t, suffix = '') { +async function setup(t, suffix = '', initial = '') { const f = await fixture(); t.after(() => f.close()); const server = await startServer({ port: 0, board: f.boardURL }); t.after(() => close(server)); const b = await browser(); t.after(() => b.close()); await b.call('Page.addScriptToEvaluateOnNewDocument', { source: stub }); + if (initial) await b.call('Page.addScriptToEvaluateOnNewDocument', { source: initial }); await b.navigate(`http://127.0.0.1:${server.address().port}/${suffix}#/chat`); const wait = expression => b.evaluate(`(async()=>{for(let i=0;i<100;i++){if(${expression})return;await new Promise(r=>setTimeout(r,30));}throw new Error(${JSON.stringify(expression)});})()`); const set = (selector, text) => b.evaluate(`(()=>{const el=document.querySelector(${JSON.stringify(selector)});el.value=${JSON.stringify(text)};el.dispatchEvent(new Event('input',{bubbles:true}));return true;})()`); @@ -63,6 +64,154 @@ async function setup(t, suffix = '') { }; return { b, wait, set, click, route, refresh }; } + +test('chat browser: initial disabled channel reports unavailable lists and does not offer creation', async t => { + const { b } = await setup(t, '', 'window.__readFailure="channel-disabled"'); + const text = await b.evaluate('document.querySelector(".chat-area").textContent'); + assert.match(text, /chat.*channel.*disabled/i); + assert.doesNotMatch(text, /No projects yet|No threads yet|mosaic plugins|SENTINEL/i); + assert.equal(await b.evaluate('document.querySelector("#chat-project-form button")?.disabled ?? true'), true); + assert.equal(await b.evaluate('window.__writes.length'), 0); +}); + +test('chat browser: refused creation keeps the draft, disables creation and recovers after refresh', async t => { + const { b, wait, set, click, refresh } = await setup(t); + await set('#chat-project-name', 'Pomodoro Timer'); + await b.evaluate('window.__answers.push({status:503,body:{error:"channel-disabled",sent:false,message:"SENTINEL private transport"}}),true'); + await click('#chat-project-form button[type=submit]'); + await wait('document.querySelector("#chat-project-form [role=status]")?.textContent.includes("Not sent")'); + assert.match(await b.evaluate('document.querySelector("#chat-project-form [role=status]").textContent'), /channel.*disabled/i); + assert.doesNotMatch(await b.evaluate('document.querySelector(".chat-area").textContent'), /SENTINEL/); + assert.equal(await b.evaluate('document.querySelector("#chat-project-name").value'), 'Pomodoro Timer'); + assert.equal(await b.evaluate('document.querySelector("#chat-project-form button").disabled'), true); + await refresh(); + await wait('!document.querySelector("#chat-project-form button").disabled'); + assert.equal(await b.evaluate('document.querySelector("#chat-project-name").value'), 'Pomodoro Timer'); + assert.equal(await b.evaluate('window.__writes.length'), 1); + await b.evaluate(`window.__answers.push({body:{id:'${P}'}}),true`); + await click('#chat-project-form button[type=submit]'); + await wait('document.querySelector("#chat-thread-form")'); + assert.equal(await b.evaluate('window.__writes[1].body.name'), 'Pomodoro Timer'); +}); + +test('chat browser: failed refresh marks cached lists stale; successful empty reads retain creation', async t => { + const { b, wait, refresh } = await setup(t); + await b.evaluate('window.__readFailure="channel-disabled";true'); + await refresh(); + await wait('document.querySelector(".chat-error")'); + const failed = await b.evaluate('document.querySelector(".chat-area").textContent'); + assert.match(failed, /channel.*disabled/i); + assert.match(failed, /previous|cached|stale/i); + assert.doesNotMatch(failed, /No projects yet|No threads yet/); + assert.equal(await b.evaluate('document.querySelector("#chat-project-form button").disabled'), true); + await b.evaluate('window.__readFailure=null;window.__projects=[];window.__threads=[];true'); + await refresh(); + await wait('document.querySelector(".chat-area").textContent.includes("No projects yet")'); + assert.match(await b.evaluate('document.querySelector(".chat-area").textContent'), /No threads yet/); + assert.equal(await b.evaluate('document.querySelector("#chat-project-form button").disabled'), false); + assert.equal(await b.evaluate('window.__writes.length'), 0); +}); + +test('chat browser: disabled thread creation retains its draft and refresh restores the action', async t => { + const { b, wait, set, click, refresh } = await setup(t); + await b.evaluate(`location.hash='#/chat/projects/${P}';true`); + await wait('document.querySelector("#chat-thread-form button") && !document.querySelector("#chat-thread-form button").disabled'); + await set('#chat-thread-name', 'planning'); + await b.evaluate('window.__answers.push({status:503,body:{error:"channel-disabled",sent:false}}),true'); + await click('#chat-thread-form button'); + await wait('document.querySelector("#chat-thread-form [role=status]").textContent.includes("Not sent")'); + assert.match(await b.evaluate('document.querySelector("#chat-thread-form [role=status]").textContent'), /channel.*disabled/i); + assert.equal(await b.evaluate('document.querySelector("#chat-thread-name").value'), 'planning'); + assert.equal(await b.evaluate('document.querySelector("#chat-thread-form button").disabled'), true); + await refresh(); + await wait('!document.querySelector("#chat-thread-form button").disabled'); + assert.equal(await b.evaluate('document.querySelector("#chat-thread-name").value'), 'planning'); + assert.equal(await b.evaluate('window.__writes.length'), 1); +}); + +test('chat browser: uncertain disabled send remains unknown, preserves draft and does not retry', async t => { + const { b, wait, set, click, route, refresh } = await setup(t); + await route(A); await set('#chat-body', 'unsure draft'); + await b.evaluate('window.__answers.push({status:503,body:{error:"channel-disabled",message:"SENTINEL"}}),true'); + await click('#chat-send-form button'); + await wait('document.querySelector("#chat-receipt").textContent.includes("Outcome unknown")'); + assert.doesNotMatch(await b.evaluate('document.querySelector("#chat-receipt").textContent'), /Not sent|SENTINEL/); + assert.equal(await b.evaluate('document.querySelector("#chat-body").value'), 'unsure draft'); + assert.equal(await b.evaluate('document.querySelector("#chat-send-form button").disabled'), true); + assert.equal(await b.evaluate('document.querySelector("#chat-session-form button").disabled'), true); + await refresh(); + await wait('!document.querySelector("#chat-send-form button").disabled'); + assert.equal(await b.evaluate('document.querySelector("#chat-body").value'), 'unsure draft'); + assert.equal(await b.evaluate('window.__writes.length'), 1); +}); + +test('chat browser: a refused send explains the disabled channel and retains the message', async t => { + const { b, wait, set, click, route } = await setup(t); + await route(A); await set('#chat-body', 'keep my message'); + await b.evaluate('window.__answers.push({status:503,body:{error:"channel-disabled",sent:false,message:"SENTINEL"}}),true'); + await click('#chat-send-form button'); + await wait('document.querySelector("#chat-receipt").textContent.includes("Not sent")'); + const receipt = await b.evaluate('document.querySelector("#chat-receipt").textContent'); + assert.match(receipt, /channel.*disabled/i); + assert.doesNotMatch(receipt, /Outcome unknown|SENTINEL/); + assert.equal(await b.evaluate('document.querySelector("#chat-body").value'), 'keep my message'); + assert.equal(await b.evaluate('document.querySelector("#chat-send-form button").disabled'), true); + assert.equal(await b.evaluate('window.__writes.length'), 1); +}); + +test('chat browser: failed shared-thread read does not claim an empty shared list', async t => { + const { b, wait, refresh } = await setup(t); + await b.evaluate('window.__failurePath="shared=true";window.__readFailure="channel-disabled";true'); + await refresh(); + await wait('document.querySelector(".chat-error")'); + const text = await b.evaluate('document.querySelector(".chat-area").textContent'); + assert.match(text, /channel.*disabled/i); + assert.doesNotMatch(text, /No threads yet/); +}); + +test('chat browser: a shared-list refusal does not discard an owned thread draft', async t => { + const { b, wait, set, route, refresh } = await setup(t); + await route(A); await set('#chat-body', 'owned thread draft'); + await b.evaluate('window.__failurePath="shared=true";window.__readFailure="access-refused";true'); + await refresh(); await wait('document.querySelector(".chat-error")'); + await b.evaluate('window.__readFailure=null;true'); + await refresh(); await wait('document.querySelector("#chat-body")'); + assert.equal(await b.evaluate('document.querySelector("#chat-body").value'), 'owned thread draft'); +}); + +test('chat browser: a refused share explains the disabled channel without exposing transport text', async t => { + const { b, wait, set, click, route } = await setup(t); + await route(A); await set('#chat-share-target', 'user:reader'); + await b.evaluate('window.__answers.push({status:503,body:{error:"channel-disabled",sent:false,message:"SENTINEL"}}),true'); + await click('#chat-share-form button'); + await wait('document.querySelector("#chat-share-form + [role=status]")?.textContent.includes("refused")'); + const receipt = await b.evaluate('document.querySelector("#chat-share-form + [role=status]").textContent'); + assert.match(receipt, /chat channel.*disabled/i); + assert.doesNotMatch(receipt, /SENTINEL/); + assert.equal(await b.evaluate('document.querySelector("#chat-share-target").value'), 'user:reader'); + assert.equal(await b.evaluate('window.__writes.length'), 1); +}); +test('chat browser: session catalog recovery restores controls and scopes drafts and messages', async t => { + const { b, wait, set, click, route, refresh } = await setup(t); + await b.evaluate('window.__failurePath="/sessions";window.__readFailure="access-refused";true'); + await route(A); + assert.match(await b.evaluate('document.querySelector(".chat-area").textContent'), /sessions.*not.*available/i); + await set('#chat-body', 'legacy draft'); + await b.evaluate(`window.__readFailure=null;window.__sessions['${A}']=[{id:'${B}',name:'default',default:true,state:'active',revision:2}];window.__pages.push({rows:[{id:'${M}',body:'session history',from_role:'assistant',at:'2026-10-18T00:00:00Z'}],after:'${M}',hasMore:false});true`); + await refresh(); + assert.equal(await b.evaluate('document.querySelector("#chat-session")?.value'), B); + assert.equal(await b.evaluate('!!document.querySelector("#chat-session-form") && !!document.querySelector("#chat-clear")'), true); + assert.match(await b.evaluate('document.querySelector(".chat-log").textContent'), /session history/); + assert.equal(await b.evaluate('document.querySelector("#chat-body").value'), '', 'legacy draft is not copied into another session'); + await set('#chat-body', 'session draft'); + await b.evaluate(`window.__answers.push({body:{id:'${P}'}}),true`); + await click('#chat-send-form button'); + await wait('document.querySelector("#chat-receipt").textContent.includes("Accepted")'); + assert.deepEqual(await b.evaluate('window.__writes[0].body'), { body: 'session draft', session: B }); + await b.evaluate('window.__readFailure="access-refused";true'); + await refresh(); + assert.equal(await b.evaluate('document.querySelector("#chat-body").value'), 'legacy draft'); +}); test('chat browser: list/create named projects and threads, hostile labels inert and no implicit writes', async t => { const { b, wait, set, click } = await setup(t); assert.equal(await b.evaluate('window.__writes.length'), 0); diff --git a/packages/webui/tests/room-browser.test.mjs b/packages/webui/tests/room-browser.test.mjs index 1e375c235..03c8a76ef 100644 --- a/packages/webui/tests/room-browser.test.mjs +++ b/packages/webui/tests/room-browser.test.mjs @@ -40,6 +40,7 @@ const stub = `(() => { if(path==='/api/library/revert'){window.__writes.push({path,body:JSON.parse(init.body)});return answer({project:'books',path:'Notes/One.md',reverted:'${SHA}',commit:'${LAST}'});} if(!path.startsWith('/api/chat/'))return real(url,init); if(method==='GET')window.__reads.push(path); + if(method==='GET' && window.__chatOffline)throw new TypeError('offline'); if(path==='/api/chat/projects')return answer({rows:window.__projects}); if(path==='/api/chat/instances')return answer({rows:window.__instances}); if(path.includes('/rooms/')){ @@ -76,6 +77,37 @@ async function setup(t, { path = `/chat/rooms/${P}`, before = '', suffix = '' } await wait(path.includes('/rooms/') ? 'document.querySelector(".chat-room")' : 'document.querySelector("#chat-thread-form")'); return { b, wait, text, set }; } +test('disabled room read shows unavailable history and disables opening', async t => { + const { b, text } = await setup(t, { before: 'window.__readError="channel-disabled";' }); + assert.match(await text('.chat-error'), /chat channel.*disabled/i); + assert.match(await text('.chat-room-log'), /unavailable/i); + assert.doesNotMatch(await text('.chat-room'), /No messages yet|Caught up to the last read/); + assert.equal(await b.evaluate('document.querySelector("#chat-room-open").disabled'), true); + assert.equal(await b.evaluate('window.__writes.length'), 0); +}); +test('room keeps a known disabled channel through a failed refresh and recovers on a successful read', async t => { + const { b, wait, text } = await setup(t); + const refresh = async () => { + await wait('!document.querySelector("#refresh").disabled'); + await b.evaluate('document.querySelector(".chat-area").dataset.beforeRefresh="yes";document.querySelector("#refresh").click();true'); + await wait('!document.querySelector(".chat-area")?.dataset.beforeRefresh'); + }; + assert.match(await text('.chat-room-log'), /Broadcast once/); + await b.evaluate('window.__readError="channel-disabled";true'); + await refresh(); + assert.match(await text('.chat-error'), /channel.*disabled/i); + assert.equal(await b.evaluate('document.querySelector("#chat-room-open").disabled'), true); + await b.evaluate('window.__readError=null;window.__chatOffline=true;true'); + await refresh(); + assert.equal(await b.evaluate('document.querySelector("#chat-room-open").disabled'), true); + await b.evaluate('document.querySelector("#chat-room-open").dispatchEvent(new MouseEvent("click",{bubbles:true}));true'); + assert.equal(await b.evaluate('window.__writes.length'), 0, 'the write guard also refuses a synthetic click'); + assert.match(await text('.chat-room-log'), /Broadcast once/); + await b.evaluate('window.__chatOffline=false;true'); + await refresh(); + assert.equal(await b.evaluate('document.querySelector("#chat-room-open").disabled'), false); + assert.equal(await b.evaluate('window.__writes.length'), 0, 'recovery reads never open a room'); +}); test('C2-10c room merges members, shows a broadcast once, reuses cited renderer and suppresses checked notice forgery', async t => { const { b, wait, text } = await setup(t); await wait('document.querySelector(".chat-cites")');