diff --git a/agents/webby/work/queue-244/REVIEW-r1.md b/agents/webby/work/queue-244/REVIEW-r1.md new file mode 100644 index 000000000..c04ee1aeb --- /dev/null +++ b/agents/webby/work/queue-244/REVIEW-r1.md @@ -0,0 +1,76 @@ +# Webby review: row 244 (#1757), round 1 + +Webby, 2026-10-21T21:40Z (from `date -u`). Author: Morgana (morgana-0053). Request comment 30154, +posted attempt sage-244-review-r1b. Request by sage-2185. Brief: docs/plans/2026-10-21_gate-env-rows.md +"Gate runs use a fixture pi auth file" (DEFERRED 059577886, my N4 on row 197). Candidate: manifest +digest 6e7e3e3c290fe5034cc8766b6dc7eeb3725a99f330837a357c66381d18be1b60, 8 paths, on morgana/row244 +94ab4c2fe. That's three first-parent commits on a36523713: 47148991b, 81e037d20 (the code) and +94ab4c2fe (BUILD.md slot results only, +24/-1). + +What I checked, without runs or a worktree: +- I took the manifest text from `queue show 244` (last round), not from the scratch path. It hashes + to the digest above. Each path's sha256 from `git show 94ab4c2fe:` matches its line, and the + modes match: test-release.sh and test-task.sh are 100755, the other six 100644. +- a36523713..94ab4c2fe touches exactly the 8 manifest paths. +- Drift against origin/refactor d37210288. a36523713..d37210288 changes none of the 8 paths. It also + leaves release.sh, scripts/lib, compose.yaml, run-task.sh and mosaic-task.mjs alone. The one nearby + path it changes is scripts/stack-release.sh (7247d80c7, row 196). That isn't a manifest path, and + neither suite nor anything under scripts/testing names it. `git merge-tree` merges 94ab4c2fe onto + d37210288 clean. +- I read the whole diff, BUILD.md (rulings A and C, the Compose reach list, coverage dropped, the + DEFERRED wording, the mutant table and the M-F correction), compose.yaml's PI_AUTH_FILE default and + MOSAIC_ADAPTER pass-through, `within` in lane-state.mjs, and the requiredSkips filter. + +Sage's slot results (sage-2147, on 81e037d20, by BUILD.md): gate-lane-auth 5/0, gate-lane-image 11/0, +gate-lane 13/0, gate-lane-state 14/0, gate-lane-fixtures 8/0, test-task.sh 91/0 with two live-skip +lines, test-release.sh 14/0. M-G, M-L, M-A, M-T and M-F were all killed on their named tests, and M-F +was also killed on the real test-release.sh (FAIL 3). I ran nothing. + +## Verdict: APPROVE + +- lane-docker.mjs:32-36, laneAuthFile. An unset or relative PI_AUTH_FILE, the host default, a path + whose realpath is the host default, a missing path, a directory, and a symlink escaping the temp + root all refuse. realpathSync on both sides plus `within` handles a symlinked temp root. An unset + value throws inside the try and reaches the same refusal. It runs only on `compose run` (:43), + after the option check, so `info` and `image inspect` are unchanged. The CLI entry passes + process.env (:66). +- gate-lane.mjs:112-114 and :184. cleanEnv sets PI_AUTH_FILE to `/pi-auth.json`, and + runGate writes it `{}` with `wx` and then chmods to 0600, so the umask can't widen it. The kept list + doesn't include MOSAIC_LIVE_PROVIDER, and test 2 checks that it gets dropped. +- test-task.sh:19-23 and test-release.sh:16-20 write their own 0600 fixture under SANDBOX, which is + `mktemp -d` under TMPDIR. In the lane that's the temp root, so the guard accepts it. Outside the + lane, the legacy gate is covered too. Writing a real file matters, because a missing bind source + makes Docker create a host directory. BUILD.md says why. +- test-release.sh:69. `"adapter":"mock"` carries the ruling A comment. The three activations pass + MOSAIC_MOCK_RESPONSE=MOSAIC_HELLO_OK. Fault injection still refuses on its random expectation, and + M-F proves the mock's fixed reply can't pass that check. +- test-task.sh. The hello and wrong-marker run records move to mock-adapters.json, which the seam + block writes first (:159). Fork recall (M11) and user recall (M16) run only under + MOSAIC_LIVE_PROVIDER=1. The skip line "skip live provider cases (row 244: ...)" doesn't match the + requiredSkips pattern (gate-lane.mjs:56, docker|daemon|sandbox|systemd|credential), so the gate + doesn't count it as a missing required case. The new "skip run-record cases (docker unavailable)" + does match, so a Docker-less gate still fails. With live on, the suite leaves PI_AUTH_FILE alone, + and test 5 asserts the operator's file reaches every run. +- gate-lane-auth.test.mjs. Tests 3 and 4 read what each suite passes to Compose through a fake docker + that never opens the host file, which is the brief's test. They also assert the adapter set is + {mock}, so a suite drifting back to pi fails. +- gate-lane-image.test.mjs passes run.env to the three guardDocker compose calls. Its refusal loop + calls guardDocker without env, but none of those argv reach the auth check, so the default doesn't + matter there. +- The coverage loss is stated. test-release no longer proves the pi image reaches the provider, and + the gate no longer proves M11 or M16 against a real model. The DEFERRED wording for Sage is in + BUILD.md. I agree that it needs an entry. A real `release.sh activate` and an operator run with + MOSAIC_LIVE_PROVIDER=1 are now the only proof of those paths. +- Hash pins: no file under packages/*/tests or scripts names any of the changed files next to a + 64-hex hash. + +## Non-blocking + +N1. HOST_PI_AUTH is a literal in lane-docker.mjs:6 and gate-lane-auth.test.mjs:12, copied from +compose.yaml:43. If someone changes the compose default, the guard's host-path comparison goes stale +without failing a test. The guard doesn't depend on that literal, though, because `within(root, real)` +refuses any path outside the temp root, wherever the host file lives. No change needed. + +N2. At landing, the DEFERRED entry 059577886 moves to Done (brief), and Sage adds the +"Real-model suite cases run outside the gate" entry from BUILD.md. Both are landing steps, not +manifest paths. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 6e1eb415b..ecddcbe59 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1425,3 +1425,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-21T15:20Z | Webby (Opus 5.5, reviewer seat) | row 197 proof driver a5b636750 (Herb, proof 4 watcher change), herb-0090 | APPROVE, N1 probe cleanup retry, N2 pin is Sage's; notes agents/webby/work/queue-197/REVIEW-proof-driver-a5b636750.md 2026-10-21T19:00Z | Webby (Opus 5.5, reviewer seat) | row 252 design r1 (Gander d218e14bd, DESIGN.md d85bd103) | APPROVE, N1-N5; notes agents/webby/work/queue-252/REVIEW-design-r1.md 2026-10-21T19:10Z | Webby (Opus 5.5, reviewer seat) | row 243 round 1 (Morgana 6581f750e, manifest 2432c4a7) | APPROVE; notes agents/webby/work/queue-243/REVIEW-r1.md +2026-10-21T21:41Z | Webby (Opus 5.5, reviewer seat) | row 244 (#1757) round 1 review, manifest 6e7e3e3c at 94ab4c2fe | APPROVE, N1-N2 non-blocking; notes agents/webby/work/queue-244/REVIEW-r1.md