test: capture remaining checkout race regressions

2026-07-31 17:50:58 -05:00
parent a0209ee102
commit ece7653ca0
3 changed files with 67 additions and 8 deletions
@@ -110,6 +110,34 @@ test('a mismatched complete hook set fails loudly instead of reporting a stale i
  assert.equal(await readFile(activeShim, 'utf8'), 'old-complete');
 });

+test('a competing successful installer is not removed by the losing process', async () => {
+  const root = await fixture('concurrent');
+  const activeShim = path.join(root, '.husky', '_', 'h');
+  let restored = false;
+
+  await assert.rejects(
+    installHooks({
+      root,
+      quarantineRoot: path.join(fixtureRoot, 'concurrent-quarantine'),
+      runHusky: async (stagingHooks) => {
+        await mkdir(path.join(stagingHooks, '_'), { recursive: true });
+        await writeFile(path.join(stagingHooks, '_', 'h'), 'ours');
+        await mkdir(path.dirname(activeShim), { recursive: true });
+        await writeFile(activeShim, 'peer');
+      },
+      activateHooks: async () => {},
+      readHooksPath: async () => null,
+      restoreHooksPath: async () => {
+        restored = true;
+      },
+    }),
+    /Hook installation failed/,
+  );
+
+  assert.equal(await readFile(activeShim, 'utf8'), 'peer');
+  assert.equal(restored, false);
+});
+
 test('an explicit interactive HUSKY=0 opt-out preserves existing hooks without running installer', async () => {
  const root = await fixture('disabled');
  const activeShim = path.join(root, '.husky', '_', 'h');