From ee00386ba108cd184b1ab5dd353b920cbbc97c78 Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Mon, 12 Oct 2026 18:31:24 -0500 Subject: [PATCH] queue: revs 853-855, row 90 round 2 in review, request comment 28054 (#1584) --- docs/plans/QUEUE.md | 4 +- docs/plans/queue.json | 117 ++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 116 insertions(+), 5 deletions(-) diff --git a/docs/plans/QUEUE.md b/docs/plans/QUEUE.md index cf6ebeb2e..4099c49ae 100644 --- a/docs/plans/QUEUE.md +++ b/docs/plans/QUEUE.md @@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here. -Generated from `docs/plans/queue.json` revision 852 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. +Generated from `docs/plans/queue.json` revision 855 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. | # | Piece | Owner | Issues | State | After | Gate | Brief | Note | |---|---|---|---|---|---|---|---|---| @@ -126,7 +126,7 @@ Generated from `docs/plans/queue.json` revision 852 by `queue render`. Do not ed | 87 | I1 design: interfaces and the I2 to I6 rows | sage; reviewers darkwing, filbert | #1581 | briefed | 86 done | darkwing and filbert approve on 1581; the design doc and the I2-I6 briefs committed, rows queued (sage) | `docs/plans/2026-10-12_i1-containerized-install.md` § I1 design: interfaces and the I2 to I6 rows | human-proof research in agents/researcher/work/i1-human-proof (1ae3020d): relay recommended; its 0666 socket lets a same-UID host process pass, and decision 95 says the containerized install closes that limit, so the design must answer it; finding 6 (nonce copy, host mode today) goes in too | | 88 | Row 61 follow-up: the field table's notes and tests | researcher; reviewers filbert | #1582 | briefed | 61 done | filbert approves on 1582 naming the candidate manifest; tasks and webui node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing (decision 109) (sage) | `docs/plans/2026-10-12_row61-followup.md` § Row 61 follow-up: the field table's notes and tests | Decision 122: Researcher builds this on Haiku 5.5 high effort after row 86 lands; Filbert reviews on Codex gpt-6.1-sol | | 89 | PM task reads that fit a session | dewey; reviewers darkwing | #1583 | done | 81 done | darkwing approves on 1583 naming the candidate manifest; bus, harness, webui and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing, live at the next bus restart (decision 109) (sage) | `docs/plans/2026-10-12_pm-task-flow.md` § PM task reads that fit a session | Also fixes the session text's built-in tools line for Claude Code (PM findings fault 9). | -| 90 | The approved requirement ids as data | dewey; reviewers filbert | #1584 | in-review, round 1, request posted | 89 done | filbert approves on 1584 naming the candidate manifest; tasks, bus, harness, webui and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing, live at the next bus restart (decision 109) (sage) | `docs/plans/2026-10-12_pm-task-flow.md` § The approved requirement ids as data | lands after row 63 (decision 125): shared paths conflict when stacked; once row 63 lands, Dewey rebases and requests round 2 from Filbert | +| 90 | The approved requirement ids as data | dewey; reviewers filbert | #1584 | in-review, round 2, request posted | 89 done | filbert approves on 1584 naming the candidate manifest; tasks, bus, harness, webui and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing, live at the next bus restart (decision 109) (sage) | `docs/plans/2026-10-12_pm-task-flow.md` § The approved requirement ids as data | lands after row 63 (decision 125): shared paths conflict when stacked; once row 63 lands, Dewey rebases and requests round 2 from Filbert | | 91 | A project checkout in each role workspace | darkwing; reviewers filbert | #1585 | briefed | 92 done | filbert approves on 1585 naming the candidate manifest; seat, cli, bus and harness node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing, live at the next bus restart (decision 109) (sage) | `docs/plans/2026-10-12_pm-task-flow.md` § A project checkout in each role workspace | Vikunja P19 #228 c78 item 6. Blocks S7 (row 42); Darkwing builds it before row 88. The coder-to-reviewer handoff is the next row. | | 92 | Role sessions confined to their own files | darkwing; reviewers dewey, filbert | #1586 | done | — | filbert and dewey approve on 1586 naming the candidate manifest; seat, cli, harness, bus and webui node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing, live at the next bus restart (decision 109) (sage) | `docs/plans/2026-10-12_session-confinement.md` § Role sessions confined to their own files | Q126 answered (decision 119): lands on ~/.config/mosaic-dev/secrets/claude-session.env; launch check accepts any ENV_ALLOW provider credential so a proxy key swaps in by file | | 93 | A review loop through the bus: push_working, request_review, fetch_review, review_verdict | filbert; reviewers darkwing, dewey | #1587 | briefed | 91 done, 95 done | darkwing and dewey approve on 1587 naming the candidate manifest; bus, harness, seat and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; live at the next bus restart, Mos's go first (sage-0104) (sage) | `docs/plans/2026-10-12_pm-test-fixes.md` § A review loop through the bus | runner.mjs: row 90 adds 'request ID' to turnRequest's header (Sage approved, outside row 90's file list); if row 90 lands first, row 93 bases its runner.mjs on it | diff --git a/docs/plans/queue.json b/docs/plans/queue.json index fc38ec65a..3139c52a7 100644 --- a/docs/plans/queue.json +++ b/docs/plans/queue.json @@ -1,7 +1,7 @@ { "version": 1, "canonicalRoot": "/mnt/storage/src/mosaic-stack", - "revision": 852, + "revision": 855, "rows": [ { "id": 1, @@ -7405,6 +7405,37 @@ "candidate": "26d1fbdf23c2ae70fd9317fe6484e7bdf4339f45b59463e66123c100dbf1ac7d" } ] + }, + { + "n": 2, + "op": "dewey-90-review-request-2", + "by": "dewey", + "at": "2026-10-12T23:30:49.277Z", + "issue": 1584, + "candidate": { + "kind": "manifest", + "digest": "95611274ff1c5d022f958f6158c5bde8f9482fa11dc6820cc749402ef326022b", + "text": "07fa600a67a59d2bb3d4c8ba8de43e002a08ca6e58c0aaef57118f0816936bdc packages/bus/README.md\nd87bfeae25bb8e2d70a8b40dc565d812fbee25e5d74e34bc8999da580b62f3f9 packages/bus/src/broker.mjs\na00fb48fd82d3df5429561e487c7ec836976814e400ed27b6226dee813171d48 packages/bus/tests/requirements.test.mjs\n031e6b5a787150de847a290843634268edb3c50f62b625cc719367a5b6c8cf42 packages/harness/src/bundle.mjs\n91069964d1455b84b8b96f5772bb348d1250f4c0a064fe4eaa720b1ee56d90f8 packages/harness/src/runner.mjs\n8394fb1a9fa95fa562bc7c538432b4cad798586c33dfbbb680f295cf950cdfce packages/harness/src/tools.mjs\nbf4e7fad255338000e703a83f12a4568e1bae0211cba187e43af0ddb1d2d99cb packages/harness/tests/bundle.test.mjs\n0ff62327f91b7dfddc4a9e8fa4c5af42d0d40e7c67ff0aabf508de2a2aa19c4a packages/harness/tests/runner.test.mjs\nb136925ffa30cf8b23e8c198ad67d3f7f122659fa35b9ac6fda063870911ec30 packages/harness/tests/tools.test.mjs\n13f938085b6ac3ecc6364dd2fb4de749509e7d22291cc970cd2121a5924fceca packages/seat/src/sandbox.mjs\n2b234b173ccb1e6f37dc4d99dbde35b5db274b86a583a24e6e18c6eab84a0430 packages/tasks/README.md\n2cd2616bd5755472355f580e42ebc0e2545dffe9c1062f617a61e22c117e86b2 packages/tasks/requirements.json\n38e7b85650247759f06c09fce205b2970b8368bc81491f51dc6b3c90ba2a846d packages/tasks/src/requirements.mjs\ncf0ce9d31c2efd1fd79c15f649801d3b6e8135310630a86901731dc364ba95eb packages/tasks/src/verbs.mjs\nf5b1b8c977e75d8129eb9e85b7c633210a83683f152632f28be0e5cb9152042a packages/tasks/tests/adapter.test.mjs\n793cb8f8acbadf2e2d741c439d01a61d7bbe13d639f133bc19d214f67bdb0fc9 packages/tasks/tests/fields.test.mjs\n5233a68d0f6d25857fd13c321b42fb3d6a1848265240a4c49c342e27161704bc packages/tasks/tests/requirements.test.mjs\n1c73baca1404f92700b341c4ad0bf6c8f92a274315e77cd044c08edeb10ccdb7 packages/tasks/tests/shapes.test.mjs\n4aad97b3914572d647f767a6f10bac4da83c3de803f2c9d2359b72e540fc8b79 packages/tasks/tests/sync.test.mjs\nece745dc9fb59d6f0a14ee862e712e51af011219e04a8406d44f463906ff5847 packages/tasks/tests/verbs.test.mjs\n73ce966340f9d4369b1c6d7854829d4cf60fdb1cb673d38287b914d107ccf053 roles/pm.md\n" + }, + "request": "comment", + "attempts": [ + { + "op": "dewey-90-review-request-2", + "by": "dewey", + "at": "2026-10-12T23:30:49.277Z", + "state": "posted", + "comment": 28054, + "transport": { + "outcome": "posted", + "status": 201, + "comment": 28054, + "detail": "created" + }, + "resolutions": [] + } + ], + "duplicateRisk": false, + "receipts": [] } ] }, @@ -7415,8 +7446,8 @@ "note": "lands after row 63 (decision 125): shared paths conflict when stacked; once row 63 lands, Dewey rebases and requests round 2 from Filbert", "blockedReason": null, "createdAt": "2026-10-12T19:38:43.564Z", - "updatedAt": "2026-10-12T22:55:06.275Z", - "updatedBy": "filbert" + "updatedAt": "2026-10-12T23:30:53.519Z", + "updatedBy": "dewey" }, { "id": 91, @@ -30888,6 +30919,86 @@ "receipt": "ok dewey-69-verdict-1 rev 852 row 69 round 1 approve by dewey (comment 28048)" }, "viewSha": "ab09442c384d7e46d8838b788d7d0002582d20bef49c2c504b8038231a6ee622" + }, + { + "rev": 853, + "op": "dewey-90-round2-reopen", + "verb": "move", + "args": { + "id": 90, + "to": "in-progress", + "reason": null, + "candidate": null, + "evidence": null, + "issue": null + }, + "by": "dewey", + "at": "2026-10-12T23:30:43.535Z", + "semantics": 2, + "result": { + "row": 90, + "from": "in-review", + "to": "in-progress", + "round": null, + "issue": null, + "candidate": null, + "receipt": "ok dewey-90-round2-reopen rev 853 row 90 in-review→in-progress" + }, + "viewSha": "1204bc2f2067326753a336326a5ffe25441fbd5d6894fc97cf13225dd0fa71d6" + }, + { + "rev": 854, + "op": "dewey-90-review-request-2", + "verb": "move", + "args": { + "id": 90, + "to": "in-review", + "reason": null, + "candidate": "agents/dewey/work/queue-90/r2/candidate-manifest.sha256", + "evidence": null, + "issue": null + }, + "by": "dewey", + "at": "2026-10-12T23:30:49.277Z", + "semantics": 2, + "result": { + "row": 90, + "from": "in-progress", + "to": "in-review", + "round": 2, + "issue": 1584, + "candidate": { + "kind": "manifest", + "digest": "95611274ff1c5d022f958f6158c5bde8f9482fa11dc6820cc749402ef326022b", + "text": "07fa600a67a59d2bb3d4c8ba8de43e002a08ca6e58c0aaef57118f0816936bdc packages/bus/README.md\nd87bfeae25bb8e2d70a8b40dc565d812fbee25e5d74e34bc8999da580b62f3f9 packages/bus/src/broker.mjs\na00fb48fd82d3df5429561e487c7ec836976814e400ed27b6226dee813171d48 packages/bus/tests/requirements.test.mjs\n031e6b5a787150de847a290843634268edb3c50f62b625cc719367a5b6c8cf42 packages/harness/src/bundle.mjs\n91069964d1455b84b8b96f5772bb348d1250f4c0a064fe4eaa720b1ee56d90f8 packages/harness/src/runner.mjs\n8394fb1a9fa95fa562bc7c538432b4cad798586c33dfbbb680f295cf950cdfce packages/harness/src/tools.mjs\nbf4e7fad255338000e703a83f12a4568e1bae0211cba187e43af0ddb1d2d99cb packages/harness/tests/bundle.test.mjs\n0ff62327f91b7dfddc4a9e8fa4c5af42d0d40e7c67ff0aabf508de2a2aa19c4a packages/harness/tests/runner.test.mjs\nb136925ffa30cf8b23e8c198ad67d3f7f122659fa35b9ac6fda063870911ec30 packages/harness/tests/tools.test.mjs\n13f938085b6ac3ecc6364dd2fb4de749509e7d22291cc970cd2121a5924fceca packages/seat/src/sandbox.mjs\n2b234b173ccb1e6f37dc4d99dbde35b5db274b86a583a24e6e18c6eab84a0430 packages/tasks/README.md\n2cd2616bd5755472355f580e42ebc0e2545dffe9c1062f617a61e22c117e86b2 packages/tasks/requirements.json\n38e7b85650247759f06c09fce205b2970b8368bc81491f51dc6b3c90ba2a846d packages/tasks/src/requirements.mjs\ncf0ce9d31c2efd1fd79c15f649801d3b6e8135310630a86901731dc364ba95eb packages/tasks/src/verbs.mjs\nf5b1b8c977e75d8129eb9e85b7c633210a83683f152632f28be0e5cb9152042a packages/tasks/tests/adapter.test.mjs\n793cb8f8acbadf2e2d741c439d01a61d7bbe13d639f133bc19d214f67bdb0fc9 packages/tasks/tests/fields.test.mjs\n5233a68d0f6d25857fd13c321b42fb3d6a1848265240a4c49c342e27161704bc packages/tasks/tests/requirements.test.mjs\n1c73baca1404f92700b341c4ad0bf6c8f92a274315e77cd044c08edeb10ccdb7 packages/tasks/tests/shapes.test.mjs\n4aad97b3914572d647f767a6f10bac4da83c3de803f2c9d2359b72e540fc8b79 packages/tasks/tests/sync.test.mjs\nece745dc9fb59d6f0a14ee862e712e51af011219e04a8406d44f463906ff5847 packages/tasks/tests/verbs.test.mjs\n73ce966340f9d4369b1c6d7854829d4cf60fdb1cb673d38287b914d107ccf053 roles/pm.md\n" + }, + "receipt": "ok dewey-90-review-request-2 rev 854 row 90 in-progress→in-review round 2 on #1584; request dewey-90-review-request-2 requesting" + }, + "viewSha": "135c9d41359db35cb40e7364c715241533f10c73c162988800666f85e2d79673" + }, + { + "rev": 855, + "op": "dewey-90-review-request-2.outcome", + "verb": "review-outcome", + "args": { + "id": 90, + "attempt": "dewey-90-review-request-2", + "outcome": "posted", + "status": 201, + "comment": 28054, + "detail": "created" + }, + "by": "dewey", + "at": "2026-10-12T23:30:53.519Z", + "semantics": 2, + "result": { + "row": 90, + "round": 2, + "attempt": "dewey-90-review-request-2", + "state": "posted", + "receipt": "ok dewey-90-review-request-2.outcome rev 855 row 90 round 2 request dewey-90-review-request-2 posted comment 28054" + }, + "viewSha": "d8e340a4872fe8083086e392c104aeb40608f4075930316dcc8ff3bc8f524f20" } ] }