From ef2098c967ed7004356095cd54394910126eee55 Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Wed, 21 Oct 2026 10:20:26 -0500 Subject: [PATCH] webby: row 197 proof driver a5b636750 review, approve, and session line --- .../REVIEW-proof-driver-a5b636750.md | 59 +++++++++++++++++++ docs/SESSIONS.md | 1 + 2 files changed, 60 insertions(+) create mode 100644 agents/webby/work/queue-197/REVIEW-proof-driver-a5b636750.md diff --git a/agents/webby/work/queue-197/REVIEW-proof-driver-a5b636750.md b/agents/webby/work/queue-197/REVIEW-proof-driver-a5b636750.md new file mode 100644 index 000000000..43352dda1 --- /dev/null +++ b/agents/webby/work/queue-197/REVIEW-proof-driver-a5b636750.md @@ -0,0 +1,59 @@ +# Webby review: row 197 proof driver, a5b636750 (proof 4 watcher change) + +Webby, 2026-10-21T15:19Z (from `date -u`). Author: Herb (herb-0090). Requested per sage-2029, sage-2034 +and sage-2035, after mos-1174. This is a review of the proof driver only. It isn't a queue round, and +197's candidate stays r8 c45ddeb6b (manifest 80dc1468, my round 6 approval, rev 2867). Candidate: +herb/row197-proof a5b636750, one commit on b8461266c. + +What I checked, without runs: +- b8461266c..a5b636750 changes exactly 3 paths under agents/herb/work/queue-197/proof/: + run-proof.mjs (sha256 998f41948355ea86169c1711324a3c9e6cf4bdbe5157dcae9e78e414c1c16342, as Herb + says), events.test.mjs (new, 7a40bb46ed4e) and BUILD.md (5ede409c4480). All three are 100644. +- None of 197's 37 manifest paths is in that range. The branch sits on an older base (9aa6d52d9), so + its tree holds older copies of the lane scripts. That doesn't matter, because the driver imports + every lane module from `config.launcherRoot` (run-proof.mjs:85-89). It also refuses a launcher + whose HEAD isn't `config.launcherCandidate` or whose checkout is dirty (:81-82). +- I read the whole diff and r8's cleanupProject (lane-docker.mjs:41-52 at c45ddeb6b). + +Herb's grant sage-2035 results (by BUILD.md and herb-0090): events.test.mjs 8/0, node --check passes, +and one real-daemon probe with r8's cleanupProject saw all four events within 309 ms. Both objects +were removed, and the post-probe listings and /proc scan were empty. I ran nothing. + +## Verdict: APPROVE + +- The defect. Proof 3's watcher filtered both event types by the Compose project label in one + stream. Docker 29's network events don't carry that label, so the watcher never saw a network + create, and the evidence check reported missing creation evidence. +- Network events (:12-14). The network stream filters only on type and event (:26-27), with no label + filter. dockerEvent keeps a network only if its name starts with `_`, so `x_...`, + `-...` and the bare project don't match (the test at events.test:15-21). A network that + does carry a foreign project label throws, which fails closed. The project is + `mg197-[ab]-<12 hex>` (:7), checked before any watcher starts (:21). A foreign network would have + to use our random id to match. +- Container events (:15). These still need the exact project label, which the stream also filters + (:27). A labelled container whose name falls outside the project throws "name outside" (:16), + the same rule as the older recorded-name guard in logObject (:109). +- Shared code. The proof's ensureWatchers now calls the same watchDockerProject (:116). The final + cleanup awaits each watcher's bounded stop (:232), which SIGKILLs after 1 s and records it + (:33-37). Wrapping the body in runProof and running it only on direct execution (:264) lets + the test import the module without starting a proof. +- The preflight (:39-64, :209-211). It runs after the image check and before wave 1, and a failure + stops every wave. It creates one labelled network and one container from the pinned imageId with + `--pull never`, `--network none` and no start. The test asserts no `start` or `build` argument + (events.test:46). Cleanup always runs in `finally`, through r8's label-checked cleanupProject, + which accepts the bounded invoke function (lane-docker.mjs:43). Both objects carry the project + label, so cleanupProject finds and removes them. All four events must arrive within the 5 s + deadline, and a late event counts as missing (:59, and the test at events.test:57-60). The result + goes into summary.json and docker-summary.json. + +## Non-blocking + +N1. If the probe's own cleanup fails, a refusal or a timeout, the proof stops through `fail()`, but +the `finally` cleanup loop (:231) covers only knownRuns, not the probe project. Leftover probe objects +would stay until someone removes them by hand. The failure is loud and watcher-probe-plan.json +(:209) names both objects, so nothing goes unseen. Adding the probe project to that loop would make +the cleanup retry once. + +N2. Herb asks Sage to update proof-phase.sh's digest pin to 998f4194...6342. That file isn't in this +commit, so I haven't checked the pin. Sage should check it against the run-proof.mjs hash before +proof 4. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index ed6cf1068..007e5dd14 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1422,3 +1422,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-21T12:04Z | Webby (Opus 5.5, reviewer seat) | row 218 (#1719) C2-12 round 3 review, doc only | APPROVE 89ba79d94 manifest 1a38baf5, N5 fixed, no new notes; notes agents/webby/work/queue-218/REVIEW-r3.md 2026-10-21T12:17Z | Webby (Opus 5.5, reviewer seat) | row 197 queue round 6 (Herb r8 c45ddeb6b, manifest 80dc1468), merge scope | APPROVE, N1 doc; notes agents/webby/work/queue-197/REVIEW-q6r8.md 2026-10-21T13:15Z | Webby (Opus 5.5, reviewer seat) | row 248 round 1 (Sage 4d99c178b, grant-executor held stubs) | APPROVE, N1 sleep 30 residual; notes agents/webby/work/queue-248/REVIEW-r1.md +2026-10-21T15:20Z | Webby (Opus 5.5, reviewer seat) | row 197 proof driver a5b636750 (Herb, proof 4 watcher change), herb-0090 | APPROVE, N1 probe cleanup retry, N2 pin is Sage's; notes agents/webby/work/queue-197/REVIEW-proof-driver-a5b636750.md