row 181 (#1679, P19 390): the restore guard counts every row a restore drops

COUNTED, next to STORE_JS, lists the 11 tables a bus writer fills without an event in the same
transaction (role_claims through usage_records, in schema order). STORE_JS count and heldcount
return events after STAMP plus each listed table after STAMP from the same open as before. A
listed table the store lacks counts 0, and one that exists but can't be read refuses
restore-mismatch.

rollback --restore refuses post-backup-events unless the total is 0 or --events equals it, and
the message names each table with rows. The in-run recount compares the same total. An
events-only store prints the old text. T46 reads every table in schema.sql and fails on a table
in no list or in two.

Filbert approved round 1 in #1679 comment 29372. Follow-ups F1 (task_comment_cursors) and F2
(the refusal text at stack-release.sh:909) are recorded in agents/darkwing/work/queue-181/BUILD.md.
This commit is contained in:
darkwing authored and Jason Woltje committed 2026-10-19 23:49:44 -05:00
1 parent d7184aeac1
commit ef48597d0e
3 files changed
+129 -16

No files matched your search

+9 -4
View File
@@ -372,6 +372,8 @@ scripts/stack-release.sh pm-on BUSINESS [--timeout S]
scripts/stack-release.sh rollback BUSINESS [--restore ACTIVATION [--events N]] [--timeout S] [--plan]
scripts/stack-release.sh status BUSINESS
common options: --copies DIR, --bin DIR
--events N is the total of the per-table counts the post-backup-events refusal prints: events and
every table in COUNTED.
```
This is an operator plan, not an action agents run. Both reviews and the
@@ -433,10 +435,13 @@ refuses `capture-failed` before it stops anything. Adopt uses the same rule.
Jason or Mos settles it from the rollback set the message names.
7. `rollback BUSINESS` returns to the copy before the pointer's, taken from
the log. When the schemas differ it needs `--restore ACTIVATION`, with or
without a `-1` to `-9` suffix; events
written after that backup need `--events N` with the count it prints, and
Jason decides first. It refuses `business-unreadable` and
`unknown-kind-for-target` like `activate`. For the second, set each kind
without a `-1` to `-9` suffix. Rows written after that backup need
`--events N`, and Jason decides first. The count covers events and every
table in `COUNTED` (row 181), the tables a bus writer fills without an
event. The `post-backup-events` refusal prints one count per table with
rows, in that order, for example `1 event(s), 1 instance_names row(s)`.
N is the total of those printed counts, read off the refusal. It refuses
`business-unreadable` and `unknown-kind-for-target` like `activate`. For the second, set each kind
it names to `null` through the live bus first, with the `plugins set`
command in step 2 of the next section.
8. Jason's plain `mosaic talk pm "..."` must print sent and a reply. Keep the