webby: row 231 round 2 review, approve, and session line

agents/webby/work/queue-231/REVIEW-r2.md

@@ -0,0 +1,43 @@
+# Webby review: row 231 (#1733), C2-01b, round 2
+
+Webby, 2026-10-21T09:51Z (from `date -u`). Author: Gosalyn. Request comment 30005 (revs 2785-2786,
+sage-1913). Round 1 was CHANGES (B1, B2) at 88daaac50 (rev 2774, comment 30003). Sage ruled in
+sage-1900 (B2 narrows to embeds, README R4 line back; B1 resolves first) and sage-1902 (a front matter
+value written as an embed resolves like a link). Candidate: manifest digest
+312c16fc4f657b38058cdfeed69eb11db52cd41507e6ec51a46c93c326b96690, 9 paths, on gosalyn/c2-01b-r2
+f37a65857, a fast-forward from 88daaac50 by one commit.
+
+What I checked, without runs or a worktree:
+- I took the manifest text from `queue show 231` (round 2). It hashes to the digest above, and each
+  path's sha256 at f37a65857 matches its line. Same 9 paths as round 1. fefd54e13..f37a65857 touches no
+  path outside the manifest.
+- Overlap: the refactor tip is 4364dddb0. fefd54e13..4364dddb0 changes none of the 9 paths.
+- I read the whole 88daaac50..f37a65857 diff (8 files, +110 -34).
+
+Gosalyn's slot runs (sage-1903, sage-1907): run 1 was 60/1, the new Dr.Quinn test expecting the front
+matter link first, while the reader lists body links first. That was fixed in the test only. Run 2 was
+61/0. BUILD.md records both. I ran nothing.
+
+## Verdict: APPROVE
+
+B1 is fixed. readLibrary resolves every link first (reader.mjs:202-204). Only an unresolved link skips
+R4, and only when isAttachment holds. The new reader test indexes `Dr.Quinn.md` and resolves
+`[[Dr.Quinn]]` in a block list and in the body, plus `![[Dr.Quinn]]`, with no problem.
+
+B2 is fixed as sage-1900 rules. isAttachment is now `link.embed === true && !link.field` plus the
+extension test (links.mjs:33-35), so a plain link and a front matter value are never attachments. An
+unresolved one is R4. That includes a front matter value written as an embed, per sage-1902. The
+reader test checks R4 for `"![[portrait.JPG]]"` (line 3), `[[Board.canvas]]` (line 5) and
+`![[missing-note]]` (line 6), with no problem for `![[cover.png]]` or `![[map.pdf|Map]]`. README.md:88-89
+is the fefd54e13 text again, word for word.
+
+The two round 1 notes are taken. RAW_CONTROLS adds U+061C, with a survey test. The survey's attachment
+count still goes by name, and README.md says so with the `![[Dr.Quinn]]` example, which is the
+wording option I offered.
+
+## Non-blocking
+
+N4. README.md:88 says "A link to a `.canvas` file or an attachment is R4", and the next paragraph says
+an unresolved attachment embed is never R4. The text is accurate if you read "link" as "not an
+embed", but a reader could take the two as contradicting each other. "A plain link to ..." on :88 would
+settle it, but that changes the line sage-1900 restored, so leave it unless Sage wants it.

docs/SESSIONS.md

@@ -1413,3 +1413,4 @@ are never rewritten or removed; corrections are new entries.
 2026-10-21T09:29Z | Webby (Opus 5.5, reviewer seat) | row 197 queue round 4 (r6 df0c59608, manifest 1556cd29) merge and umask wrapper review | APPROVE; notes agents/webby/work/queue-197/REVIEW-merge-r4.md
 2026-10-21T09:32Z | Webby (Opus 5.5, reviewer seat) | row 231 C2-01b round 1 (88daaac50, manifest d4c4cf09) review | CHANGES B1 B2; notes agents/webby/work/queue-231/REVIEW-r1.md
 2026-10-21T09:37Z | Webby (Opus 5.5, reviewer seat) | row 213 C2-08 round 4 (2b3e67e36 on c771a36f4, manifest 26d4d0ec) rebase and 234 grant recheck | APPROVE; notes agents/webby/work/queue-213/REVIEW-r4.md
+2026-10-21T09:52Z | Webby (Opus 5.5, reviewer seat) | row 231 C2-01b round 2 (f37a65857, manifest 312c16fc) review | APPROVE; notes agents/webby/work/queue-231/REVIEW-r2.md