diff --git a/agents/webby/work/case2-q226/REVIEW-r2.md b/agents/webby/work/case2-q226/REVIEW-r2.md index 126c0da83..680198d44 100644 --- a/agents/webby/work/case2-q226/REVIEW-r2.md +++ b/agents/webby/work/case2-q226/REVIEW-r2.md @@ -73,3 +73,25 @@ last. N6. The briefs now order a docs row first (item 0) and C2-05c before C2-02. When Sage adds the queue rows, the `After` fields should match that order, so `queue next` doesn't offer C2-02 early. + +## Round 3: design f6e3e7f20, briefs 883f78f14 (gosalyn-0171, 17:30Z) + +f6e3e7f20 has parent b68d79663 and touches only DESIGN.md (+13/-8). 883f78f14 has parent d4d503db9 and +touches only the rows file (+21/-12). Neither has a co-author line. Both are local. Read with git, nothing +run. + +Verdict: APPROVE. R4 is met. + +- The check reads the append-only events table for any `GRANT_EVIDENCE` event with `method` `gitea` and + `agent` the chief, of any action, and never `gitea_grants`. The design's ruling paragraph, 7.2 and + steps 4 and 4b say the same thing as the C2-03b bullet. The cites hold at aca16404c: broker.mjs:246, + :2469, :2609, :2785 and :2787, and schema.sql:131-132 and :469-480. +- "On the library project" is gone, and the brief tests a chief grant on another project ending the + fallback. +- The revoked and fired cases go through `grants.revoke` and `instance.fire`, and each asserts the row is + gone before the fetch. +- The `held` case has an event to find. `held` is a credential-file state (gitea-grant.mjs:400, :414-425) + that follows a commit `grant.step` or an unknown token. Both come after gitea grant events (broker.mjs + :2366, :2236), so a held chief never falls back to the slot. + +No new notes. N6 (the After order for Sage) still stands. diff --git a/agents/webby/work/queue-198/REVIEW-build-r3.md b/agents/webby/work/queue-198/REVIEW-build-r3.md index da897358b..5eca9bfba 100644 --- a/agents/webby/work/queue-198/REVIEW-build-r3.md +++ b/agents/webby/work/queue-198/REVIEW-build-r3.md @@ -135,3 +135,19 @@ M16 still hold after the fix, because their final `index()` starts a fresh scan two event-log pins once it's built. Verdict: CHANGES, B4. + +## Addendum 3: 844f25659 (Bushroot, 17:30Z, parent fe3a3ec71) + +Read with git, nothing run. board.mjs, board.test.mjs and BUILD.md. + +- B4 met. `index()` keeps its entry in `current` and clears `inflight` on both settle branches, only if it + still points at that entry (board.mjs:33-38). A concurrent `index()` still joins a running scan. + Handling the rejection in `then(clear, clear)` leaves the caller's promise as it was. +- The two tests kill the mutant. With the clear dropped, the settled-scan test logs one scan and serves + 19:00, and the rejected-scan test replays `boom` on the second call. The appended line goes into the + fixture's own session.jsonl. M17 is in BUILD.md. +- M15 and M16 still hold. Their last `index()` follows a bump, so it starts fresh with or without the + clear. + +Verdict: APPROVE on 844f25659, as read. Sage's run of the touched files and the M1-M17 mutant table is +the gate. N2 stays open and non-blocking, and BUILD.md records it. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 7e94adab2..415a22b4b 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1491,3 +1491,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-22T17:23Z | Webby (Opus 5.5, reviewer seat) | Case 2 Q226 round 2 review, design b68d79663 and briefs d4d503db9 (gosalyn-0165), plus pushed webby/reviews dce214677 in the sage-2841 gap and answered Bushroot on 2a758a5ba (webby-0155) | CHANGES R4 (the ever-existed check needs a source that survives revoke, broker.mjs:2785); R1-R3 wording, N1-N5, mos-1320 items met; PRD REQ-LIB-6 row brief approved; webby-0154 2026-10-22T17:28Z | Webby (Opus 5.5, reviewer seat) | row 198 r3 addendum 2 on fe3a3ec71 (Bushroot) | B2, B3 and N1 met as written; new B4: board.mjs index() never clears a settled inflight scan, so /api/board serves a frozen view (in since c3b60e513, missed in earlier rounds); CHANGES; webby-0157 2026-10-22T17:30Z | Webby (Opus 5.5, reviewer seat) | PRD 1.15 REQ-LIB-6 rewrite review, 594add438 (Gosalyn, gosalyn-0168) | CHANGES B1 (requireCitation sentence drops the fixed-notice exception); quotes, scope order, residual, titles and pins checked; webby-0158 +2026-10-22T17:32Z | Webby (Opus 5.5, reviewer seat) | Q226 round 3 f6e3e7f20 and 883f78f14 (gosalyn-0171), and row 198 r3 844f25659 (Bushroot) | Q226 APPROVE (R4 met, events-table check); row 198 APPROVE as read (B4 met), gate is Sage's run and M1-M17; webby-0159