From f1b8b36d14986aa2424d80112aaec06c27665bb1 Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Sun, 11 Oct 2026 20:11:27 -0500 Subject: [PATCH] queue: revs 593-594, row 76 round 1 in review on #1570, request comment 27594, manifest ca870314 (dewey) --- docs/plans/QUEUE.md | 4 +- docs/plans/queue.json | 96 +++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 94 insertions(+), 6 deletions(-) diff --git a/docs/plans/QUEUE.md b/docs/plans/QUEUE.md index db4a2cda8..e08ba5a9a 100644 --- a/docs/plans/QUEUE.md +++ b/docs/plans/QUEUE.md @@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here. -Generated from `docs/plans/queue.json` revision 592 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. +Generated from `docs/plans/queue.json` revision 594 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. | # | Piece | Owner | Issues | State | After | Gate | Brief | Note | |---|---|---|---|---|---|---|---|---| @@ -112,7 +112,7 @@ Generated from `docs/plans/queue.json` revision 592 by `queue render`. Do not ed | 73 | Coder role: drop the task.reassign grant the broker always refuses | rocko; reviewers dewey | #1567 | done | — | dewey approves on the issue naming the candidate manifest; tasks, bus, business and harness node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder role: drop the task.reassign grant the broker always refuses | — | | 74 | WebUI preview: a signed-in, read-only Console behind the edge proxy | dewey; reviewers darkwing, filbert | #1568 | done | — | darkwing and filbert approve on the issue naming the candidate manifest; webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Sage starts it after landing once rev-sol-01 passes ops-01's route (decision 93) (sage) | `docs/plans/2026-10-11_webui-preview.md` § WebUI preview: a signed-in, read-only Console behind the edge proxy | Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged. | | 75 | Console as a user service: render, install and status, Jason starts it | rocko; reviewers filbert | #1569 | done | — | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console as a user service | — | -| 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | in-progress | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh. | +| 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | in-review, round 1, request posted | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh. | | 77 | Console service hardening: row 75 review follow-ups N1-N5 | rocko; reviewers filbert | #1571 | queued | 75 done | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_console-service-followups.md` § Console service hardening | After the cutover (2026-10-12T21:30Z). Source: Filbert comment 27430 on #1569. | | 78 | Claude pin default-path tests: row 72 review follow-up N1 | rocko; reviewers filbert | #1572 | done | 73 done | filbert approves on the issue naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Claude pin default-path tests | — | | 79 | Coder grant stale text: row 73 packet follow-up | rocko; reviewers dewey | #1573 | in-review, round 1, request posted | 73 done | dewey approves on the issue naming the candidate manifest; tasks and business node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder grant stale text | Rev for Dewey's row 73 N1 (comment 27506): brief amended. Row 79 also pins the coder's untyped list in packages/harness/tests/tools.test.mjs with one deepEqual, records Dewey's mutants.sh header correction in the packet, and adds the harness suite to the gate. | diff --git a/docs/plans/queue.json b/docs/plans/queue.json index 8f91aad49..5475cf972 100644 --- a/docs/plans/queue.json +++ b/docs/plans/queue.json @@ -1,7 +1,7 @@ { "version": 1, "canonicalRoot": "/mnt/storage/src/mosaic-stack", - "revision": 592, + "revision": 594, "rows": [ { "id": 1, @@ -5844,7 +5844,7 @@ "closes": [ 1570 ], - "state": "in-progress", + "state": "in-review", "previousState": null, "required": false, "requiredSince": null, @@ -5865,7 +5865,41 @@ "darkwing", "filbert" ], - "review": null, + "review": { + "rounds": [ + { + "n": 1, + "op": "dewey-76-review-r1-20261012", + "by": "dewey", + "at": "2026-10-12T01:10:40.699Z", + "issue": 1570, + "candidate": { + "kind": "manifest", + "digest": "ca8703145aed98142c1fdf0553ab846a9b9a808cd58c35f7cbb4fa35d7f279a2", + "text": "c6cf1714407803d21a5757f39333a396c76abf582da0df51aeee4294e00cff06 packages/webui/README.md\na0661abb7de79ce2854884c99f7d8db114d8028d99048e7387a9b2f8534cd422 packages/webui/src/bus.mjs\nc8f9845c66793b0516d5f356f6be9f8ae2d46c40fdd044945aac2a606d024bee packages/webui/src/cli.mjs\na259dd523625a83237ebc98d0361ff6de1732729a661f9e0f37492f99e3b3f60 packages/webui/src/serve.mjs\n6ec0ff037d91ba52cce3361b079131d255df8484bcc6e924956731d2b2f86de1 packages/webui/src/public/app.js\n643178391c4e5dc2ac05a9c1d2972dd374bf6f692a5f28717ec0289d74a64a91 packages/webui/src/public/bus.js\n7dfceeaf485bc9b636fb12c7bc5a0f12ca74d6b43c351feaf2d335f527f31ee9 packages/webui/tests/send.test.mjs\nfdf0d30c097ab425fe8426f940892b7422a00ab5d6b7d30cefa0c4c5feafaa35 packages/webui/tests/send-browser.test.mjs\n17cb39097414bd685d68305dd5e402fd645020695f3dee86cd6bb567dd410eff packages/webui/tests/shell.test.mjs\n" + }, + "request": "comment", + "attempts": [ + { + "op": "dewey-76-review-r1-20261012", + "by": "dewey", + "at": "2026-10-12T01:10:40.699Z", + "state": "posted", + "comment": 27594, + "transport": { + "outcome": "posted", + "status": 201, + "comment": 27594, + "detail": "created" + }, + "resolutions": [] + } + ], + "duplicateRisk": false, + "receipts": [] + } + ] + }, "claim": { "seat": "dewey", "op": "dewey-76-start-1" @@ -5873,7 +5907,7 @@ "note": "Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh.", "blockedReason": null, "createdAt": "2026-10-11T22:17:42.739Z", - "updatedAt": "2026-10-11T23:44:55.098Z", + "updatedAt": "2026-10-12T01:10:44.754Z", "updatedBy": "dewey" }, { @@ -22553,6 +22587,60 @@ "receipt": "ok darkwing-r59-verdict-2 rev 592 row 59 round 2 approve by darkwing (comment 27591)" }, "viewSha": "e2b6e13d9fd92a81e1b55ab432d44839c76aa5f1457a7f9c84ef83b6a74ad1c0" + }, + { + "rev": 593, + "op": "dewey-76-review-r1-20261012", + "verb": "move", + "args": { + "id": 76, + "to": "in-review", + "reason": null, + "candidate": "agents/dewey/work/queue-76/candidate-manifest.sha256", + "evidence": null, + "issue": null + }, + "by": "dewey", + "at": "2026-10-12T01:10:40.699Z", + "semantics": 2, + "result": { + "row": 76, + "from": "in-progress", + "to": "in-review", + "round": 1, + "issue": 1570, + "candidate": { + "kind": "manifest", + "digest": "ca8703145aed98142c1fdf0553ab846a9b9a808cd58c35f7cbb4fa35d7f279a2", + "text": "c6cf1714407803d21a5757f39333a396c76abf582da0df51aeee4294e00cff06 packages/webui/README.md\na0661abb7de79ce2854884c99f7d8db114d8028d99048e7387a9b2f8534cd422 packages/webui/src/bus.mjs\nc8f9845c66793b0516d5f356f6be9f8ae2d46c40fdd044945aac2a606d024bee packages/webui/src/cli.mjs\na259dd523625a83237ebc98d0361ff6de1732729a661f9e0f37492f99e3b3f60 packages/webui/src/serve.mjs\n6ec0ff037d91ba52cce3361b079131d255df8484bcc6e924956731d2b2f86de1 packages/webui/src/public/app.js\n643178391c4e5dc2ac05a9c1d2972dd374bf6f692a5f28717ec0289d74a64a91 packages/webui/src/public/bus.js\n7dfceeaf485bc9b636fb12c7bc5a0f12ca74d6b43c351feaf2d335f527f31ee9 packages/webui/tests/send.test.mjs\nfdf0d30c097ab425fe8426f940892b7422a00ab5d6b7d30cefa0c4c5feafaa35 packages/webui/tests/send-browser.test.mjs\n17cb39097414bd685d68305dd5e402fd645020695f3dee86cd6bb567dd410eff packages/webui/tests/shell.test.mjs\n" + }, + "receipt": "ok dewey-76-review-r1-20261012 rev 593 row 76 in-progress→in-review round 1 on #1570; request dewey-76-review-r1-20261012 requesting" + }, + "viewSha": "7cd4465d46b8cfa0558b89961572c006f9b8c1385583724651076315d6f210b0" + }, + { + "rev": 594, + "op": "dewey-76-review-r1-20261012.outcome", + "verb": "review-outcome", + "args": { + "id": 76, + "attempt": "dewey-76-review-r1-20261012", + "outcome": "posted", + "status": 201, + "comment": 27594, + "detail": "created" + }, + "by": "dewey", + "at": "2026-10-12T01:10:44.754Z", + "semantics": 2, + "result": { + "row": 76, + "round": 1, + "attempt": "dewey-76-review-r1-20261012", + "state": "posted", + "receipt": "ok dewey-76-review-r1-20261012.outcome rev 594 row 76 round 1 request dewey-76-review-r1-20261012 posted comment 27594" + }, + "viewSha": "a737f955d0ca7dfe7a2f3230c3f56086deab1fe027019be804d032de1f2bd413" } ] }