Repair native launcher skill rename and fail-closed regression coverage (#1498)

This commit is contained in:
2026-09-08 18:12:20 -05:00
parent 12ff5da7df
commit f3dce32088
9 changed files with 62 additions and 14 deletions
@@ -0,0 +1,13 @@
# Skill/launcher mismatch repair (#1498)
Owner goal authorizes Darkwing to fix this mismatch through independent review, commit and push on refactor. No live restart, deployment, policy expansion or unrelated skill adoption. Baseline 12ff5da7df91f5343a59999af98b67518c15d6a4. Preserve unrelated WUI/private artifacts and new skills. Registry review is superseded for this assignment only.
Reproduced with node --test scripts/test-darkwing-launch.mjs: exit 1 because explicit ms-agent-watch skill is absent. Log /tmp/skill-launcher-baseline.log. Replacement skills/ms-watch/SKILL.md and tools/agent-watch/agent-watch.sh exist. Stale references also occur in communications and proactive skills. Do not restore the deleted skill to hide the mismatch or run a real launcher.
Next: inspect replacement against actual watch CLI and source provenance, make the smallest compatible reference/test repair, verify failure controls remain fail-closed. Independently review exact frozen candidate via Filbert, then selective commit/push and remote verification. Acceptance: offline fixtures green, correct explicit skill path, missing-skill refusal tested, docs match real capabilities, no live effects, unrelated bytes preserved. Any replacement-skill content changes stay limited to verified contract corrections; no timer will be armed for this task.
State: working. Issue #1498 created HTTP 201. No implementation or approval claimed yet. Goal lifecycle is owned by the active extension; this is task tracking, not another goal loop.
## Verified correction
Launcher now explicitly selects ms-watch; communications/proactive references match. Replacement skill documentation reconciled against the complete watch CLI: explicit repository sender, observable query side effects, real socket precedence, transport-only acknowledgement limits. Watch implementation itself unchanged. Added missing-ms-watch refusal controls for all three Pi agents and assertions for exact new skill path/absence of old path. Combined offline fixtures 5/5 passed, bash syntax and diff whitespace checks passed. No timers, real launchers or model calls. Next gate: independent frozen-candidate review before selective publication.
+9 -3
View File
@@ -7,9 +7,15 @@ update this file to the next action). No ambiguity, no re-planning.
## Next action
Review `docs/plans/2026-09-03_auth-provider-harness-registry.md` and reconcile
Gate 7 with later owner decisions and #53's workspace/session model. This is
registry review alignment only; no registry implementation is authorized.
Complete owner goal #1498: repair the skill/launcher mismatch through independent
review, selective commit and push. Plan: `docs/plans/2026-09-08_skill-launcher-mismatch.md`.
Local correction selects ms-watch, preserves missing-skill refusal and clarifies
watch transport limitations. Offline launcher fixtures 5/5 passed. Next gate is
independent frozen-candidate review. No live restart, timer arming or deployment.
Other new skills, private/WUI artifacts and held work remain untouched.
Registry review alignment is deferred behind this explicit owner goal; no registry
implementation is authorized.
Jason accepted the bounded #1497 publication/recovery trial following the plain-
language brief and said "Proceed." Issue #1497 is closed; acceptance receipt: