mosaicstack/stack
25
0
Fork 1
Code Issues 357 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

queue: revs 126-129, row 37 S2 review round on #1519 (rocko, sage)

Browse Source
This commit is contained in:
jason.woltje
2026-10-05 17:01:08 -05:00
parent e16faafdc2
commit f594318d45
2 changed files with 151 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/queue.json
+149 -4
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 125,
"revision": 129,
"rows": [
{
"id": 1,
@@ -1755,7 +1755,7 @@
"closes": [
1519
],
"state": "in-progress",
"state": "in-review",
"previousState": null,
"required": false,
"requiredSince": null,
@@ -1770,7 +1770,55 @@
"reviewers": [
"darkwing"
],
"review": null,
"review": {
"rounds": [
{
"n": 1,
"op": "rocko-r37-review-r2",
"by": "rocko",
"at": "2026-10-05T21:46:38.146Z",
"issue": 1519,
"candidate": {
"kind": "manifest",
"digest": "6151905968ea5db80ed19ab44aebdb37e433f1803a6d8b022fa35b31c91f6ffa",
"text": "10862f4f2d606dc8705c9be4fd4770f60551a1e61a2ab475aac17089ec825a21 packages/bus/README.md\n4f8057266af34f6c70ade88fc9bde45e2aff5a58ab3ee3b8a568a532385fc1cf packages/bus/package.json\n179ffe356d4ff19a49b5ebad39b6c6bfd7771deb8e1b7c55b5e746f039d69e65 packages/bus/schema.sql\naa5efbbfa2843a3908a26fda80c2c4b2260a12aeb26ff993053cc3c97c780cc6 packages/bus/src/broker.mjs\nc9db0a59601299e755c3922ff027aa5c74a1e443dc716333053b6f30d4643030 packages/bus/src/business.mjs\nff551b6a175691b97f8d4156b3424e34780b6fe84aa5b174c87696567ed1111e packages/bus/src/client.mjs\ndfb0e33a6405d52391f3df7f698876bec2a8e55846ee09fa3cc9c66cb541dbac packages/bus/src/credentials.mjs\n269c3a66008c0d57a54b14b73cf988d5f61f5e815455486296716e98ce5e8073 packages/bus/src/human-cli.mjs\nb995fc5cff3af8ade4c990d0e3bebf9d83829e00f034ebc9c3dcfd05f252b573 packages/bus/src/human.mjs\nf40412a4724468a7b9d51af2d1d97e76b60ec4dfa2b7be8d43948382c0559da3 packages/bus/src/index.mjs\n5c340572b3dbbb25f154948f7a7782688a740ee1f967cd8f5ea3845ee3db486f packages/bus/src/process.mjs\nd57dfa2acf53a33856a1d8f853904243c1384517224393bebcc4ad2cf84acb35 packages/bus/src/runtime.mjs\n789d10b0062ad47dafaadc4e6c5e5fc55343f86d2dd13892778558213c10dd64 packages/bus/src/server.mjs\ne69cb395787c9fb7af16487a99bd053c9cfea96ee96e39c15a05ad9bd541e8b5 packages/bus/src/store.mjs\n446b6da48fabc80f20725ec0062a71f99796bd2a8006bf4a23d00ba87c1d8fb9 packages/bus/src/views.mjs\n7e469c0215b6282948b38d82d8e5019ea95bd4d0de36a73f0327dc5545ce7b24 packages/bus/tests/broker.test.mjs\n55ee33588340bb14be510d1e637e61eecb739229db8590ccc18dc8d8ca488b14 packages/bus/tests/business.test.mjs\nfc4aef72b58b352a1c1f14a745d44c26ae11f6da5b7c6961e0c547c619ed23d3 packages/bus/tests/credentials.test.mjs\n8b9805bc049caa65225b4cb6335a73705a29dc6f4fb5f76b13044df50182e01d packages/bus/tests/fixtures/crash-writer.mjs\n17442a121e48814732ba959d1a41d700253f555511e1f1ebcdb7cbae520708d3 packages/bus/tests/human.test.mjs\n480f62b8e9e9d4378677ae7347f5e48ba1f0a9a5fd222c75eb2322f2b9984dff packages/bus/tests/process.test.mjs\nb23e5d40f1e4a5af0bdba0dc34d291704d7a0966d040116fe19e13f4bc4199ac packages/bus/tests/schema.test.mjs\nd9f03aedda5b6e090eb71c2908a2889f6bba3cfdeac8204476d8d928f171716d packages/bus/tests/store.test.mjs\n50ce0d1314cfcdac2e139493b56da73ed46bf2167319eb5b14e95033ab8622ea packages/bus/tests/transport.test.mjs\n"
},
"request": "comment",
"attempts": [
{
"op": "rocko-r37-review-r2",
"by": "rocko",
"at": "2026-10-05T21:46:38.146Z",
"state": "failed",
"comment": null,
"transport": {
"outcome": "failed",
"status": null,
"comment": null,
"detail": "pre-send: the credential or account check failed"
},
"resolutions": []
},
{
"op": "sage-r37-req-r2-20261005",
"by": "sage",
"at": "2026-10-05T21:47:32.609Z",
"state": "posted",
"comment": 26756,
"transport": {
"outcome": "posted",
"status": 201,
"comment": 26756,
"detail": "created"
},
"resolutions": []
}
],
"duplicateRisk": false,
"receipts": []
}
]
},
"claim": {
"seat": "rocko",
"op": "rocko-s2-start-20261004"
@@ -1778,7 +1826,7 @@
"note": "2026-10-04: S2 pins schema v3b (48d76de7, sha256 179ffe35..., digest 52514a11..., lead decision 60), not v3a. Stamp at and read_at in one fixed-width UTC form.",
"blockedReason": null,
"createdAt": "2026-10-05T02:51:49.031Z",
"updatedAt": "2026-10-05T21:43:35.657Z",
"updatedAt": "2026-10-05T21:48:14.185Z",
"updatedBy": "sage"
},
{
@@ -6267,6 +6315,103 @@
"receipt": "ok sage-r43-briefed-20261005 rev 125 row 43 queued→briefed"
},
"viewSha": "e66854835f491ce37bb4866cf2239d8788d81c44708efe23f56f0b89c01d47c7"
},
{
"rev": 126,
"op": "rocko-r37-review-r2",
"verb": "move",
"args": {
"id": 37,
"to": "in-review",
"reason": null,
"candidate": "agents/rocko/work/slice1-s2-r2/candidate-manifest.sha256",
"evidence": null,
"issue": null
},
"by": "rocko",
"at": "2026-10-05T21:46:38.146Z",
"semantics": 2,
"result": {
"row": 37,
"from": "in-progress",
"to": "in-review",
"round": 1,
"issue": 1519,
"candidate": {
"kind": "manifest",
"digest": "6151905968ea5db80ed19ab44aebdb37e433f1803a6d8b022fa35b31c91f6ffa",
"text": "10862f4f2d606dc8705c9be4fd4770f60551a1e61a2ab475aac17089ec825a21 packages/bus/README.md\n4f8057266af34f6c70ade88fc9bde45e2aff5a58ab3ee3b8a568a532385fc1cf packages/bus/package.json\n179ffe356d4ff19a49b5ebad39b6c6bfd7771deb8e1b7c55b5e746f039d69e65 packages/bus/schema.sql\naa5efbbfa2843a3908a26fda80c2c4b2260a12aeb26ff993053cc3c97c780cc6 packages/bus/src/broker.mjs\nc9db0a59601299e755c3922ff027aa5c74a1e443dc716333053b6f30d4643030 packages/bus/src/business.mjs\nff551b6a175691b97f8d4156b3424e34780b6fe84aa5b174c87696567ed1111e packages/bus/src/client.mjs\ndfb0e33a6405d52391f3df7f698876bec2a8e55846ee09fa3cc9c66cb541dbac packages/bus/src/credentials.mjs\n269c3a66008c0d57a54b14b73cf988d5f61f5e815455486296716e98ce5e8073 packages/bus/src/human-cli.mjs\nb995fc5cff3af8ade4c990d0e3bebf9d83829e00f034ebc9c3dcfd05f252b573 packages/bus/src/human.mjs\nf40412a4724468a7b9d51af2d1d97e76b60ec4dfa2b7be8d43948382c0559da3 packages/bus/src/index.mjs\n5c340572b3dbbb25f154948f7a7782688a740ee1f967cd8f5ea3845ee3db486f packages/bus/src/process.mjs\nd57dfa2acf53a33856a1d8f853904243c1384517224393bebcc4ad2cf84acb35 packages/bus/src/runtime.mjs\n789d10b0062ad47dafaadc4e6c5e5fc55343f86d2dd13892778558213c10dd64 packages/bus/src/server.mjs\ne69cb395787c9fb7af16487a99bd053c9cfea96ee96e39c15a05ad9bd541e8b5 packages/bus/src/store.mjs\n446b6da48fabc80f20725ec0062a71f99796bd2a8006bf4a23d00ba87c1d8fb9 packages/bus/src/views.mjs\n7e469c0215b6282948b38d82d8e5019ea95bd4d0de36a73f0327dc5545ce7b24 packages/bus/tests/broker.test.mjs\n55ee33588340bb14be510d1e637e61eecb739229db8590ccc18dc8d8ca488b14 packages/bus/tests/business.test.mjs\nfc4aef72b58b352a1c1f14a745d44c26ae11f6da5b7c6961e0c547c619ed23d3 packages/bus/tests/credentials.test.mjs\n8b9805bc049caa65225b4cb6335a73705a29dc6f4fb5f76b13044df50182e01d packages/bus/tests/fixtures/crash-writer.mjs\n17442a121e48814732ba959d1a41d700253f555511e1f1ebcdb7cbae520708d3 packages/bus/tests/human.test.mjs\n480f62b8e9e9d4378677ae7347f5e48ba1f0a9a5fd222c75eb2322f2b9984dff packages/bus/tests/process.test.mjs\nb23e5d40f1e4a5af0bdba0dc34d291704d7a0966d040116fe19e13f4bc4199ac packages/bus/tests/schema.test.mjs\nd9f03aedda5b6e090eb71c2908a2889f6bba3cfdeac8204476d8d928f171716d packages/bus/tests/store.test.mjs\n50ce0d1314cfcdac2e139493b56da73ed46bf2167319eb5b14e95033ab8622ea packages/bus/tests/transport.test.mjs\n"
},
"receipt": "ok rocko-r37-review-r2 rev 126 row 37 in-progress→in-review round 1 on #1519; request rocko-r37-review-r2 requesting"
},
"viewSha": "f4371d2c4ad335c54f9b6275467ce3e28503b5755e4d62a95b7ec16e337afe4e"
},
{
"rev": 127,
"op": "rocko-r37-review-r2.outcome",
"verb": "review-outcome",
"args": {
"id": 37,
"attempt": "rocko-r37-review-r2",
"outcome": "failed",
"status": null,
"comment": null,
"detail": "pre-send: the credential or account check failed"
},
"by": "rocko",
"at": "2026-10-05T21:46:38.421Z",
"semantics": 2,
"result": {
"row": 37,
"round": 1,
"attempt": "rocko-r37-review-r2",
"state": "failed",
"receipt": "ok rocko-r37-review-r2.outcome rev 127 row 37 round 1 request rocko-r37-review-r2 failed"
},
"viewSha": "db07713fef73b11cba6c7b8b6fdb46d427452bf507923f5432aef830f49cb03d"
},
{
"rev": 128,
"op": "sage-r37-req-r2-20261005",
"verb": "review-request",
"args": {
"id": 37
},
"by": "sage",
"at": "2026-10-05T21:47:32.609Z",
"semantics": 2,
"result": {
"row": 37,
"round": 1,
"attempt": "sage-r37-req-r2-20261005",
"state": "requesting",
"receipt": "ok sage-r37-req-r2-20261005 rev 128 row 37 round 1 request sage-r37-req-r2-20261005 requesting"
},
"viewSha": "56182ec6c7a6502f04f26da7e20fa0f906d58404fe18e30f1272dde8ee64279b"
},
{
"rev": 129,
"op": "sage-r37-req-r2-20261005.outcome",
"verb": "review-outcome",
"args": {
"id": 37,
"attempt": "sage-r37-req-r2-20261005",
"outcome": "posted",
"status": 201,
"comment": 26756,
"detail": "created"
},
"by": "sage",
"at": "2026-10-05T21:48:14.185Z",
"semantics": 2,
"result": {
"row": 37,
"round": 1,
"attempt": "sage-r37-req-r2-20261005",
"state": "posted",
"receipt": "ok sage-r37-req-r2-20261005.outcome rev 129 row 37 round 1 request sage-r37-req-r2-20261005 posted comment 26756"
},
"viewSha": "488027ed41b0eb611fc86cf774008a57d92312e43a40ae7ea9d10f2ae3d110a3"
}
]
}