test: commit.test close wait and test-task recall Docker skip (#1534, row 48)

pausedCommit waits for the child's `close`, not `exit`, so the `cannot lock ref 'HEAD'` match sees git's stderr. The test-task live recall pair runs only when `docker info` succeeds, like the three live blocks above it; otherwise it prints a skip line and counts as neither a pass nor a failure. Dewey built it. Darkwing (27099) and Filbert (27100) approved round 1 on manifest 285a4ec1 (3 files). Sage's gate on 560373c3 plus the candidate: queue 148/0, conversation 182/0, webui 22/0, control-board 124/0, every scripts/test-*.sh 0 failed; test-task 98/0 with Docker and 26/0 without, with the recall-pair skip line. Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-10 03:55:24 -05:00
parent a07b37840a
commit f7c2d5cfe3
4 changed files with 109 additions and 10 deletions
@@ -169,7 +169,7 @@ async function pausedCommit(t, form) {
  const child = spawn("git", ["-C", r.root, "commit", "-e", "-q", ...form], { env: { ...r.env, GIT_EDITOR: editor }, stdio: ["ignore", "pipe", "pipe"] });
  let childErr = "";
  child.stderr.on("data", (d) => { childErr += d; });
-  const exited = new Promise((resolve) => child.on("exit", resolve));
+  const exited = new Promise((resolve) => child.on("close", resolve));
  for (let i = 0; i < 200 && !existsSync(started); i++) sleepMs(50);
  assert.ok(existsSync(started), "the editor never started");
  const locked = existsSync(join(r.gitDir, "index.lock"));