queue: revs 2129-2134: row 181 briefed (Sage 2129) and started (Darkwing 2130); row 178 round 1 in-review (Rocko 2131-2132) and review request #1676 comment 29368 (Sage 2133-2134)

This commit is contained in:
jason.woltje committed 2026-10-19 23:25:08 -05:00
1 parent 311705d5bd
commit fcfb82da2c
2 files changed
+212 -12

No files matched your search

+3 -3
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 2128 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
Generated from `docs/plans/queue.json` revision 2134 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---|
@@ -214,10 +214,10 @@ Generated from `docs/plans/queue.json` revision 2128 by `queue render`. Do not e
| 175 | Tester reads and writes for the test system: seven reads, seven writes recorded as tester (plugins, instances, routes set, name, talk without the prefix, project create, project init in the data root's project area); nine items stay human-only (#1673, Q173, mos-0870 N2, mos-0872) | dewey; reviewers filbert | #1673 | done | — | Filbert approves the candidate manifest; bus, cli, plugins, project, business and webui suites and every scripts/test-*.sh green on Sage's gate (sage) | `docs/plans/2026-10-19_tester-read-checks.md` § Brief: tester reads and writes for the test system | Landed as 98d29769e on 1d81c54ff (temp index from build.patch c9e545e5, manifest 2e30f2a1 25/25 on the tree; patch-id c1cf0ed66006 equals 9e74925c2..989699f7c). Sage gate on 716ddcf1e plus the patch: 15 package suites 2592 pass, 10 scripts/test-*.sh 422 pass, 0 fail. Filbert r3 approve 29279. F1 (TOOLS.md:452 'Until row 175 lands') is a doc-only follow-up. |
| 176 | Console tester listener on 127.0.0.1 (--tester-port, 7333 in the window), TESTER_CLI bus calls, only the row 175 tester writes; 7332 refuses x-mosaic-tester for every Host; tester reads credentials, routes, project.files, project.file (#1674, Q173 N3, mos-0872, mos-0874) | rocko; reviewers dewey | #1674 | done | 169 done, 175 done | Dewey approves the candidate manifest; bus, cli, webui and business suites and every scripts/test-*.sh green on Sage's gate (sage) | `docs/plans/2026-10-19_console-tester-listener.md` § Brief: a loopback-only Console listener for the tester | Sage gate run 2 on 473258a51 plus the patch: 15 package suites 2455 pass, 0 fail, 1 skip (editor rebuild wants esbuild 0.28.2); 10 scripts/test-*.sh 422 selftests plus 156 queue tests, 0 fail. Run 1 failed T34 with capture-failed: activate and pm-on name runs by the second and collided. A row 169 base race (the base fails the same with the id pinned), Mos agreed (mos-0902); follow-up Vikunja P19 391. |
| 177 | Tester threads: create, list, open, send and read tester-owned threads; owner and from_role tester, replies to tester, never the human's inbox; design first, Sage approves before code (#1675, Q173) | dewey; reviewers filbert | #1675 | done | 176 done | Filbert approves the candidate manifest; bus, webui and conversation suites and every scripts/test-*.sh green on Sage's gate (sage) | `docs/plans/2026-10-19_tester-threads.md` § Brief: tester threads (scoping) | Landed on refactor as 1f994257a (row 177) and 9d9d95485 (round 2), cherry-picked onto a2eebf997. range-diff vs gate candidate 1d5347670/5cb2905c7: both '='. Combined patch-id 15f9c7bba807, same as Filbert's approve (29351) and Sage's gate. Gate on c0d6bc7d5+2: GATE_PASSED, 25 steps rc=0, node 2627 pass 0 fail, scripts 422 pass 0 fail, network removed, 0 containers. |
| 178 | Console proxy proof: --proof-header and --proof-file, a signed-in request without Traefik's secret header gets 401; partial fix after the window rows, same-uid limit recorded, uid separation is Jason's on #385; console-proof.token slot, ops-01 middleware (#1676, Vikunja #385, mos-0874, mos-0878) | rocko; reviewers dewey | #1676 | in-progress | 169 done, 175 done, 176 done | Reviewer approves the candidate manifest; webui and cli suites and every scripts/test-*.sh green on Sage's gate; nothing live changes at landing (sage) | `docs/plans/2026-10-19_console-proxy-proof.md` § Brief: the Console checks that a signed-in request came through Traefik | — |
| 178 | Console proxy proof: --proof-header and --proof-file, a signed-in request without Traefik's secret header gets 401; partial fix after the window rows, same-uid limit recorded, uid separation is Jason's on #385; console-proof.token slot, ops-01 middleware (#1676, Vikunja #385, mos-0874, mos-0878) | rocko; reviewers dewey | #1676 | in-review, round 1, request posted | 169 done, 175 done, 176 done | Reviewer approves the candidate manifest; webui and cli suites and every scripts/test-*.sh green on Sage's gate; nothing live changes at landing (sage) | `docs/plans/2026-10-19_console-proxy-proof.md` § Brief: the Console checks that a signed-in request came through Traefik | — |
| 179 | docs/TOOLS.md follow-ups F1-F3 from the row 169 review | darkwing; reviewers dewey | #1677 | done | 169 done | Dewey approves the candidate manifest; no suite when no test reads docs/TOOLS.md (decision 137) (sage) | `docs/plans/2026-10-19_tools-md-169-followups.md` § Brief: docs/TOOLS.md follow-ups from the row 169 review | Landed 9e74925c2 on ce5807989 (Sage, temp index). Candidate manifest 2b161c51 approved by Dewey (29271); landed docs/TOOLS.md sha256 67acbed1 matches it. patch-id 35e385ff93cb matches Darkwing's packet. Doc-only, no suite: only stack-release.test.mjs:428 names TOOLS.md, in an expected message string (decision 137). |
| 180 | stack-release activation ids unique within one second (P19 391); --plan refusals in console_for_target through check_refuse, new code tester-port-invalid (row 176 N1); webui-service tester_port_ok length before zero strip (N2) (#1678) | darkwing; reviewers dewey | #1678 | done | — | Dewey approves the candidate manifest; cli and webui suites and every scripts/test-*.sh green on Sage's gate, a killed mutant per item (sage) | `docs/plans/2026-10-20_stack-release-after-window.md` § Brief: activation ids and plan-mode refusals (row A) | Landed on refactor as 1905e385c on 828d14a0c (Darkwing author). Patch-id 31b1d502444e equals the gate candidate (build.patch, manifest c743480e approved by Dewey 29361). Gate on 828d14a0c+candidate: GATE_PASSED, 25 steps rc=0, node 2482 pass 0 fail, scripts 422 pass 0 fail plus queue 156, network removed, 0 containers. |
| 181 | stack-release --restore guard counts every table a restore drops rows from, not only events; every schema table classified into one of four lists; UPDATE gaps recorded (P19 390, mos-0927 R1) (#1679) | darkwing; reviewers filbert | #1679 | queued | 180 done | Filbert approves the candidate manifest; cli suite and every scripts/test-*.sh green on Sage's gate, the brief's mutants killed (sage) | `docs/plans/2026-10-20_stack-release-after-window.md` § Brief: the restore guard counts every row a restore drops (row B) | — |
| 181 | stack-release --restore guard counts every table a restore drops rows from, not only events; every schema table classified into one of four lists; UPDATE gaps recorded (P19 390, mos-0927 R1) (#1679) | darkwing; reviewers filbert | #1679 | in-progress | 180 done | Filbert approves the candidate manifest; cli suite and every scripts/test-*.sh green on Sage's gate, the brief's mutants killed (sage) | `docs/plans/2026-10-20_stack-release-after-window.md` § Brief: the restore guard counts every row a restore drops (row B) | — |
| 182 | Bus: a tester message reaches only a tester-owned thread (row 177 follow-up N1) | sage | #1680 | queued | — | Reviewer approves the manifest; bus, cli, webui suites and every scripts/test-*.sh green on Sage's gate; owner-check mutant killed (sage) | `docs/plans/2026-10-20_tester-thread-follow-ups.md` § Brief: a tester message reaches only a tester-owned thread (N1) | — |
| 183 | Webui: chat.mjs names the transport it is given (row 177 follow-up N2) | sage | #1681 | queued | — | Reviewer approves the manifest; webui suite and the scripts/test-*.sh that read webui paths green on Sage's gate; old-text mutant killed (sage) | `docs/plans/2026-10-20_tester-thread-follow-ups.md` § Brief: chat.mjs names the transport it is given (N2) | — |
| 184 | CLI: tester thread verbs (thread create\|open\|read, threads, talk/follow --thread with --tester) | sage | #1682 | queued | — | Reviewer approves the manifest; cli and bus suites and every scripts/test-*.sh green on Sage's gate; both mutants killed (sage) | `docs/plans/2026-10-20_tester-thread-follow-ups.md` § Brief: tester thread verbs in the CLI | — |
+209 -9
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 2128,
"revision": 2134,
"rows": [
{
"id": 1,
@@ -18651,7 +18651,7 @@
"closes": [
1676
],
"state": "in-progress",
"state": "in-review",
"previousState": null,
"required": false,
"requiredSince": null,
@@ -18679,7 +18679,55 @@
"reviewers": [
"dewey"
],
"review": null,
"review": {
"rounds": [
{
"n": 1,
"op": "rocko-178-inreview-r1",
"by": "rocko",
"at": "2026-10-20T04:20:10.914Z",
"issue": 1676,
"candidate": {
"kind": "manifest",
"digest": "e8f7a258b955bd6a303be0247926ebd69f8a537c937b291eafe30a6f905d05dc",
"text": "8cfa645d30e598a7507f1bd853846c3291696857622b6dbe28153da43f686607 docs/TOOLS.md\n6989e7e3c7e36841c5c12c2b0e4b52d9ed678f99791bcdb52df0ffdd5eb75723 packages/cli/tests/stack-release.test.mjs\n78c7b60d23cf20863a1cb66e16af2f9363d08acc79c5b4a344cd8af4fbe5bd44 packages/webui/README.md\n4f988333ec6af225a023323dda85a159b81a77f408a8dd7bff798fe9a1f4b24b packages/webui/src/cli.mjs\nba7d3e35b225cb4e17a4d2530a0f34d0a3734641e3982229a38207a36b3cd433 packages/webui/src/serve.mjs\n045b85c09e9a04c47b6dc83762bfee2eacf080e8aec4cd2ca1ce8ca1ccbadff4 packages/webui/systemd/mosaic-webui.service.in\nc23975b140ed977f3b98dbbec5de289e9f930cc42089193c4aa7c106338a68ba packages/webui/tests/proof-cli.test.mjs\n2191896dada09a6569ff1be5fbe86c4737be1cdc25ed8d84642a95a729019b94 packages/webui/tests/proof.test.mjs\nbd8109c3fb3dcfc5a57d6e395baa4dc1fbd1211f2c5b8d4ef17cd9487d64674d packages/webui/tests/service.test.mjs\n7f60d82860b3822a0a68d16c916f129a642ab8ada5a4ed781cb4e3dabbf7a294 scripts/stack-release.sh\nd514caf757c03e5d02ef39b19359669bd2476dca1877f5d237c65bd62c33d2bf scripts/webui-service.sh\n"
},
"request": "comment",
"attempts": [
{
"op": "rocko-178-inreview-r1",
"by": "rocko",
"at": "2026-10-20T04:20:10.914Z",
"state": "failed",
"comment": null,
"transport": {
"outcome": "failed",
"status": null,
"comment": null,
"detail": "pre-send: the credential or account check failed"
},
"resolutions": []
},
{
"op": "sage-178-review-r1b",
"by": "sage",
"at": "2026-10-20T04:21:52.564Z",
"state": "posted",
"comment": 29368,
"transport": {
"outcome": "posted",
"status": 201,
"comment": 29368,
"detail": "created"
},
"resolutions": []
}
],
"duplicateRisk": false,
"receipts": []
}
]
},
"claim": {
"seat": "rocko",
"op": "rocko-178-start"
@@ -18687,8 +18735,8 @@
"note": null,
"blockedReason": null,
"createdAt": "2026-10-19T22:33:05.401Z",
"updatedAt": "2026-10-20T03:33:34.482Z",
"updatedBy": "rocko"
"updatedAt": "2026-10-20T04:22:09.519Z",
"updatedBy": "sage"
},
{
"id": 179,
@@ -18901,7 +18949,7 @@
"closes": [
1679
],
"state": "queued",
"state": "in-progress",
"previousState": null,
"required": false,
"requiredSince": null,
@@ -18922,12 +18970,15 @@
"filbert"
],
"review": null,
"claim": null,
"claim": {
"seat": "darkwing",
"op": "darkwing-181-start-1"
},
"note": null,
"blockedReason": null,
"createdAt": "2026-10-20T02:31:48.085Z",
"updatedAt": "2026-10-20T02:31:48.085Z",
"updatedBy": "sage"
"updatedAt": "2026-10-20T03:56:10.136Z",
"updatedBy": "darkwing"
},
{
"id": 182,
@@ -75252,6 +75303,155 @@
"receipt": "ok sage-r180-done rev 2128 row 180 in-review→done round 2"
},
"viewSha": "46e4ca3ac84761622a5fed3e6e02406c8df47ba6182c807e1547fe8d0a3b43f8"
},
{
"rev": 2129,
"op": "sage-r181-briefed",
"verb": "move",
"args": {
"id": 181,
"to": "briefed",
"reason": null,
"candidate": null,
"evidence": null,
"issue": null
},
"by": "sage",
"at": "2026-10-20T03:55:39.610Z",
"semantics": 2,
"result": {
"row": 181,
"from": "queued",
"to": "briefed",
"round": null,
"issue": null,
"candidate": null,
"receipt": "ok sage-r181-briefed rev 2129 row 181 queued→briefed"
},
"viewSha": "69a5686c11da0dfeacec247e6ac0ddb8164041890ed576dd764753878b7c788b"
},
{
"rev": 2130,
"op": "darkwing-181-start-1",
"verb": "move",
"args": {
"id": 181,
"to": "in-progress",
"reason": null,
"candidate": null,
"evidence": null,
"issue": null
},
"by": "darkwing",
"at": "2026-10-20T03:56:10.136Z",
"semantics": 2,
"result": {
"row": 181,
"from": "briefed",
"to": "in-progress",
"round": null,
"issue": null,
"candidate": null,
"receipt": "ok darkwing-181-start-1 rev 2130 row 181 briefed→in-progress"
},
"viewSha": "e36505fab08155981de2a06c1bdc5025ab6d0553fd773453c6e1e6a29c243b0a"
},
{
"rev": 2131,
"op": "rocko-178-inreview-r1",
"verb": "move",
"args": {
"id": 178,
"to": "in-review",
"reason": null,
"candidate": "agents/rocko/work/queue-178/candidate-manifest.sha256",
"evidence": null,
"issue": null
},
"by": "rocko",
"at": "2026-10-20T04:20:10.914Z",
"semantics": 2,
"result": {
"row": 178,
"from": "in-progress",
"to": "in-review",
"round": 1,
"issue": 1676,
"candidate": {
"kind": "manifest",
"digest": "e8f7a258b955bd6a303be0247926ebd69f8a537c937b291eafe30a6f905d05dc",
"text": "8cfa645d30e598a7507f1bd853846c3291696857622b6dbe28153da43f686607 docs/TOOLS.md\n6989e7e3c7e36841c5c12c2b0e4b52d9ed678f99791bcdb52df0ffdd5eb75723 packages/cli/tests/stack-release.test.mjs\n78c7b60d23cf20863a1cb66e16af2f9363d08acc79c5b4a344cd8af4fbe5bd44 packages/webui/README.md\n4f988333ec6af225a023323dda85a159b81a77f408a8dd7bff798fe9a1f4b24b packages/webui/src/cli.mjs\nba7d3e35b225cb4e17a4d2530a0f34d0a3734641e3982229a38207a36b3cd433 packages/webui/src/serve.mjs\n045b85c09e9a04c47b6dc83762bfee2eacf080e8aec4cd2ca1ce8ca1ccbadff4 packages/webui/systemd/mosaic-webui.service.in\nc23975b140ed977f3b98dbbec5de289e9f930cc42089193c4aa7c106338a68ba packages/webui/tests/proof-cli.test.mjs\n2191896dada09a6569ff1be5fbe86c4737be1cdc25ed8d84642a95a729019b94 packages/webui/tests/proof.test.mjs\nbd8109c3fb3dcfc5a57d6e395baa4dc1fbd1211f2c5b8d4ef17cd9487d64674d packages/webui/tests/service.test.mjs\n7f60d82860b3822a0a68d16c916f129a642ab8ada5a4ed781cb4e3dabbf7a294 scripts/stack-release.sh\nd514caf757c03e5d02ef39b19359669bd2476dca1877f5d237c65bd62c33d2bf scripts/webui-service.sh\n"
},
"receipt": "ok rocko-178-inreview-r1 rev 2131 row 178 in-progress→in-review round 1 on #1676; request rocko-178-inreview-r1 requesting"
},
"viewSha": "faf4bef2bb2722cb533904193d3fa114db2e520aeff84fb8cad2a6caa4de7217"
},
{
"rev": 2132,
"op": "rocko-178-inreview-r1.outcome",
"verb": "review-outcome",
"args": {
"id": 178,
"attempt": "rocko-178-inreview-r1",
"outcome": "failed",
"status": null,
"comment": null,
"detail": "pre-send: the credential or account check failed"
},
"by": "rocko",
"at": "2026-10-20T04:20:26.302Z",
"semantics": 2,
"result": {
"row": 178,
"round": 1,
"attempt": "rocko-178-inreview-r1",
"state": "failed",
"receipt": "ok rocko-178-inreview-r1.outcome rev 2132 row 178 round 1 request rocko-178-inreview-r1 failed"
},
"viewSha": "a14d77eed14766b44b70d9fbddd50455eb5fd35175ba0c69f1afe8e69f216fda"
},
{
"rev": 2133,
"op": "sage-178-review-r1b",
"verb": "review-request",
"args": {
"id": 178
},
"by": "sage",
"at": "2026-10-20T04:21:52.564Z",
"semantics": 2,
"result": {
"row": 178,
"round": 1,
"attempt": "sage-178-review-r1b",
"state": "requesting",
"receipt": "ok sage-178-review-r1b rev 2133 row 178 round 1 request sage-178-review-r1b requesting"
},
"viewSha": "12e0c47d0d1c30f5a4d875c687159c68da8d674b82890ff9842cfb0d4bd19f64"
},
{
"rev": 2134,
"op": "sage-178-review-r1b.outcome",
"verb": "review-outcome",
"args": {
"id": 178,
"attempt": "sage-178-review-r1b",
"outcome": "posted",
"status": 201,
"comment": 29368,
"detail": "created"
},
"by": "sage",
"at": "2026-10-20T04:22:09.519Z",
"semantics": 2,
"result": {
"row": 178,
"round": 1,
"attempt": "sage-178-review-r1b",
"state": "posted",
"receipt": "ok sage-178-review-r1b.outcome rev 2134 row 178 round 1 request sage-178-review-r1b posted comment 29368"
},
"viewSha": "d46ea60acd0847d406bd597e5cc4539dc656d1aa0d4f1423503b3fc0659714a9"
}
]
}