From fec416d1df3326f22af55fce4893d7f475730366 Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Tue, 10 Nov 2026 12:42:05 -0600 Subject: [PATCH] feat(webui): P2 system types on the org dashboard and project page, toolset design (#1873) The org dashboard lists the installed system-type modules with their own labels and descriptions, marks which are enabled, and gives the owner an enable or disable control through plugins.set behind the owner fence, with the revision and the transaction receipt. The project page selects from the organization's enabled set through project.system-types.set and shows a disabled selection as inactive, as system-types.console reports. Both routes go through the per-org Console call path and its admission checks. docs/plans/2026-11-10_system-type-toolsets-design.md proposes how a launch turns a project's active system types into toolsets under the role, mission and task ceilings. Design only; no roles/ or contract change is applied. --- .../2026-11-10_system-type-toolsets-design.md | 192 +++++++++++++++++ packages/webui/src/cli.mjs | 4 + packages/webui/src/public/chat.js | 5 +- packages/webui/src/public/index.html | 2 +- packages/webui/src/public/system-types.css | 33 +++ packages/webui/src/public/system-types.js | 189 ++++++++++++++++ packages/webui/src/public/workspace.js | 21 +- packages/webui/src/serve.mjs | 32 ++- packages/webui/src/system-types-http.mjs | 131 ++++++++++++ packages/webui/tests/browser.test.mjs | 4 +- .../webui/tests/helpers/system-types-fake.mjs | 42 ++++ .../webui/tests/system-types-browser.test.mjs | 192 +++++++++++++++++ .../webui/tests/system-types-http.test.mjs | 202 ++++++++++++++++++ .../tests/unified-workspace-browser.test.mjs | 21 +- 14 files changed, 1043 insertions(+), 27 deletions(-) create mode 100644 docs/plans/2026-11-10_system-type-toolsets-design.md create mode 100644 packages/webui/src/public/system-types.css create mode 100644 packages/webui/src/public/system-types.js create mode 100644 packages/webui/src/system-types-http.mjs create mode 100644 packages/webui/tests/helpers/system-types-fake.mjs create mode 100644 packages/webui/tests/system-types-browser.test.mjs create mode 100644 packages/webui/tests/system-types-http.test.mjs diff --git a/docs/plans/2026-11-10_system-type-toolsets-design.md b/docs/plans/2026-11-10_system-type-toolsets-design.md new file mode 100644 index 000000000..4569108e8 --- /dev/null +++ b/docs/plans/2026-11-10_system-type-toolsets-design.md @@ -0,0 +1,192 @@ +# System-type toolsets at launch + +Status: design only. Nothing here is built and no `roles/` or contract file is +changed. Prepared 2026-11-10 against `refactor` `8630b8dfc` for phase P2 of +#1873 (unified workspace). PRD requirement: REQ-SYS-2, "An agent working in a +project gets the toolsets of the system types that project uses." + +## What exists today + +- **Modules.** `installedSystemTypes()` (`packages/plugins/src/system-types.mjs`) + loads every installed `system-type` module and returns + `{id, label, description, toolsets}`. It is fail-closed: a refused module, a + missing or extra key, or a toolset name that fails `NAME` throws + `system-type-invalid`. All five shipped modules (business-management, coding, + creative-writing, marketing, montage) declare `toolsets: []`. +- **Organization enable.** The organization file's + `plugins['system-type']` holds the enabled ids. `plugins.set` writes it + through the organization writer behind the owner fence + (`organization-system-types-human-only`) and returns a transaction receipt. + The bus reads the current set with `system-types.current` on every read and + write, so it never trusts a stale snapshot. +- **Project selection.** `project.system-types.set` appends a row to + `project_system_types` (bus store, `seq`-ordered, latest wins) and accepts + only enabled ids (`system-type-not-enabled`). A read returns + `{selected, active, inactive}`, where `active = selected ∩ enabled` and + `inactive = selected − enabled`. +- **Launch.** `resolveInstance` (`packages/organization/src/resolve.mjs`) + starts from the role definition's `tools`, filters them by each layer's + `limits.tools` (system, business, project, agent), and freezes the result + with a digest. The launcher (`packages/cli/src/launcher.mjs`) passes that + result to `buildBundle` (`packages/harness/src/bundle.mjs`), which writes + `policy.json` (`tools: builtinTools(resolved.limits.tools)`), `tools.json` + (typed host tools) and `manifest.json` once each (`flag: "wx"`). +- **Run tasks.** `scripts/mosaic-task.mjs` validates a mission's + `capabilities.tools` as a ceiling and a task's `capabilities.tools` as the + allowlist, both drawn from `SUPPORTED_TOOLS`. A task narrows the mission. + It never widens it. + +Nothing on the launch path reads system types today, so every launch gets +exactly its role's tools. That is the coding module's behavior, and the +design keeps it as the default. + +## Resolution at launch + +A launch resolves its toolsets in the host-side launcher, before +`resolveInstance` freezes the digest. In order: + +1. **Pick the project.** The launch's project is the one the session is + started for: the thread's project for a project thread, or none. A launch + with no single project (an organization-wide session, or a role started + with several code projects in scope) gets no system-type toolsets. Taking + the union across projects would widen one project's agent with another + project's tools, so the union is ruled out. +2. **Read the active set.** The launcher asks the bus, as the host, for the + project's selection and computes `active = selected ∩ enabled`. `enabled` + comes from `system-types.current`, the same trusted read the routes use. + Inactive selections are dropped and recorded in the manifest. They do not + refuse the launch, because the owner may disable a type at any time and + that must not strand running work. +3. **Load the modules.** `installedSystemTypes()` runs. If it throws + `system-type-invalid`, the launch refuses with that code. An active id + with no installed module refuses `system-type-missing`. +4. **Map toolset names to tools.** Each active module's `toolsets` are looked + up in the reviewed mapping file (below). The result is a set of tool names, + each a member of the role vocabulary `TOOLS` + (`packages/organization/src/vocabulary.mjs`) or a typed host tool that + `typedTools` already knows how to build. +5. **Bound by the ceilings.** The added tools are intersected, in this order, + with: + - the role's `systemTypeTools` ceiling (new, see the proposal); + - every layer's `limits.tools`, exactly as `resolveInstance` already + filters the base tools; + - for a run task, the mission's `capabilities.tools` and then the task's. + + The final set is `base ∪ added`, where `base` is today's result and + `added` has passed every filter above. Base tools are never removed by a + system type, and no added tool can exceed any ceiling. Invariant 7 holds + because each later layer can only remove entries. +6. **Record it.** `resolveInstance` takes the added list as an input and + includes `systemTypes: {project, active, dropped, toolsets, added}` in the + resolved object, so the digest covers it. `buildBundle` writes the same + block into `manifest.json`. The run record then shows which types and + mapping produced each tool. + +No step adds credentials, network reach or authority. `limits.network` and +`authority` are computed exactly as today. A toolset that needs a credential +gets it the way any role does, through the role file's `credentials` and a +reviewed commit. A system type never grants one. + +## The mapping file + +The mapping is repository policy, so it lives under `roles/` and changes only +through a reviewed commit, the same rule that governs `roles/*.json` +(invariant 7, AGENTS.md "Role model"). Proposed path: +`roles/toolsets/system-types.json`. It sits in a subdirectory because two +loaders read every `roles/*.json` as a role definition +(`instance-settings.mjs` `definitions()`, `harness/tests/tools.test.mjs`). +A mapping file at `roles/` top level would be read as a broken role. + +Proposed format: + +```json +{ + "toolsetsVersion": 1, + "toolsets": { + "repository": { "tools": ["read", "write", "edit", "bash", "grep", "find", "ls"] }, + "web-research": { "tools": ["web"] } + } +} +``` + +The two entries are illustrations, not part of the proposal. No shipped +module names a toolset today, so the file would ship as +`{"toolsetsVersion": 1, "toolsets": {}}`. + +Rules a loader enforces, fail-closed: + +- Exactly the keys `toolsetsVersion` (must be `1`) and `toolsets`. Each entry + has exactly the key `tools`. +- Each toolset name matches `NAME` from `packages/plugins/src/kinds.mjs`, the + same pattern modules must use. +- `tools` is a non-empty list of distinct names, each in `TOOLS` or in the + typed-tool names `typedTools` can build. Anything else refuses + `toolset-mapping-invalid` at load. +- The file is read from the release copy, like the role files, and its + sha256 goes into `manifest.sources`. + +Who may change it: a reviewed commit on the repository, landed by the lead +with Jason's authority over role policy. An organization owner cannot change +it at runtime, and neither the Console nor the bus has a write path to it. +Organization owners choose which types are enabled and projects choose among +them. The repository decides what a type's toolsets may contain. + +## Fail-closed behavior + +| Condition | Result | +| --- | --- | +| An installed module is refused or malformed | launch refuses `system-type-invalid` | +| An active id has no installed module | launch refuses `system-type-missing` | +| A module names a toolset the mapping lacks | launch refuses `toolset-unmapped` | +| The mapping file is missing, unreadable or invalid | launch refuses `toolset-mapping-invalid`, but only when at least one active type declares a toolset; a launch with nothing to map never reads it | +| A mapped tool is outside the role's `systemTypeTools` ceiling | the tool is dropped and recorded under `dropped`, launch continues | +| The bus cannot answer the project's selection | launch refuses `system-types-unavailable`; it does not fall back to "no types", which could hide a missing toolset the operator expects | +| A selection is inactive (disabled in the organization) | dropped and recorded, launch continues | + +The two "continue" rows are narrowing, never widening. Every row that could +change what an agent may do refuses instead. + +## The coding module + +Coding declares `toolsets: []`. It adds nothing, and a coding project's agent +keeps exactly its role's tools: for `roles/coder.json` that is +`read, write, edit, bash, grep, find, ls` with network `api-only`, the same as +today. Turning the design on changes nothing for any shipped module until a +module declares a toolset and a reviewed commit maps it. + +## Proposed `roles/` change (not applied) + +1. Add an optional V2 key `systemTypeTools` to the role schema + (`packages/organization/src/role.mjs`): a distinct list from `TOOLS` (same + check as `checkTools`, but empty is allowed). It is the role's ceiling for + tools a system type may add. Absent means `[]`, so no system type can add + any tool to that role. Every existing role file stays valid and behaves as + today. + + ```diff + const V2_REQUIRED = ["roleVersion", "name", "title", "contract", "tools", "network", "authority", "credentials"]; + -const V2_KEYS = [...V2_REQUIRED, "messaging", "skills", "hireable"]; + +const V2_KEYS = [...V2_REQUIRED, "messaging", "skills", "hireable", "systemTypeTools"]; + ``` + +2. Add `roles/toolsets/system-types.json` with an empty `toolsets` object, and + a loader beside the role loader with the checks listed above. +3. Have `resolveInstance` accept `systemTypes` (the launcher's step 1-4 + result) and apply step 5. Have `buildBundle` copy the block into the + manifest. `scripts/mosaic-task.mjs` already bounds tools by mission and + task. It would apply the same filter to the added list. + +No contract under `contracts/` changes: the constitution's least-privilege +rule already covers this, and the design adds no new authority. Each of the +three steps is a reviewed change to role policy and needs Jason's sign-off +before it is built. + +## Open points for the build + +- Business-file projects (`b.projects`, used for checkouts) and bus projects + (UUIDs in `project_system_types`) are separate records today. Step 1 needs + the launch to carry the bus project id of the thread it serves. The build + should confirm how a project thread names its project at launch before + wiring step 2. +- A running session keeps the toolsets it launched with. Disabling a type + takes effect at the next launch, which matches how role changes behave. diff --git a/packages/webui/src/cli.mjs b/packages/webui/src/cli.mjs index e18635559..57f6c977c 100644 --- a/packages/webui/src/cli.mjs +++ b/packages/webui/src/cli.mjs @@ -5,6 +5,7 @@ import { startServer, previewOptions, proofOptions, DEFAULT_BOARD } from './serv import { busCaller, busBusiness, userCaller, consoleCall } from './bus.mjs'; import { organizationConsole } from './organizations.mjs'; import { consoleBus, userOptionsFor, agentCaller, TESTER_AGENT_VERBS } from './console-bus.mjs'; +import { SYSTEM_TYPE_VERBS } from './system-types-http.mjs'; import { consoleAccess } from './access.mjs'; import { accessContextFor } from '../../cli/src/access.mjs'; import { accessFilePath, loadAccess } from '../../organization/src/access.mjs'; @@ -169,6 +170,9 @@ try { // The owner reads request status on the selected organization's bus, as on the root Console. Request // writes stay off: the README "Console actions" inventory marks them unavailable for the organizations release. requestRead: session.user === undefined ? consoleCall({ dataRoot: root, socket: paths.socket, business: id }) : null, + // Phase P2 (#1873): the owner's System types writes, the organization's enable switch (plugins.set + // with its revision) and a project's selection, over the owner's human transport under --send only. + systemTypesWrite: session.user === undefined && sendOn ? agentCaller(owner, SYSTEM_TYPE_VERBS) : null, reads: consoleReads({ root: REPO, queueRoot: options.checkout ?? REPO, system, configDir: configDir(), rolesDir: rolesDir(), business: id, orgRoot: root }), }; }, diff --git a/packages/webui/src/public/chat.js b/packages/webui/src/public/chat.js index 6acbe74a6..c81e37124 100644 --- a/packages/webui/src/public/chat.js +++ b/packages/webui/src/public/chat.js @@ -620,7 +620,7 @@ html += p && !c.refused && redesigned ? window.MosaicProjects.header(p, c.section, c.threads) : heading(p?.name ?? 'Project unavailable'); if (p && !c.refused) { if (p.archived && redesigned && !c.canSend) html += '

This project is archived. Its saved conversations and records stay readable.

'; - if (c.settings) html += `

Project overview

Project information

Repository: ${txt(p.repo || 'Not linked')}

Repository setting unavailable.
`; + if (c.settings) html += `

Project overview

Project information

Repository: ${txt(p.repo || 'Not linked')}

Repository setting unavailable.
System types unavailable.
`; else if (c.section === 'conversations' && redesigned) html += `

Conversations

${c.threads.filter(t=>!t.shared && t.project===p.id).map(t=>`${txt(t.name)}With ${txt(t.instance)}`).join('') || '

No conversations yet. Start one to begin work.

'}
${p.archived ? '' : `
New conversation${creation('thread', c.id)}
`}

Shared with me

${c.threads.some(t=>t.shared && t.project===p.id)?threads(c.threads.filter(t=>t.shared && t.project===p.id)):'

Nothing is shared with you yet.

'}`; else if (c.section === 'conversations') html += '

Conversations

' + threads(c.threads.filter(t => !t.shared)) + (p.archived ? '' : creation('thread', c.id)); else if (redesigned) html += '
Reading…
'; @@ -684,6 +684,9 @@ const remote = c.container.querySelector('[data-chat-remote]'); const project = c.projects.find(p => p.id === c.id); if (remote && roomOwner() && typeof window.MosaicProjectRemote?.mount === 'function') { remote.replaceChildren(); window.MosaicProjectRemote.mount({ container: remote, projectId: c.id, repositoryKey: project?.repo ?? null, projectArchived: !!c.projectArchived, preserve: true }); } + // Phase P2 (#1873): the project's System types selection, the owner's, mounted like the remote. + const types = c.container.querySelector('[data-chat-system-types]'); + if (types && roomOwner() && typeof window.MosaicSystemTypes?.mount === 'function') window.MosaicSystemTypes.mount({ container: types, projectId: c.id, archived: !!c.projectArchived }); if (!window.MosaicOrg && (!redesigned || c.kind !== 'project' || c.settings || c.projectArchived)) window.MosaicProjectArchive?.mount(c.container, c); if (redesigned && c.kind === 'project' && c.projectArchived && !c.settings) { const controls = c.container.querySelector('.project-archive-control'); diff --git a/packages/webui/src/public/index.html b/packages/webui/src/public/index.html index 1687c34d1..b13004bfe 100644 --- a/packages/webui/src/public/index.html +++ b/packages/webui/src/public/index.html @@ -7,7 +7,7 @@ - + diff --git a/packages/webui/src/public/system-types.css b/packages/webui/src/public/system-types.css new file mode 100644 index 000000000..e3b9d0e89 --- /dev/null +++ b/packages/webui/src/public/system-types.css @@ -0,0 +1,33 @@ +/* Phase P2 (#1873): System types on the organization dashboard (.ws-types, the chips and the + Settings row's Open) and on a project's information page (.project-types). */ +html[data-organizations] .ws-chip{display:inline-flex;align-items:center;font-size:12px;font-weight:500;padding:1px 7px;border:1px solid var(--line);border-radius:4px;color:var(--text);white-space:nowrap} +html[data-organizations] .ws-cfg button.go{border:0;background:none;padding:0;cursor:pointer;font:inherit;font-size:12.5px;font-weight:600;color:var(--action)} +html[data-organizations] .ws-cfg button.go:hover{text-decoration:underline} +html[data-organizations] .ws-types-list{display:grid;list-style:none;margin:0;padding:0;border:1px solid var(--line);border-radius:8px;overflow:hidden;background:var(--surface)} +html[data-organizations] .ws-types-list li{display:grid;grid-template-columns:minmax(0,1fr) auto auto;align-items:center;gap:4px 12px;padding:8px 12px;border-bottom:1px solid color-mix(in srgb,var(--line) 60%,transparent)} +html[data-organizations] .ws-types-list li:last-child{border-bottom:0} +html[data-organizations] .ws-types-list .t{display:flex;flex-direction:column;min-width:0} +html[data-organizations] .ws-types-list .t b{font-size:13px;font-weight:600;color:var(--strong)} +html[data-organizations] .ws-types-list .t .d{font-size:12px;color:var(--muted);overflow-wrap:anywhere} +html[data-organizations] .ws-types-list .ws-dot{font-size:12.5px} +html[data-organizations] .ws-types-list .ws-btn[aria-disabled="true"]{color:var(--muted);cursor:progress} +html[data-organizations] .ws-types>.note{margin:8px 0 0} +html[data-organizations] .ws-types-status:empty{display:none} +html[data-organizations] .ws-types-status code{overflow-wrap:anywhere} +html[data-organizations] .ws-types h2:focus{outline:none} +@media (max-width:759px){ + html[data-organizations] .ws-types-list li{grid-template-columns:minmax(0,1fr) auto} + html[data-organizations] .ws-types-list .t{grid-column:1/-1} +} + +.project-types{border:1px solid var(--border, var(--line, #aaa));border-radius:4px;padding:1rem;margin-top:1rem;overflow-wrap:anywhere} +.project-types fieldset{border:0;margin:0;padding:0;display:grid;gap:.5rem} +.project-types legend{font-weight:600;margin-bottom:.25rem} +.project-types-option{display:flex;align-items:flex-start;gap:.5rem;min-height:44px} +.project-types-option input{margin-top:.2rem;width:20px;height:20px;flex:none} +.project-types-option span{display:flex;flex-direction:column;min-width:0} +.project-types-option small{color:var(--muted, inherit)} +.project-types button{min-height:44px;margin-top:.75rem} +.project-types-tag{font-size:.8em;font-weight:600;padding:0 .4em;border:1px solid currentColor;border-radius:4px;color:var(--warning, inherit)} +.project-types [role="status"]:empty{display:none} +.project-types [role="status"]:focus{outline:none} diff --git a/packages/webui/src/public/system-types.js b/packages/webui/src/public/system-types.js new file mode 100644 index 000000000..b926f6e12 --- /dev/null +++ b/packages/webui/src/public/system-types.js @@ -0,0 +1,189 @@ +// Phase P2 (#1873): System types, the owner's control on the organization dashboard and on a project's +// information page. The modules, their labels and descriptions come from the system-type plug-ins +// through /api/system-types; nothing here lists a module. Writes go to the same route, which uses the +// organization writer (revision, owner fence, receipt) or project.system-types.set; the server and the +// bus recheck every write, so a control shown here grants nothing. +(() => { + 'use strict'; + const esc = value => String(value ?? '').replace(/[&<>"']/g, c => ({ '&': '&', '<': '<', '>': '>', '"': '"', "'": ''' }[c])); + const enc = encodeURIComponent; + const ID = /^[A-Za-z0-9][A-Za-z0-9._-]{0,159}$/; + const orgPath = (org, rest) => (org ? `/api/orgs/${enc(org)}/${rest}` : `/api/${rest}`); + const LINES = { + 'sign-in-required': 'Sign in again to see or change system types.', + 'owner-only': "System types are the organization owner's.", + 'read-only': 'This Console only reads. Changing system types needs signed-in send mode.', + 'human-required': "Only the organization's owner can change system types.", + 'organization-system-types-human-only': "Only the organization's owner can change system types.", + 'revision-conflict': 'The organization file changed after this page read it. The list was read again; try again.', + 'organization-busy': 'The organization file is being written. Try again in a moment.', + 'system-type-not-enabled': 'A chosen type is not enabled in the organization any more. The list was read again.', + 'system-type-unknown': 'A chosen type is not installed in this tree.', + 'project-not-found': 'This project was not found.', + 'not-configured': 'System types are not configured on this Console.', + 'system-type-invalid': 'An installed system type module is invalid, so none can be read.', + 'no-bus-host': 'The bus is not running.', + 'invalid-request': 'The request was refused as invalid.', + }; + const line = code => LINES[code] || 'The bus did not confirm the outcome. The list was read again; check it before you retry.'; + + // One request; a refusal keeps its code so the page can say why. + async function call(path, body) { + const init = body === undefined ? { cache: 'no-store', redirect: 'manual' } + : { method: 'POST', cache: 'no-store', redirect: 'manual', headers: { 'content-type': 'application/json' }, body: JSON.stringify(body) }; + let response; + try { response = await fetch(path, init); } catch { return { ok: false, code: 'outcome-unknown' }; } + if (response.type === 'opaqueredirect') return { ok: false, code: 'sign-in-required' }; + const value = await response.json().catch(() => null); + if (!response.ok) return { ok: false, code: typeof value?.error === 'string' ? value.error : 'outcome-unknown' }; + return value && typeof value === 'object' ? { ok: true, value } : { ok: false, code: 'outcome-unknown' }; + } + const read = (org, project = null) => call(orgPath(org, project === null ? 'system-types' : `system-types/projects/${enc(project)}`)); + const labelOf = (value, id) => value.installed.find(m => m.id === id)?.label || id; + const valid = value => value && Array.isArray(value.installed) && Array.isArray(value.enabled); + + // ---------- organization dashboard ---------- + // Per organization: the last read, the type a write is pending on, and the last outcome line. + const orgs = new Map(); + const slot = org => { if (!orgs.has(org)) orgs.set(org, { value: null, code: null, pending: null, outcome: null }); return orgs.get(org); }; + function remember(org, result) { + const s = slot(org); + if (result.ok && valid(result.value)) { s.value = result.value; s.code = null; } else { s.value = null; s.code = result.ok ? 'outcome-unknown' : result.code; } + return s; + } + // The chip row under the header: the enabled modules' labels. + function chips(org) { + const s = slot(org), v = s.value; + const body = !v ? `${esc(s.code === 'owner-only' ? line('owner-only') : 'System types unavailable')}` + : !v.installed.length ? 'No system type modules are installed.' + : v.enabled.length ? `${v.enabled.map(id => `${esc(labelOf(v, id))}`).join('')}Each project picks from these; none is required.` + : 'None enabled. Enable them under System types below; each project picks from the enabled ones.'; + return `
System types${body}
`; + } + // The Settings row's value. + function summary(org) { + const v = slot(org).value; + return v ? `${v.enabled.filter(id => v.installed.some(m => m.id === id)).length} of ${v.installed.length} installed enabled` : 'Could not be read'; + } + function section(org) { + const s = slot(org), v = s.value; + const head = `

System types

installed modules; each project picks from the enabled ones
`; + const status = `

${s.outcome ? s.outcome : ''}

`; + if (!v) return `
${head}

${esc(s.code === 'owner-only' ? line('owner-only') : `System types unavailable. ${line(s.code)}`)}

${status}
`; + if (!v.installed.length) return `
${head}

No system type modules are installed.

${status}
`; + const rows = v.installed.map(m => { + const on = v.enabled.includes(m.id), busy = s.pending !== null; + const state = `${on ? 'enabled' : 'off'}`; + const control = v.writable + ? `` + : ''; + return `
  • ${esc(m.label)}${esc(m.description)}${state}${control}
  • `; + }).join(''); + const why = v.writable ? '

    Disabling a type keeps it in the projects that pick it; they show it as inactive until it is enabled again.

    ' + : `

    ${esc(line('read-only'))}

    `; + return `
    ${head}${why}${status}
    `; + } + // The dashboard asks for this before it paints; the result stays for chips(), summary() and section(). + const load = async org => remember(org, await read(org)); + // After a write, the three parts are repainted in place; the 10 s dashboard repaint reads again anyway. + function repaint(org) { + if (window.MosaicOrg?.id !== org) return; + const view = document.querySelector('[data-org-dashboard]'); if (!view) return; + const a = document.activeElement, key = view.contains(a) ? a.dataset?.focusKey || null : null; + const swap = (selector, html) => { const el = view.querySelector(selector); if (el) el.outerHTML = html; }; + swap('[data-system-type-chips]', chips(org)); + swap('[data-system-types]', section(org)); + const value = view.querySelector('[data-org-setting="System types"] .v'); if (value) { value.textContent = summary(org); value.title = summary(org); } + if (key) view.querySelector(`[data-focus-key="${CSS.escape(key)}"]`)?.focus({ preventScroll: true }); + } + async function toggle(button) { + const org = window.MosaicOrg?.id, s = org ? slot(org) : null, type = button.dataset.systemTypeToggle; + if (!s?.value?.writable || s.pending !== null || typeof s.value.revision !== 'string') return; + const on = s.value.enabled.includes(type); + const enabled = on ? s.value.enabled.filter(id => id !== type) : [...s.value.enabled, type]; + s.pending = type; s.outcome = null; repaint(org); + const result = await call(orgPath(org, 'system-types'), { revision: s.value.revision, enabled }); + s.pending = null; + const label = labelOf(s.value, type); + if (result.ok && typeof result.value.transaction === 'string') { + s.outcome = `${esc(label)} ${on ? 'disabled' : 'enabled'}. Receipt ${esc(result.value.transaction)}.`; + } else s.outcome = esc(result.ok ? line('outcome-unknown') : line(result.code)); + await load(org); + repaint(org); + } + document.addEventListener('click', e => { + const button = e.target.closest?.('[data-system-type-toggle]'); + // A pending write marks the buttons aria-disabled, not disabled, so focus stays on the one pressed. + if (button) { e.preventDefault(); if (button.getAttribute('aria-disabled') !== 'true') toggle(button); return; } + const open = e.target.closest?.('[data-system-types-open]'); + if (open) { e.preventDefault(); const h = document.querySelector('[data-system-types-heading]'); h?.scrollIntoView({ block: 'start' }); h?.focus({ preventScroll: true }); } + }); + + // ---------- project information page ---------- + let active = null; + document.addEventListener('mosaic-signed-out', () => { active?.dispose(); active = null; }); + // The chat view mounts again on every repaint and keeps the section; leaving the page marks it stale, + // so coming back (say, after the dashboard changed the enabled set) reads again. + window.addEventListener('hashchange', () => { if (active) active.stale = true; }); + function mount({ container, projectId, archived = false }) { + if (!(container instanceof Element)) return; + const org = window.MosaicOrg?.id ?? null; + if (active && active.org === org && active.projectId === projectId) { + container.replaceChildren(active.section); + if (active.archived !== archived) { active.archived = archived; active.paint(); } + if (active.stale) { active.stale = false; active.refresh(); } + return; + } + active?.dispose(); + const section = document.createElement('section'); + section.className = 'project-types'; + section.setAttribute('data-project-system-types', ''); + container.replaceChildren(section); + let value = null, code = null, outcome = '', saving = false, disposed = false, generation = 0; + const state = { org, projectId, section, archived, stale: false, paint, refresh: () => refresh(), dispose: () => { disposed = true; generation++; section.replaceChildren(); } }; + active = state; + function paint() { + if (disposed) return; + const head = '

    System types

    '; + const status = `

    ${outcome}

    `; + if (!ID.test(projectId ?? '')) { section.innerHTML = `${head}

    System types unavailable.

    `; return; } + if (!value) { section.innerHTML = `${head}

    ${esc(code ? `System types unavailable. ${line(code)}` : 'Reading system types…')}

    ${status}`; return; } + const sel = value.project, enabled = value.installed.filter(m => value.enabled.includes(m.id)); + const inactive = sel.inactive.length + ? `

    Inactive, because the organization has disabled them:

    ${value.writable && !state.archived ? '

    Saving keeps only enabled types, so it removes these from the project.

    ' : ''}
    ` + : ''; + const intro = '

    This project picks from the system types its organization has enabled. None is required.

    '; + if (!enabled.length) { + section.innerHTML = `${head}${intro}

    The organization has no system types enabled. The owner enables them on the organization dashboard.

    ${inactive}${status}`; + return; + } + const canWrite = value.writable && !state.archived; + const boxes = enabled.map(m => ``).join(''); + const why = state.archived ? '

    This project is archived; its selection is shown read only.

    ' : value.writable ? '' : `

    ${esc(line('read-only'))}

    `; + section.innerHTML = `${head}${intro}
    Selected system types${boxes}
    ${inactive}${canWrite ? `` : ''}
    ${why}${status}`; + } + async function refresh() { + const turn = ++generation; + const result = await read(org, projectId); + if (disposed || turn !== generation) return; + if (result.ok && valid(result.value) && result.value.project) { value = result.value; code = null; } else { value = null; code = result.ok ? 'outcome-unknown' : result.code; } + paint(); + } + section.addEventListener('submit', async e => { + e.preventDefault(); + if (saving || !value?.writable || state.archived) return; + const chosen = [...section.querySelectorAll('input[name="system-type"]:checked')].map(i => i.value); + saving = true; outcome = ''; paint(); + const result = await call(orgPath(org, `system-types/projects/${enc(projectId)}`), { systemTypes: chosen }); + if (disposed) return; + saving = false; + outcome = result.ok ? esc(result.value.selected.length ? `Saved. Selected: ${result.value.selected.map(id => labelOf(value, id)).join(', ')}.` : 'Saved. No system types selected.') : esc(line(result.code)); + await refresh(); + section.querySelector('[data-project-system-types-status]')?.focus({ preventScroll: true }); + }); + paint(); + refresh(); + } + + window.MosaicSystemTypes = Object.freeze({ load, chips, summary, section, mount }); +})(); diff --git a/packages/webui/src/public/workspace.js b/packages/webui/src/public/workspace.js index c43959864..6225d471e 100644 --- a/packages/webui/src/public/workspace.js +++ b/packages/webui/src/public/workspace.js @@ -1,7 +1,8 @@ // The unified workspace screens in organization mode: the sidebar's Organizations and Projects // groups (sample 01), the organization dashboard (sample 03) and the Agents levels (sample 08). // Every read goes through MosaicWorkspaceData (workspace-data.js). Nothing here writes; the bus -// restart button is console-restart.js's own control, with its gating and trail unchanged. +// restart button is console-restart.js's own control, with its gating and trail unchanged, and the +// System types chips, row and section are system-types.js's (Phase P2), with its own reads and writes. (() => { 'use strict'; if (!document.documentElement.hasAttribute('data-organizations')) return; @@ -154,7 +155,7 @@ const secH = (title, note = '', link = '') => `

    ${title}

    ${note ? `${note}` : ''}${link}
    `; function settingsList(org, ctx) { - const { business, settings, instances, orgCount } = ctx; + const { business, settings, instances, orgCount, types } = ctx; const b = business?.business, s = settings; const unread = 'Could not be read'; const names = instances ? Object.keys(instances) : null; @@ -166,7 +167,7 @@ const rows = [ ['business', 'Identity', b ? `${label(org)} · ${org.id} · kind not recorded` : unread, 'org file', 'business'], ['flag', 'Appearance', `${titleCase(theme)} theme · ${initials(org)} avatar`, b?.appearance?.theme || org.theme ? 'org file' : 'system', 'appearance'], - ['cube', 'System types', 'Not built yet', 'not built', null], + ['cube', 'System types', types ? types.summary(org.id) : 'Could not be read', 'org file', types ? '@system-types' : null], ['folder', 'Projects', b ? (Array.isArray(b.projects) && b.projects.length ? plural(b.projects.length, 'project') : 'No projects') : unread, 'org file', '#/projects'], ['people', 'Agents and roles', names ? (names.length ? `${plural(names.length, 'agent')} · ${Object.values(instances).filter(running).length} running` : 'No agents') : unread, 'org file', 'agents'], ['term', 'Models and routing', models ? (models.length ? models.join(' · ') : 'No models set') : unread, 'org file', 'routing'], @@ -185,8 +186,10 @@ ['close', 'Archive or delete', "Archive or delete this organization's file", 'danger', 'organizations'], ]; return ``; } @@ -200,7 +203,8 @@ const list = Array.isArray(listRead) ? listRead : null; const org = list?.find(o => o.id === id && !o.invalid); if (!org) return `

    Organization unavailable

    ${list ? 'This organization is not on your list.' : 'The organization list could not be read.'}

    `; - const reads = await Promise.allSettled([data.business(id), data.settings(id), data.instances(id), data.threads(id), data.projects(id), data.queue(id), data.agents(id), data.claims(id)]); + const types = window.MosaicSystemTypes || null; + const reads = await Promise.allSettled([data.business(id), data.settings(id), data.instances(id), data.threads(id), data.projects(id), data.queue(id), data.agents(id), data.claims(id), types ? types.load(id) : null]); const value = i => (reads[i].status === 'fulfilled' ? reads[i].value : null); const business = value(0), settings = value(1), instances = instancesOf(value(2)); const threads = rowsOf(value(3)), projectRows = rowsOf(value(4)), queue = rowsOf(value(5)); @@ -220,7 +224,7 @@ const meta = `

    Kind not recordedid ${esc(id)}Tracker: ${tracker ? esc(titleCase(tracker)) : 'not set'}${dot(bcls, bglyph, org.busHealthy ? `bus running, read ${clock()}` : `bus unavailable, read ${clock()}`, true)}Restart is a trailed human action; reload arrives with the cross-org update.

    `; const projectName = pid => projectRows?.find(p => p.id === pid)?.name || pid; - const typechips = '
    System typesNo system types yet. They arrive with the system types update.
    '; + const typechips = types ? types.chips(id) : '
    System typesSystem types unavailable
    '; const docChips = !docRead ? 'Docs unavailable' : docRead.failed ? 'Docs unavailable' : docRead.rows.length ? docRead.rows.slice(0, 6).map(d => `${icon('doc')}${esc(docName(d.path))}${esc(projectName(d.project))}`).join('') : 'No docs yet'; const docrow = `
    Docs${docChips}All docs
    `; @@ -258,7 +262,8 @@
    ${secH('Settings', 'every setting, with where its value comes from')} - ${settingsList(org, { business, settings, instances, orgCount: list ? list.length : null })} + ${settingsList(org, { business, settings, instances, orgCount: list ? list.length : null, types })} + ${types ? types.section(id) : ''}
    `; diff --git a/packages/webui/src/serve.mjs b/packages/webui/src/serve.mjs index b17e8bc38..0340a3c99 100644 --- a/packages/webui/src/serve.mjs +++ b/packages/webui/src/serve.mjs @@ -18,6 +18,7 @@ import { themesHTTP } from './themes-http.mjs'; import { DECISION_ROUTE, decisionHTTP, decisionRefuse, createConfirmations } from './decision-http.mjs'; import { REQUEST_ROUTE, requestHTTP, requestRefuse } from './request-http.mjs'; import { PROJECT_REMOTE_ROUTE, projectRemoteHTTP } from './project-remote-http.mjs'; +import { SYSTEM_TYPES_ROUTE, systemTypesHTTP } from './system-types-http.mjs'; import { orgAdminHTTP, defaultOrgAdmin } from './org-admin.mjs'; import { consoleRestartHTTP } from './console-restart-http.mjs'; import { workspaceHTTP } from './workspace-read.mjs'; @@ -76,6 +77,9 @@ const files = new Map([ ['/editor.css', ['editor.css', 'text/css; charset=utf-8']], ['/icons.svg', ['icons.svg', 'image/svg+xml']], ['/project-remote.css', ['project-remote.css', 'text/css; charset=utf-8']], + // Phase P2 (#1873): the owner's System types control (dashboard section and project selection). + ['/system-types.js', ['system-types.js', 'text/javascript; charset=utf-8']], + ['/system-types.css', ['system-types.css', 'text/css; charset=utf-8']], ...[400, 500, 600, 700].map(w => [`/assets/fonts/manrope-${w}.woff2`, [`assets/fonts/manrope-${w}.woff2`, 'font/woff2']]), ...[400, 500, 700].map(w => [`/assets/fonts/jetbrains-mono-${w}.woff2`, [`assets/fonts/jetbrains-mono-${w}.woff2`, 'font/woff2']]), ]); @@ -507,7 +511,9 @@ const AGENT_ROUTES = { }; // F3: the writes the owner makes on a selected organization's bus from Settings (dev org Console). const ORG_OWNER_WRITE = path => path === '/api/settings' || path === '/api/instances' || path === '/api/routes' - || Object.hasOwn(SEAT_ROUTES, path) || Object.hasOwn(AGENT_ROUTES, path) || path.startsWith('/api/proxy/'); + || Object.hasOwn(SEAT_ROUTES, path) || Object.hasOwn(AGENT_ROUTES, path) || path.startsWith('/api/proxy/') + // Phase P2 (#1873): the System types enable switch and a project's selection; the route keeps its own checks. + || SYSTEM_TYPES_ROUTE.test(path); async function agentSend(req, res, { route, agentWrite, preview, log, note = null }) { let target = null; // The instance or name is quoted and cut short so a crafted value can't forge a log line. A reason is never logged. @@ -773,7 +779,7 @@ async function libraryStatusRead(res, read, search) { // `log` takes one line per send attempt that got past sign-in; never the body. `fieldsFile` is for // tests; the field table is otherwise the committed packages/tasks/fields.json. // `agentWrite` (row 194, D7) is `(verb, args) => Promise` for the Agents section's verbs and instance.request. -export async function startServer({ host = '127.0.0.1', port = 7330, board = DEFAULT_BOARD, timeout = 20000, bus = null, reads = null, preview = null, sso = null, tester = false, testerSocket = null, testerAuthHeader = null, proof = null, testerProofHeader = null, send = null, settingsWrite = null, projectFiles = null, projectFile = null, projectSave = null, libraryStatus = null, libraryRevert = null, chat = null, nameWrite = null, assistantStop = null, instancesWrite = null, routesWrite = null, agentWrite = null, proxyCall = null, processing = null, decisionWrite = null, requestRead = null, requestWrite = null, userOptions = null, federation = null, organizations = null, preselect = null, routes = [], orgAdmin = null, devAllowHosts = [], log = line => console.log(line), fieldsFile = undefined, restart = null, trail = null, boot = randomUUID(), workspaceTimeoutMs = undefined, agentLevels = null } = {}) { +export async function startServer({ host = '127.0.0.1', port = 7330, board = DEFAULT_BOARD, timeout = 20000, bus = null, reads = null, preview = null, sso = null, tester = false, testerSocket = null, testerAuthHeader = null, proof = null, testerProofHeader = null, send = null, settingsWrite = null, projectFiles = null, projectFile = null, projectSave = null, libraryStatus = null, libraryRevert = null, chat = null, nameWrite = null, assistantStop = null, instancesWrite = null, routesWrite = null, agentWrite = null, proxyCall = null, processing = null, decisionWrite = null, requestRead = null, requestWrite = null, systemTypesWrite = null, userOptions = null, federation = null, organizations = null, preselect = null, routes = [], orgAdmin = null, devAllowHosts = [], log = line => console.log(line), fieldsFile = undefined, restart = null, trail = null, boot = randomUUID(), workspaceTimeoutMs = undefined, agentLevels = null } = {}) { // org-lan-bind: the dev owner on the LAN is an explicit opt-in. `devAllowHosts` names the Host // names (without a port) a remote browser may use; only the dev owner takes them, and only with // them may it bind a non-loopback IPv4 address. SSO, preview and tester listeners stay loopback. @@ -796,6 +802,8 @@ export async function startServer({ host = '127.0.0.1', port = 7330, board = DEF // #797 / #1839 Task 3: the request intake reads need --sso, the writes also --send; never the tester. if ((requestRead !== null || requestWrite !== null) && (tester || sso === null || (requestRead !== null && typeof requestRead !== 'function') || (requestWrite !== null && (send === null || typeof requestWrite !== 'function')))) throw new Error('Console requests need --sso (and --send for the writes) on the main listener'); + // Phase P2 (#1873): the owner's System types writes need --sso and --send, never the tester. + if (systemTypesWrite !== null && (tester || sso === null || send === null || typeof systemTypesWrite !== 'function')) throw new Error('System types writes need --sso and --send on the main listener'); const confirmations = createConfirmations(); const registered = routeTable(); for (const registerRoutes of routes) registerRoutes(registered); @@ -818,7 +826,7 @@ export async function startServer({ host = '127.0.0.1', port = 7330, board = DEF // `userOptions` (FED R6, #1800) is `session => options`, the bus-backed options over that session // user's own transport (console-bus.mjs). Only a signed-in listener has user sessions. if (userOptions !== null && (sso === null || typeof userOptions !== 'function')) throw new Error('user sessions need --sso'); - const owner = { bus, reads, send, settingsWrite, projectFiles, projectFile, projectSave, libraryStatus, libraryRevert, chat, nameWrite, assistantStop, instancesWrite, routesWrite, agentWrite, proxyCall, processing, decisionWrite, requestRead, requestWrite, upstream, files }; + const owner = { bus, reads, send, settingsWrite, projectFiles, projectFile, projectSave, libraryStatus, libraryRevert, chat, nameWrite, assistantStop, instancesWrite, routesWrite, agentWrite, proxyCall, processing, decisionWrite, requestRead, requestWrite, systemTypesWrite, upstream, files }; const hub = federationView(federation); // An object with none of the three is refused too: asking for the preview never serves without it. if (preview !== null && !(preview = previewOptions({ publicHost: preview.host, authHeader: preview.header, allowUser: preview.user }))) { @@ -832,7 +840,7 @@ export async function startServer({ host = '127.0.0.1', port = 7330, board = DEF let boundAddress = null, boundPort = null; const server = createServer(async (req, res) => { // A granted user's request rebinds these below; every other request keeps the owner's. - let { bus, reads, send, settingsWrite, projectFiles, projectFile, projectSave, libraryStatus, libraryRevert, chat, nameWrite, assistantStop, instancesWrite, routesWrite, agentWrite, proxyCall, processing, decisionWrite, requestRead, requestWrite, upstream, files } = owner, granted = false, chatGrants = []; + let { bus, reads, send, settingsWrite, projectFiles, projectFile, projectSave, libraryStatus, libraryRevert, chat, nameWrite, assistantStop, instancesWrite, routesWrite, agentWrite, proxyCall, processing, decisionWrite, requestRead, requestWrite, systemTypesWrite, upstream, files } = owner, granted = false, chatGrants = []; res.setHeader('x-content-type-options', 'nosniff'); res.setHeader('referrer-policy', 'no-referrer'); // Under --sso the Sign out form's POST is redirected to the provider's end-session endpoint, and @@ -902,7 +910,7 @@ export async function startServer({ host = '127.0.0.1', port = 7330, board = DEF // alone stays open on a loopback Host for the status and release gates (Q-C). if (sso !== null && !named && !(path === '/healthz' && req.method === 'GET')) return json(res, 403, { error: 'public Host required' }); // No CORS. JSON content type and same-origin checks keep browser forms out. - const decisionPath = DECISION_ROUTE.test(path), requestPath = REQUEST_ROUTE.test(path), remotePath = PROJECT_REMOTE_ROUTE.test(path); + const decisionPath = DECISION_ROUTE.test(path), requestPath = REQUEST_ROUTE.test(path), remotePath = PROJECT_REMOTE_ROUTE.test(path), systemTypesPath = SYSTEM_TYPES_ROUTE.test(path); if (req.headers.origin && req.headers.origin !== (named ? (sso ? (localOrigin ?? sso.publicOrigin) : `https://${preview.host}`) : `http://${req.headers.host}`)) return decisionPath ? decisionRefuse(res, 'cross-origin') : requestPath ? requestRefuse(res, 'cross-origin') : json(res, 403, { error: 'cross-origin request refused' }); let signer = preview, ssoSession = null; @@ -914,7 +922,7 @@ export async function startServer({ host = '127.0.0.1', port = 7330, board = DEF if (!session && path !== '/healthz') { if (decisionPath) return decisionRefuse(res, 'sign-in-required'); if (requestPath) return requestRefuse(res, 'sign-in-required'); - if (remotePath) return json(res, 401, { error: 'sign-in-required' }); + if (remotePath || systemTypesPath) return json(res, 401, { error: 'sign-in-required' }); if (path.startsWith('/api/') || req.method !== 'GET') return json(res, 401, { error: 'sign-in required' }); res.writeHead(303, { location: `/auth/login?return=${encodeURIComponent(path + search)}`, 'cache-control': 'no-store' }); return res.end(); @@ -928,7 +936,7 @@ export async function startServer({ host = '127.0.0.1', port = 7330, board = DEF if (!organizations && !userRoute(path, req.method)) return json(res, 403, { error: 'owner-only', message: 'this part of the Console is the business owner\'s' }); if (!organizations && userOptions === null) return json(res, 503, { error: 'not-configured', message: 'the Console has no user transport' }); if (!organizations) ({ bus, send, settingsWrite, projectFiles, projectFile, projectSave, chat, nameWrite, assistantStop, instancesWrite, routesWrite, agentWrite, processing } = userOptions(session)); - reads = null; upstream = null; libraryStatus = null; libraryRevert = null; files = USER_FILES; granted = true; proxyCall = null; + reads = null; upstream = null; libraryStatus = null; libraryRevert = null; files = USER_FILES; granted = true; proxyCall = null; systemTypesWrite = null; chatGrants = sso.chatGrants?.(session) ?? []; } } @@ -959,7 +967,7 @@ export async function startServer({ host = '127.0.0.1', port = 7330, board = DEF ({ bus = null, reads = null, send = null, settingsWrite = null, projectFiles = null, projectFile = null, projectSave = null, libraryStatus = null, libraryRevert = null, chat = null, nameWrite = null, assistantStop = null, instancesWrite = null, routesWrite = null, agentWrite = null, proxyCall = null, - processing = null, decisionWrite = null, requestRead = null, requestWrite = null, upstream = null } = selected); + processing = null, decisionWrite = null, requestRead = null, requestWrite = null, systemTypesWrite = null, upstream = null } = selected); } // F3: the owner's settings writes reach the selected organization's bus too (limits, routing, // agents, assistant, instances, model proxy). The routes below keep their own checks. @@ -1016,7 +1024,13 @@ export async function startServer({ host = '127.0.0.1', port = 7330, board = DEF return projectRemoteHTTP(req, res, { path, read: requestRead, write: send ? requestWrite : null, session: ssoSession, live: () => sso.session(req), origin: localOrigin ?? sso.publicOrigin }); } - if (tester && ['/project-remote.js', '/project-remote.css', '/files.js', '/files.css'].includes(path)) return json(res, 403, { error: 'owner-only' }); + // Phase P2 (#1873): the owner's System types read and writes on the selected organization. + if (systemTypesPath) { + if (tester || granted || !named || sso === null) return json(res, 403, { error: 'owner-only' }); + return systemTypesHTTP(req, res, { path, read: requestRead, write: send ? systemTypesWrite : null, + session: ssoSession, live: () => sso.session(req), origin: localOrigin ?? sso.publicOrigin }); + } + if (tester && ['/project-remote.js', '/project-remote.css', '/files.js', '/files.css', '/system-types.js', '/system-types.css'].includes(path)) return json(res, 403, { error: 'owner-only' }); // Row 194 (#1692, D4.1): the tester also launches and terminates. if (tester && !['GET', 'HEAD'].includes(req.method) && !['/api/instances', '/api/routes', '/api/name', '/api/agent/launch', '/api/agent/terminate'].includes(path) && !TESTER_CHAT_WRITE.test(path)) return json(res, 403, { error: 'read-only', sent: false }); diff --git a/packages/webui/src/system-types-http.mjs b/packages/webui/src/system-types-http.mjs new file mode 100644 index 000000000..d08419d29 --- /dev/null +++ b/packages/webui/src/system-types-http.mjs @@ -0,0 +1,131 @@ +// Phase P2 (#1873): the owner's System types routes on a selected organization. Owner Console +// transports only; no caller-supplied business, actor or subject reaches the bus. +// +// GET /api/system-types installed modules (label, description) and the enabled set, +// plus the plugin revision when writes are on +// POST /api/system-types {revision, enabled}: plugins.set {'system-type': enabled}, +// the organization writer's owner fence, revision and receipt +// GET /api/system-types/projects/ the same, with the project's selection, active and inactive +// POST /api/system-types/projects/ {systemTypes}: project.system-types.set +// +// `read` is the owner's Console call (consoleCall): it reaches only `system-types.console`, which the +// broker answers to the business human's console cap. `write` is the owner's human transport limited +// to SYSTEM_TYPE_VERBS, present only for the owner's own session under --send. +export const SYSTEM_TYPES_ROUTE = /^\/api\/system-types(?:\/projects\/([^/]+))?$/; +export const SYSTEM_TYPE_VERBS = Object.freeze(['plugins', 'plugins.set', 'project.system-types.set']); +const ID = /^[A-Za-z0-9][A-Za-z0-9._-]{0,159}$/; +// A module name, as plugins/src/kinds.mjs NAME. +const NAME = /^[a-z][a-z0-9-]{0,63}$/; +const REVISION = /^[a-f0-9]{64}$/; +const TRANSACTION = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/; +const MAX_TYPES = 64; +const one = (req, key) => req.headersDistinct[key]?.length === 1 ? req.headersDistinct[key][0] : null; +const codes = { + 'invalid-request': 400, 'invalid-plugins': 400, 'unknown-plugin': 400, 'system-type-unknown': 400, + 'project-not-found': 404, 'revision-conflict': 409, 'organization-busy': 409, 'system-type-not-enabled': 409, + 'human-required': 403, 'organization-system-types-human-only': 403, 'read-only': 403, + 'not-configured': 503, 'system-type-invalid': 503, 'no-bus-host': 503, +}; +function json(res, status, value) { + res.writeHead(status, { 'content-type': 'application/json', 'cache-control': 'no-store' }); + res.end(JSON.stringify(value)); +} +const names = list => Array.isArray(list) && list.length <= MAX_TYPES && list.every(x => typeof x === 'string' && NAME.test(x)) && new Set(list).size === list.length; +const text = value => typeof value === 'string' && value.trim() !== '' && value.length <= 400 && !/[\r\n]/.test(value); +function consoleShape(result, project) { + if (!result || !Array.isArray(result.installed) || !names(result.enabled)) return null; + const installed = []; + for (const m of result.installed) { + if (!m || !NAME.test(m.id ?? '') || !text(m.label) || !text(m.description)) return null; + installed.push({ id: m.id, label: m.label, description: m.description }); + } + if (new Set(installed.map(m => m.id)).size !== installed.length) return null; + let selection = null; + if (project !== null) { + const p = result.project; + if (!p || p.project !== project || !names(p.selected) || !names(p.active) || !names(p.inactive)) return null; + selection = { project, selected: p.selected, active: p.active, inactive: p.inactive }; + } else if (result.project !== null) return null; + return { installed, enabled: result.enabled, project: selection }; +} +const selectionShape = (r, project) => r && r.project === project && names(r.selected) && names(r.active) && names(r.inactive) + ? { project, selected: r.selected, active: r.active, inactive: r.inactive } : null; + +async function body(req, keys) { + if (one(req, 'content-type')?.split(';')[0].trim().toLowerCase() !== 'application/json') return null; + const chunks = []; let size = 0; + for await (const chunk of req) { size += chunk.length; if (size > 4096) return 'too-large'; chunks.push(chunk); } + let value; + try { value = JSON.parse(Buffer.concat(chunks).toString('utf8')); } catch { return null; } + if (!value || typeof value !== 'object' || Array.isArray(value) || Object.keys(value).length !== keys.length || !keys.every(k => Object.hasOwn(value, k))) return null; + return value; +} + +export async function systemTypesHTTP(req, res, { path, read, write, session, live, origin }) { + const refuse = (status, error) => json(res, status, { error }); + const fail = error => { const code = codes[error?.code] ? error.code : 'outcome-unknown'; return refuse(codes[code] ?? 503, code); }; + if (!['GET', 'POST'].includes(req.method)) return refuse(405, 'method-not-allowed'); + if (!session) return refuse(401, 'sign-in-required'); + if (!read) return refuse(503, 'not-configured'); + if (req.method === 'POST' && !write) return refuse(403, 'read-only'); + const site = one(req, 'sec-fetch-site'), from = one(req, 'origin'); + if (req.method === 'POST' ? from !== origin || site !== 'same-origin' + : (req.headersDistinct.origin && from !== origin) || (req.headersDistinct['sec-fetch-site'] && !['same-origin', 'none'].includes(site))) + return refuse(403, 'cross-origin'); + let project = null; + const match = SYSTEM_TYPES_ROUTE.exec(path); + if (match?.[1] !== undefined) { + try { project = decodeURIComponent(match[1]); } catch { return refuse(404, 'project-not-found'); } + if (!ID.test(project)) return refuse(404, 'project-not-found'); + } + let args = null; + if (req.method === 'POST') { + const value = await body(req, project === null ? ['revision', 'enabled'] : ['systemTypes']); + if (value === 'too-large') return refuse(413, 'invalid-request'); + if (!value) return refuse(400, 'invalid-request'); + if (project === null ? typeof value.revision !== 'string' || !REVISION.test(value.revision) || !names(value.enabled) : !names(value.systemTypes)) + return refuse(400, 'invalid-request'); + args = value; + } + if (live() !== session) return refuse(401, 'sign-in-required'); + const subject = { provider: session.provider, iss: session.iss, sub: session.sub }; + // The read comes first on every request: a write names only modules this organization has installed. + let current; + try { current = consoleShape(await read('system-types.console', project === null ? {} : { project }, { subject }), project); } + catch (error) { return fail(error); } + if (!current) return refuse(503, 'outcome-unknown'); + const installed = new Set(current.installed.map(m => m.id)); + + if (req.method === 'GET') { + let revision = null; + if (write && project === null) { + try { revision = (await write('plugins', {}))?.revision ?? null; } catch (error) { return fail(error); } + if (!REVISION.test(revision ?? '')) return refuse(503, 'outcome-unknown'); + } + if (live() !== session) return refuse(401, 'sign-in-required'); + return json(res, 200, { ...current, writable: Boolean(write), ...(project === null && write ? { revision } : {}) }); + } + + if (project === null) { + if (args.enabled.some(id => !installed.has(id))) return refuse(400, 'system-type-unknown'); + let result; + try { result = await write('plugins.set', { revision: args.revision, plugins: { 'system-type': args.enabled } }); } + catch (error) { return fail(error); } + // A write admitted at spawn may already have committed: its receipt is returned even if the + // session ended meanwhile, never reported as not done. + const enabled = result?.plugins?.['system-type'] ?? []; + if (!result || !REVISION.test(result.revision ?? '') || !TRANSACTION.test(result.transaction ?? '') || !names(enabled) + || JSON.stringify(enabled) !== JSON.stringify(args.enabled)) + return refuse(503, 'outcome-unknown'); + return json(res, 200, { enabled, revision: result.revision, transaction: result.transaction }); + } + + // The broker refuses a type the organization has not enabled (system-type-not-enabled); a type that + // is not installed is refused here first. + if (args.systemTypes.some(id => !installed.has(id))) return refuse(400, 'system-type-unknown'); + let result; + try { result = selectionShape(await write('project.system-types.set', { project, systemTypes: args.systemTypes }), project); } + catch (error) { return fail(error); } + if (!result || JSON.stringify(result.selected) !== JSON.stringify(args.systemTypes)) return refuse(503, 'outcome-unknown'); + return json(res, 200, result); +} diff --git a/packages/webui/tests/browser.test.mjs b/packages/webui/tests/browser.test.mjs index 1d1a77b5c..036c91f45 100644 --- a/packages/webui/tests/browser.test.mjs +++ b/packages/webui/tests/browser.test.mjs @@ -18,8 +18,8 @@ test('served Console browser: real board fixtures, keyboard, drafts, receipts, t assert.equal(await b.evaluate('document.querySelector("#session-count").textContent'), '3 of 4'); await b.evaluate('document.querySelector("#hide-offline").click()'); assert.equal(await b.evaluate('document.querySelectorAll("table.sessions tbody tr").length'), 4); - // Rows 129, 154, 191, 194 and 294: chat.js, editor.js, processing.js, agents.js and federation.js are the scripts added, and #1839 adds requests.js (the intake panel under an owner's chat message), all same origin; the list is the pin, so another script is a visible change. #797 adds project-archive.js immediately after chat.js. F2 adds onboarding.js after org-create.js, and F3 adds console-restart.js after it. U2 (#1873) adds workspace-data.js and workspace.js before console-restart.js, and U4b adds tasks-board.js after workspace.js. U5 (#1873) adds panes.js (Side by side) just before bus.js, which mounts it. - assert.deepEqual(await b.evaluate('[...document.querySelectorAll("script")].map(s => s.getAttribute("src"))'), ['/editor.js', '/processing.js', '/org-create.js', '/onboarding.js', '/workspace-data.js', '/workspace.js', '/tasks-board.js', '/console-restart.js', '/display.js', '/inbox.js', '/files.js', '/project-remote.js', '/federation.js', '/brand.js', '/app.js', '/markdown-preview.js', '/projects.js', '/chat.js', '/project-archive.js', '/agents.js', '/panes.js', '/bus.js', '/requests.js']); + // Rows 129, 154, 191, 194 and 294: chat.js, editor.js, processing.js, agents.js and federation.js are the scripts added, and #1839 adds requests.js (the intake panel under an owner's chat message), all same origin; the list is the pin, so another script is a visible change. #797 adds project-archive.js immediately after chat.js. F2 adds onboarding.js after org-create.js, and F3 adds console-restart.js after it. U2 (#1873) adds workspace-data.js and workspace.js before console-restart.js, and U4b adds tasks-board.js after workspace.js. U5 (#1873) adds panes.js (Side by side) just before bus.js, which mounts it. P2 (#1873) adds system-types.js after project-remote.js. + assert.deepEqual(await b.evaluate('[...document.querySelectorAll("script")].map(s => s.getAttribute("src"))'), ['/editor.js', '/processing.js', '/org-create.js', '/onboarding.js', '/workspace-data.js', '/workspace.js', '/tasks-board.js', '/console-restart.js', '/display.js', '/inbox.js', '/files.js', '/project-remote.js', '/system-types.js', '/federation.js', '/brand.js', '/app.js', '/markdown-preview.js', '/projects.js', '/chat.js', '/project-archive.js', '/agents.js', '/panes.js', '/bus.js', '/requests.js']); assert.equal(await b.evaluate(`document.querySelectorAll('script[src="/processing.js"]').length`), 1); assert.equal(await b.evaluate(`document.querySelectorAll('script[src="/chat.js"]').length`), 1); assert.equal(await b.evaluate('!!window.injected'), false); diff --git a/packages/webui/tests/helpers/system-types-fake.mjs b/packages/webui/tests/helpers/system-types-fake.mjs new file mode 100644 index 000000000..784b9ec79 --- /dev/null +++ b/packages/webui/tests/helpers/system-types-fake.mjs @@ -0,0 +1,42 @@ +import { createHash, randomUUID } from 'node:crypto'; +import { installedSystemTypes } from '../../../plugins/src/system-types.mjs'; + +// Phase P2 (#1873): a per-organization stand-in for the two transports the System types routes use, +// shaped as the broker answers them. `requestRead` answers system-types.console with the installed +// modules (the plug-in data itself, read from packages/plugins), the enabled set and a project's +// selection. `systemTypesWrite` answers plugins, plugins.set (revision checked, a transaction +// returned) and project.system-types.set (enabled types only). `owner: false` makes plugins.set +// refuse as the organization writer's owner fence does for anyone but the human. +export async function systemTypesFake({ enabled = [], projects = {}, owner = true } = {}) { + const installed = await installedSystemTypes(); + const state = { enabled: [...enabled], projects: structuredClone(projects), n: 0, writes: [] }; + const revision = () => createHash('sha256').update(`system-types-${state.n}`).digest('hex'); + const fail = code => { throw Object.assign(new Error(code), { code }); }; + const selection = project => { + const selected = state.projects[project]; + return { project, selected: [...selected], active: selected.filter(x => state.enabled.includes(x)), inactive: selected.filter(x => !state.enabled.includes(x)) }; + }; + const requestRead = async (verb, args) => { + if (verb !== 'system-types.console') fail('invalid-request'); + if (args.project !== undefined && !Object.hasOwn(state.projects, args.project)) fail('project-not-found'); + return { installed: structuredClone(installed), enabled: [...state.enabled], project: args.project === undefined ? null : selection(args.project) }; + }; + const systemTypesWrite = async (verb, args) => { + state.writes.push(verb); + if (verb === 'plugins') return { business: 'fake', revision: revision(), plugins: { 'system-type': [...state.enabled] } }; + if (verb === 'plugins.set') { + if (args.revision !== revision()) fail('revision-conflict'); + if (!owner) fail('organization-system-types-human-only'); + state.enabled = [...args.plugins['system-type']]; state.n++; + return { business: 'fake', revision: revision(), plugins: { 'system-type': [...state.enabled] }, transaction: randomUUID() }; + } + if (verb === 'project.system-types.set') { + if (!Object.hasOwn(state.projects, args.project)) fail('project-not-found'); + if (args.systemTypes.some(x => !state.enabled.includes(x))) fail('system-type-not-enabled'); + state.projects[args.project] = [...args.systemTypes]; + return selection(args.project); + } + fail('invalid-request'); + }; + return { requestRead, systemTypesWrite, state, installed }; +} diff --git a/packages/webui/tests/system-types-browser.test.mjs b/packages/webui/tests/system-types-browser.test.mjs new file mode 100644 index 000000000..d3b707974 --- /dev/null +++ b/packages/webui/tests/system-types-browser.test.mjs @@ -0,0 +1,192 @@ +// Phase P2 (#1873): System types on the organization dashboard (sample 03) and on a project's information +// page. The Console, its per-organization routes and the pages are real; only the two bus transports are +// the fake in helpers/system-types-fake.mjs, which reads the installed modules from packages/plugins. The +// server-side admission checks and the real organization writer are in system-types-http.test.mjs. +// MOSAIC_UX_SHOTS= also writes light and dark shots at 1440x900 and 390x844. +import { test } from 'node:test'; +import assert from 'node:assert/strict'; +import { mkdirSync } from 'node:fs'; +import { join } from 'node:path'; +import { startServer } from '../src/serve.mjs'; +import { createDevOwner } from '../src/dev-owner.mjs'; +import { browser } from './browser.mjs'; +import { close } from './fixture.mjs'; +import { systemTypesFake } from './helpers/system-types-fake.mjs'; + +const P = '10000000-0000-4000-8000-0000000000b1'; +const RECEIPT = /Receipt ([0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12})\./; +const waitFor = b => expression => b.evaluate(`(async()=>{for(let i=0;i<300;i++){if(${expression})return true;await new Promise(r=>setTimeout(r,30))}throw Error(${JSON.stringify(expression)}+' | '+(document.querySelector('main')?.innerText||'').slice(0,1500))})()`); + +// One running organization with one project. `send` is the owner's signed-in send mode; without it the +// Console only reads and the route gets no writer. +function organizations(st, { send = true } = {}) { + const business = { business: { id: 'acme', human: 'jason', arbiters: [], projects: [P], vars: {}, instances: [], appearance: { theme: null } } }; + return { + list: async () => [{ id: 'acme', label: 'Acme', theme: null, busHealthy: true }], + resolve: async id => id !== 'acme' ? null : ({ + busHealthy: true, requestRead: st.requestRead, systemTypesWrite: send ? st.systemTypesWrite : null, ...(send ? { send: async () => ({}) } : {}), + reads: { business: async () => business, settings: async () => ({}), queue: async () => ({ rows: [] }), busStatus: async () => ({}) }, + bus: { instances: async () => ({ business: 'acme', revision: 'a'.repeat(64), launch: true, noHire: [], retired: [], definitions: {}, instances: {} }), + messages: async () => ({ messages: [], unread: 0 }), agents: async () => [], 'thread.claims': async () => [], inbox: async () => [], tasks: async () => [] }, + chat: { projects: async () => [{ id: P, name: 'Work', repo: null }], threads: async () => [] }, + }), + }; +} + +async function page(t, st, { send = true, width = 1440, height = 900 } = {}) { + const server = await startServer({ port: 0, sso: createDevOwner(), ...(send ? { send: async () => ({}) } : {}), organizations: organizations(st, { send }), log: () => {} }); + t.after(() => close(server)); + const b = await browser({ machine: false }); t.after(() => b.close()); + const errors = []; + b.on('Runtime.exceptionThrown', p => errors.push(p.exceptionDetails?.exception?.description ?? p.exceptionDetails?.text ?? 'exception')); + await b.viewport(width, height); + const base = `http://127.0.0.1:${server.address().port}/`; + return { b, base, wait: waitFor(b), errors }; +} +const dashboard = async ({ b, base, wait }) => { + await b.navigate(`${base}#/orgs/acme/organization`); + await wait('document.querySelector("[data-org-dashboard] [data-system-types]") && !/Reading/.test(document.querySelector("[data-system-types]").textContent)'); +}; +const settings = async ({ b, base, wait }) => { + await b.navigate(`${base}#/orgs/acme/projects/${P}/settings`); + await wait('document.querySelector("[data-project-system-types]") && !/Reading system types/.test(document.querySelector("[data-project-system-types]").textContent)'); +}; +const text = (b, selector) => b.evaluate(`(document.querySelector(${JSON.stringify(selector)})?.innerText ?? '').replace(/\\s+/g, ' ').trim()`); +const chips = b => b.evaluate(`[...document.querySelectorAll('[data-system-type-chips] .ws-chip')].map(c => c.textContent)`); +const click = (b, selector) => b.evaluate(`(document.querySelector(${JSON.stringify(selector)}).click(), true)`); + +test('the dashboard lists the installed modules from the plug-in data and the owner switches one with a receipt', { timeout: 60000 }, async t => { + const st = await systemTypesFake({ enabled: ['coding'], projects: { [P]: [] } }); + const p = await page(t, st); const { b, wait } = p; + await dashboard(p); + // Every row is a module the plug-ins declare, in their order, with their label and description. + const rows = await b.evaluate(`[...document.querySelectorAll('[data-system-types] li')].map(li => [li.dataset.systemType, li.querySelector('.t b').textContent, li.querySelector('.t .d').textContent, li.querySelector('.ws-dot').textContent.replace(/[●–]/, '')])`); + assert.deepEqual(rows, st.installed.map(m => [m.id, m.label, m.description, m.id === 'coding' ? 'enabled' : 'off'])); + assert.ok(st.installed.length >= 2, 'the tree installs more than one system type module'); + assert.deepEqual(await chips(b), ['Coding']); + assert.match(await text(b, '[data-system-type-chips]'), /Each project picks from these; none is required\.$/); + assert.match(await text(b, '[data-org-setting="System types"]'), new RegExp(`1 of ${st.installed.length} installed enabled`)); + // The Settings row's Open moves focus to the section heading. + await click(b, '[data-org-setting="System types"] [data-system-types-open]'); + assert.equal(await b.evaluate('document.activeElement?.dataset.systemTypesHeading'), ''); + + // Enable Marketing from the keyboard; the receipt is the organization writer's transaction. + await b.evaluate(`document.querySelector('[data-system-type-toggle="marketing"]').focus(), true`); + assert.equal(await b.evaluate(`document.activeElement.getAttribute('aria-label')`), 'Enable Marketing'); + await b.key('Enter'); + await wait(`/Receipt/.test(document.querySelector('[data-system-types-status]')?.textContent)`); + assert.match(await text(b, '[data-system-types-status]'), new RegExp(`^Marketing enabled\\. ${RECEIPT.source}$`)); + assert.deepEqual(st.state.enabled, ['coding', 'marketing']); + assert.deepEqual(await chips(b), ['Coding', 'Marketing']); + assert.match(await text(b, '[data-org-setting="System types"]'), new RegExp(`2 of ${st.installed.length} installed enabled`)); + // Focus stays on the switch it pressed, which now says Disable. + assert.deepEqual(await b.evaluate(`[document.activeElement.dataset.focusKey, document.activeElement.getAttribute('aria-label')]`), ['st:marketing', 'Disable Marketing']); + + // Disable Coding; another write changed the organization file meanwhile, so the first try is refused. + st.state.n++; + await click(b, '[data-system-type-toggle="coding"]'); + await wait(`/changed after this page read it/.test(document.querySelector('[data-system-types-status]')?.textContent)`); + assert.deepEqual(st.state.enabled, ['coding', 'marketing']); + await click(b, '[data-system-type-toggle="coding"]'); + await wait(`/Coding disabled/.test(document.querySelector('[data-system-types-status]')?.textContent)`); + assert.match(await text(b, '[data-system-types-status]'), RECEIPT); + assert.deepEqual(st.state.enabled, ['marketing']); + assert.equal(await b.evaluate(`document.querySelector('[data-system-type="coding"] .ws-dot').textContent.replace(/[●–]/, '')`), 'off'); + assert.deepEqual(p.errors, []); +}); + +test('without the owner proof the switch is refused, and a read-only Console offers none', { timeout: 60000 }, async t => { + // The writer's owner fence refuses: the page says so and nothing changes. + const fenced = await systemTypesFake({ enabled: ['coding'], projects: { [P]: [] }, owner: false }); + const p = await page(t, fenced); const { b, wait } = p; + await dashboard(p); + await click(b, '[data-system-type-toggle="marketing"]'); + await wait(`/owner can change/.test(document.querySelector('[data-system-types-status]')?.textContent)`); + assert.equal(await text(b, '[data-system-types-status]'), "Only the organization's owner can change system types."); + assert.deepEqual(fenced.state.enabled, ['coding']); + assert.doesNotMatch(await text(b, '[data-system-types]'), /Receipt/); + + // A Console without send mode reads the list and shows no switch; no write reaches the transport. + const readOnly = await systemTypesFake({ enabled: ['coding'], projects: { [P]: ['coding'] } }); + const q = await page(t, readOnly, { send: false }); + await dashboard(q); + assert.equal(await q.b.evaluate(`document.querySelectorAll('[data-system-types] li').length`), readOnly.installed.length); + assert.equal(await q.b.evaluate(`document.querySelectorAll('[data-system-type-toggle]').length`), 0); + assert.match(await text(q.b, '[data-system-types]'), /This Console only reads\. Changing system types needs signed-in send mode\./); + // The project page shows the selection read only too. + await settings(q); + assert.equal(await q.b.evaluate(`[...document.querySelectorAll('[data-project-system-types] input')].every(i => i.disabled)`), true); + assert.equal(await q.b.evaluate(`document.querySelector('[data-project-system-types] button[type=submit]')`), null); + assert.deepEqual(readOnly.state.writes, []); +}); + +test('a project selects only enabled modules and a disabled selection shows as inactive', { timeout: 60000 }, async t => { + // Montage was selected, then disabled in the organization. + const st = await systemTypesFake({ enabled: ['coding', 'marketing'], projects: { [P]: ['montage'] } }); + const p = await page(t, st); const { b, wait } = p; + await settings(p); + const label = id => st.installed.find(m => m.id === id).label; + assert.deepEqual(await b.evaluate(`[...document.querySelectorAll('[data-project-system-types] input[name=system-type]')].map(i => [i.value, i.checked, i.closest('label').querySelector('strong').textContent])`), + [['coding', false, label('coding')], ['marketing', false, label('marketing')]]); + assert.deepEqual(await b.evaluate(`[...document.querySelectorAll('[data-inactive-type]')].map(li => [li.dataset.inactiveType, li.innerText.replace(/\\s+/g, ' ').trim()])`), [['montage', `${label('montage')} inactive`]]); + assert.match(await text(b, '[data-project-system-types-inactive]'), /Saving keeps only enabled types/); + + // Pick Marketing and save: the inactive one goes, the saved selection is the bus's answer. + await b.evaluate(`document.querySelector('[data-project-system-types] input[value=marketing]').click(), true`); + await click(b, '[data-project-system-types] button[type=submit]'); + await wait(`/Saved/.test(document.querySelector('[data-project-system-types-status]')?.textContent)`); + assert.equal(await text(b, '[data-project-system-types-status]'), `Saved. Selected: ${label('marketing')}.`); + assert.equal(await b.evaluate(`document.activeElement?.hasAttribute('data-project-system-types-status')`), true); + assert.deepEqual(st.state.projects[P], ['marketing']); + assert.equal(await b.evaluate(`document.querySelector('[data-inactive-type]')`), null); + + // The organization disables Coding after the page read it; saving it is refused and the list is read again. + await b.evaluate(`document.querySelector('[data-project-system-types] input[value=coding]').click(), true`); + st.state.enabled = ['marketing']; + await click(b, '[data-project-system-types] button[type=submit]'); + await wait(`/not enabled in the organization/.test(document.querySelector('[data-project-system-types-status]')?.textContent)`); + assert.deepEqual(st.state.projects[P], ['marketing']); + assert.deepEqual(await b.evaluate(`[...document.querySelectorAll('[data-project-system-types] input[name=system-type]')].map(i => i.value)`), ['marketing']); + + // The owner disables Marketing on the dashboard; back on the project it stays selected, shown inactive. + await dashboard(p); + await click(b, '[data-system-type-toggle="marketing"]'); + await wait(`/Marketing disabled/.test(document.querySelector('[data-system-types-status]')?.textContent)`); + assert.deepEqual(st.state.enabled, []); + await settings(p); + assert.match(await text(b, '[data-project-system-types]'), /The organization has no system types enabled\./); + assert.deepEqual(await b.evaluate(`[...document.querySelectorAll('[data-inactive-type]')].map(li => li.dataset.inactiveType)`), ['marketing']); + assert.equal(await b.evaluate(`document.querySelectorAll('[data-project-system-types] input').length`), 0); + assert.deepEqual(p.errors, []); +}); + +test('the dashboard section and the project page fit a phone screen in light and dark', { timeout: 90000 }, async t => { + const st = await systemTypesFake({ enabled: ['coding', 'marketing'], projects: { [P]: ['coding', 'montage'] } }); + const shots = process.env.MOSAIC_UX_SHOTS; + if (shots) mkdirSync(shots, { recursive: true }); + for (const [width, height] of [[1440, 900], [390, 844]]) { + const p = await page(t, st, { width, height }); const { b } = p; + for (const mode of ['light', 'dark']) { + await b.call('Emulation.setEmulatedMedia', { features: [{ name: 'prefers-color-scheme', value: mode }] }); + await dashboard(p); + // The default appearance is Harbor in the dark whatever the OS says; the header switch picks the mode. + if (await b.evaluate(`document.getElementById('theme-switch').getAttribute('aria-checked')`) !== String(mode === 'dark')) { + await b.evaluate(`document.getElementById('theme-switch').click(), true`); + await p.wait(`document.getElementById('theme-switch').getAttribute('aria-checked') === '${mode === 'dark'}'`); + } + await b.evaluate(`document.querySelector('[data-system-types-heading]').scrollIntoView({ block: 'start' }), true`); + assert.equal(await b.evaluate('document.documentElement.scrollWidth <= document.documentElement.clientWidth'), true, `dashboard ${width} ${mode}`); + assert.equal(await b.evaluate(`[...document.querySelectorAll('[data-system-types] li')].every(li => li.scrollWidth <= li.clientWidth)`), true, `dashboard rows ${width} ${mode}`); + if (shots) await b.screenshot(join(shots, `p2-dashboard-types-${width}-${mode}.png`)); + await settings(p); + await b.evaluate(`document.querySelector('[data-project-system-types]').scrollIntoView({ block: 'start' }), true`); + // At 1440 a project page taller than the window already overflows by its header's primary action + // (projects.css, before P2), so the wide check is the section's own box; the phone check is the page. + if (width === 390) assert.equal(await b.evaluate('document.documentElement.scrollWidth <= document.documentElement.clientWidth'), true, `project ${width} ${mode}`); + assert.equal(await b.evaluate(`(s => s.scrollWidth <= s.clientWidth && s.getBoundingClientRect().right <= document.documentElement.clientWidth)(document.querySelector('[data-project-system-types]'))`), true, `project section ${width} ${mode}`); + assert.equal(await b.evaluate(`[...document.querySelectorAll('[data-project-system-types] .project-types-option')].every(o => o.getBoundingClientRect().height >= 44)`), true, `targets ${width} ${mode}`); + if (shots) await b.screenshot(join(shots, `p2-project-types-${width}-${mode}.png`)); + } + assert.deepEqual(p.errors, []); + } +}); diff --git a/packages/webui/tests/system-types-http.test.mjs b/packages/webui/tests/system-types-http.test.mjs new file mode 100644 index 000000000..c0b6dd1fa --- /dev/null +++ b/packages/webui/tests/system-types-http.test.mjs @@ -0,0 +1,202 @@ +import test from 'node:test'; +import assert from 'node:assert/strict'; +import { mkdtempSync, mkdirSync, readFileSync, rmSync } from 'node:fs'; +import { request } from 'node:http'; +import { tmpdir } from 'node:os'; +import { join } from 'node:path'; +import { businessDoc, rolesCopy, systemFor, writeJson } from '../../organization/tests/helpers.mjs'; +import { loadBusiness } from '../../organization/src/organization-config.mjs'; +import { resolveInstance } from '../../organization/src/resolve.mjs'; +import { busOrganization } from '../../bus/src/organization-context.mjs'; +import { startBroker } from '../../bus/src/runtime.mjs'; +import { serve } from '../../bus/src/server.mjs'; +import { Client } from '../../bus/src/client.mjs'; +import { installedSystemTypes } from '../../plugins/src/system-types.mjs'; +import { startServer } from '../src/serve.mjs'; +import { close } from './fixture.mjs'; + +// Phase P2 (#1873): the owner's System types routes on a selected organization, end to end. An +// ephemeral organization with the real runtime writer (plugins.set, the system types owner fence, +// changes.jsonl) and the broker's console socket for the read; the SSO session is a fixture +// authority. `writer` picks the cap the write transport binds: the owner's human cap, or the tester. +async function fixture(t, { writer = 'owner', send = true } = {}) { + // Cleanups run last-made first, registered as soon as each resource exists. + const undo = []; t.after(async () => { for (const step of undo.reverse()) await step(); }); + const root = mkdtempSync(join(tmpdir(), 'st-')); + const rolesDir = rolesCopy(root), system = systemFor(root); + const doc = businessDoc(root, 'demo'); + doc.plugins = { ...(doc.plugins ?? {}), 'system-type': ['coding'], harness: ['pi'] }; + doc.vars = { ...doc.vars, 'bus.tester': true }; + const file = writeJson(join(root, 'businesses/demo.json'), doc); + mkdirSync(join(root, 'data'), { mode: 0o700 }); + const business = loadBusiness('demo', { dir: root, rolesDir }); + const resolved = Object.fromEntries(Object.keys(business.roles).map(instance => [instance, resolveInstance({ system, business, instance })])); + undo.push(() => rmSync(root, { recursive: true, force: true })); + const runtime = await startBroker({ dataRoot: join(root, 'data'), businesses: { demo: busOrganization(business, resolved) }, organization: { dir: root, rolesDir, system } }); + undo.push(() => runtime.close()); + const path = join(root, 'b.sock'); + const socketServer = await serve({ broker: runtime.broker, path, peerReader: { read: async () => ({}), close: () => {} }, + authenticateConsole: proof => runtime.broker.bindConsole({ business: 'demo', human: 'jason', subject: proof.subject }) }); + undo.push(() => socketServer.close()); + const owner = runtime.broker.bindHuman({ business: 'demo', human: 'jason', via: 'cli', outsideAgent: true }); + const role = Object.keys(business.roles)[0]; + const cap = writer === 'tester' ? runtime.broker.bindTester({ business: 'demo' }) + : writer === 'agent' ? runtime.broker.bindLaunch({ business: 'demo', role, run: 'agent-run', harness: 'pi' }) : owner; + const calls = []; + const requestRead = (verb, args, ctx) => { calls.push(['read', verb]); return new Client({ path, console: { subject: ctx.subject } }).call(verb, args); }; + const systemTypesWrite = async (verb, args) => { calls.push(['write', verb]); return runtime.broker.request(cap, { verb, args }); }; + const session = { provider: 'fixture', iss: 'https://issuer.example', sub: 'owner', name: 'jason' }; + let active = true; + const sso = { publicOrigin: '', publicHost: '', formTargets: () => [], session: () => active ? session : null, handle: () => {}, health: () => ({}) }; + const organizations = { + list: async () => [{ id: 'demo', label: 'Demo', busHealthy: true }], + resolve: async id => id !== 'demo' ? null : { busHealthy: true, send: send ? async () => ({}) : null, requestRead, systemTypesWrite: send ? systemTypesWrite : null, + reads: { business: async () => ({ business: { id: 'demo' } }) }, bus: {}, chat: { projects: async () => [], threads: async () => [] } }, + }; + const web = await startServer({ port: 0, board: 'http://127.0.0.1:9', sso, send: async () => ({}), organizations, log: () => {} }); + const base = `http://127.0.0.1:${web.address().port}`; + sso.publicOrigin = base; sso.publicHost = new URL(base).host; + undo.push(() => close(web)); + const project = runtime.broker.request(owner, { verb: 'project.create', args: { name: 'example' } }).id; + const onDisk = () => JSON.parse(readFileSync(file)).plugins['system-type']; + return { base, file, project, calls, onDisk, signOut: () => { active = false; } }; +} + +function call(f, path, method = 'GET', body, headers = {}) { + return new Promise((resolve, reject) => { + const data = body === undefined ? undefined : typeof body === 'string' ? body : JSON.stringify(body); + const req = request(f.base + path, { method, headers: { ...(data !== undefined ? { origin: f.base, 'sec-fetch-site': 'same-origin', 'content-type': 'application/json', 'content-length': Buffer.byteLength(data) } : {}), ...headers } }, res => { + let text = ''; res.on('data', chunk => { text += chunk; }); res.on('end', () => resolve([res.statusCode, JSON.parse(text)])); + }); + req.on('error', reject); req.setTimeout(10000, () => req.destroy(new Error('fixture request timed out'))); req.end(data); + }); +} +const ORG = '/api/orgs/demo/system-types'; + +test('the owner reads the installed modules and enables one with the revision, getting a receipt', async t => { + const f = await fixture(t); + const [status, before] = await call(f, ORG); + assert.equal(status, 200, JSON.stringify(before)); + // Labels and descriptions are the modules' own, never a list in the WebUI. + const modules = (await installedSystemTypes()).map(({ id, label, description }) => ({ id, label, description })); + assert.deepEqual(before.installed, modules); + assert.deepEqual(before.enabled, ['coding']); + assert.equal(before.project, null); assert.equal(before.writable, true); assert.match(before.revision, /^[a-f0-9]{64}$/); + const [saved, receipt] = await call(f, ORG, 'POST', { revision: before.revision, enabled: ['coding', 'montage'] }); + assert.equal(saved, 200, JSON.stringify(receipt)); + assert.deepEqual(receipt.enabled, ['coding', 'montage']); + assert.match(receipt.transaction, /^[0-9a-f-]{36}$/); assert.notEqual(receipt.revision, before.revision); + assert.deepEqual(f.onDisk(), ['coding', 'montage']); + const [, after] = await call(f, ORG); + assert.deepEqual(after.enabled, ['coding', 'montage']); assert.equal(after.revision, receipt.revision); + // The revision is the proof: the old one is refused and nothing is written. + const [stale, conflict] = await call(f, ORG, 'POST', { revision: before.revision, enabled: [] }); + assert.deepEqual([stale, conflict.error], [409, 'revision-conflict']); + assert.deepEqual(f.onDisk(), ['coding', 'montage']); +}); + +test('the admission checks refuse before any write', async t => { + const f = await fixture(t); + const [, { revision }] = await call(f, ORG); + const good = { revision, enabled: [] }; + for (const [label, body, headers, expected] of [ + ['unknown module', { revision, enabled: ['nope'] }, {}, [400, 'system-type-unknown']], + ['duplicate', { revision, enabled: ['coding', 'coding'] }, {}, [400, 'invalid-request']], + ['extra field', { ...good, actor: 'jason' }, {}, [400, 'invalid-request']], + ['business field', { ...good, business: 'other' }, {}, [400, 'invalid-request']], + ['no revision', { enabled: [] }, {}, [400, 'invalid-request']], + ['bad revision', { revision: 'x', enabled: [] }, {}, [400, 'invalid-request']], + ['not JSON', '{', {}, [400, 'invalid-request']], + ['too large', JSON.stringify({ revision, enabled: [], pad: 'x'.repeat(5000) }), {}, [413, 'invalid-request']], + ['form post', good, { 'content-type': 'text/plain' }, [400, 'invalid-request']], + // The Console's own origin check answers a foreign Origin first; the route's own check answers Sec-Fetch-Site. + ['cross origin', good, { origin: 'https://other.example' }, [403, 'cross-origin request refused']], + ['cross site', good, { 'sec-fetch-site': 'cross-site' }, [403, 'cross-origin']], + ]) { + const writes = f.calls.filter(c => c[0] === 'write' && c[1] === 'plugins.set').length; + const [status, result] = await call(f, ORG, 'POST', body, headers); + assert.deepEqual([status, result.error], expected, label); + assert.equal(f.calls.filter(c => c[0] === 'write' && c[1] === 'plugins.set').length, writes, label); + assert.deepEqual(f.onDisk(), ['coding'], label); + } + const [method] = await call(f, ORG, 'PUT'); + assert.equal(method, 405); + const [cross, crossBody] = await call(f, ORG, 'GET', undefined, { origin: 'https://other.example' }); + assert.equal(cross, 403); assert.match(crossBody.error, /^cross-origin/); + const [badProject, badProjectBody] = await call(f, `${ORG}/projects/${encodeURIComponent('../x')}`); + assert.deepEqual([badProject, badProjectBody.error], [404, 'project-not-found']); + f.signOut(); + const [signedOut, signedOutBody] = await call(f, ORG, 'POST', good); + assert.deepEqual([signedOut, signedOutBody.error], [401, 'sign-in-required']); + assert.deepEqual(f.onDisk(), ['coding']); +}); + +test('without the owner human proof the enable switch is refused', async t => { + // A Console without --send has no write transport: the read works, the write is read-only. + const readOnly = await fixture(t, { send: false }); + const [status, view] = await call(readOnly, ORG); + assert.equal(status, 200); assert.equal(view.writable, false); assert.equal(view.revision, undefined); + const [refused, body] = await call(readOnly, ORG, 'POST', { revision: 'a'.repeat(64), enabled: [] }); + assert.deepEqual([refused, body.error], [403, 'read-only']); + assert.deepEqual(readOnly.onDisk(), ['coding']); + // A write transport bound as the tester or as an agent, not the owner's human cap, is refused by the + // broker, and the receipt-bearing path never runs. + for (const writer of ['tester', 'agent']) { + const f = await fixture(t, { writer }); + const [fenced, fence] = await call(f, ORG, 'POST', { revision: 'b'.repeat(64), enabled: [] }); + assert.deepEqual([fenced, fence.error], [403, 'human-required'], writer); + assert.deepEqual(f.onDisk(), ['coding'], writer); + } +}); + +test('a project selects only enabled modules and a disabled selection reads as inactive', async t => { + const f = await fixture(t); + const path = `${ORG}/projects/${f.project}`; + const [status, empty] = await call(f, path); + assert.equal(status, 200, JSON.stringify(empty)); + assert.deepEqual(empty.project, { project: f.project, selected: [], active: [], inactive: [] }); + assert.equal(empty.revision, undefined); + const [notEnabled, notEnabledBody] = await call(f, path, 'POST', { systemTypes: ['montage'] }); + assert.deepEqual([notEnabled, notEnabledBody.error], [409, 'system-type-not-enabled']); + const [unknown, unknownBody] = await call(f, path, 'POST', { systemTypes: ['nope'] }); + assert.deepEqual([unknown, unknownBody.error], [400, 'system-type-unknown']); + const [saved, selection] = await call(f, path, 'POST', { systemTypes: ['coding'] }); + assert.equal(saved, 200, JSON.stringify(selection)); + assert.deepEqual(selection, { project: f.project, selected: ['coding'], active: ['coding'], inactive: [] }); + // The owner disables coding for the organization; the project keeps its selection, now inactive. + const [, { revision }] = await call(f, ORG); + assert.equal((await call(f, ORG, 'POST', { revision, enabled: [] }))[0], 200); + const [, after] = await call(f, path); + assert.deepEqual(after.enabled, []); + assert.deepEqual(after.project, { project: f.project, selected: ['coding'], active: [], inactive: ['coding'] }); + const [missing, missingBody] = await call(f, `${ORG}/projects/no-such-project`); + assert.deepEqual([missing, missingBody.error], [404, 'project-not-found']); + const [missingWrite, missingWriteBody] = await call(f, `${ORG}/projects/no-such-project`, 'POST', { systemTypes: [] }); + assert.deepEqual([missingWrite, missingWriteBody.error], [404, 'project-not-found']); +}); + +test('the tester listener and a Console without SSO never reach the routes or the files', async t => { + const { createDevOwner } = await import('../src/dev-owner.mjs'); + let reached = 0; + const hit = async () => { reached++; return {}; }; + const organizations = { list: async () => [{ id: 'demo', label: 'Demo', busHealthy: true }], + resolve: async () => ({ busHealthy: true, send: hit, requestRead: hit, systemTypesWrite: hit, reads: { business: async () => ({ business: { id: 'demo' } }) }, bus: {}, chat: { projects: async () => [], threads: async () => [] } }) }; + const root = mkdtempSync(join(tmpdir(), 'stt-')), socket = join(root, 't.sock'); + const tester = await startServer({ tester: true, testerSocket: socket, board: 'http://127.0.0.1:9', organizations, log: () => {} }); + t.after(async () => { await close(tester); rmSync(root, { recursive: true, force: true }); }); + const viaTester = (path, method = 'GET') => new Promise((resolve, reject) => { + const req = request({ socketPath: socket, path, method, headers: { host: 'mosaic-tester.invalid' } }, res => { res.resume(); res.on('end', () => resolve(res.statusCode)); }); + req.on('error', reject); req.end(); + }); + for (const path of ['/system-types.js', '/system-types.css']) assert.equal(await viaTester(path), 403, path); + // The tester has no organization session, so the per-organization routes answer org-unavailable. + for (const [path, method] of [[ORG, 'GET'], [ORG, 'POST'], [`${ORG}/projects/p1`, 'GET']]) assert.ok([403, 404].includes(await viaTester(path, method)), path); + const plain = await startServer({ port: 0, organizations, log: () => {} }); t.after(() => close(plain)); + const plainBase = `http://127.0.0.1:${plain.address().port}`; + assert.ok((await fetch(`${plainBase}${ORG}`)).status >= 400); + // The owner's dev session on a Console with the routes: the file is served. + const owner = await startServer({ port: 0, sso: createDevOwner(), send: async () => ({}), organizations, log: () => {} }); t.after(() => close(owner)); + assert.equal((await fetch(`http://127.0.0.1:${owner.address().port}/system-types.js`)).status, 200); + assert.equal(reached, 0); + await assert.rejects(startServer({ port: 0, sso: createDevOwner(), systemTypesWrite: hit, log: () => {} }), /System types writes need/); +}); diff --git a/packages/webui/tests/unified-workspace-browser.test.mjs b/packages/webui/tests/unified-workspace-browser.test.mjs index 178aad6f9..87c6d2d0d 100644 --- a/packages/webui/tests/unified-workspace-browser.test.mjs +++ b/packages/webui/tests/unified-workspace-browser.test.mjs @@ -6,11 +6,13 @@ import { createOrgAdmin } from '../src/org-admin.mjs'; import { browser } from './browser.mjs'; import { close } from './fixture.mjs'; import { fileURLToPath } from 'node:url'; +import { systemTypesFake } from './helpers/system-types-fake.mjs'; const waitFor = b => expression => b.evaluate(`(async()=>{for(let i=0;i<150;i++){if(${expression})return;await new Promise(r=>setTimeout(r,30))}throw Error(${JSON.stringify(expression)})})()`); -// Three organizations as sample 01 and 03 show them: two running buses and one stopped. -function workspaceOrgs({ failThreads = false, seen = null } = {}) { +// Three organizations as sample 01 and 03 show them: two running buses and one stopped. P2: each running +// organization's System types read comes from the installed modules; `send` adds the owner's writes. +function workspaceOrgs({ failThreads = false, seen = null, send = false, types = {} } = {}) { const ORGS = [ { id: 'ddigital', label: 'Distinctly Digital', theme: 'rosewood', busHealthy: true }, { id: 'forge', label: 'Forge', theme: 'cobalt', busHealthy: true }, @@ -24,6 +26,8 @@ function workspaceOrgs({ failThreads = false, seen = null } = {}) { const AGENTS = { ddigital: [{ role: 'chief', holder_run: 'r1', state: 'waiting' }, { role: 'copywriter', holder_run: 'r2', state: 'working' }], forge: [] }; const claim = (thread, holder_run) => ({ thread, holder_run, harness: 'claude', at: '2026-11-09T12:00:00.000Z' }); const CLAIMS = { ddigital: [claim('t3', 'r1'), claim('t1', 'r2'), claim('t2', 'r3')], forge: [] }; + const TYPES = { ddigital: { enabled: ['coding', 'marketing'], projects: { 'spring-launch': ['coding'], 'brand-refresh': ['marketing'] } }, forge: { enabled: [], projects: { 'api-gateway': [] } }, ...types }; + const fakes = {}; const FILES = { 'spring-launch': ['docs/north-star.md', 'docs/launch-plan.md', 'src/index.js'], 'brand-refresh': ['docs/brand-voice-guide.md'], 'api-gateway': [] }; const instances = id => ({ business: id, revision: 'a'.repeat(64), launch: true, noHire: [], retired: [], definitions: {}, instances: Object.fromEntries(Object.entries(INSTANCES[id]).map(([n, [definition, running]]) => [n, { definition, vars: {}, launched: true, launcher: false, protected: false, kept: false, running, alive: [] }])) }); @@ -35,8 +39,10 @@ function workspaceOrgs({ failThreads = false, seen = null } = {}) { seen?.push(id); const org = ORGS.find(o => o.id === id); if (!org) return null; if (!org.busHealthy) return { busHealthy: false, reads: null, bus: {}, chat: { projects: async () => [], threads: async () => [] } }; + fakes[id] ??= systemTypesFake(TYPES[id]); + const st = await fakes[id]; return { - busHealthy: true, + busHealthy: true, requestRead: st.requestRead, systemTypesWrite: send ? st.systemTypesWrite : null, ...(send ? { send: async () => ({}) } : {}), reads: { business: async () => business(id), settings: async () => ({ release: '0.0.42', notifier: { binding: 'discord' }, launch: { limits: { total: 4 } } }), queue: async () => ({ rows: id === 'ddigital' ? [{ state: 'done' }, { state: 'in-progress' }, { state: 'queued' }] : [] }), busStatus: async () => ({}) }, bus: { instances: async () => instances(id), messages: async () => ({ messages: [], unread: 0 }), agents: async () => AGENTS[id], 'thread.claims': async () => CLAIMS[id], inbox: async () => [], tasks: async () => [] }, @@ -125,7 +131,8 @@ test('organization dashboard renders every section from the per-organization rea assert.equal(head.avatar, 'DD'); assert.equal(head.title, 'Distinctly Digital'); assert.match(head.meta, /Kind not recorded/); assert.match(head.meta, /id ddigital/); assert.match(head.meta, /Tracker: Vikunja/); assert.match(head.meta, /bus running, read \d/); assert.match(head.colour, /^#[0-9a-f]{6}$/i); - assert.match(await b.evaluate('document.querySelector(".ws-typechips").innerText'), /System types\s+No system types yet/i); + // System types: the enabled modules by their own labels (P2). + assert.match(await b.evaluate('document.querySelector(".ws-typechips").innerText'), /System types\s+Coding\s*Marketing\s+Each project picks from these/i); // Docs come from the project files reads: only documents, named by project. assert.deepEqual(await b.evaluate('[...document.querySelectorAll(".ws-doc")].map(a => a.innerText.replace(/\\s+/g, " ").trim())'), ['North star Spring launch', 'Launch plan Spring launch', 'Brand voice guide Brand refresh']); // KPIs and metrics: one honest empty tile each, with no invented number. @@ -150,7 +157,8 @@ test('organization dashboard renders every section from the per-organization rea for (const s of settings) { assert.ok(s.icon, s.name); assert.ok(s.value, s.name); assert.ok(TAGS.includes(s.tag), `${s.name}: ${s.tag}`); } const by = Object.fromEntries(settings.map(s => [s.name, s])); assert.deepEqual([by['Members and invites'].tag, by['Members and invites'].href], ['not built', null]); - assert.deepEqual([by['System types'].tag, by['System types'].href], ['not built', null]); + assert.deepEqual([by['System types'].tag, by['System types'].value], ['org file', '2 of 5 installed enabled']); + assert.equal(await b.evaluate('document.querySelector(\'[data-org-setting="System types"] button.go\').textContent'), 'Open'); assert.deepEqual([by['Archive or delete'].tag, by['Archive or delete'].danger, by['Archive or delete'].href], ['danger', true, '#/settings/organizations']); assert.equal(by.Identity.value, 'Distinctly Digital · ddigital · kind not recorded'); assert.equal(by['Task tracker'].value, 'Vikunja'); @@ -170,7 +178,8 @@ test('organization dashboard empty states say so in one short line', async t => await waitFor(b)('document.querySelector("[data-org-dashboard] [data-org-settings]")'); const text = await b.evaluate('document.querySelector("[data-org-dashboard]").innerText'); // Section labels are uppercased by CSS, so innerText carries the uppercase form. - for (const line of [/System types\s+No system types yet\. They arrive with the system types update\./i, /Docs\s+No docs yet/i, /No KPIs defined in the organization file/, /No metrics recorded yet/, /Active agent sessions\s+none running/i, /No active agent sessions/, /Queue\s+no rows/i, /Tracker: not set/]) + // The empty organization has no System types read, so it says unavailable, never that none exist. + for (const line of [/System types\s+System types unavailable/i, /Docs\s+No docs yet/i, /No KPIs defined in the organization file/, /No metrics recorded yet/, /Active agent sessions\s+none running/i, /No active agent sessions/, /Queue\s+no rows/i, /Tracker: not set/]) assert.match(text, line); assert.equal(await b.evaluate('document.querySelectorAll("[data-org-settings] > li").length'), SETTINGS.length); });