5 Commits

Include renames

Author	SHA1	Message	Date
marcie	d326e6572a	framework tools/git: strict value guards + provider-failure normalization family-wide (codex blockers on PR #1464) ... - Value guards now reject option-like values: --anything always, and single-dash flag shapes (-h, -i). Previously -b --help consumed --help as the body and performed the write (codex example: issue-close -i --help proceeding to 'Closed GitHub issue #--help'). Multi-char dash-leading text (-start of a list) stays a legal value. - Every remaining direct provider exec (gh/tea/CMD arrays across issue-create/edit/assign/list/view, milestone-*, pr-create/edit, pr-close, issue-close/reopen) wrapped with rc capture and normalized to exit 1 with a stderr message — provider exit 2 no longer collides with the reserved usage-error status. - All 16 usage-contract suites gained option-like and short-flag arms (16/16 green). Existing suites re-verified; test-pr-edit and test-issue-create-interactive-auth fail identically with these changes stashed (environment-coupled, not regressions; documented).	2026-08-28 18:26:10 -05:00
marcie	ca91586222	framework tools/git: pr-review body-required actions fail fast (codex suggestion on PR #1464) ... request-changes and comment both validate their required body immediately after argument parsing (rc 2, stderr, zero provider contact). The repo-host-override suite's action-message expectation updated to the new wording; suite green.	2026-08-28 18:17:30 -05:00
marcie	da4a5b2f19	framework tools/git: pr-review validates --action before provider contact (codex blocker on PR #1464) ... An unsupported --action previously reached platform detection (and could touch the provider) before failing with a provider-class status; comment-without-body exited 1 mid-switch. Both now fail fast with usage_error (rc 2, stderr) immediately after argument parsing. Test arms added including the zero-provider-contact assertion for invalid-action runs.	2026-08-28 18:14:57 -05:00
marcie	c43b1a1293	framework tools/git: issue-create R1/R4 conversion + template bug fix (P1) ... - issue-create: usage() default exit is now 2 (usage-error contract); unknown option, missing title, and value-less -t/-b/-l/-m land there with stderr messages; exit-code line added to help. Interactive -i/--interactive unchanged (boolean, no value arm). Existing body-safety and interactive-auth suites still green. - Template bug fixed across ALL seven usage-contract suites: expect_stderr referenced an unbound $desc (should be $2); latent until issue-create's capitalized 'Unknown option' missed the case-sensitive grep and fired it. All seven re-verified green. - Suite enrolled (population 79); mirrored to the brain tree.	2026-08-28 18:01:12 -05:00
marcie	31a447a46f	framework tools/git: pr-review R1/R4 conversion (P1) ... -b/--body canonical review comment flag with -c/--comment alias; usage errors stderr + exit 2 (unknown option, missing -n/-a, value-less flags including -a/-l/-r/-H, and the semantic check: request-changes without a comment). Existing pr-review suites still green. Suite enrolled in framework-shell CI (enumeration guard OK); mirrored to the brain tree.	2026-08-28 17:57:29 -05:00