Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
a337d7873b |
+1
-24
@@ -30,19 +30,6 @@ steps:
|
|||||||
# the baked pnpm store.
|
# the baked pnpm store.
|
||||||
- pnpm install --frozen-lockfile --prefer-offline
|
- pnpm install --frozen-lockfile --prefer-offline
|
||||||
|
|
||||||
# ---------------------------------------------------------------------------
|
|
||||||
# The steps below (sanitization, upgrade-guard, typecheck, lint, format,
|
|
||||||
# test) are the COMPLETE mandatory verification set. SDLC-D-034 mirrors them
|
|
||||||
# one-for-one in the canonical terminal verification command — root
|
|
||||||
# `pnpm verify:release` (scripts/verify-release.mjs) — which the publish
|
|
||||||
# pipeline (.woodpecker/publish.yml `verify` step) runs before ANY publish
|
|
||||||
# effect. These lines stay direct (not routed through the runner) because the
|
|
||||||
# #1017 test-enumeration guard audits framework tool paths through THIS
|
|
||||||
# surface; scripts/verify-release.test.mjs enforces that the runner's stage
|
|
||||||
# table keeps matching these commands exactly, so the two cannot drift.
|
|
||||||
# ---------------------------------------------------------------------------
|
|
||||||
|
|
||||||
# Canonical verify:release stage `sanitization`.
|
|
||||||
# Blocking gate: public framework package must contain no operator-specific
|
# Blocking gate: public framework package must contain no operator-specific
|
||||||
# personal data or private $HOME defaults. Runs early (no node_modules needed).
|
# personal data or private $HOME defaults. Runs early (no node_modules needed).
|
||||||
sanitization:
|
sanitization:
|
||||||
@@ -60,7 +47,6 @@ steps:
|
|||||||
# with everything it guards; this direct line keeps one instrument running.
|
# with everything it guards; this direct line keeps one instrument running.
|
||||||
- bash packages/mosaic/framework/tools/quality/scripts/check-test-enumeration.sh
|
- bash packages/mosaic/framework/tools/quality/scripts/check-test-enumeration.sh
|
||||||
|
|
||||||
# Canonical verify:release stage `upgrade-guard`.
|
|
||||||
# Blocking gate (#791): a framework upgrade must never write or delete an
|
# Blocking gate (#791): a framework upgrade must never write or delete an
|
||||||
# operator-owned path. The HARD GATE proves an unanticipated operator sentinel
|
# operator-owned path. The HARD GATE proves an unanticipated operator sentinel
|
||||||
# survives a keep-mode reseed byte-identical (with rsync present AND absent —
|
# survives a keep-mode reseed byte-identical (with rsync present AND absent —
|
||||||
@@ -82,8 +68,6 @@ steps:
|
|||||||
- bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-durable-snapshot.sh
|
- bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-durable-snapshot.sh
|
||||||
- bash packages/mosaic/framework/tools/quality/scripts/test-install-migration.sh
|
- bash packages/mosaic/framework/tools/quality/scripts/test-install-migration.sh
|
||||||
|
|
||||||
# Canonical verify:release stage `typecheck` — the same `pnpm typecheck`
|
|
||||||
# invocation (which runs the checkout preflight first, then turbo).
|
|
||||||
typecheck:
|
typecheck:
|
||||||
image: *node_image
|
image: *node_image
|
||||||
commands:
|
commands:
|
||||||
@@ -94,8 +78,7 @@ steps:
|
|||||||
- sanitization
|
- sanitization
|
||||||
- upgrade-guard
|
- upgrade-guard
|
||||||
|
|
||||||
# lint, format, and test are independent — run in parallel after typecheck.
|
# lint, format, and test are independent — run in parallel after typecheck
|
||||||
# Each runs exactly its canonical verify:release stage command.
|
|
||||||
lint:
|
lint:
|
||||||
image: *node_image
|
image: *node_image
|
||||||
commands:
|
commands:
|
||||||
@@ -112,12 +95,6 @@ steps:
|
|||||||
depends_on:
|
depends_on:
|
||||||
- typecheck
|
- typecheck
|
||||||
|
|
||||||
# Canonical verify:release stage `test` — the `pnpm test` line below is the
|
|
||||||
# shared command; everything else in this step is PIPELINE-LEVEL
|
|
||||||
# prerequisite the canonical command expects its caller to provide (SDLC-D-034):
|
|
||||||
# the ci-postgres service + pg_isready wait + db:migrate (postgres path),
|
|
||||||
# `apk add openssl`, and the pinned pi install. None of those can move into
|
|
||||||
# the runner (it must also work locally on the PGlite path with no database).
|
|
||||||
test:
|
test:
|
||||||
image: *node_image
|
image: *node_image
|
||||||
environment:
|
environment:
|
||||||
|
|||||||
@@ -1,19 +1,5 @@
|
|||||||
# Build, publish npm packages, and push Docker images
|
# Build, publish npm packages, and push Docker images
|
||||||
# Runs on main for stable publishes and on next for integration-line prereleases/images
|
# Runs on main for stable publishes and on next for integration-line prereleases/images
|
||||||
#
|
|
||||||
# SDLC-D-034 publish gate: every publish effect (publish-npm, publish-next-npm,
|
|
||||||
# and every image build/push step) depends DIRECTLY on the `verify` step below.
|
|
||||||
# `verify` (a) asserts the provider's commit identity matches the actual
|
|
||||||
# checkout (CI_COMMIT_SHA == git rev-parse HEAD, fail closed on mismatch or
|
|
||||||
# emptiness) and (b) runs the canonical terminal verification command
|
|
||||||
# (`pnpm verify:release`), which mirrors the PR CI pipeline's complete
|
|
||||||
# mandatory set (sanitization, upgrade-guard, preflight+typecheck, lint,
|
|
||||||
# format:check, test, build) — see scripts/verify-release.mjs. A missing,
|
|
||||||
# failed, skipped, cancelled, or inconclusive verification therefore skips the
|
|
||||||
# dependent publish effects (fail closed). Path-filtered short-circuits may
|
|
||||||
# skip publish EFFECTS (e.g. docs-only merges) but never bypass `verify` for a
|
|
||||||
# publish that does run: `verify` itself carries no path filter.
|
|
||||||
# scripts/verify-release.test.mjs enforces this DAG invariant at checkout time.
|
|
||||||
|
|
||||||
variables:
|
variables:
|
||||||
# Pre-baked CI base (see .woodpecker/ci-image.yml): node:24-alpine +
|
# Pre-baked CI base (see .woodpecker/ci-image.yml): node:24-alpine +
|
||||||
@@ -62,45 +48,6 @@ steps:
|
|||||||
# Resolve from the baked pnpm store instead of a cold network fetch.
|
# Resolve from the baked pnpm store instead of a cold network fetch.
|
||||||
- pnpm install --frozen-lockfile --prefer-offline
|
- pnpm install --frozen-lockfile --prefer-offline
|
||||||
|
|
||||||
# SDLC-D-034 exact-commit publish gate. No `when`/path filter on purpose: it
|
|
||||||
# runs for every event this pipeline serves so no publish effect can ever
|
|
||||||
# start without it. Fails closed on commit-identity mismatch (or either SHA
|
|
||||||
# being empty) and on any incomplete verification.
|
|
||||||
verify:
|
|
||||||
image: *node_image
|
|
||||||
commands:
|
|
||||||
- *enable_pnpm
|
|
||||||
# (a) Commit identity: the provider's claimed SHA must equal the actual
|
|
||||||
# checkout HEAD — verification of anything else must never authorize a
|
|
||||||
# publish of this commit.
|
|
||||||
- |
|
|
||||||
if [ -z "$CI_COMMIT_SHA" ]; then
|
|
||||||
echo "[verify] FATAL: CI_COMMIT_SHA is empty — cannot certify commit identity" >&2
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
CHECKOUT_SHA="$(git rev-parse HEAD 2>/dev/null || true)"
|
|
||||||
if [ -z "$CHECKOUT_SHA" ]; then
|
|
||||||
echo "[verify] FATAL: git rev-parse HEAD returned nothing — cannot certify commit identity" >&2
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
if [ "$CI_COMMIT_SHA" != "$CHECKOUT_SHA" ]; then
|
|
||||||
echo "[verify] FATAL: provider commit ($CI_COMMIT_SHA) != checkout HEAD ($CHECKOUT_SHA)" >&2
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
echo "[verify] commit identity confirmed: $CHECKOUT_SHA"
|
|
||||||
# (b) Canonical terminal verification. Caller-provided prerequisites the
|
|
||||||
# runner expects (see .woodpecker/ci.yml comments): bash/rsync for the
|
|
||||||
# guard stages, openssl + the pinned pi binary for the test stage. git is
|
|
||||||
# baked into ci-base but re-asserted here so the identity check above can
|
|
||||||
# never silently depend on a stale baked image. DATABASE_URL is
|
|
||||||
# deliberately NOT set: the canonical command must hold on the PGlite
|
|
||||||
# path too and never sets or requires a database itself.
|
|
||||||
- apk add --no-cache bash rsync openssl git
|
|
||||||
- npm install -g @earendil-works/[email protected]
|
|
||||||
- pnpm verify:release
|
|
||||||
depends_on:
|
|
||||||
- install
|
|
||||||
|
|
||||||
build:
|
build:
|
||||||
image: *node_image
|
image: *node_image
|
||||||
commands:
|
commands:
|
||||||
@@ -108,7 +55,6 @@ steps:
|
|||||||
- pnpm build
|
- pnpm build
|
||||||
depends_on:
|
depends_on:
|
||||||
- install
|
- install
|
||||||
- verify
|
|
||||||
|
|
||||||
publish-npm:
|
publish-npm:
|
||||||
image: *node_image
|
image: *node_image
|
||||||
@@ -168,7 +114,6 @@ steps:
|
|||||||
exit 1
|
exit 1
|
||||||
depends_on:
|
depends_on:
|
||||||
- build
|
- build
|
||||||
- verify
|
|
||||||
|
|
||||||
publish-next-npm:
|
publish-next-npm:
|
||||||
image: *node_image
|
image: *node_image
|
||||||
@@ -247,7 +192,6 @@ steps:
|
|||||||
echo "[publish-next] @mosaicstack/mosaic@next resolves to $RESOLVED_VERSION"
|
echo "[publish-next] @mosaicstack/mosaic@next resolves to $RESOLVED_VERSION"
|
||||||
depends_on:
|
depends_on:
|
||||||
- build
|
- build
|
||||||
- verify
|
|
||||||
|
|
||||||
# TODO: Uncomment when ready to publish to npmjs.org
|
# TODO: Uncomment when ready to publish to npmjs.org
|
||||||
# publish-npmjs:
|
# publish-npmjs:
|
||||||
@@ -261,7 +205,6 @@ steps:
|
|||||||
# - bash scripts/publish-npmjs.sh
|
# - bash scripts/publish-npmjs.sh
|
||||||
# depends_on:
|
# depends_on:
|
||||||
# - build
|
# - build
|
||||||
# - verify
|
|
||||||
# when:
|
# when:
|
||||||
# - event: [tag]
|
# - event: [tag]
|
||||||
|
|
||||||
@@ -299,7 +242,6 @@ steps:
|
|||||||
/kaniko/executor --context . --dockerfile docker/gateway.Dockerfile $DESTINATIONS
|
/kaniko/executor --context . --dockerfile docker/gateway.Dockerfile $DESTINATIONS
|
||||||
depends_on:
|
depends_on:
|
||||||
- build
|
- build
|
||||||
- verify
|
|
||||||
|
|
||||||
build-appservice:
|
build-appservice:
|
||||||
image: gcr.io/kaniko-project/executor:debug
|
image: gcr.io/kaniko-project/executor:debug
|
||||||
@@ -326,7 +268,6 @@ steps:
|
|||||||
/kaniko/executor --context . --dockerfile docker/appservice.Dockerfile $DESTINATIONS
|
/kaniko/executor --context . --dockerfile docker/appservice.Dockerfile $DESTINATIONS
|
||||||
depends_on:
|
depends_on:
|
||||||
- build
|
- build
|
||||||
- verify
|
|
||||||
|
|
||||||
build-web:
|
build-web:
|
||||||
image: gcr.io/kaniko-project/executor:debug
|
image: gcr.io/kaniko-project/executor:debug
|
||||||
@@ -353,4 +294,3 @@ steps:
|
|||||||
/kaniko/executor --context . --dockerfile docker/web.Dockerfile $DESTINATIONS
|
/kaniko/executor --context . --dockerfile docker/web.Dockerfile $DESTINATIONS
|
||||||
depends_on:
|
depends_on:
|
||||||
- build
|
- build
|
||||||
- verify
|
|
||||||
|
|||||||
@@ -190,13 +190,7 @@ beforeEach((ctx) => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
afterAll(async () => {
|
afterAll(async () => {
|
||||||
// Cleanup only when the fixture actually installed rows. `handle` is set
|
if (!handle) return;
|
||||||
// before the first query (createDb connects lazily), so on an unreachable
|
|
||||||
// database `handle` is truthy while nothing was inserted — cleanup must
|
|
||||||
// honor `dbAvailable` or the skip path fails the file with ECONNREFUSED in
|
|
||||||
// afterAll (caught live by the publish pipeline's no-DATABASE_URL verify
|
|
||||||
// step, pipeline 2486).
|
|
||||||
if (!handle || !dbAvailable) return;
|
|
||||||
const db = handle.db;
|
const db = handle.db;
|
||||||
|
|
||||||
// Delete in dependency order (FK constraints)
|
// Delete in dependency order (FK constraints)
|
||||||
|
|||||||
@@ -0,0 +1,110 @@
|
|||||||
|
'use client';
|
||||||
|
|
||||||
|
import type { ReactElement } from 'react';
|
||||||
|
import { formatAge, type FreshnessLabel } from '@/lib/freshness/model';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Rendering rules for non-current freshness states (RI-5-001).
|
||||||
|
*
|
||||||
|
* - `unavailable` renders an explicit failure panel — never an empty
|
||||||
|
* healthy collection.
|
||||||
|
* - `stale` may render last-known data, but only under a visible label
|
||||||
|
* carrying source identity, snapshot version, and age.
|
||||||
|
* - `partial` renders the verified parts plus an explicit list of what is
|
||||||
|
* missing.
|
||||||
|
*/
|
||||||
|
|
||||||
|
interface RetryableNoticeProps {
|
||||||
|
readonly onRetry?: () => void;
|
||||||
|
readonly retryLabel?: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
function RetryButton({ onRetry, retryLabel }: RetryableNoticeProps): ReactElement | null {
|
||||||
|
if (!onRetry) return null;
|
||||||
|
return (
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={onRetry}
|
||||||
|
className="mt-2 rounded-lg border border-surface-border px-3 py-1.5 text-xs transition-colors hover:border-gray-500"
|
||||||
|
>
|
||||||
|
{retryLabel ?? 'Retry'}
|
||||||
|
</button>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface UnavailableDataNoticeProps extends RetryableNoticeProps {
|
||||||
|
/** What is unavailable, e.g. "Tasks". */
|
||||||
|
readonly title: string;
|
||||||
|
/** Optional underlying failure detail (network message, invalidation reason). */
|
||||||
|
readonly detail?: string | null;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Explicit `unavailable` state. Never renders as an empty healthy collection. */
|
||||||
|
export function UnavailableDataNotice({
|
||||||
|
title,
|
||||||
|
detail,
|
||||||
|
onRetry,
|
||||||
|
retryLabel,
|
||||||
|
}: UnavailableDataNoticeProps): ReactElement {
|
||||||
|
return (
|
||||||
|
<div role="alert" className="rounded-lg border border-error/40 px-4 py-3 text-sm">
|
||||||
|
<p className="font-medium text-text-primary">{title} are unavailable</p>
|
||||||
|
<p className="mt-1 text-text-muted">
|
||||||
|
This is not an empty result — the data could not be verified from the gateway.
|
||||||
|
{detail ? ` ${detail}` : ''}
|
||||||
|
</p>
|
||||||
|
<RetryButton onRetry={onRetry} retryLabel={retryLabel} />
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface StaleDataNoticeProps extends RetryableNoticeProps {
|
||||||
|
/** Provenance of the last-known snapshot being displayed. */
|
||||||
|
readonly label: FreshnessLabel;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Situational-awareness banner for `stale` data: last-known data may render,
|
||||||
|
* but visibly labeled with source identity, snapshot version, and age.
|
||||||
|
*/
|
||||||
|
export function StaleDataNotice({
|
||||||
|
label,
|
||||||
|
onRetry,
|
||||||
|
retryLabel,
|
||||||
|
}: StaleDataNoticeProps): ReactElement {
|
||||||
|
return (
|
||||||
|
<div role="status" className="rounded-lg border border-warning/40 px-4 py-3 text-sm">
|
||||||
|
<p className="font-medium text-warning">Showing last-known data — it may be out of date</p>
|
||||||
|
<p className="mt-1 text-xs text-text-muted">
|
||||||
|
Source {label.source} · snapshot v{label.version} · fetched{' '}
|
||||||
|
{formatAge(label.fetchedAt, Date.now())}. Verdicts derived from this data are unknown and
|
||||||
|
changes are disabled until it is revalidated.
|
||||||
|
</p>
|
||||||
|
<RetryButton onRetry={onRetry} retryLabel={retryLabel ?? 'Revalidate'} />
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface PartialDataNoticeProps extends RetryableNoticeProps {
|
||||||
|
/** Display names of the sections whose collections are unavailable. */
|
||||||
|
readonly missing: readonly string[];
|
||||||
|
}
|
||||||
|
|
||||||
|
/** `partial` surface banner: verified parts render, missing parts are explicit. */
|
||||||
|
export function PartialDataNotice({
|
||||||
|
missing,
|
||||||
|
onRetry,
|
||||||
|
retryLabel,
|
||||||
|
}: PartialDataNoticeProps): ReactElement {
|
||||||
|
return (
|
||||||
|
<div role="status" className="rounded-lg border border-warning/40 px-4 py-3 text-sm">
|
||||||
|
<p className="font-medium text-warning">Some data could not be loaded</p>
|
||||||
|
<p className="mt-1 text-xs text-text-muted">
|
||||||
|
{missing.join(', ')} {missing.length === 1 ? 'is' : 'are'} unavailable — sections below show
|
||||||
|
an explicit unavailable state instead of an empty list. Derived verdicts remain unknown
|
||||||
|
until every collection is revalidated.
|
||||||
|
</p>
|
||||||
|
<RetryButton onRetry={onRetry} retryLabel={retryLabel ?? 'Revalidate'} />
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
@@ -0,0 +1,324 @@
|
|||||||
|
import { describe, expect, it } from 'vitest';
|
||||||
|
import type { Task } from '@/lib/types';
|
||||||
|
import {
|
||||||
|
acceptSnapshot,
|
||||||
|
assertMutable,
|
||||||
|
canMutate,
|
||||||
|
combineFreshness,
|
||||||
|
computeDigest,
|
||||||
|
computeFreshness,
|
||||||
|
DEFAULT_FRESHNESS_POLICY,
|
||||||
|
formatAge,
|
||||||
|
type FreshSnapshot,
|
||||||
|
invalidationReasonLabels,
|
||||||
|
StaleMutationError,
|
||||||
|
UNKNOWN_VERDICT,
|
||||||
|
verdictValue,
|
||||||
|
} from './model';
|
||||||
|
import { validateProjectCollection, validateTaskCollection } from './validators';
|
||||||
|
|
||||||
|
const NOW = 1_800_000_000_000;
|
||||||
|
|
||||||
|
const policy = { ...DEFAULT_FRESHNESS_POLICY, staleAfterMs: 60_000 };
|
||||||
|
|
||||||
|
const taskPayload: Task[] = [
|
||||||
|
{
|
||||||
|
id: 'task-1',
|
||||||
|
title: 'T1',
|
||||||
|
description: null,
|
||||||
|
status: 'not-started',
|
||||||
|
priority: 'high',
|
||||||
|
projectId: 'project-1',
|
||||||
|
missionId: null,
|
||||||
|
assignee: null,
|
||||||
|
tags: null,
|
||||||
|
dueDate: null,
|
||||||
|
metadata: null,
|
||||||
|
createdAt: '2026-08-01T00:00:00.000Z',
|
||||||
|
updatedAt: '2026-08-01T00:00:00.000Z',
|
||||||
|
},
|
||||||
|
];
|
||||||
|
|
||||||
|
function acceptedTaskSnapshot(
|
||||||
|
overrides: Partial<FreshSnapshot<typeof taskPayload>> = {},
|
||||||
|
): FreshSnapshot<typeof taskPayload> {
|
||||||
|
const result = acceptSnapshot({
|
||||||
|
value: taskPayload,
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
previous: null,
|
||||||
|
policy,
|
||||||
|
source: 'gateway:/api/tasks',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
if (result.outcome !== 'accepted') {
|
||||||
|
throw new Error(`fixture setup failed: ${result.reason}`);
|
||||||
|
}
|
||||||
|
return { ...result.snapshot, ...overrides };
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('computeFreshness', () => {
|
||||||
|
it('treats a missing snapshot as unavailable, never as an empty healthy collection', () => {
|
||||||
|
expect(computeFreshness({ snapshot: null, policy, now: NOW })).toBe('unavailable');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns current for a fresh verified snapshot regardless of data emptiness', () => {
|
||||||
|
const empty = acceptSnapshot({
|
||||||
|
value: [],
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
previous: null,
|
||||||
|
policy,
|
||||||
|
source: 'gateway:/api/tasks',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
if (empty.outcome !== 'accepted') throw new Error('expected acceptance');
|
||||||
|
expect(computeFreshness({ snapshot: empty.snapshot, policy, now: NOW })).toBe('current');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('degrades to stale once the snapshot ages past staleAfterMs', () => {
|
||||||
|
const snapshot = acceptedTaskSnapshot();
|
||||||
|
expect(computeFreshness({ snapshot, policy, now: NOW + 60_001 })).toBe('stale');
|
||||||
|
expect(computeFreshness({ snapshot, policy, now: NOW + 59_999 })).toBe('current');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('degrades to stale when the latest revalidation failed', () => {
|
||||||
|
const snapshot = acceptedTaskSnapshot();
|
||||||
|
expect(computeFreshness({ snapshot, policy, now: NOW, degraded: true })).toBe('stale');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('mutation guard', () => {
|
||||||
|
it('permits mutations only on current data', () => {
|
||||||
|
expect(canMutate('current')).toBe(true);
|
||||||
|
for (const state of ['stale', 'partial', 'unknown', 'unavailable'] as const) {
|
||||||
|
expect(canMutate(state)).toBe(false);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('refuses mutations on non-current data via assertMutable', () => {
|
||||||
|
expect(() => assertMutable('current')).not.toThrow();
|
||||||
|
for (const state of ['stale', 'partial', 'unknown', 'unavailable'] as const) {
|
||||||
|
let thrown: unknown;
|
||||||
|
try {
|
||||||
|
assertMutable(state);
|
||||||
|
} catch (caught) {
|
||||||
|
thrown = caught;
|
||||||
|
}
|
||||||
|
expect(thrown).toBeInstanceOf(StaleMutationError);
|
||||||
|
expect(thrown).toBeInstanceOf(Error);
|
||||||
|
if (thrown instanceof StaleMutationError) {
|
||||||
|
expect(thrown.name).toBe('StaleMutationError');
|
||||||
|
expect(thrown.freshness).toBe(state);
|
||||||
|
expect(thrown.message).toContain(state);
|
||||||
|
expect(thrown.message).toContain('revalidat');
|
||||||
|
}
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('acceptSnapshot', () => {
|
||||||
|
it('accepts a valid payload with provenance', () => {
|
||||||
|
const result = acceptSnapshot({
|
||||||
|
value: taskPayload,
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
previous: null,
|
||||||
|
policy,
|
||||||
|
source: 'gateway:/api/tasks',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
expect(result.outcome).toBe('accepted');
|
||||||
|
if (result.outcome !== 'accepted') return;
|
||||||
|
expect(result.snapshot.source).toBe('gateway:/api/tasks');
|
||||||
|
expect(result.snapshot.version).toBe(1);
|
||||||
|
expect(result.snapshot.fetchedAt).toBe(NOW);
|
||||||
|
expect(result.snapshot.data).toEqual(taskPayload);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('invalidates a schema-mismatched payload instead of rendering it', () => {
|
||||||
|
const result = acceptSnapshot({
|
||||||
|
value: { not: 'an array' },
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
previous: acceptedTaskSnapshot(),
|
||||||
|
policy,
|
||||||
|
source: 'gateway:/api/tasks',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
expect(result).toEqual({ outcome: 'invalidated', reason: 'schema-mismatch' });
|
||||||
|
expect(invalidationReasonLabels['schema-mismatch']).toContain('schema');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('invalidates cross-workspace payloads', () => {
|
||||||
|
const userOne = acceptSnapshot({
|
||||||
|
value: [
|
||||||
|
{
|
||||||
|
id: 'p1',
|
||||||
|
name: 'P1',
|
||||||
|
description: null,
|
||||||
|
status: 'active',
|
||||||
|
userId: 'user-1',
|
||||||
|
metadata: null,
|
||||||
|
createdAt: '2026-08-01T00:00:00.000Z',
|
||||||
|
updatedAt: '2026-08-01T00:00:00.000Z',
|
||||||
|
},
|
||||||
|
],
|
||||||
|
validate: validateProjectCollection,
|
||||||
|
previous: null,
|
||||||
|
policy,
|
||||||
|
source: 'gateway:/api/projects',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
if (userOne.outcome !== 'accepted') throw new Error('expected acceptance');
|
||||||
|
|
||||||
|
const switched = acceptSnapshot({
|
||||||
|
value: [
|
||||||
|
{
|
||||||
|
id: 'p9',
|
||||||
|
name: 'P9',
|
||||||
|
description: null,
|
||||||
|
status: 'active',
|
||||||
|
userId: 'user-2',
|
||||||
|
metadata: null,
|
||||||
|
createdAt: '2026-08-01T00:00:00.000Z',
|
||||||
|
updatedAt: '2026-08-01T00:00:00.000Z',
|
||||||
|
},
|
||||||
|
],
|
||||||
|
validate: validateProjectCollection,
|
||||||
|
previous: userOne.snapshot,
|
||||||
|
policy,
|
||||||
|
source: 'gateway:/api/projects',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
expect(switched).toEqual({ outcome: 'invalidated', reason: 'cross-workspace' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('keeps the previous workspace for collections with no intrinsic identity', () => {
|
||||||
|
const userOne = acceptSnapshot({
|
||||||
|
value: [
|
||||||
|
{
|
||||||
|
id: 'p1',
|
||||||
|
name: 'P1',
|
||||||
|
description: null,
|
||||||
|
status: 'active',
|
||||||
|
userId: 'user-1',
|
||||||
|
metadata: null,
|
||||||
|
createdAt: '2026-08-01T00:00:00.000Z',
|
||||||
|
updatedAt: '2026-08-01T00:00:00.000Z',
|
||||||
|
},
|
||||||
|
],
|
||||||
|
validate: validateProjectCollection,
|
||||||
|
previous: null,
|
||||||
|
policy,
|
||||||
|
source: 'gateway:/api/projects',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
if (userOne.outcome !== 'accepted') throw new Error('expected acceptance');
|
||||||
|
|
||||||
|
// Empty list after the user deleted every project: no identity to check,
|
||||||
|
// so the verified scope is retained and the empty state stays healthy.
|
||||||
|
const emptied = acceptSnapshot({
|
||||||
|
value: [],
|
||||||
|
validate: validateProjectCollection,
|
||||||
|
previous: userOne.snapshot,
|
||||||
|
policy,
|
||||||
|
source: 'gateway:/api/projects',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
expect(emptied.outcome).toBe('accepted');
|
||||||
|
if (emptied.outcome === 'accepted') {
|
||||||
|
expect(emptied.snapshot.data).toEqual([]);
|
||||||
|
expect(emptied.snapshot.workspace).toBe('user-1');
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('invalidates version regressions', () => {
|
||||||
|
const previous = acceptedTaskSnapshot({ version: 7 });
|
||||||
|
const regressed = acceptSnapshot({
|
||||||
|
value: taskPayload,
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
previous,
|
||||||
|
policy,
|
||||||
|
source: 'gateway:/api/tasks',
|
||||||
|
now: NOW,
|
||||||
|
incomingVersion: 3,
|
||||||
|
});
|
||||||
|
expect(regressed).toEqual({ outcome: 'invalidated', reason: 'version-regression' });
|
||||||
|
|
||||||
|
const newerSchema = acceptedTaskSnapshot({ schemaVersion: 4 });
|
||||||
|
const downgradedClient = acceptSnapshot({
|
||||||
|
value: taskPayload,
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
previous: newerSchema,
|
||||||
|
policy: { ...policy, schemaVersion: 2 },
|
||||||
|
source: 'gateway:/api/tasks',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
expect(downgradedClient).toEqual({ outcome: 'invalidated', reason: 'version-regression' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('increments the version monotonically across accepted snapshots', () => {
|
||||||
|
const first = acceptedTaskSnapshot();
|
||||||
|
const second = acceptSnapshot({
|
||||||
|
value: taskPayload,
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
previous: first,
|
||||||
|
policy,
|
||||||
|
source: 'gateway:/api/tasks',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
expect(second.outcome).toBe('accepted');
|
||||||
|
if (second.outcome === 'accepted') {
|
||||||
|
expect(second.snapshot.version).toBe(first.version + 1);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('combineFreshness', () => {
|
||||||
|
it('gates the surface on the primary collection', () => {
|
||||||
|
expect(combineFreshness('unavailable', ['current'])).toBe('unavailable');
|
||||||
|
expect(combineFreshness('unknown', ['current'])).toBe('unknown');
|
||||||
|
expect(combineFreshness('current', [])).toBe('current');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('degrades to partial when a secondary is unavailable', () => {
|
||||||
|
expect(combineFreshness('current', ['current', 'unavailable'])).toBe('partial');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('degrades to unknown while a secondary is still loading', () => {
|
||||||
|
expect(combineFreshness('current', ['unknown'])).toBe('unknown');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('degrades to stale when any collection is stale', () => {
|
||||||
|
expect(combineFreshness('current', ['stale'])).toBe('stale');
|
||||||
|
expect(combineFreshness('stale', ['current'])).toBe('stale');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('propagates partial secondaries', () => {
|
||||||
|
expect(combineFreshness('current', ['partial'])).toBe('partial');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('computeDigest', () => {
|
||||||
|
it('is stable across key order and changes with data', () => {
|
||||||
|
const a = computeDigest({ x: 1, y: [1, 2] });
|
||||||
|
const b = computeDigest({ y: [1, 2], x: 1 });
|
||||||
|
expect(a).toBe(b);
|
||||||
|
expect(computeDigest({ x: 1, y: [1, 3] })).not.toBe(a);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('verdictValue', () => {
|
||||||
|
it('returns the value only for verified inputs', () => {
|
||||||
|
expect(verdictValue(true, '5')).toBe('5');
|
||||||
|
expect(verdictValue(false, '5')).toBe(UNKNOWN_VERDICT);
|
||||||
|
expect(verdictValue(false, '5')).not.toBe('5');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('formatAge', () => {
|
||||||
|
it('labels age in human terms', () => {
|
||||||
|
expect(formatAge(NOW, NOW)).toBe('just now');
|
||||||
|
expect(formatAge(NOW, NOW + 15_000)).toBe('under a minute ago');
|
||||||
|
expect(formatAge(NOW, NOW + 120_000)).toBe('2m ago');
|
||||||
|
expect(formatAge(NOW, NOW + 3 * 3_600_000)).toBe('3h ago');
|
||||||
|
expect(formatAge(NOW, NOW + 2 * 86_400_000)).toBe('2d ago');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,261 @@
|
|||||||
|
/**
|
||||||
|
* Typed freshness model for gateway-fetched collections (RI-5-001).
|
||||||
|
*
|
||||||
|
* A failed or stale fetch must never be indistinguishable from an empty
|
||||||
|
* healthy collection. Every fetched surface carries an explicit freshness
|
||||||
|
* state, a verified snapshot identity (source, workspace, version, age), and
|
||||||
|
* a mutation guard that refuses state-changing operations unless the data is
|
||||||
|
* verified current.
|
||||||
|
*/
|
||||||
|
|
||||||
|
/** Freshness states for fetched data. Never inferred from emptiness. */
|
||||||
|
export type FreshnessState = 'current' | 'stale' | 'partial' | 'unknown' | 'unavailable';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Reasons a snapshot is invalidated. An invalidated snapshot is treated as
|
||||||
|
* unavailable and is never rendered as current.
|
||||||
|
*/
|
||||||
|
export type InvalidationReason =
|
||||||
|
| 'cache-corruption'
|
||||||
|
| 'cross-workspace'
|
||||||
|
| 'schema-mismatch'
|
||||||
|
| 'version-regression';
|
||||||
|
|
||||||
|
/** Human-readable labels for invalidation reasons (UI + error messages). */
|
||||||
|
export const invalidationReasonLabels: Record<InvalidationReason, string> = {
|
||||||
|
'cache-corruption': 'cached snapshot failed integrity checks',
|
||||||
|
'cross-workspace': 'data belongs to a different workspace',
|
||||||
|
'schema-mismatch': 'response did not match the expected schema',
|
||||||
|
'version-regression': 'snapshot version regressed below the accepted version',
|
||||||
|
};
|
||||||
|
|
||||||
|
/** A verified snapshot of fetched data with full provenance. */
|
||||||
|
export interface FreshSnapshot<T> {
|
||||||
|
readonly data: T;
|
||||||
|
/** Source identity of the fetch, e.g. `gateway:/api/tasks`. */
|
||||||
|
readonly source: string;
|
||||||
|
/** Workspace scope the data belongs to. */
|
||||||
|
readonly workspace: string;
|
||||||
|
/** Monotonic snapshot sequence number for this surface. */
|
||||||
|
readonly version: number;
|
||||||
|
/** Schema version of the validator that accepted this snapshot. */
|
||||||
|
readonly schemaVersion: number;
|
||||||
|
/** Epoch ms at which the data was verified. */
|
||||||
|
readonly fetchedAt: number;
|
||||||
|
/** Integrity digest of `data`, used to detect cache corruption. */
|
||||||
|
readonly digest: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Provenance label rendered next to last-known data. */
|
||||||
|
export interface FreshnessLabel {
|
||||||
|
readonly source: string;
|
||||||
|
readonly version: number;
|
||||||
|
readonly fetchedAt: number;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Policy governing freshness for a surface. */
|
||||||
|
export interface FreshnessPolicy {
|
||||||
|
/** Active workspace scope. Snapshots from other scopes are invalidated. */
|
||||||
|
readonly workspace: string;
|
||||||
|
/** Schema version of the current validator. */
|
||||||
|
readonly schemaVersion: number;
|
||||||
|
/** Age after which a verified snapshot degrades from current to stale. */
|
||||||
|
readonly staleAfterMs: number;
|
||||||
|
}
|
||||||
|
|
||||||
|
export const DEFAULT_FRESHNESS_POLICY: FreshnessPolicy = {
|
||||||
|
workspace: 'default',
|
||||||
|
schemaVersion: 1,
|
||||||
|
staleAfterMs: 60_000,
|
||||||
|
};
|
||||||
|
|
||||||
|
/** Payload returned by a successful schema validation. */
|
||||||
|
export interface FreshPayload<T> {
|
||||||
|
readonly data: T;
|
||||||
|
/**
|
||||||
|
* Workspace identity extracted from the payload itself when the collection
|
||||||
|
* carries one (e.g. a uniform `userId` on projects). `null` when the
|
||||||
|
* collection has no intrinsic workspace identity.
|
||||||
|
*/
|
||||||
|
readonly workspace: string | null;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Error thrown when a mutation is attempted on non-current data. */
|
||||||
|
export class StaleMutationError extends Error {
|
||||||
|
readonly freshness: FreshnessState;
|
||||||
|
|
||||||
|
constructor(freshness: FreshnessState) {
|
||||||
|
super(`Refused mutation on ${freshness} data: revalidation is required before mutating.`);
|
||||||
|
this.name = 'StaleMutationError';
|
||||||
|
this.freshness = freshness;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Stable JSON digest used for snapshot integrity checks. */
|
||||||
|
export function computeDigest(value: unknown): string {
|
||||||
|
// FNV-1a 32-bit over the stable JSON serialization. This is an integrity
|
||||||
|
// check against corruption, not a cryptographic guarantee.
|
||||||
|
let hash = 0x811c9dc5;
|
||||||
|
for (const byte of stableStringify(value)) {
|
||||||
|
hash ^= byte.charCodeAt(0);
|
||||||
|
hash = Math.imul(hash, 0x01000193) >>> 0;
|
||||||
|
}
|
||||||
|
return hash.toString(16).padStart(8, '0');
|
||||||
|
}
|
||||||
|
|
||||||
|
function stableStringify(value: unknown): string {
|
||||||
|
return serialize(value);
|
||||||
|
}
|
||||||
|
|
||||||
|
function serialize(value: unknown): string {
|
||||||
|
if (value === null || typeof value !== 'object') return JSON.stringify(value) ?? 'null';
|
||||||
|
if (Array.isArray(value)) return `[${value.map(serialize).join(',')}]`;
|
||||||
|
const entries = Object.entries(value as Record<string, unknown>)
|
||||||
|
.filter(([, item]) => item !== undefined)
|
||||||
|
.sort(([left], [right]) => (left < right ? -1 : left > right ? 1 : 0))
|
||||||
|
.map(([key, item]) => `${JSON.stringify(key)}:${serialize(item)}`);
|
||||||
|
return `{${entries.join(',')}}`;
|
||||||
|
}
|
||||||
|
|
||||||
|
export type AcceptSnapshotResult<T> =
|
||||||
|
| { readonly outcome: 'accepted'; readonly snapshot: FreshSnapshot<T> }
|
||||||
|
| { readonly outcome: 'invalidated'; readonly reason: InvalidationReason };
|
||||||
|
|
||||||
|
export interface AcceptSnapshotOptions<T> {
|
||||||
|
/** Raw fetched value (untrusted JSON). */
|
||||||
|
readonly value: unknown;
|
||||||
|
/** Schema validator; returns `null` when the value does not match. */
|
||||||
|
readonly validate: (value: unknown) => FreshPayload<T> | null;
|
||||||
|
/** Previously accepted snapshot for this surface, if any. */
|
||||||
|
readonly previous: FreshSnapshot<T> | null;
|
||||||
|
readonly policy: FreshnessPolicy;
|
||||||
|
readonly source: string;
|
||||||
|
/**
|
||||||
|
* Version carried by the incoming payload when the transport exposes one.
|
||||||
|
* Must not regress below the accepted snapshot's version.
|
||||||
|
*/
|
||||||
|
readonly incomingVersion?: number;
|
||||||
|
readonly now: number;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Validate and accept a fetched value as a snapshot, or invalidate it.
|
||||||
|
*
|
||||||
|
* Invalidation rules (each treated as unavailable, never rendered current):
|
||||||
|
* - schema mismatch: the payload fails validation
|
||||||
|
* - cross-workspace: the payload's workspace differs from the verified one
|
||||||
|
* - version regression: payload/schema version is below the accepted one
|
||||||
|
*/
|
||||||
|
export function acceptSnapshot<T>(options: AcceptSnapshotOptions<T>): AcceptSnapshotResult<T> {
|
||||||
|
const payload = options.validate(options.value);
|
||||||
|
if (payload === null) {
|
||||||
|
return { outcome: 'invalidated', reason: 'schema-mismatch' };
|
||||||
|
}
|
||||||
|
|
||||||
|
// Workspace identity: the payload's own scope wins; a collection with no
|
||||||
|
// intrinsic identity (e.g. an empty list after every project was deleted)
|
||||||
|
// keeps the previously verified scope rather than resetting to the policy
|
||||||
|
// default, so a legitimately empty response is not mistaken for a scope
|
||||||
|
// change.
|
||||||
|
const workspace = payload.workspace ?? options.previous?.workspace ?? options.policy.workspace;
|
||||||
|
if (options.previous !== null && options.previous.workspace !== workspace) {
|
||||||
|
return { outcome: 'invalidated', reason: 'cross-workspace' };
|
||||||
|
}
|
||||||
|
if (options.previous !== null && options.policy.schemaVersion < options.previous.schemaVersion) {
|
||||||
|
return { outcome: 'invalidated', reason: 'version-regression' };
|
||||||
|
}
|
||||||
|
if (
|
||||||
|
options.incomingVersion !== undefined &&
|
||||||
|
options.previous !== null &&
|
||||||
|
options.incomingVersion < options.previous.version
|
||||||
|
) {
|
||||||
|
return { outcome: 'invalidated', reason: 'version-regression' };
|
||||||
|
}
|
||||||
|
|
||||||
|
const snapshot: FreshSnapshot<T> = {
|
||||||
|
data: payload.data,
|
||||||
|
source: options.source,
|
||||||
|
workspace,
|
||||||
|
version: options.incomingVersion ?? (options.previous?.version ?? 0) + 1,
|
||||||
|
schemaVersion: options.policy.schemaVersion,
|
||||||
|
fetchedAt: options.now,
|
||||||
|
digest: computeDigest(payload.data),
|
||||||
|
};
|
||||||
|
return { outcome: 'accepted', snapshot };
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface ComputeFreshnessOptions {
|
||||||
|
readonly snapshot: FreshSnapshot<unknown> | null;
|
||||||
|
readonly policy: FreshnessPolicy;
|
||||||
|
readonly now: number;
|
||||||
|
/**
|
||||||
|
* True when the snapshot cannot be trusted as current regardless of age:
|
||||||
|
* the latest revalidation failed, or the snapshot was restored from cache
|
||||||
|
* and has not been verified by a fetch in this session.
|
||||||
|
*/
|
||||||
|
readonly degraded?: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Compute the freshness state of a snapshot. A missing snapshot is
|
||||||
|
* `unavailable` (never "empty and healthy"); a degraded or aged snapshot is
|
||||||
|
* `stale` (situational awareness only).
|
||||||
|
*/
|
||||||
|
export function computeFreshness(options: ComputeFreshnessOptions): FreshnessState {
|
||||||
|
const { snapshot, policy, now, degraded = false } = options;
|
||||||
|
if (snapshot === null) return 'unavailable';
|
||||||
|
if (degraded) return 'stale';
|
||||||
|
if (now - snapshot.fetchedAt > policy.staleAfterMs) return 'stale';
|
||||||
|
return 'current';
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Only verified-current data may back a state-changing action. */
|
||||||
|
export function canMutate(state: FreshnessState): boolean {
|
||||||
|
return state === 'current';
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Defense in depth: reject the mutation call itself on non-current data. */
|
||||||
|
export function assertMutable(state: FreshnessState): void {
|
||||||
|
if (!canMutate(state)) {
|
||||||
|
throw new StaleMutationError(state);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Combine freshness across a multi-collection surface (primary + secondaries).
|
||||||
|
* The primary collection gates the surface: unknown while it loads,
|
||||||
|
* unavailable when it fails. Missing secondaries degrade the surface to
|
||||||
|
* `partial`; aged collections degrade it to `stale`.
|
||||||
|
*/
|
||||||
|
export function combineFreshness(
|
||||||
|
primary: FreshnessState,
|
||||||
|
secondaries: readonly FreshnessState[],
|
||||||
|
): FreshnessState {
|
||||||
|
if (primary === 'unavailable') return 'unavailable';
|
||||||
|
if (primary === 'unknown') return 'unknown';
|
||||||
|
if (secondaries.includes('unavailable')) return 'partial';
|
||||||
|
if (secondaries.includes('unknown')) return 'unknown';
|
||||||
|
if (secondaries.includes('stale') || primary === 'stale') return 'stale';
|
||||||
|
if (secondaries.includes('partial')) return 'partial';
|
||||||
|
return 'current';
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Render-safe age label for snapshot provenance. */
|
||||||
|
export function formatAge(fetchedAt: number, now: number): string {
|
||||||
|
const ageMs = Math.max(0, now - fetchedAt);
|
||||||
|
if (ageMs < 10_000) return 'just now';
|
||||||
|
const minutes = Math.floor(ageMs / 60_000);
|
||||||
|
if (minutes < 1) return 'under a minute ago';
|
||||||
|
if (minutes < 60) return `${minutes}m ago`;
|
||||||
|
const hours = Math.floor(minutes / 60);
|
||||||
|
if (hours < 24) return `${hours}h ago`;
|
||||||
|
const days = Math.floor(hours / 24);
|
||||||
|
return `${days}d ago`;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Derived verdict placeholder for non-current inputs — never a green value. */
|
||||||
|
export const UNKNOWN_VERDICT = '?';
|
||||||
|
|
||||||
|
export function verdictValue(verified: boolean, value: string): string {
|
||||||
|
return verified ? value : UNKNOWN_VERDICT;
|
||||||
|
}
|
||||||
@@ -0,0 +1,197 @@
|
|||||||
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
||||||
|
import { acceptSnapshot, DEFAULT_FRESHNESS_POLICY } from './model';
|
||||||
|
import { clearSnapshotCache, readSnapshotCache, writeSnapshotCache } from './snapshot-cache';
|
||||||
|
import { validateProjectCollection, validateTaskCollection } from './validators';
|
||||||
|
import { projectFixtures, taskFixtures } from '@/spa/pages/page-fixtures';
|
||||||
|
import type { Project, Task } from '@/lib/types';
|
||||||
|
|
||||||
|
const KEY = 'test:tasks';
|
||||||
|
const NOW = 1_800_000_000_000;
|
||||||
|
const policy = { ...DEFAULT_FRESHNESS_POLICY, staleAfterMs: 60_000 };
|
||||||
|
|
||||||
|
function storedTaskSnapshot() {
|
||||||
|
const result = acceptSnapshot({
|
||||||
|
value: taskFixtures,
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
previous: null,
|
||||||
|
policy,
|
||||||
|
source: 'gateway:/api/tasks',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
if (result.outcome !== 'accepted') throw new Error('fixture setup failed');
|
||||||
|
return result.snapshot;
|
||||||
|
}
|
||||||
|
|
||||||
|
function storedProjectSnapshot() {
|
||||||
|
const result = acceptSnapshot({
|
||||||
|
value: projectFixtures,
|
||||||
|
validate: validateProjectCollection,
|
||||||
|
previous: null,
|
||||||
|
policy,
|
||||||
|
source: 'gateway:/api/projects',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
if (result.outcome !== 'accepted') throw new Error('fixture setup failed');
|
||||||
|
return result.snapshot;
|
||||||
|
}
|
||||||
|
|
||||||
|
function readTasks() {
|
||||||
|
return readSnapshotCache({
|
||||||
|
key: KEY,
|
||||||
|
workspace: policy.workspace,
|
||||||
|
policy,
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Write an arbitrary value directly at the raw cache slot. */
|
||||||
|
function writeRaw(key: string, value: unknown): void {
|
||||||
|
sessionStorage.setItem(`mosaic:freshness:v1:${key}`, JSON.stringify(value));
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Parse and re-write the stored entry (for tampering with internals). */
|
||||||
|
function tamperStored<T>(key: string, mutate: (stored: T) => void): void {
|
||||||
|
const parsed = JSON.parse(sessionStorage.getItem(`mosaic:freshness:v1:${key}`) ?? '{}') as T;
|
||||||
|
mutate(parsed);
|
||||||
|
writeRaw(key, parsed);
|
||||||
|
}
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
sessionStorage.clear();
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
sessionStorage.clear();
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('readSnapshotCache', () => {
|
||||||
|
it('misses when nothing is stored', () => {
|
||||||
|
expect(readTasks()).toEqual({ outcome: 'miss' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('hits for a well-formed entry and preserves provenance', () => {
|
||||||
|
const snapshot = storedTaskSnapshot();
|
||||||
|
writeSnapshotCache(KEY, snapshot);
|
||||||
|
|
||||||
|
const result = readTasks();
|
||||||
|
expect(result.outcome).toBe('hit');
|
||||||
|
if (result.outcome === 'hit') {
|
||||||
|
expect(result.snapshot.data).toEqual(taskFixtures);
|
||||||
|
expect(result.snapshot.source).toBe('gateway:/api/tasks');
|
||||||
|
expect(result.snapshot.version).toBe(snapshot.version);
|
||||||
|
expect(result.snapshot.fetchedAt).toBe(snapshot.fetchedAt);
|
||||||
|
expect(result.snapshot.workspace).toBe(snapshot.workspace);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('invalidates unparsable entries as cache corruption', () => {
|
||||||
|
sessionStorage.setItem(`mosaic:freshness:v1:${KEY}`, '{not json');
|
||||||
|
expect(readTasks()).toEqual({ outcome: 'invalidated', reason: 'cache-corruption' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('invalidates structurally wrong entries as cache corruption', () => {
|
||||||
|
const malformed: unknown[] = [
|
||||||
|
'nested but not a snapshot',
|
||||||
|
{ data: taskFixtures }, // missing provenance fields
|
||||||
|
{
|
||||||
|
data: taskFixtures,
|
||||||
|
source: 1,
|
||||||
|
workspace: 'w',
|
||||||
|
version: 1,
|
||||||
|
schemaVersion: 1,
|
||||||
|
fetchedAt: 1,
|
||||||
|
digest: 'x',
|
||||||
|
},
|
||||||
|
null,
|
||||||
|
17,
|
||||||
|
];
|
||||||
|
for (const entry of malformed) {
|
||||||
|
writeRaw(KEY, entry);
|
||||||
|
expect(readTasks()).toEqual({ outcome: 'invalidated', reason: 'cache-corruption' });
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('invalidates digest mismatches as cache corruption (tampered data)', () => {
|
||||||
|
writeSnapshotCache(KEY, storedTaskSnapshot());
|
||||||
|
tamperStored<{ data: Task[] }>(KEY, (stored) => {
|
||||||
|
stored.data = [...stored.data, { ...stored.data[0]!, id: 'injected-task' }];
|
||||||
|
});
|
||||||
|
expect(readTasks()).toEqual({ outcome: 'invalidated', reason: 'cache-corruption' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('invalidates entries scoped to another workspace', () => {
|
||||||
|
const snapshot = storedTaskSnapshot();
|
||||||
|
writeSnapshotCache(KEY, { ...snapshot, workspace: 'someone-else' });
|
||||||
|
expect(readTasks()).toEqual({ outcome: 'invalidated', reason: 'cross-workspace' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('invalidates entries written by a newer schema as a version regression', () => {
|
||||||
|
const snapshot = storedTaskSnapshot();
|
||||||
|
writeSnapshotCache(KEY, { ...snapshot, schemaVersion: policy.schemaVersion + 1 });
|
||||||
|
expect(readTasks()).toEqual({ outcome: 'invalidated', reason: 'version-regression' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('invalidates entries whose data no longer validates (schema mismatch)', () => {
|
||||||
|
writeSnapshotCache(KEY, storedTaskSnapshot());
|
||||||
|
tamperStored<{ data: unknown }>(KEY, (stored) => {
|
||||||
|
stored.data = { malformed: true };
|
||||||
|
});
|
||||||
|
expect(readTasks()).toEqual({ outcome: 'invalidated', reason: 'schema-mismatch' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('never reports a corrupted raw entry as a hit (negative control)', () => {
|
||||||
|
for (const raw of ['{oops', 'null', '"string"', '[]', '12']) {
|
||||||
|
sessionStorage.setItem(`mosaic:freshness:v1:${KEY}`, raw);
|
||||||
|
const result = readTasks();
|
||||||
|
expect(result.outcome).not.toBe('hit');
|
||||||
|
expect(result.outcome).toBe('invalidated');
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('scopes project collections by their workspace identity', () => {
|
||||||
|
const snapshot = storedProjectSnapshot();
|
||||||
|
writeSnapshotCache('test:projects', snapshot);
|
||||||
|
|
||||||
|
const sameScope = readSnapshotCache({
|
||||||
|
key: 'test:projects',
|
||||||
|
workspace: 'user-1',
|
||||||
|
policy,
|
||||||
|
validate: validateProjectCollection,
|
||||||
|
});
|
||||||
|
expect(sameScope.outcome).toBe('hit');
|
||||||
|
|
||||||
|
const foreignScope = readSnapshotCache({
|
||||||
|
key: 'test:projects',
|
||||||
|
workspace: 'user-2',
|
||||||
|
policy,
|
||||||
|
validate: validateProjectCollection,
|
||||||
|
});
|
||||||
|
expect(foreignScope).toEqual({ outcome: 'invalidated', reason: 'cross-workspace' });
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('writeSnapshotCache round-trip', () => {
|
||||||
|
it('round-trips an accepted project snapshot', () => {
|
||||||
|
const snapshot = storedProjectSnapshot();
|
||||||
|
writeSnapshotCache('test:projects', snapshot);
|
||||||
|
const result = readSnapshotCache({
|
||||||
|
key: 'test:projects',
|
||||||
|
workspace: snapshot.workspace,
|
||||||
|
policy,
|
||||||
|
validate: validateProjectCollection,
|
||||||
|
});
|
||||||
|
expect(result.outcome).toBe('hit');
|
||||||
|
if (result.outcome === 'hit') {
|
||||||
|
expect(result.snapshot.data).toEqual(projectFixtures as Project[]);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('clearSnapshotCache', () => {
|
||||||
|
it('drops the entry so the next read misses', () => {
|
||||||
|
writeSnapshotCache(KEY, storedTaskSnapshot());
|
||||||
|
expect(readTasks().outcome).toBe('hit');
|
||||||
|
clearSnapshotCache(KEY);
|
||||||
|
expect(readTasks()).toEqual({ outcome: 'miss' });
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,154 @@
|
|||||||
|
import {
|
||||||
|
computeDigest,
|
||||||
|
type FreshPayload,
|
||||||
|
type FreshSnapshot,
|
||||||
|
type FreshnessPolicy,
|
||||||
|
type InvalidationReason,
|
||||||
|
} from './model';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Session-scoped last-known snapshot cache (RI-5-001).
|
||||||
|
*
|
||||||
|
* Restored snapshots are situational awareness only: they surface as `stale`
|
||||||
|
* until a fetch re-verifies them. A cache entry that is corrupted, belongs to
|
||||||
|
* another workspace, was written by a newer schema, or no longer validates is
|
||||||
|
* invalidated (treated as unavailable, never rendered as current).
|
||||||
|
*/
|
||||||
|
|
||||||
|
const CACHE_PREFIX = 'mosaic:freshness:v1';
|
||||||
|
|
||||||
|
interface StoredSnapshot {
|
||||||
|
data: unknown;
|
||||||
|
source: string;
|
||||||
|
workspace: string;
|
||||||
|
version: number;
|
||||||
|
schemaVersion: number;
|
||||||
|
fetchedAt: number;
|
||||||
|
digest: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export type SnapshotCacheRead<T> =
|
||||||
|
| { readonly outcome: 'hit'; readonly snapshot: FreshSnapshot<T> }
|
||||||
|
| { readonly outcome: 'miss' }
|
||||||
|
| { readonly outcome: 'invalidated'; readonly reason: InvalidationReason };
|
||||||
|
|
||||||
|
export interface ReadSnapshotCacheOptions<T> {
|
||||||
|
readonly key: string;
|
||||||
|
readonly workspace: string;
|
||||||
|
readonly policy: FreshnessPolicy;
|
||||||
|
readonly validate: (value: unknown) => FreshPayload<T> | null;
|
||||||
|
}
|
||||||
|
|
||||||
|
function cacheKey(key: string): string {
|
||||||
|
return `${CACHE_PREFIX}:${key}`;
|
||||||
|
}
|
||||||
|
|
||||||
|
function isStoredSnapshot(value: unknown): value is StoredSnapshot {
|
||||||
|
if (typeof value !== 'object' || value === null) return false;
|
||||||
|
const candidate = value as Record<string, unknown>;
|
||||||
|
return (
|
||||||
|
typeof candidate['data'] === 'object' &&
|
||||||
|
candidate['data'] !== null &&
|
||||||
|
typeof candidate['source'] === 'string' &&
|
||||||
|
typeof candidate['workspace'] === 'string' &&
|
||||||
|
typeof candidate['version'] === 'number' &&
|
||||||
|
typeof candidate['schemaVersion'] === 'number' &&
|
||||||
|
typeof candidate['fetchedAt'] === 'number' &&
|
||||||
|
typeof candidate['digest'] === 'string'
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
function getStorage(): Storage | null {
|
||||||
|
try {
|
||||||
|
return globalThis.sessionStorage ?? null;
|
||||||
|
} catch {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Restore a cached snapshot under the active workspace scope. Every failure
|
||||||
|
* mode maps to an explicit invalidation reason or a miss — never to data
|
||||||
|
* that renders as current.
|
||||||
|
*/
|
||||||
|
export function readSnapshotCache<T>(options: ReadSnapshotCacheOptions<T>): SnapshotCacheRead<T> {
|
||||||
|
const storage = getStorage();
|
||||||
|
if (storage === null) return { outcome: 'miss' };
|
||||||
|
|
||||||
|
let raw: string | null;
|
||||||
|
try {
|
||||||
|
raw = storage.getItem(cacheKey(options.key));
|
||||||
|
} catch {
|
||||||
|
return { outcome: 'miss' };
|
||||||
|
}
|
||||||
|
if (raw === null) return { outcome: 'miss' };
|
||||||
|
|
||||||
|
let parsed: unknown;
|
||||||
|
try {
|
||||||
|
parsed = JSON.parse(raw);
|
||||||
|
} catch {
|
||||||
|
return { outcome: 'invalidated', reason: 'cache-corruption' };
|
||||||
|
}
|
||||||
|
if (!isStoredSnapshot(parsed)) {
|
||||||
|
return { outcome: 'invalidated', reason: 'cache-corruption' };
|
||||||
|
}
|
||||||
|
if (parsed.workspace !== options.workspace) {
|
||||||
|
return { outcome: 'invalidated', reason: 'cross-workspace' };
|
||||||
|
}
|
||||||
|
if (parsed.schemaVersion > options.policy.schemaVersion) {
|
||||||
|
// Written by a newer build than the running client: version regression.
|
||||||
|
return { outcome: 'invalidated', reason: 'version-regression' };
|
||||||
|
}
|
||||||
|
|
||||||
|
const payload = options.validate(parsed.data);
|
||||||
|
if (payload === null) {
|
||||||
|
return { outcome: 'invalidated', reason: 'schema-mismatch' };
|
||||||
|
}
|
||||||
|
if (computeDigest(payload.data) !== parsed.digest) {
|
||||||
|
return { outcome: 'invalidated', reason: 'cache-corruption' };
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
outcome: 'hit',
|
||||||
|
snapshot: {
|
||||||
|
data: payload.data,
|
||||||
|
source: parsed.source,
|
||||||
|
workspace: parsed.workspace,
|
||||||
|
version: parsed.version,
|
||||||
|
schemaVersion: parsed.schemaVersion,
|
||||||
|
fetchedAt: parsed.fetchedAt,
|
||||||
|
digest: parsed.digest,
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Persist a verified snapshot. Failures are non-fatal (cache is best-effort). */
|
||||||
|
export function writeSnapshotCache<T>(key: string, snapshot: FreshSnapshot<T>): void {
|
||||||
|
const storage = getStorage();
|
||||||
|
if (storage === null) return;
|
||||||
|
const stored: StoredSnapshot = {
|
||||||
|
data: snapshot.data,
|
||||||
|
source: snapshot.source,
|
||||||
|
workspace: snapshot.workspace,
|
||||||
|
version: snapshot.version,
|
||||||
|
schemaVersion: snapshot.schemaVersion,
|
||||||
|
fetchedAt: snapshot.fetchedAt,
|
||||||
|
digest: snapshot.digest,
|
||||||
|
};
|
||||||
|
try {
|
||||||
|
storage.setItem(cacheKey(key), JSON.stringify(stored));
|
||||||
|
} catch {
|
||||||
|
// Quota or serialization failures simply skip caching.
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Drop a cached snapshot (used when a surface invalidates its cache entry). */
|
||||||
|
export function clearSnapshotCache(key: string): void {
|
||||||
|
const storage = getStorage();
|
||||||
|
if (storage === null) return;
|
||||||
|
try {
|
||||||
|
storage.removeItem(cacheKey(key));
|
||||||
|
} catch {
|
||||||
|
// Ignorable: a wedged storage entry is detected as corruption on read.
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,372 @@
|
|||||||
|
import { act } from 'react';
|
||||||
|
import { createRoot, type Root } from 'react-dom/client';
|
||||||
|
import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from 'vitest';
|
||||||
|
import type { Task } from '@/lib/types';
|
||||||
|
import { acceptSnapshot, StaleMutationError, DEFAULT_FRESHNESS_POLICY } from './model';
|
||||||
|
import type { FreshnessFailure } from './use-fresh-collection';
|
||||||
|
import {
|
||||||
|
describeFailure,
|
||||||
|
useFreshCollection,
|
||||||
|
type FreshCollection,
|
||||||
|
type UseFreshCollectionOptions,
|
||||||
|
} from './use-fresh-collection';
|
||||||
|
import { validateProjectCollection, validateTaskCollection } from './validators';
|
||||||
|
import { projectFixtures, taskFixtures } from '@/spa/pages/page-fixtures';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Failure-matrix coverage for the freshness seam (RI-5-001): network failure,
|
||||||
|
* auth failure, malformed response, cache corruption, stale age, schema
|
||||||
|
* mismatch, cross-workspace, recovery, and stale-action rejection — with
|
||||||
|
* negative controls proving no case yields current data or an enabled
|
||||||
|
* mutation.
|
||||||
|
*/
|
||||||
|
|
||||||
|
const NOW = 1_800_000_000_000;
|
||||||
|
|
||||||
|
interface Deferred<T> {
|
||||||
|
promise: Promise<T>;
|
||||||
|
resolve: (value: T) => void;
|
||||||
|
reject: (reason?: unknown) => void;
|
||||||
|
}
|
||||||
|
|
||||||
|
function createDeferred<T>(): Deferred<T> {
|
||||||
|
let resolve!: (value: T) => void;
|
||||||
|
let reject!: (reason?: unknown) => void;
|
||||||
|
const promise = new Promise<T>((res, rej) => {
|
||||||
|
resolve = res;
|
||||||
|
reject = rej;
|
||||||
|
});
|
||||||
|
return { promise, resolve, reject };
|
||||||
|
}
|
||||||
|
|
||||||
|
let root: Root | null = null;
|
||||||
|
let container: HTMLDivElement;
|
||||||
|
let latest: FreshCollection<Task[]> | null = null;
|
||||||
|
|
||||||
|
function Probe({
|
||||||
|
options,
|
||||||
|
}: {
|
||||||
|
options: UseFreshCollectionOptions<Task[]>;
|
||||||
|
}): React.ReactElement | null {
|
||||||
|
latest = useFreshCollection<Task[]>(options);
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
beforeAll(() => {
|
||||||
|
Object.defineProperty(globalThis, 'IS_REACT_ACT_ENVIRONMENT', {
|
||||||
|
configurable: true,
|
||||||
|
value: true,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
sessionStorage.clear();
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(async () => {
|
||||||
|
await act(async () => {
|
||||||
|
root?.unmount();
|
||||||
|
});
|
||||||
|
document.body.replaceChildren();
|
||||||
|
root = null;
|
||||||
|
latest = null;
|
||||||
|
sessionStorage.clear();
|
||||||
|
vi.restoreAllMocks();
|
||||||
|
});
|
||||||
|
|
||||||
|
async function renderCollection(
|
||||||
|
options: UseFreshCollectionOptions<Task[]>,
|
||||||
|
): Promise<FreshCollection<Task[]>> {
|
||||||
|
container = document.createElement('div');
|
||||||
|
document.body.append(container);
|
||||||
|
root = createRoot(container);
|
||||||
|
await act(async () => {
|
||||||
|
root?.render(<Probe options={options} />);
|
||||||
|
});
|
||||||
|
if (latest === null) throw new Error('hook did not run');
|
||||||
|
return latest;
|
||||||
|
}
|
||||||
|
|
||||||
|
function taskOptions(
|
||||||
|
overrides: Partial<UseFreshCollectionOptions<Task[]>> = {},
|
||||||
|
): UseFreshCollectionOptions<Task[]> {
|
||||||
|
return {
|
||||||
|
source: 'gateway:/api/tasks',
|
||||||
|
fetcher: () => Promise.resolve(taskFixtures),
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
cacheKey: 'tasks',
|
||||||
|
clock: () => NOW,
|
||||||
|
...overrides,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function authError(statusCode: number): Error & { statusCode: number } {
|
||||||
|
return Object.assign(new Error(`Request failed with ${statusCode}`), { statusCode });
|
||||||
|
}
|
||||||
|
|
||||||
|
function seedCache(key: string): number {
|
||||||
|
const result = acceptSnapshot({
|
||||||
|
value: taskFixtures,
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
previous: null,
|
||||||
|
policy: DEFAULT_FRESHNESS_POLICY,
|
||||||
|
source: 'gateway:/api/tasks',
|
||||||
|
now: NOW,
|
||||||
|
});
|
||||||
|
if (result.outcome !== 'accepted') throw new Error('fixture setup failed');
|
||||||
|
sessionStorage.setItem(`mosaic:freshness:v1:${key}`, JSON.stringify({ ...result.snapshot }));
|
||||||
|
return result.snapshot.version;
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('useFreshCollection failure matrix', () => {
|
||||||
|
it('is unknown (not empty) while the first validation is in flight', async () => {
|
||||||
|
const deferred = createDeferred<Task[]>();
|
||||||
|
const collection = await renderCollection(taskOptions({ fetcher: () => deferred.promise }));
|
||||||
|
|
||||||
|
expect(collection.freshness).toBe('unknown');
|
||||||
|
expect(collection.validating).toBe(true);
|
||||||
|
expect(collection.data).toBeNull();
|
||||||
|
expect(collection.canMutate).toBe(false);
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
deferred.resolve(taskFixtures);
|
||||||
|
await deferred.promise;
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('becomes current with provenance after a verified fetch', async () => {
|
||||||
|
const collection = await renderCollection(taskOptions());
|
||||||
|
|
||||||
|
expect(collection.freshness).toBe('current');
|
||||||
|
expect(collection.data).toEqual(taskFixtures);
|
||||||
|
expect(collection.snapshot?.source).toBe('gateway:/api/tasks');
|
||||||
|
expect(collection.snapshot?.version).toBe(1);
|
||||||
|
expect(collection.failure).toBeNull();
|
||||||
|
expect(collection.canMutate).toBe(true);
|
||||||
|
// Verified snapshot is persisted for last-known restore.
|
||||||
|
expect(sessionStorage.getItem('mosaic:freshness:v1:tasks')).toBeTruthy();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('treats a network failure as unavailable — never an empty healthy collection', async () => {
|
||||||
|
const collection = await renderCollection(
|
||||||
|
taskOptions({ fetcher: () => Promise.reject(new Error('network down')) }),
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(collection.freshness).toBe('unavailable');
|
||||||
|
expect(collection.data).toBeNull();
|
||||||
|
expect(collection.failure).toEqual({ kind: 'fetch', message: 'network down' });
|
||||||
|
expect(collection.canMutate).toBe(false);
|
||||||
|
expect(describeFailure(collection.failure)).toBe('network down');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('treats an auth failure as unavailable and drops the last-known snapshot', async () => {
|
||||||
|
let call = 0;
|
||||||
|
const collection = await renderCollection(
|
||||||
|
taskOptions({
|
||||||
|
fetcher: () => {
|
||||||
|
call += 1;
|
||||||
|
return call === 1 ? Promise.resolve(taskFixtures) : Promise.reject(authError(401));
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
expect(collection.freshness).toBe('current');
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
await collection.revalidate();
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(latest?.freshness).toBe('unavailable');
|
||||||
|
expect(latest?.data).toBeNull();
|
||||||
|
expect(latest?.failure?.kind).toBe('fetch');
|
||||||
|
// The previous user's data must not linger in the session cache.
|
||||||
|
expect(sessionStorage.getItem('mosaic:freshness:v1:tasks')).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('invalidates a malformed response as a schema mismatch', async () => {
|
||||||
|
const collection = await renderCollection(
|
||||||
|
taskOptions({ fetcher: () => Promise.resolve({ malformed: true }) }),
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(collection.freshness).toBe('unavailable');
|
||||||
|
expect(collection.data).toBeNull();
|
||||||
|
expect(collection.failure).toEqual({ kind: 'invalidated', reason: 'schema-mismatch' });
|
||||||
|
expect(collection.canMutate).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('keeps the previous snapshot as labeled stale when a later payload mismatches', async () => {
|
||||||
|
let call = 0;
|
||||||
|
const collection = await renderCollection(
|
||||||
|
taskOptions({
|
||||||
|
fetcher: () => {
|
||||||
|
call += 1;
|
||||||
|
return call === 1 ? Promise.resolve(taskFixtures) : Promise.resolve('garbage');
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
expect(collection.freshness).toBe('current');
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
await collection.revalidate();
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(latest?.freshness).toBe('stale');
|
||||||
|
expect(latest?.data).toEqual(taskFixtures);
|
||||||
|
expect(latest?.failure).toEqual({ kind: 'invalidated', reason: 'schema-mismatch' });
|
||||||
|
expect(latest?.canMutate).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('drops the snapshot when the workspace changes under it (cross-workspace)', async () => {
|
||||||
|
let call = 0;
|
||||||
|
const collection = await renderCollection(
|
||||||
|
taskOptions({
|
||||||
|
fetcher: () => {
|
||||||
|
call += 1;
|
||||||
|
return Promise.resolve(
|
||||||
|
call === 1 ? projectFixtures : [{ ...projectFixtures[0], userId: 'user-2' }],
|
||||||
|
);
|
||||||
|
},
|
||||||
|
validate: validateProjectCollection as unknown as (value: unknown) => {
|
||||||
|
data: Task[];
|
||||||
|
workspace: string | null;
|
||||||
|
},
|
||||||
|
source: 'gateway:/api/projects',
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
expect(collection.freshness).toBe('current');
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
await collection.revalidate();
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(latest?.freshness).toBe('unavailable');
|
||||||
|
expect(latest?.data).toBeNull();
|
||||||
|
expect(latest?.failure).toEqual({ kind: 'invalidated', reason: 'cross-workspace' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('ages from current to stale and refuses mutations on stale data', async () => {
|
||||||
|
let fakeNow = NOW;
|
||||||
|
const collection = await renderCollection(
|
||||||
|
taskOptions({
|
||||||
|
clock: () => fakeNow,
|
||||||
|
policy: { staleAfterMs: 40 },
|
||||||
|
tickMs: 10,
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
expect(collection.freshness).toBe('current');
|
||||||
|
|
||||||
|
// Age the snapshot past the policy and let the tick recompute.
|
||||||
|
fakeNow = NOW + 60;
|
||||||
|
await act(async () => {
|
||||||
|
await new Promise((resolve) => setTimeout(resolve, 25));
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(latest?.freshness).toBe('stale');
|
||||||
|
expect(latest?.data).toEqual(taskFixtures);
|
||||||
|
expect(latest?.canMutate).toBe(false);
|
||||||
|
|
||||||
|
const operation = vi.fn(async () => 'result');
|
||||||
|
await expect(latest?.mutate(operation)).rejects.toBeInstanceOf(StaleMutationError);
|
||||||
|
expect(operation).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('recovers to current after a successful revalidation', async () => {
|
||||||
|
let call = 0;
|
||||||
|
const collection = await renderCollection(
|
||||||
|
taskOptions({
|
||||||
|
fetcher: () => {
|
||||||
|
call += 1;
|
||||||
|
return call === 1
|
||||||
|
? Promise.reject(new Error('first attempt failed'))
|
||||||
|
: Promise.resolve(taskFixtures);
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
expect(collection.freshness).toBe('unavailable');
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
await collection.revalidate();
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(latest?.freshness).toBe('current');
|
||||||
|
expect(latest?.failure).toBeNull();
|
||||||
|
|
||||||
|
const operation = vi.fn(async (data: Task[]) => data.length);
|
||||||
|
await expect(latest?.mutate(operation)).resolves.toBe(taskFixtures.length);
|
||||||
|
expect(operation).toHaveBeenCalledOnce();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('restores a cached snapshot as unverified stale data, then verifies it', async () => {
|
||||||
|
const seededVersion = seedCache('tasks');
|
||||||
|
const deferred = createDeferred<Task[]>();
|
||||||
|
const collection = await renderCollection(taskOptions({ fetcher: () => deferred.promise }));
|
||||||
|
|
||||||
|
// Restored data is situational awareness only: labeled stale, never
|
||||||
|
// current, and mutations are refused before verification.
|
||||||
|
expect(collection.freshness).toBe('stale');
|
||||||
|
expect(collection.data).toEqual(taskFixtures);
|
||||||
|
expect(collection.canMutate).toBe(false);
|
||||||
|
await expect(collection.mutate(vi.fn())).rejects.toBeInstanceOf(StaleMutationError);
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
deferred.resolve(taskFixtures);
|
||||||
|
await deferred.promise;
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(latest?.freshness).toBe('current');
|
||||||
|
expect(latest?.snapshot?.version).toBe(seededVersion + 1);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('never promotes corrupted cache data to current (cache corruption)', async () => {
|
||||||
|
sessionStorage.setItem('mosaic:freshness:v1:tasks', '{"data":');
|
||||||
|
const collection = await renderCollection(
|
||||||
|
taskOptions({ fetcher: () => Promise.reject(new Error('still down')) }),
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(collection.freshness).toBe('unavailable');
|
||||||
|
expect(collection.data).toBeNull();
|
||||||
|
expect(collection.canMutate).toBe(false);
|
||||||
|
// The corrupted entry is dropped so it cannot come back.
|
||||||
|
expect(sessionStorage.getItem('mosaic:freshness:v1:tasks')).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('refuses mutations while unknown or unavailable — the call itself, not just the button', async () => {
|
||||||
|
const deferred = createDeferred<Task[]>();
|
||||||
|
const unknown = await renderCollection(taskOptions({ fetcher: () => deferred.promise }));
|
||||||
|
const operation = vi.fn(async () => 'result');
|
||||||
|
await expect(unknown.mutate(operation)).rejects.toBeInstanceOf(StaleMutationError);
|
||||||
|
expect(operation).not.toHaveBeenCalled();
|
||||||
|
await act(async () => {
|
||||||
|
deferred.reject(new Error('failed'));
|
||||||
|
await deferred.promise.catch(() => undefined);
|
||||||
|
});
|
||||||
|
|
||||||
|
const unavailable = latest!;
|
||||||
|
await expect(unavailable.mutate(operation)).rejects.toBeInstanceOf(StaleMutationError);
|
||||||
|
expect(operation).not.toHaveBeenCalled();
|
||||||
|
expect(unavailable.canMutate).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('degrades to stale with last-known data when a revalidation fails after success', async () => {
|
||||||
|
let call = 0;
|
||||||
|
const collection = await renderCollection(
|
||||||
|
taskOptions({
|
||||||
|
fetcher: () => {
|
||||||
|
call += 1;
|
||||||
|
return call === 1
|
||||||
|
? Promise.resolve(taskFixtures)
|
||||||
|
: Promise.reject(new Error('connection lost'));
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
expect(collection.freshness).toBe('current');
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
await collection.revalidate();
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(latest?.freshness).toBe('stale');
|
||||||
|
expect(latest?.data).toEqual(taskFixtures);
|
||||||
|
const failure: FreshnessFailure | null = latest?.failure ?? null;
|
||||||
|
expect(failure).toEqual({ kind: 'fetch', message: 'connection lost' });
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,281 @@
|
|||||||
|
import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
|
||||||
|
import {
|
||||||
|
acceptSnapshot,
|
||||||
|
assertMutable,
|
||||||
|
computeFreshness,
|
||||||
|
DEFAULT_FRESHNESS_POLICY,
|
||||||
|
invalidationReasonLabels,
|
||||||
|
type FreshPayload,
|
||||||
|
type FreshSnapshot,
|
||||||
|
type FreshnessPolicy,
|
||||||
|
type FreshnessState,
|
||||||
|
type InvalidationReason,
|
||||||
|
StaleMutationError,
|
||||||
|
} from './model';
|
||||||
|
import { clearSnapshotCache, readSnapshotCache, writeSnapshotCache } from './snapshot-cache';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Freshness-aware collection fetch hook (RI-5-001).
|
||||||
|
*
|
||||||
|
* One hook owns one gateway collection end to end: fetch, schema validation,
|
||||||
|
* snapshot acceptance with provenance, session-scoped last-known caching,
|
||||||
|
* aging, and the mutation guard. Pages consume `freshness` and never infer
|
||||||
|
* health from emptiness.
|
||||||
|
*/
|
||||||
|
|
||||||
|
/** Why the latest validation did not produce a current snapshot. */
|
||||||
|
export type FreshnessFailure =
|
||||||
|
| { readonly kind: 'fetch'; readonly message: string }
|
||||||
|
| { readonly kind: 'invalidated'; readonly reason: InvalidationReason };
|
||||||
|
|
||||||
|
export interface UseFreshCollectionOptions<T> {
|
||||||
|
/** Source identity for provenance labels, e.g. `gateway:/api/tasks`. */
|
||||||
|
readonly source: string;
|
||||||
|
/** Performs the unvalidated fetch. The hook owns abort and verification. */
|
||||||
|
readonly fetcher: (signal: AbortSignal) => Promise<unknown>;
|
||||||
|
/**
|
||||||
|
* Runtime schema validator. Returning `null` invalidates the payload
|
||||||
|
* (`schema-mismatch`) instead of letting malformed JSON flow into render.
|
||||||
|
*/
|
||||||
|
readonly validate: (value: unknown) => FreshPayload<T> | null;
|
||||||
|
/** Overrides of the default freshness policy. */
|
||||||
|
readonly policy?: Partial<FreshnessPolicy>;
|
||||||
|
/**
|
||||||
|
* Session cache key for last-known snapshots. `null`/omitted disables
|
||||||
|
* restore. Restored snapshots are unverified: they render only as
|
||||||
|
* labeled `stale` data until a fetch re-verifies them.
|
||||||
|
*/
|
||||||
|
readonly cacheKey?: string | null;
|
||||||
|
/** Injectable clock for deterministic age transitions in tests. */
|
||||||
|
readonly clock?: () => number;
|
||||||
|
/** Aging tick interval override (default derived from `staleAfterMs`). */
|
||||||
|
readonly tickMs?: number;
|
||||||
|
/** When false, no fetch runs (surfaces stay `unavailable`/`unknown`). */
|
||||||
|
readonly enabled?: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface FreshCollection<T> {
|
||||||
|
/** Last verified (or restored-unverified) snapshot, or `null`. */
|
||||||
|
readonly snapshot: FreshSnapshot<T> | null;
|
||||||
|
/** Snapshot data or `null` — never a fabricated empty collection. */
|
||||||
|
readonly data: T | null;
|
||||||
|
readonly freshness: FreshnessState;
|
||||||
|
/** True while a validation request is in flight. */
|
||||||
|
readonly validating: boolean;
|
||||||
|
/** Outcome of the latest failed validation, `null` when healthy. */
|
||||||
|
readonly failure: FreshnessFailure | null;
|
||||||
|
/** False unless freshness is `current`; drives disabled UI affordances. */
|
||||||
|
readonly canMutate: boolean;
|
||||||
|
/** Re-run the fetch and re-verify. Always allowed (it is a read). */
|
||||||
|
readonly revalidate: () => Promise<void>;
|
||||||
|
/**
|
||||||
|
* Run a state-changing operation against verified-current data only.
|
||||||
|
* Rejects with `StaleMutationError` on any other state — the guard fires
|
||||||
|
* even if a disabled button was bypassed (defense in depth).
|
||||||
|
*/
|
||||||
|
readonly mutate: <R>(operation: (data: T) => Promise<R>) => Promise<R>;
|
||||||
|
}
|
||||||
|
|
||||||
|
const defaultClock = (): number => Date.now();
|
||||||
|
|
||||||
|
function resolveTickMs(policy: FreshnessPolicy, override?: number): number {
|
||||||
|
if (override !== undefined && override > 0) return override;
|
||||||
|
return Math.min(5_000, Math.max(250, Math.floor(policy.staleAfterMs / 4)));
|
||||||
|
}
|
||||||
|
|
||||||
|
function isAuthFailure(caught: unknown): boolean {
|
||||||
|
return (
|
||||||
|
typeof caught === 'object' &&
|
||||||
|
caught !== null &&
|
||||||
|
'statusCode' in caught &&
|
||||||
|
((caught as { statusCode?: unknown }).statusCode === 401 ||
|
||||||
|
(caught as { statusCode?: unknown }).statusCode === 403)
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
function fetchFailureMessage(caught: unknown): string {
|
||||||
|
if (caught instanceof Error && caught.message.trim().length > 0) return caught.message;
|
||||||
|
return 'The request failed.';
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Human-readable summary of a failure for unavailable/stale notices. */
|
||||||
|
export function describeFailure(failure: FreshnessFailure | null): string | null {
|
||||||
|
if (failure === null) return null;
|
||||||
|
if (failure.kind === 'fetch') return failure.message;
|
||||||
|
return `The snapshot was invalidated: ${invalidationReasonLabels[failure.reason]}.`;
|
||||||
|
}
|
||||||
|
|
||||||
|
export function useFreshCollection<T>(options: UseFreshCollectionOptions<T>): FreshCollection<T> {
|
||||||
|
const optionsRef = useRef(options);
|
||||||
|
optionsRef.current = options;
|
||||||
|
|
||||||
|
const policy = useMemo<FreshnessPolicy>(
|
||||||
|
() => ({ ...DEFAULT_FRESHNESS_POLICY, ...options.policy }),
|
||||||
|
[options.policy],
|
||||||
|
);
|
||||||
|
const policyRef = useRef(policy);
|
||||||
|
policyRef.current = policy;
|
||||||
|
|
||||||
|
const clockRef = useRef(options.clock ?? defaultClock);
|
||||||
|
clockRef.current = options.clock ?? defaultClock;
|
||||||
|
|
||||||
|
const [snapshot, setSnapshot] = useState<FreshSnapshot<T> | null>(null);
|
||||||
|
const [failure, setFailure] = useState<FreshnessFailure | null>(null);
|
||||||
|
const [unverified, setUnverified] = useState(false);
|
||||||
|
const [validating, setValidating] = useState(options.enabled !== false);
|
||||||
|
const [now, setNow] = useState(() => (options.clock ?? defaultClock)());
|
||||||
|
|
||||||
|
const snapshotRef = useRef(snapshot);
|
||||||
|
snapshotRef.current = snapshot;
|
||||||
|
const failureRef = useRef(failure);
|
||||||
|
failureRef.current = failure;
|
||||||
|
const unverifiedRef = useRef(unverified);
|
||||||
|
unverifiedRef.current = unverified;
|
||||||
|
|
||||||
|
const runRef = useRef(0);
|
||||||
|
const abortRef = useRef<AbortController | null>(null);
|
||||||
|
|
||||||
|
const revalidate = useCallback(async (): Promise<void> => {
|
||||||
|
const current = optionsRef.current;
|
||||||
|
if (current.enabled === false) {
|
||||||
|
setValidating(false);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const runId = ++runRef.current;
|
||||||
|
abortRef.current?.abort();
|
||||||
|
const controller = new AbortController();
|
||||||
|
abortRef.current = controller;
|
||||||
|
setValidating(true);
|
||||||
|
|
||||||
|
let value: unknown;
|
||||||
|
try {
|
||||||
|
value = await current.fetcher(controller.signal);
|
||||||
|
} catch (caught) {
|
||||||
|
if (runRef.current !== runId || controller.signal.aborted) return;
|
||||||
|
if (isAuthFailure(caught)) {
|
||||||
|
// An unauthenticated viewer must not keep (or be served) the
|
||||||
|
// previous user's last-known data.
|
||||||
|
setSnapshot(null);
|
||||||
|
setUnverified(false);
|
||||||
|
if (current.cacheKey) clearSnapshotCache(current.cacheKey);
|
||||||
|
}
|
||||||
|
setFailure({ kind: 'fetch', message: fetchFailureMessage(caught) });
|
||||||
|
setValidating(false);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (runRef.current !== runId) return;
|
||||||
|
|
||||||
|
const result = acceptSnapshot({
|
||||||
|
value,
|
||||||
|
validate: current.validate,
|
||||||
|
previous: snapshotRef.current,
|
||||||
|
policy: policyRef.current,
|
||||||
|
source: current.source,
|
||||||
|
now: clockRef.current(),
|
||||||
|
});
|
||||||
|
|
||||||
|
if (result.outcome === 'accepted') {
|
||||||
|
setSnapshot(result.snapshot);
|
||||||
|
setUnverified(false);
|
||||||
|
setFailure(null);
|
||||||
|
if (current.cacheKey) writeSnapshotCache(current.cacheKey, result.snapshot);
|
||||||
|
} else {
|
||||||
|
if (result.reason === 'cross-workspace') {
|
||||||
|
// Data verified for a different workspace must not linger as
|
||||||
|
// last-known situational awareness either.
|
||||||
|
setSnapshot(null);
|
||||||
|
setUnverified(false);
|
||||||
|
}
|
||||||
|
if (current.cacheKey) clearSnapshotCache(current.cacheKey);
|
||||||
|
setFailure({ kind: 'invalidated', reason: result.reason });
|
||||||
|
}
|
||||||
|
setValidating(false);
|
||||||
|
}, []);
|
||||||
|
|
||||||
|
// Restore the last-known snapshot (unverified) and run the first fetch.
|
||||||
|
useEffect(() => {
|
||||||
|
if (optionsRef.current.enabled === false) {
|
||||||
|
setValidating(false);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const cacheKey = optionsRef.current.cacheKey;
|
||||||
|
if (cacheKey) {
|
||||||
|
const restored = readSnapshotCache<T>({
|
||||||
|
key: cacheKey,
|
||||||
|
workspace: policyRef.current.workspace,
|
||||||
|
policy: policyRef.current,
|
||||||
|
validate: optionsRef.current.validate,
|
||||||
|
});
|
||||||
|
if (restored.outcome === 'hit') {
|
||||||
|
setSnapshot(restored.snapshot);
|
||||||
|
setUnverified(true);
|
||||||
|
} else if (restored.outcome === 'invalidated') {
|
||||||
|
// A corrupted/foreign/regressed entry is dropped immediately; it must
|
||||||
|
// never surface as data. The fetch decides the visible state.
|
||||||
|
clearSnapshotCache(cacheKey);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
void revalidate();
|
||||||
|
|
||||||
|
return () => {
|
||||||
|
abortRef.current?.abort();
|
||||||
|
};
|
||||||
|
// Mount-once by design: `revalidate` is stable and reads live options
|
||||||
|
// through refs, so it never needs to re-run when options change.
|
||||||
|
// Route-param pages remount this hook via an identity `key` instead.
|
||||||
|
}, [revalidate]);
|
||||||
|
|
||||||
|
// Aging tick: recomputes freshness as the snapshot ages past the policy.
|
||||||
|
useEffect(() => {
|
||||||
|
const interval = setInterval(
|
||||||
|
() => {
|
||||||
|
setNow(clockRef.current());
|
||||||
|
},
|
||||||
|
resolveTickMs(policyRef.current, optionsRef.current.tickMs),
|
||||||
|
);
|
||||||
|
return () => clearInterval(interval);
|
||||||
|
}, []);
|
||||||
|
|
||||||
|
const freshness = useMemo<FreshnessState>(() => {
|
||||||
|
if (snapshot === null) return validating ? 'unknown' : 'unavailable';
|
||||||
|
return computeFreshness({
|
||||||
|
snapshot,
|
||||||
|
policy,
|
||||||
|
now,
|
||||||
|
degraded: failure !== null || unverified,
|
||||||
|
});
|
||||||
|
// `now` from state covers age; refs inside computeFreshness are pure.
|
||||||
|
}, [snapshot, validating, failure, unverified, now, policy]);
|
||||||
|
|
||||||
|
const canMutate = freshness === 'current';
|
||||||
|
|
||||||
|
const mutate = useCallback(async <R>(operation: (data: T) => Promise<R>): Promise<R> => {
|
||||||
|
const currentSnapshot = snapshotRef.current;
|
||||||
|
// No verified snapshot at all: with nothing verified there is nothing
|
||||||
|
// current to mutate, regardless of the recorded failure.
|
||||||
|
if (currentSnapshot === null) throw new StaleMutationError('unavailable');
|
||||||
|
const state = computeFreshness({
|
||||||
|
snapshot: currentSnapshot,
|
||||||
|
policy: policyRef.current,
|
||||||
|
now: clockRef.current(),
|
||||||
|
degraded: failureRef.current !== null || unverifiedRef.current,
|
||||||
|
});
|
||||||
|
assertMutable(state);
|
||||||
|
return operation(currentSnapshot.data);
|
||||||
|
}, []);
|
||||||
|
|
||||||
|
return {
|
||||||
|
snapshot,
|
||||||
|
data: snapshot === null ? null : snapshot.data,
|
||||||
|
freshness,
|
||||||
|
validating,
|
||||||
|
failure,
|
||||||
|
canMutate,
|
||||||
|
revalidate,
|
||||||
|
mutate,
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -0,0 +1,103 @@
|
|||||||
|
import { describe, expect, it } from 'vitest';
|
||||||
|
import type { Mission, Project, Task } from '@/lib/types';
|
||||||
|
import {
|
||||||
|
validateMissionCollection,
|
||||||
|
validateProjectCollection,
|
||||||
|
validateProjectEntity,
|
||||||
|
validateTaskCollection,
|
||||||
|
} from './validators';
|
||||||
|
import { missionFixtures, projectFixtures, taskFixtures } from '@/spa/pages/page-fixtures';
|
||||||
|
|
||||||
|
describe('validateTaskCollection', () => {
|
||||||
|
it('accepts a well-formed task collection', () => {
|
||||||
|
expect(validateTaskCollection(taskFixtures)).toEqual({
|
||||||
|
data: taskFixtures,
|
||||||
|
workspace: null,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('accepts an empty collection (a healthy empty state is a valid payload)', () => {
|
||||||
|
expect(validateTaskCollection([])).toEqual({ data: [], workspace: null });
|
||||||
|
});
|
||||||
|
|
||||||
|
it.each([
|
||||||
|
['not an array', { items: [] }],
|
||||||
|
['item is not an object', ['nope']],
|
||||||
|
['missing id', [{ ...(taskFixtures[0] as Task), id: undefined }]],
|
||||||
|
['missing title', [{ ...(taskFixtures[0] as Task), title: undefined }]],
|
||||||
|
['unknown status enum', [{ ...(taskFixtures[0] as Task), status: 'finished' }]],
|
||||||
|
['unknown priority enum', [{ ...(taskFixtures[0] as Task), priority: 'urgent' }]],
|
||||||
|
['tags of the wrong type', [{ ...(taskFixtures[0] as Task), tags: 'spa' }]],
|
||||||
|
['metadata of the wrong type', [{ ...(taskFixtures[0] as Task), metadata: 'notes' }]],
|
||||||
|
['createdAt of the wrong type', [{ ...(taskFixtures[0] as Task), createdAt: 1234 }]],
|
||||||
|
['null sneaks past a required string', [{ ...(taskFixtures[0] as Task), title: null }]],
|
||||||
|
])('rejects a malformed payload: %s', (_label, value) => {
|
||||||
|
expect(validateTaskCollection(value)).toBeNull();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('validateMissionCollection', () => {
|
||||||
|
it('accepts a well-formed mission collection', () => {
|
||||||
|
expect(validateMissionCollection(missionFixtures)).toEqual({
|
||||||
|
data: missionFixtures,
|
||||||
|
workspace: null,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it.each([
|
||||||
|
['not an array', null],
|
||||||
|
['item missing name', [{ ...(missionFixtures[0] as Mission), name: 42 }]],
|
||||||
|
['unknown status enum', [{ ...(missionFixtures[0] as Mission), status: 'canceled' }]],
|
||||||
|
['projectId of the wrong type', [{ ...(missionFixtures[0] as Mission), projectId: 7 }]],
|
||||||
|
])('rejects a malformed payload: %s', (_label, value) => {
|
||||||
|
expect(validateMissionCollection(value)).toBeNull();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('validateProjectCollection', () => {
|
||||||
|
it('accepts a uniform workspace-scoped collection and reports its workspace', () => {
|
||||||
|
expect(validateProjectCollection(projectFixtures)).toEqual({
|
||||||
|
data: projectFixtures,
|
||||||
|
workspace: 'user-1',
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('accepts an empty collection with no workspace identity', () => {
|
||||||
|
expect(validateProjectCollection([])).toEqual({ data: [], workspace: null });
|
||||||
|
});
|
||||||
|
|
||||||
|
it.each([
|
||||||
|
['not an array', 42],
|
||||||
|
['item missing userId', [{ ...(projectFixtures[0] as Project), userId: undefined }]],
|
||||||
|
['unknown status enum', [{ ...(projectFixtures[0] as Project), status: 'live' }]],
|
||||||
|
['description of the wrong type', [{ ...(projectFixtures[0] as Project), description: 1 }]],
|
||||||
|
])('rejects a malformed payload: %s', (_label, value) => {
|
||||||
|
expect(validateProjectCollection(value)).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('rejects a collection mixing workspace identities (cross-workspace leak)', () => {
|
||||||
|
const mixed = [
|
||||||
|
projectFixtures[0] as Project,
|
||||||
|
{ ...(projectFixtures[1] as Project), userId: 'user-2' },
|
||||||
|
];
|
||||||
|
expect(validateProjectCollection(mixed)).toBeNull();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('validateProjectEntity', () => {
|
||||||
|
it('accepts a well-formed project and reports its workspace', () => {
|
||||||
|
expect(validateProjectEntity(projectFixtures[0])).toEqual({
|
||||||
|
data: projectFixtures[0],
|
||||||
|
workspace: 'user-1',
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it.each([
|
||||||
|
['not an object', 'project-1'],
|
||||||
|
['null', null],
|
||||||
|
['array', [projectFixtures[0]]],
|
||||||
|
['missing userId', [{ ...(projectFixtures[0] as Project), userId: null }]],
|
||||||
|
])('rejects a malformed entity: %s', (_label, value) => {
|
||||||
|
expect(validateProjectEntity(value)).toBeNull();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,135 @@
|
|||||||
|
import type { Mission, Project, Task, MissionStatus, TaskPriority, TaskStatus } from '@/lib/types';
|
||||||
|
import type { FreshPayload } from './model';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Runtime schema validators for gateway collections (RI-5-001).
|
||||||
|
*
|
||||||
|
* `api<T>()` returns untrusted JSON cast to `T`; these validators are the
|
||||||
|
* seam where a malformed response becomes an explicit schema mismatch
|
||||||
|
* instead of flowing into the render path as if it were healthy data.
|
||||||
|
*/
|
||||||
|
|
||||||
|
const taskStatuses: readonly TaskStatus[] = [
|
||||||
|
'not-started',
|
||||||
|
'in-progress',
|
||||||
|
'blocked',
|
||||||
|
'done',
|
||||||
|
'cancelled',
|
||||||
|
];
|
||||||
|
const taskPriorities: readonly TaskPriority[] = ['critical', 'high', 'medium', 'low'];
|
||||||
|
const missionStatuses: readonly MissionStatus[] = [
|
||||||
|
'planning',
|
||||||
|
'active',
|
||||||
|
'paused',
|
||||||
|
'completed',
|
||||||
|
'failed',
|
||||||
|
];
|
||||||
|
const projectStatuses: readonly Project['status'][] = ['active', 'paused', 'completed', 'archived'];
|
||||||
|
|
||||||
|
function isRecord(value: unknown): value is Record<string, unknown> {
|
||||||
|
return typeof value === 'object' && value !== null && !Array.isArray(value);
|
||||||
|
}
|
||||||
|
|
||||||
|
function isString(value: unknown): value is string {
|
||||||
|
return typeof value === 'string';
|
||||||
|
}
|
||||||
|
|
||||||
|
function isNullableString(value: unknown): value is string | null {
|
||||||
|
return value === null || typeof value === 'string';
|
||||||
|
}
|
||||||
|
|
||||||
|
function isOneOf<T extends string>(value: unknown, allowed: readonly T[]): value is T {
|
||||||
|
return typeof value === 'string' && (allowed as readonly string[]).includes(value);
|
||||||
|
}
|
||||||
|
|
||||||
|
function isNullableRecord(value: unknown): value is Record<string, unknown> | null {
|
||||||
|
return value === null || isRecord(value);
|
||||||
|
}
|
||||||
|
|
||||||
|
function isNullableStringArray(value: unknown): value is string[] | null {
|
||||||
|
if (value === null) return true;
|
||||||
|
if (!Array.isArray(value)) return false;
|
||||||
|
return value.every((item) => typeof item === 'string');
|
||||||
|
}
|
||||||
|
|
||||||
|
function isIsoLike(value: unknown): value is string {
|
||||||
|
return typeof value === 'string' && value.length > 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
function isTask(value: unknown): value is Task {
|
||||||
|
if (!isRecord(value)) return false;
|
||||||
|
return (
|
||||||
|
isString(value['id']) &&
|
||||||
|
isString(value['title']) &&
|
||||||
|
isOneOf(value['status'], taskStatuses) &&
|
||||||
|
isOneOf(value['priority'], taskPriorities) &&
|
||||||
|
isNullableString(value['projectId']) &&
|
||||||
|
isNullableString(value['missionId']) &&
|
||||||
|
isNullableString(value['assignee']) &&
|
||||||
|
isNullableStringArray(value['tags']) &&
|
||||||
|
isNullableRecord(value['metadata']) &&
|
||||||
|
isNullableString(value['dueDate']) &&
|
||||||
|
isIsoLike(value['createdAt']) &&
|
||||||
|
isIsoLike(value['updatedAt'])
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Tasks carry no workspace identity; scope falls back to the policy. */
|
||||||
|
export function validateTaskCollection(value: unknown): FreshPayload<Task[]> | null {
|
||||||
|
if (!Array.isArray(value) || !value.every(isTask)) return null;
|
||||||
|
return { data: value as Task[], workspace: null };
|
||||||
|
}
|
||||||
|
|
||||||
|
function isMission(value: unknown): value is Mission {
|
||||||
|
if (!isRecord(value)) return false;
|
||||||
|
return (
|
||||||
|
isString(value['id']) &&
|
||||||
|
isString(value['name']) &&
|
||||||
|
isOneOf(value['status'], missionStatuses) &&
|
||||||
|
isNullableString(value['projectId']) &&
|
||||||
|
isNullableString(value['description']) &&
|
||||||
|
isNullableRecord(value['metadata']) &&
|
||||||
|
isIsoLike(value['createdAt']) &&
|
||||||
|
isIsoLike(value['updatedAt'])
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Missions carry no workspace identity; scope falls back to the policy. */
|
||||||
|
export function validateMissionCollection(value: unknown): FreshPayload<Mission[]> | null {
|
||||||
|
if (!Array.isArray(value) || !value.every(isMission)) return null;
|
||||||
|
return { data: value as Mission[], workspace: null };
|
||||||
|
}
|
||||||
|
|
||||||
|
function isProject(value: unknown): value is Project {
|
||||||
|
if (!isRecord(value)) return false;
|
||||||
|
return (
|
||||||
|
isString(value['id']) &&
|
||||||
|
isString(value['name']) &&
|
||||||
|
isOneOf(value['status'], projectStatuses) &&
|
||||||
|
isString(value['userId']) &&
|
||||||
|
isNullableString(value['description']) &&
|
||||||
|
isNullableRecord(value['metadata']) &&
|
||||||
|
isIsoLike(value['createdAt']) &&
|
||||||
|
isIsoLike(value['updatedAt'])
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Projects are workspace-scoped: every item must carry the same `userId`.
|
||||||
|
* A collection mixing identities (cross-workspace leak) is a schema
|
||||||
|
* mismatch; the uniform `userId` becomes the snapshot workspace.
|
||||||
|
*/
|
||||||
|
export function validateProjectCollection(value: unknown): FreshPayload<Project[]> | null {
|
||||||
|
if (!Array.isArray(value) || !value.every(isProject)) return null;
|
||||||
|
const projects = value as Project[];
|
||||||
|
const workspaces = new Set(projects.map((project) => project.userId));
|
||||||
|
if (workspaces.size > 1) return null;
|
||||||
|
return { data: projects, workspace: projects.length > 0 ? projects[0]!.userId : null };
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Single project entity (project detail primary collection). */
|
||||||
|
export function validateProjectEntity(value: unknown): FreshPayload<Project> | null {
|
||||||
|
if (!isProject(value)) return null;
|
||||||
|
const project = value as Project;
|
||||||
|
return { data: project, workspace: project.userId };
|
||||||
|
}
|
||||||
@@ -35,6 +35,7 @@ afterEach(async () => {
|
|||||||
document.body.replaceChildren();
|
document.body.replaceChildren();
|
||||||
root = null;
|
root = null;
|
||||||
apiMock.mockReset();
|
apiMock.mockReset();
|
||||||
|
sessionStorage.clear();
|
||||||
});
|
});
|
||||||
|
|
||||||
async function renderProjectDetailPage(): Promise<ReturnType<typeof createMemoryRouter>> {
|
async function renderProjectDetailPage(): Promise<ReturnType<typeof createMemoryRouter>> {
|
||||||
@@ -64,21 +65,49 @@ function clickButtonByText(text: string): void {
|
|||||||
button.dispatchEvent(new MouseEvent('click', { bubbles: true }));
|
button.dispatchEvent(new MouseEvent('click', { bubbles: true }));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async function flushAct(): Promise<void> {
|
||||||
|
await act(async () => {
|
||||||
|
await Promise.resolve();
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
interface Deferred<T> {
|
||||||
|
promise: Promise<T>;
|
||||||
|
resolve: (value: T) => void;
|
||||||
|
}
|
||||||
|
|
||||||
|
function createDeferred<T>(): Deferred<T> {
|
||||||
|
let resolve!: (value: T) => void;
|
||||||
|
const promise = new Promise<T>((res) => {
|
||||||
|
resolve = res;
|
||||||
|
});
|
||||||
|
return { promise, resolve };
|
||||||
|
}
|
||||||
|
|
||||||
|
const projectOneTasks = taskFixtures.filter((task) => task.projectId === 'project-1');
|
||||||
|
|
||||||
|
function mockHealthyLoad(): void {
|
||||||
|
apiMock
|
||||||
|
.mockResolvedValueOnce(projectFixtures[0])
|
||||||
|
.mockResolvedValueOnce(missionFixtures)
|
||||||
|
.mockResolvedValueOnce(projectOneTasks);
|
||||||
|
}
|
||||||
|
|
||||||
describe('ProjectDetailPage', () => {
|
describe('ProjectDetailPage', () => {
|
||||||
it('loads the project, tasks, missions, and optional PRD content for the active project', async () => {
|
it('loads the project, tasks, missions, and optional PRD content for the active project', async () => {
|
||||||
apiMock
|
mockHealthyLoad();
|
||||||
.mockResolvedValueOnce(projectFixtures[0])
|
|
||||||
.mockResolvedValueOnce(missionFixtures)
|
|
||||||
.mockResolvedValueOnce(taskFixtures.filter((task) => task.projectId === 'project-1'));
|
|
||||||
|
|
||||||
await renderProjectDetailPage();
|
await renderProjectDetailPage();
|
||||||
|
|
||||||
expect(apiMock.mock.calls).toEqual([
|
expect(apiMock.mock.calls.map((call) => call[0])).toEqual([
|
||||||
['/api/projects/project-1'],
|
'/api/projects/project-1',
|
||||||
['/api/missions'],
|
'/api/missions',
|
||||||
['/api/tasks?projectId=project-1'],
|
'/api/tasks?projectId=project-1',
|
||||||
]);
|
]);
|
||||||
|
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'current',
|
||||||
|
);
|
||||||
expect(container.textContent).toContain('Mosaic Stack');
|
expect(container.textContent).toContain('Mosaic Stack');
|
||||||
expect(container.textContent).toContain('Route /projects/:id');
|
expect(container.textContent).toContain('Route /projects/:id');
|
||||||
expect(container.textContent).toContain('Tasks');
|
expect(container.textContent).toContain('Tasks');
|
||||||
@@ -101,10 +130,7 @@ describe('ProjectDetailPage', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
it('opens and closes the existing read-only task modal from the tasks tab', async () => {
|
it('opens and closes the existing read-only task modal from the tasks tab', async () => {
|
||||||
apiMock
|
mockHealthyLoad();
|
||||||
.mockResolvedValueOnce(projectFixtures[0])
|
|
||||||
.mockResolvedValueOnce(missionFixtures)
|
|
||||||
.mockResolvedValueOnce(taskFixtures.filter((task) => task.projectId === 'project-1'));
|
|
||||||
|
|
||||||
await renderProjectDetailPage();
|
await renderProjectDetailPage();
|
||||||
|
|
||||||
@@ -134,35 +160,153 @@ describe('ProjectDetailPage', () => {
|
|||||||
expect(container.querySelector('[role="dialog"]')).toBeNull();
|
expect(container.querySelector('[role="dialog"]')).toBeNull();
|
||||||
});
|
});
|
||||||
|
|
||||||
it('renders the project with an empty missions tab when the missions request fails', async () => {
|
it('shows verified completion verdicts when the task collection is current', async () => {
|
||||||
apiMock
|
mockHealthyLoad();
|
||||||
.mockResolvedValueOnce(projectFixtures[0])
|
|
||||||
.mockRejectedValueOnce(new Error('Missions request failed'))
|
|
||||||
.mockResolvedValueOnce(taskFixtures.filter((task) => task.projectId === 'project-1'));
|
|
||||||
|
|
||||||
await renderProjectDetailPage();
|
await renderProjectDetailPage();
|
||||||
|
|
||||||
expect(container.textContent).toContain('Mosaic Stack');
|
const doneCard = [...container.querySelectorAll('div')].find(
|
||||||
expect(container.querySelector('[role="alert"]')).toBeNull();
|
(candidate) => candidate.textContent === 'Done1',
|
||||||
|
);
|
||||||
await act(async () => {
|
expect(doneCard).toBeTruthy();
|
||||||
clickButtonByText('Missions (0)');
|
const inProgressCard = [...container.querySelectorAll('div')].find(
|
||||||
});
|
(candidate) => candidate.textContent === 'In Progress1',
|
||||||
|
);
|
||||||
expect(container.textContent).toContain('No missions for this project');
|
expect(inProgressCard).toBeTruthy();
|
||||||
});
|
});
|
||||||
|
|
||||||
it('renders a visible alert when the project request fails and lets the user navigate back', async () => {
|
it('renders an explicit unavailable missions tab when the missions request fails (partial, not empty)', async () => {
|
||||||
|
apiMock
|
||||||
|
.mockResolvedValueOnce(projectFixtures[0])
|
||||||
|
.mockRejectedValueOnce(new Error('Missions request failed'))
|
||||||
|
.mockResolvedValueOnce(projectOneTasks);
|
||||||
|
|
||||||
|
await renderProjectDetailPage();
|
||||||
|
|
||||||
|
// Secondary failure degrades the surface to partial; the project itself
|
||||||
|
// still renders.
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'partial',
|
||||||
|
);
|
||||||
|
expect(container.textContent).toContain('Mosaic Stack');
|
||||||
|
const partial = container.querySelector('[role="status"]');
|
||||||
|
expect(partial?.textContent).toContain('Missions');
|
||||||
|
expect(partial?.textContent).toContain('unavailable');
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
clickButtonByText('Missions (?)');
|
||||||
|
});
|
||||||
|
|
||||||
|
const alert = container.querySelector('[role="alert"]');
|
||||||
|
expect(alert?.textContent).toContain('Missions request failed');
|
||||||
|
// Negative control: a failed fetch must not look like an empty list.
|
||||||
|
expect(container.textContent).not.toContain('No missions for this project');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('marks derived verdicts unknown when the tasks collection is unavailable', async () => {
|
||||||
|
apiMock
|
||||||
|
.mockResolvedValueOnce(projectFixtures[0])
|
||||||
|
.mockResolvedValueOnce(missionFixtures)
|
||||||
|
.mockRejectedValueOnce(new Error('Tasks request failed'));
|
||||||
|
|
||||||
|
await renderProjectDetailPage();
|
||||||
|
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'partial',
|
||||||
|
);
|
||||||
|
|
||||||
|
// Completion verdicts become unknown ('?') — never green counts.
|
||||||
|
for (const label of ['Done', 'In Progress', 'Blocked', 'Tasks']) {
|
||||||
|
const unknownCard = [...container.querySelectorAll('div')].find(
|
||||||
|
(candidate) => candidate.textContent === `${label}?`,
|
||||||
|
);
|
||||||
|
expect(unknownCard, `expected ${label} card to render ?`).toBeTruthy();
|
||||||
|
}
|
||||||
|
// Negative control: no green "Done 1" verdict anywhere.
|
||||||
|
expect(
|
||||||
|
[...container.querySelectorAll('div')].some((candidate) => candidate.textContent === 'Done1'),
|
||||||
|
).toBe(false);
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
clickButtonByText('Tasks (?)');
|
||||||
|
});
|
||||||
|
|
||||||
|
const alert = container.querySelector('[role="alert"]');
|
||||||
|
expect(alert?.textContent).toContain('Tasks request failed');
|
||||||
|
// Negative control: no healthy empty task list from a failed fetch.
|
||||||
|
expect(container.textContent).not.toContain('No tasks found');
|
||||||
|
expect(container.querySelector('table')).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('recovers a partial surface to current after revalidation', async () => {
|
||||||
|
apiMock
|
||||||
|
.mockResolvedValueOnce(projectFixtures[0])
|
||||||
|
.mockResolvedValueOnce(missionFixtures)
|
||||||
|
.mockRejectedValueOnce(new Error('Tasks request failed'))
|
||||||
|
.mockResolvedValueOnce(projectFixtures[0])
|
||||||
|
.mockResolvedValueOnce(missionFixtures)
|
||||||
|
.mockResolvedValueOnce(projectOneTasks);
|
||||||
|
|
||||||
|
await renderProjectDetailPage();
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'partial',
|
||||||
|
);
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
clickButtonByText('Revalidate');
|
||||||
|
});
|
||||||
|
await flushAct();
|
||||||
|
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'current',
|
||||||
|
);
|
||||||
|
expect(
|
||||||
|
[...container.querySelectorAll('div')].some((candidate) => candidate.textContent === 'Done1'),
|
||||||
|
).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("never shows one project's data on another project's route after navigation", async () => {
|
||||||
|
mockHealthyLoad();
|
||||||
|
|
||||||
|
const router = await renderProjectDetailPage();
|
||||||
|
expect(container.textContent).toContain('Mosaic Stack');
|
||||||
|
|
||||||
|
const deferred = createDeferred<(typeof projectFixtures)[number]>();
|
||||||
|
apiMock
|
||||||
|
.mockResolvedValueOnce(deferred.promise)
|
||||||
|
.mockResolvedValueOnce([])
|
||||||
|
.mockResolvedValueOnce([]);
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
await router.navigate('/projects/project-2');
|
||||||
|
});
|
||||||
|
|
||||||
|
// While project-2 loads, nothing from project-1 may render on its route.
|
||||||
|
expect(container.textContent).toContain('Loading project...');
|
||||||
|
expect(container.textContent).not.toContain('Mosaic Stack');
|
||||||
|
expect(container.textContent).not.toContain('Route /projects/:id');
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
deferred.resolve(projectFixtures[1]!);
|
||||||
|
await deferred.promise;
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(container.textContent).toContain('Agent Runtime');
|
||||||
|
expect(apiMock.mock.calls[3]?.[0]).toBe('/api/projects/project-2');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('renders a visible unavailable state when the project request fails and lets the user navigate back', async () => {
|
||||||
apiMock
|
apiMock
|
||||||
.mockRejectedValueOnce(new Error('Project request failed'))
|
.mockRejectedValueOnce(new Error('Project request failed'))
|
||||||
.mockResolvedValueOnce(missionFixtures)
|
.mockResolvedValueOnce(missionFixtures)
|
||||||
.mockResolvedValueOnce(taskFixtures.filter((task) => task.projectId === 'project-1'));
|
.mockResolvedValueOnce(projectOneTasks);
|
||||||
|
|
||||||
const router = await renderProjectDetailPage();
|
const router = await renderProjectDetailPage();
|
||||||
|
|
||||||
const alert = container.querySelector('[role="alert"]');
|
const alert = container.querySelector('[role="alert"]');
|
||||||
expect(alert).toBeTruthy();
|
expect(alert).toBeTruthy();
|
||||||
expect(alert?.textContent).toContain('Project request failed');
|
expect(alert?.textContent).toContain('Project request failed');
|
||||||
|
expect(alert?.textContent).toContain('not an empty result');
|
||||||
expect(container.textContent).not.toContain('Mosaic Stack');
|
expect(container.textContent).not.toContain('Mosaic Stack');
|
||||||
|
|
||||||
await act(async () => {
|
await act(async () => {
|
||||||
|
|||||||
@@ -1,14 +1,30 @@
|
|||||||
import { useEffect, useState, type ReactElement } from 'react';
|
import { useState, type ReactElement } from 'react';
|
||||||
import { useNavigate, useParams } from 'react-router-dom';
|
import { useNavigate, useParams } from 'react-router-dom';
|
||||||
import { MissionTimeline } from '@/components/projects/mission-timeline';
|
import { MissionTimeline } from '@/components/projects/mission-timeline';
|
||||||
import { PrdViewer } from '@/components/projects/prd-viewer';
|
import { PrdViewer } from '@/components/projects/prd-viewer';
|
||||||
import { TaskDetailModal } from '@/components/tasks/task-detail-modal';
|
import { TaskDetailModal } from '@/components/tasks/task-detail-modal';
|
||||||
import { TaskListView } from '@/components/tasks/task-list-view';
|
import { TaskListView } from '@/components/tasks/task-list-view';
|
||||||
import { TaskStatusSummary } from '@/components/tasks/task-status-summary';
|
import { TaskStatusSummary } from '@/components/tasks/task-status-summary';
|
||||||
|
import {
|
||||||
|
PartialDataNotice,
|
||||||
|
StaleDataNotice,
|
||||||
|
UnavailableDataNotice,
|
||||||
|
} from '@/components/freshness/freshness-notices';
|
||||||
import { api } from '@/lib/api';
|
import { api } from '@/lib/api';
|
||||||
import { cn } from '@/lib/cn';
|
import { cn } from '@/lib/cn';
|
||||||
import type { Mission, Project, Task, TaskStatus } from '@/lib/types';
|
import type { Mission, Project, Task, TaskStatus } from '@/lib/types';
|
||||||
import { getErrorMessage } from './page-errors';
|
import {
|
||||||
|
combineFreshness,
|
||||||
|
UNKNOWN_VERDICT,
|
||||||
|
verdictValue,
|
||||||
|
type FreshSnapshot,
|
||||||
|
} from '@/lib/freshness/model';
|
||||||
|
import { describeFailure, useFreshCollection } from '@/lib/freshness/use-fresh-collection';
|
||||||
|
import {
|
||||||
|
validateMissionCollection,
|
||||||
|
validateProjectEntity,
|
||||||
|
validateTaskCollection,
|
||||||
|
} from '@/lib/freshness/validators';
|
||||||
|
|
||||||
type Tab = 'overview' | 'tasks' | 'missions' | 'prd';
|
type Tab = 'overview' | 'tasks' | 'missions' | 'prd';
|
||||||
|
|
||||||
@@ -51,73 +67,62 @@ function TabButton({ id, label, activeTab, onClick }: TabButtonProps): ReactElem
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** Remounts per project id so no state from one project renders for another. */
|
||||||
export function ProjectDetailPage(): ReactElement {
|
export function ProjectDetailPage(): ReactElement {
|
||||||
const { id = '' } = useParams();
|
const { id = '' } = useParams();
|
||||||
|
return <ProjectDetail id={id} key={id} />;
|
||||||
|
}
|
||||||
|
|
||||||
|
function ProjectDetail({ id }: { id: string }): ReactElement {
|
||||||
const navigate = useNavigate();
|
const navigate = useNavigate();
|
||||||
const [project, setProject] = useState<Project | null>(null);
|
const enabled = id.length > 0;
|
||||||
const [missions, setMissions] = useState<Mission[]>([]);
|
|
||||||
const [tasks, setTasks] = useState<Task[]>([]);
|
// Primary collection gates the surface; missions and tasks are secondaries
|
||||||
const [loading, setLoading] = useState(true);
|
// whose failures degrade the surface to `partial` instead of rendering
|
||||||
const [error, setError] = useState<string | null>(null);
|
// empty healthy lists.
|
||||||
|
const project = useFreshCollection<Project>({
|
||||||
|
source: `gateway:/api/projects/${id}`,
|
||||||
|
fetcher: (signal) => api<unknown>(`/api/projects/${id}`, { signal }),
|
||||||
|
validate: validateProjectEntity,
|
||||||
|
// No last-known restore: the entity carries workspace identity that
|
||||||
|
// cannot be scope-checked before display (see ProjectsPage note).
|
||||||
|
enabled,
|
||||||
|
});
|
||||||
|
const missions = useFreshCollection<Mission[]>({
|
||||||
|
source: 'gateway:/api/missions',
|
||||||
|
fetcher: (signal) => api<unknown>('/api/missions', { signal }),
|
||||||
|
validate: validateMissionCollection,
|
||||||
|
cacheKey: enabled ? 'missions' : null,
|
||||||
|
enabled,
|
||||||
|
});
|
||||||
|
const tasks = useFreshCollection<Task[]>({
|
||||||
|
source: `gateway:/api/tasks?projectId=${id}`,
|
||||||
|
fetcher: (signal) => api<unknown>(`/api/tasks?projectId=${id}`, { signal }),
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
cacheKey: enabled ? `project-tasks:${id}` : null,
|
||||||
|
enabled,
|
||||||
|
});
|
||||||
|
|
||||||
const [activeTab, setActiveTab] = useState<Tab>('overview');
|
const [activeTab, setActiveTab] = useState<Tab>('overview');
|
||||||
const [taskFilter, setTaskFilter] = useState<TaskStatus | 'all'>('all');
|
const [taskFilter, setTaskFilter] = useState<TaskStatus | 'all'>('all');
|
||||||
const [selectedTask, setSelectedTask] = useState<Task | null>(null);
|
const [selectedTask, setSelectedTask] = useState<Task | null>(null);
|
||||||
|
|
||||||
useEffect(() => {
|
const surface = combineFreshness(project.freshness, [missions.freshness, tasks.freshness]);
|
||||||
if (!id) {
|
const tasksVerified = tasks.freshness === 'current';
|
||||||
setError('Project id is missing.');
|
const projectMissions = missions.data?.filter((mission) => mission.projectId === id) ?? null;
|
||||||
setLoading(false);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
let cancelled = false;
|
const retryAll = (): void => {
|
||||||
setLoading(true);
|
void Promise.all([project.revalidate(), missions.revalidate(), tasks.revalidate()]);
|
||||||
setError(null);
|
};
|
||||||
|
|
||||||
void Promise.all([
|
if (!enabled) {
|
||||||
api<Project>('/api/projects/' + id),
|
|
||||||
api<Mission[]>('/api/missions').catch(() => [] as Mission[]),
|
|
||||||
api<Task[]>('/api/tasks?projectId=' + id).catch(() => [] as Task[]),
|
|
||||||
])
|
|
||||||
.then(([loadedProject, allMissions, loadedTasks]) => {
|
|
||||||
if (cancelled) return;
|
|
||||||
setProject(loadedProject);
|
|
||||||
setMissions(allMissions.filter((mission) => mission.projectId === id));
|
|
||||||
setTasks(loadedTasks);
|
|
||||||
})
|
|
||||||
.catch((caught: unknown) => {
|
|
||||||
if (cancelled) return;
|
|
||||||
setError(getErrorMessage(caught, 'Failed to load project.'));
|
|
||||||
})
|
|
||||||
.finally(() => {
|
|
||||||
if (cancelled) return;
|
|
||||||
setLoading(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
return () => {
|
|
||||||
cancelled = true;
|
|
||||||
};
|
|
||||||
}, [id]);
|
|
||||||
|
|
||||||
if (loading) {
|
|
||||||
return (
|
|
||||||
<div className="flex min-h-screen flex-col px-4 py-6 sm:px-6">
|
|
||||||
<header className="mb-6 border-b px-1 pb-3">
|
|
||||||
<h1 className="text-2xl font-semibold">Project</h1>
|
|
||||||
</header>
|
|
||||||
<p className="py-16 text-center text-sm text-text-muted">Loading project...</p>
|
|
||||||
</div>
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (error || !project) {
|
|
||||||
return (
|
return (
|
||||||
<div className="flex min-h-screen flex-col px-4 py-6 sm:px-6">
|
<div className="flex min-h-screen flex-col px-4 py-6 sm:px-6">
|
||||||
<header className="mb-6 border-b px-1 pb-3">
|
<header className="mb-6 border-b px-1 pb-3">
|
||||||
<h1 className="text-2xl font-semibold">Project</h1>
|
<h1 className="text-2xl font-semibold">Project</h1>
|
||||||
</header>
|
</header>
|
||||||
<div role="alert" className="rounded-lg border border-error/40 px-4 py-3 text-sm">
|
<div role="alert" className="rounded-lg border border-error/40 px-4 py-3 text-sm">
|
||||||
{error ?? 'Project not found.'}
|
Project id is missing.
|
||||||
</div>
|
</div>
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
@@ -130,18 +135,81 @@ export function ProjectDetailPage(): ReactElement {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (project.freshness === 'unknown') {
|
||||||
|
return (
|
||||||
|
<div className="flex min-h-screen flex-col px-4 py-6 sm:px-6">
|
||||||
|
<header className="mb-6 border-b px-1 pb-3">
|
||||||
|
<h1 className="text-2xl font-semibold">Project</h1>
|
||||||
|
</header>
|
||||||
|
<p className="py-16 text-center text-sm text-text-muted">Loading project...</p>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (project.freshness === 'unavailable' || project.data === null) {
|
||||||
|
return (
|
||||||
|
<div className="flex min-h-screen flex-col px-4 py-6 sm:px-6">
|
||||||
|
<header className="mb-6 border-b px-1 pb-3">
|
||||||
|
<h1 className="text-2xl font-semibold">Project</h1>
|
||||||
|
</header>
|
||||||
|
<UnavailableDataNotice
|
||||||
|
title="This project"
|
||||||
|
detail={describeFailure(project.failure)}
|
||||||
|
onRetry={retryAll}
|
||||||
|
/>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={() => navigate('/projects')}
|
||||||
|
className="mt-4 w-fit text-sm underline"
|
||||||
|
>
|
||||||
|
Back to projects
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
const projectTasks = tasks.data ?? null;
|
||||||
const filteredTasks =
|
const filteredTasks =
|
||||||
taskFilter === 'all' ? tasks : tasks.filter((task) => task.status === taskFilter);
|
projectTasks === null
|
||||||
const prdContent = getPrdContent(project);
|
? []
|
||||||
|
: taskFilter === 'all'
|
||||||
|
? projectTasks
|
||||||
|
: projectTasks.filter((task) => task.status === taskFilter);
|
||||||
|
|
||||||
|
// Derived completion verdicts: unknown (never green) unless the task
|
||||||
|
// collection is verified current.
|
||||||
|
const doneCount = projectTasks?.filter((task) => task.status === 'done').length ?? 0;
|
||||||
|
const inProgressCount = projectTasks?.filter((task) => task.status === 'in-progress').length ?? 0;
|
||||||
|
const blockedCount = projectTasks?.filter((task) => task.status === 'blocked').length ?? 0;
|
||||||
|
|
||||||
|
const prdContent = getPrdContent(project.data);
|
||||||
const tabs: Array<{ id: Tab; label: string }> = [
|
const tabs: Array<{ id: Tab; label: string }> = [
|
||||||
{ id: 'overview', label: 'Overview' },
|
{ id: 'overview', label: 'Overview' },
|
||||||
{ id: 'tasks', label: `Tasks (${tasks.length})` },
|
{
|
||||||
{ id: 'missions', label: `Missions (${missions.length})` },
|
id: 'tasks',
|
||||||
|
label: `Tasks (${projectTasks === null ? UNKNOWN_VERDICT : projectTasks.length})`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: 'missions',
|
||||||
|
label: `Missions (${projectMissions === null ? UNKNOWN_VERDICT : projectMissions.length})`,
|
||||||
|
},
|
||||||
...(prdContent ? [{ id: 'prd' as const, label: 'PRD' }] : []),
|
...(prdContent ? [{ id: 'prd' as const, label: 'PRD' }] : []),
|
||||||
];
|
];
|
||||||
|
|
||||||
|
const staleSnapshot: FreshSnapshot<unknown> | null =
|
||||||
|
project.freshness === 'stale'
|
||||||
|
? project.snapshot
|
||||||
|
: missions.freshness === 'stale'
|
||||||
|
? missions.snapshot
|
||||||
|
: tasks.freshness === 'stale'
|
||||||
|
? tasks.snapshot
|
||||||
|
: null;
|
||||||
|
const missingSections: string[] = [];
|
||||||
|
if (missions.freshness === 'unavailable') missingSections.push('Missions');
|
||||||
|
if (tasks.freshness === 'unavailable') missingSections.push('Tasks');
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="flex min-h-screen flex-col px-4 py-6 sm:px-6">
|
<div data-freshness={surface} className="flex min-h-screen flex-col px-4 py-6 sm:px-6">
|
||||||
<header className="mb-6 border-b px-1 pb-3">
|
<header className="mb-6 border-b px-1 pb-3">
|
||||||
<nav className="mb-4 flex items-center gap-2 text-sm text-text-muted">
|
<nav className="mb-4 flex items-center gap-2 text-sm text-text-muted">
|
||||||
<button
|
<button
|
||||||
@@ -152,49 +220,64 @@ export function ProjectDetailPage(): ReactElement {
|
|||||||
Projects
|
Projects
|
||||||
</button>
|
</button>
|
||||||
<span>/</span>
|
<span>/</span>
|
||||||
<span className="text-text-primary">{project.name}</span>
|
<span className="text-text-primary">{project.data.name}</span>
|
||||||
</nav>
|
</nav>
|
||||||
|
|
||||||
<div className="flex items-start justify-between gap-4">
|
<div className="flex items-start justify-between gap-4">
|
||||||
<div>
|
<div>
|
||||||
<div className="flex items-center gap-3">
|
<div className="flex items-center gap-3">
|
||||||
<h1 className="text-2xl font-semibold text-text-primary">{project.name}</h1>
|
<h1 className="text-2xl font-semibold text-text-primary">{project.data.name}</h1>
|
||||||
<span
|
<span
|
||||||
className={cn(
|
className={cn(
|
||||||
'rounded-full px-2 py-0.5 text-xs',
|
'rounded-full px-2 py-0.5 text-xs',
|
||||||
projectStatusColors[project.status] ?? 'bg-gray-600/20 text-gray-400',
|
projectStatusColors[project.data.status] ?? 'bg-gray-600/20 text-gray-400',
|
||||||
)}
|
)}
|
||||||
>
|
>
|
||||||
{project.status}
|
{project.data.status}
|
||||||
</span>
|
</span>
|
||||||
</div>
|
</div>
|
||||||
{project.description ? (
|
{project.data.description ? (
|
||||||
<p className="mt-1 text-sm text-text-muted">{project.description}</p>
|
<p className="mt-1 text-sm text-text-muted">{project.data.description}</p>
|
||||||
) : null}
|
) : null}
|
||||||
<p className="mt-2 text-xs text-text-muted">
|
<p className="mt-2 text-xs text-text-muted">
|
||||||
Created {new Date(project.createdAt).toLocaleDateString()} · Updated{' '}
|
Created {new Date(project.data.createdAt).toLocaleDateString()} · Updated{' '}
|
||||||
{new Date(project.updatedAt).toLocaleDateString()}
|
{new Date(project.data.updatedAt).toLocaleDateString()}
|
||||||
</p>
|
</p>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
</header>
|
</header>
|
||||||
|
|
||||||
|
{staleSnapshot !== null ? (
|
||||||
|
<div className="mb-6">
|
||||||
|
<StaleDataNotice label={staleSnapshot} onRetry={retryAll} />
|
||||||
|
</div>
|
||||||
|
) : null}
|
||||||
|
|
||||||
|
{missingSections.length > 0 ? (
|
||||||
|
<div className="mb-6">
|
||||||
|
<PartialDataNotice missing={missingSections} onRetry={retryAll} />
|
||||||
|
</div>
|
||||||
|
) : null}
|
||||||
|
|
||||||
<div className="mb-6 grid grid-cols-2 gap-3 sm:grid-cols-4">
|
<div className="mb-6 grid grid-cols-2 gap-3 sm:grid-cols-4">
|
||||||
<StatCard label="Tasks" value={String(tasks.length)} />
|
<StatCard
|
||||||
|
label="Tasks"
|
||||||
|
value={projectTasks === null ? UNKNOWN_VERDICT : String(projectTasks.length)}
|
||||||
|
/>
|
||||||
<StatCard
|
<StatCard
|
||||||
label="Done"
|
label="Done"
|
||||||
value={String(tasks.filter((task) => task.status === 'done').length)}
|
value={verdictValue(tasksVerified, String(doneCount))}
|
||||||
valueClass="text-success"
|
valueClass={tasksVerified ? 'text-success' : undefined}
|
||||||
/>
|
/>
|
||||||
<StatCard
|
<StatCard
|
||||||
label="In Progress"
|
label="In Progress"
|
||||||
value={String(tasks.filter((task) => task.status === 'in-progress').length)}
|
value={verdictValue(tasksVerified, String(inProgressCount))}
|
||||||
valueClass="text-blue-400"
|
valueClass={tasksVerified ? 'text-blue-400' : undefined}
|
||||||
/>
|
/>
|
||||||
<StatCard
|
<StatCard
|
||||||
label="Blocked"
|
label="Blocked"
|
||||||
value={String(tasks.filter((task) => task.status === 'blocked').length)}
|
value={verdictValue(tasksVerified, String(blockedCount))}
|
||||||
valueClass={tasks.some((task) => task.status === 'blocked') ? 'text-error' : undefined}
|
valueClass={tasksVerified && blockedCount > 0 ? 'text-error' : undefined}
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
@@ -211,23 +294,43 @@ export function ProjectDetailPage(): ReactElement {
|
|||||||
</div>
|
</div>
|
||||||
|
|
||||||
{activeTab === 'overview' ? (
|
{activeTab === 'overview' ? (
|
||||||
<OverviewTab project={project} missions={missions} tasks={tasks} />
|
<OverviewTab project={project.data} missions={projectMissions} tasks={projectTasks} />
|
||||||
) : null}
|
) : null}
|
||||||
|
|
||||||
{activeTab === 'tasks' ? (
|
{activeTab === 'tasks' ? (
|
||||||
<div>
|
<div>
|
||||||
<div className="mb-4">
|
{projectTasks === null ? (
|
||||||
<TaskStatusSummary
|
<UnavailableDataNotice
|
||||||
tasks={tasks}
|
title="Tasks"
|
||||||
activeFilter={taskFilter}
|
detail={describeFailure(tasks.failure)}
|
||||||
onFilterChange={setTaskFilter}
|
onRetry={retryAll}
|
||||||
/>
|
/>
|
||||||
</div>
|
) : (
|
||||||
<TaskListView tasks={filteredTasks} onTaskClick={setSelectedTask} />
|
<>
|
||||||
|
<div className="mb-4">
|
||||||
|
<TaskStatusSummary
|
||||||
|
tasks={projectTasks}
|
||||||
|
activeFilter={taskFilter}
|
||||||
|
onFilterChange={setTaskFilter}
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
<TaskListView tasks={filteredTasks} onTaskClick={setSelectedTask} />
|
||||||
|
</>
|
||||||
|
)}
|
||||||
</div>
|
</div>
|
||||||
) : null}
|
) : null}
|
||||||
|
|
||||||
{activeTab === 'missions' ? <MissionTimeline missions={missions} /> : null}
|
{activeTab === 'missions' ? (
|
||||||
|
projectMissions === null ? (
|
||||||
|
<UnavailableDataNotice
|
||||||
|
title="Missions"
|
||||||
|
detail={describeFailure(missions.failure)}
|
||||||
|
onRetry={retryAll}
|
||||||
|
/>
|
||||||
|
) : (
|
||||||
|
<MissionTimeline missions={projectMissions} />
|
||||||
|
)
|
||||||
|
) : null}
|
||||||
|
|
||||||
{activeTab === 'prd' && prdContent ? (
|
{activeTab === 'prd' && prdContent ? (
|
||||||
<div className="rounded-lg border border-surface-border bg-surface-card p-6">
|
<div className="rounded-lg border border-surface-border bg-surface-card p-6">
|
||||||
@@ -248,18 +351,26 @@ function OverviewTab({
|
|||||||
tasks,
|
tasks,
|
||||||
}: {
|
}: {
|
||||||
project: Project;
|
project: Project;
|
||||||
missions: Mission[];
|
missions: Mission[] | null;
|
||||||
tasks: Task[];
|
tasks: Task[] | null;
|
||||||
}): ReactElement {
|
}): ReactElement {
|
||||||
const recentTasks = [...tasks]
|
const recentTasks =
|
||||||
.sort((left, right) => new Date(right.updatedAt).getTime() - new Date(left.updatedAt).getTime())
|
tasks === null
|
||||||
.slice(0, 5);
|
? null
|
||||||
|
: [...tasks]
|
||||||
|
.sort(
|
||||||
|
(left, right) =>
|
||||||
|
new Date(right.updatedAt).getTime() - new Date(left.updatedAt).getTime(),
|
||||||
|
)
|
||||||
|
.slice(0, 5);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="grid gap-6 lg:grid-cols-2">
|
<div className="grid gap-6 lg:grid-cols-2">
|
||||||
<section>
|
<section>
|
||||||
<h2 className="mb-3 text-sm font-semibold text-text-secondary">Recent Tasks</h2>
|
<h2 className="mb-3 text-sm font-semibold text-text-secondary">Recent Tasks</h2>
|
||||||
{recentTasks.length === 0 ? (
|
{recentTasks === null ? (
|
||||||
|
<UnavailableDataNotice title="Tasks" />
|
||||||
|
) : recentTasks.length === 0 ? (
|
||||||
<div className="rounded-lg border border-surface-border bg-surface-card p-4 text-center">
|
<div className="rounded-lg border border-surface-border bg-surface-card p-4 text-center">
|
||||||
<p className="text-sm text-text-muted">No tasks yet</p>
|
<p className="text-sm text-text-muted">No tasks yet</p>
|
||||||
</div>
|
</div>
|
||||||
@@ -287,7 +398,9 @@ function OverviewTab({
|
|||||||
|
|
||||||
<section>
|
<section>
|
||||||
<h2 className="mb-3 text-sm font-semibold text-text-secondary">Missions</h2>
|
<h2 className="mb-3 text-sm font-semibold text-text-secondary">Missions</h2>
|
||||||
{missions.length === 0 ? (
|
{missions === null ? (
|
||||||
|
<UnavailableDataNotice title="Missions" />
|
||||||
|
) : missions.length === 0 ? (
|
||||||
<div className="rounded-lg border border-surface-border bg-surface-card p-4 text-center">
|
<div className="rounded-lg border border-surface-border bg-surface-card p-4 text-center">
|
||||||
<p className="text-sm text-text-muted">No missions yet</p>
|
<p className="text-sm text-text-muted">No missions yet</p>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -51,6 +51,7 @@ afterEach(async () => {
|
|||||||
document.body.replaceChildren();
|
document.body.replaceChildren();
|
||||||
root = null;
|
root = null;
|
||||||
apiMock.mockReset();
|
apiMock.mockReset();
|
||||||
|
sessionStorage.clear();
|
||||||
});
|
});
|
||||||
|
|
||||||
async function renderProjectsPage(): Promise<ReturnType<typeof createMemoryRouter>> {
|
async function renderProjectsPage(): Promise<ReturnType<typeof createMemoryRouter>> {
|
||||||
@@ -71,6 +72,22 @@ async function renderProjectsPage(): Promise<ReturnType<typeof createMemoryRoute
|
|||||||
return router;
|
return router;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function clickButtonByText(text: string): void {
|
||||||
|
const button = [...container.querySelectorAll('button')].find((candidate) =>
|
||||||
|
candidate.textContent?.includes(text),
|
||||||
|
);
|
||||||
|
if (!button) {
|
||||||
|
throw new Error(`Button containing "${text}" not found`);
|
||||||
|
}
|
||||||
|
button.dispatchEvent(new MouseEvent('click', { bubbles: true }));
|
||||||
|
}
|
||||||
|
|
||||||
|
async function flushAct(): Promise<void> {
|
||||||
|
await act(async () => {
|
||||||
|
await Promise.resolve();
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
describe('ProjectsPage', () => {
|
describe('ProjectsPage', () => {
|
||||||
it('shows a visible loading state while the project request is in flight', async () => {
|
it('shows a visible loading state while the project request is in flight', async () => {
|
||||||
const deferred = createDeferred<typeof projectFixtures>();
|
const deferred = createDeferred<typeof projectFixtures>();
|
||||||
@@ -91,7 +108,7 @@ describe('ProjectsPage', () => {
|
|||||||
|
|
||||||
const router = await renderProjectsPage();
|
const router = await renderProjectsPage();
|
||||||
|
|
||||||
expect(apiMock).toHaveBeenCalledWith('/api/projects');
|
expect(apiMock.mock.calls[0]?.[0]).toBe('/api/projects');
|
||||||
expect(container.textContent).toContain('Mosaic Stack');
|
expect(container.textContent).toContain('Mosaic Stack');
|
||||||
expect(container.textContent).toContain('Agent Runtime');
|
expect(container.textContent).toContain('Agent Runtime');
|
||||||
|
|
||||||
@@ -108,7 +125,7 @@ describe('ProjectsPage', () => {
|
|||||||
expect(container.textContent).toContain('Project detail target');
|
expect(container.textContent).toContain('Project detail target');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('renders the empty state when the API returns no projects', async () => {
|
it('renders the empty state only for a verified empty collection', async () => {
|
||||||
apiMock.mockResolvedValueOnce([]);
|
apiMock.mockResolvedValueOnce([]);
|
||||||
|
|
||||||
await renderProjectsPage();
|
await renderProjectsPage();
|
||||||
@@ -117,9 +134,12 @@ describe('ProjectsPage', () => {
|
|||||||
expect(container.textContent).toContain(
|
expect(container.textContent).toContain(
|
||||||
'Projects will appear here when created via the gateway API',
|
'Projects will appear here when created via the gateway API',
|
||||||
);
|
);
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'current',
|
||||||
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
it('renders a visible alert when the projects request fails', async () => {
|
it('renders a failed fetch as an explicit unavailable state, never an empty collection', async () => {
|
||||||
apiMock.mockRejectedValueOnce(new Error('Projects are unavailable'));
|
apiMock.mockRejectedValueOnce(new Error('Projects are unavailable'));
|
||||||
|
|
||||||
await renderProjectsPage();
|
await renderProjectsPage();
|
||||||
@@ -127,5 +147,51 @@ describe('ProjectsPage', () => {
|
|||||||
const alert = container.querySelector('[role="alert"]');
|
const alert = container.querySelector('[role="alert"]');
|
||||||
expect(alert).toBeTruthy();
|
expect(alert).toBeTruthy();
|
||||||
expect(alert?.textContent).toContain('Projects are unavailable');
|
expect(alert?.textContent).toContain('Projects are unavailable');
|
||||||
|
expect(alert?.textContent).toContain('not an empty result');
|
||||||
|
|
||||||
|
// Negative controls: no healthy empty state and no project cards render
|
||||||
|
// from a failed fetch.
|
||||||
|
expect(container.textContent).not.toContain('No projects yet');
|
||||||
|
expect(container.textContent).not.toContain('Mosaic Stack');
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'unavailable',
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('renders an auth failure as unavailable and recovers after retry', async () => {
|
||||||
|
apiMock
|
||||||
|
.mockRejectedValueOnce(Object.assign(new Error('Unauthorized'), { statusCode: 401 }))
|
||||||
|
.mockResolvedValueOnce(projectFixtures);
|
||||||
|
|
||||||
|
await renderProjectsPage();
|
||||||
|
|
||||||
|
const alert = container.querySelector('[role="alert"]');
|
||||||
|
expect(alert?.textContent).toContain('Unauthorized');
|
||||||
|
expect(container.textContent).not.toContain('No projects yet');
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
clickButtonByText('Retry');
|
||||||
|
});
|
||||||
|
await flushAct();
|
||||||
|
|
||||||
|
expect(container.querySelector('[role="alert"]')).toBeNull();
|
||||||
|
expect(container.textContent).toContain('Mosaic Stack');
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'current',
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('renders a schema-mismatched response as unavailable, never as data', async () => {
|
||||||
|
apiMock.mockResolvedValueOnce({ results: projectFixtures });
|
||||||
|
|
||||||
|
await renderProjectsPage();
|
||||||
|
|
||||||
|
const alert = container.querySelector('[role="alert"]');
|
||||||
|
expect(alert?.textContent).toContain('not an empty result');
|
||||||
|
expect(container.textContent).not.toContain('Mosaic Stack');
|
||||||
|
expect(container.textContent).not.toContain('No projects yet');
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'unavailable',
|
||||||
|
);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -1,53 +1,51 @@
|
|||||||
import { useEffect, useState, type ReactElement } from 'react';
|
import { type ReactElement } from 'react';
|
||||||
import { useNavigate } from 'react-router-dom';
|
import { useNavigate } from 'react-router-dom';
|
||||||
import { ProjectCard } from '@/components/projects/project-card';
|
import { ProjectCard } from '@/components/projects/project-card';
|
||||||
|
import { StaleDataNotice, UnavailableDataNotice } from '@/components/freshness/freshness-notices';
|
||||||
import { api } from '@/lib/api';
|
import { api } from '@/lib/api';
|
||||||
import type { Project } from '@/lib/types';
|
import type { Project } from '@/lib/types';
|
||||||
import { getErrorMessage } from './page-errors';
|
import { useFreshCollection, describeFailure } from '@/lib/freshness/use-fresh-collection';
|
||||||
|
import { validateProjectCollection } from '@/lib/freshness/validators';
|
||||||
|
|
||||||
export function ProjectsPage(): ReactElement {
|
export function ProjectsPage(): ReactElement {
|
||||||
const navigate = useNavigate();
|
const navigate = useNavigate();
|
||||||
const [projects, setProjects] = useState<Project[]>([]);
|
const projects = useFreshCollection<Project[]>({
|
||||||
const [loading, setLoading] = useState(true);
|
source: 'gateway:/api/projects',
|
||||||
const [error, setError] = useState<string | null>(null);
|
fetcher: (signal) => api<unknown>('/api/projects', { signal }),
|
||||||
|
validate: validateProjectCollection,
|
||||||
useEffect(() => {
|
// Projects carry workspace identity (userId) that is only knowable from
|
||||||
let cancelled = false;
|
// the payload itself, so a restored entry cannot be scope-checked before
|
||||||
|
// display. Conservative choice: no last-known restore for this surface;
|
||||||
void api<Project[]>('/api/projects')
|
// cross-workspace switching is still invalidated at verification time.
|
||||||
.then((response) => {
|
});
|
||||||
if (cancelled) return;
|
const retry = (): void => {
|
||||||
setProjects(response);
|
void projects.revalidate();
|
||||||
})
|
};
|
||||||
.catch((caught: unknown) => {
|
|
||||||
if (cancelled) return;
|
|
||||||
setError(getErrorMessage(caught, 'Failed to load projects.'));
|
|
||||||
})
|
|
||||||
.finally(() => {
|
|
||||||
if (cancelled) return;
|
|
||||||
setLoading(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
return () => {
|
|
||||||
cancelled = true;
|
|
||||||
};
|
|
||||||
}, []);
|
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="flex min-h-screen flex-col px-4 py-6 sm:px-6">
|
<div
|
||||||
|
data-freshness={projects.freshness}
|
||||||
|
className="flex min-h-screen flex-col px-4 py-6 sm:px-6"
|
||||||
|
>
|
||||||
<header className="mb-6 border-b px-1 pb-3">
|
<header className="mb-6 border-b px-1 pb-3">
|
||||||
<h1 className="text-2xl font-semibold">Projects</h1>
|
<h1 className="text-2xl font-semibold">Projects</h1>
|
||||||
</header>
|
</header>
|
||||||
|
|
||||||
{error ? (
|
{projects.freshness === 'stale' && projects.snapshot ? (
|
||||||
<div role="alert" className="mb-6 rounded-lg border border-error/40 px-4 py-3 text-sm">
|
<div className="mb-6">
|
||||||
{error}
|
<StaleDataNotice label={projects.snapshot} onRetry={retry} />
|
||||||
</div>
|
</div>
|
||||||
) : null}
|
) : null}
|
||||||
|
|
||||||
{loading ? (
|
{projects.freshness === 'unknown' ? (
|
||||||
<p className="py-8 text-center text-sm text-text-muted">Loading projects...</p>
|
<p className="py-8 text-center text-sm text-text-muted">Loading projects...</p>
|
||||||
) : projects.length === 0 ? (
|
) : projects.freshness === 'unavailable' ? (
|
||||||
|
<UnavailableDataNotice
|
||||||
|
title="Projects"
|
||||||
|
detail={describeFailure(projects.failure)}
|
||||||
|
onRetry={retry}
|
||||||
|
/>
|
||||||
|
) : projects.data !== null && projects.data.length === 0 ? (
|
||||||
<div className="py-12 text-center">
|
<div className="py-12 text-center">
|
||||||
<h2 className="text-lg font-medium text-text-secondary">No projects yet</h2>
|
<h2 className="text-lg font-medium text-text-secondary">No projects yet</h2>
|
||||||
<p className="mt-1 text-sm text-text-muted">
|
<p className="mt-1 text-sm text-text-muted">
|
||||||
@@ -56,7 +54,7 @@ export function ProjectsPage(): ReactElement {
|
|||||||
</div>
|
</div>
|
||||||
) : (
|
) : (
|
||||||
<div className="grid gap-4 sm:grid-cols-2 lg:grid-cols-3">
|
<div className="grid gap-4 sm:grid-cols-2 lg:grid-cols-3">
|
||||||
{projects.map((project) => (
|
{(projects.data ?? []).map((project) => (
|
||||||
<ProjectCard
|
<ProjectCard
|
||||||
key={project.id}
|
key={project.id}
|
||||||
project={project}
|
project={project}
|
||||||
|
|||||||
@@ -3,6 +3,9 @@ import { createRoot, type Root } from 'react-dom/client';
|
|||||||
import { createMemoryRouter, RouterProvider, type RouteObject } from 'react-router-dom';
|
import { createMemoryRouter, RouterProvider, type RouteObject } from 'react-router-dom';
|
||||||
import { afterAll, afterEach, beforeAll, describe, expect, it, vi } from 'vitest';
|
import { afterAll, afterEach, beforeAll, describe, expect, it, vi } from 'vitest';
|
||||||
import { taskFixtures } from './page-fixtures';
|
import { taskFixtures } from './page-fixtures';
|
||||||
|
import { acceptSnapshot, DEFAULT_FRESHNESS_POLICY } from '@/lib/freshness/model';
|
||||||
|
import { writeSnapshotCache } from '@/lib/freshness/snapshot-cache';
|
||||||
|
import { validateTaskCollection } from '@/lib/freshness/validators';
|
||||||
|
|
||||||
const { apiMock } = vi.hoisted(() => ({
|
const { apiMock } = vi.hoisted(() => ({
|
||||||
apiMock: vi.fn(),
|
apiMock: vi.fn(),
|
||||||
@@ -48,6 +51,7 @@ afterEach(async () => {
|
|||||||
document.body.replaceChildren();
|
document.body.replaceChildren();
|
||||||
root = null;
|
root = null;
|
||||||
apiMock.mockReset();
|
apiMock.mockReset();
|
||||||
|
sessionStorage.clear();
|
||||||
});
|
});
|
||||||
|
|
||||||
async function renderTasksPage(): Promise<void> {
|
async function renderTasksPage(): Promise<void> {
|
||||||
@@ -72,6 +76,13 @@ function clickButtonByText(text: string): void {
|
|||||||
button.dispatchEvent(new MouseEvent('click', { bubbles: true }));
|
button.dispatchEvent(new MouseEvent('click', { bubbles: true }));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** Flush pending promise callbacks inside the act environment. */
|
||||||
|
async function flushAct(): Promise<void> {
|
||||||
|
await act(async () => {
|
||||||
|
await Promise.resolve();
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
describe('TasksPage', () => {
|
describe('TasksPage', () => {
|
||||||
it('shows a visible loading state before the tasks request settles', async () => {
|
it('shows a visible loading state before the tasks request settles', async () => {
|
||||||
const deferred = createDeferred<typeof taskFixtures>();
|
const deferred = createDeferred<typeof taskFixtures>();
|
||||||
@@ -132,7 +143,7 @@ describe('TasksPage', () => {
|
|||||||
expect(container.textContent).toContain('Wire list and kanban modal interactions');
|
expect(container.textContent).toContain('Wire list and kanban modal interactions');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('renders a visible alert when the tasks request fails', async () => {
|
it('renders a failed fetch as an explicit unavailable state, never an empty healthy board', async () => {
|
||||||
apiMock.mockRejectedValueOnce(new Error('Tasks request failed'));
|
apiMock.mockRejectedValueOnce(new Error('Tasks request failed'));
|
||||||
|
|
||||||
await renderTasksPage();
|
await renderTasksPage();
|
||||||
@@ -140,5 +151,80 @@ describe('TasksPage', () => {
|
|||||||
const alert = container.querySelector('[role="alert"]');
|
const alert = container.querySelector('[role="alert"]');
|
||||||
expect(alert).toBeTruthy();
|
expect(alert).toBeTruthy();
|
||||||
expect(alert?.textContent).toContain('Tasks request failed');
|
expect(alert?.textContent).toContain('Tasks request failed');
|
||||||
|
expect(alert?.textContent).toContain('not an empty result');
|
||||||
|
|
||||||
|
// Negative controls: no board, no healthy empty-state markers, and the
|
||||||
|
// surface is marked unavailable rather than current.
|
||||||
|
expect(container.textContent).not.toContain('Not Started');
|
||||||
|
expect(container.textContent).not.toContain('No tasks');
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'unavailable',
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('recovers to a current board after retrying a failed fetch', async () => {
|
||||||
|
apiMock
|
||||||
|
.mockRejectedValueOnce(new Error('Tasks request failed'))
|
||||||
|
.mockResolvedValueOnce(taskFixtures);
|
||||||
|
|
||||||
|
await renderTasksPage();
|
||||||
|
expect(container.querySelector('[role="alert"]')).toBeTruthy();
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
clickButtonByText('Retry');
|
||||||
|
});
|
||||||
|
await flushAct();
|
||||||
|
|
||||||
|
expect(container.querySelector('[role="alert"]')).toBeNull();
|
||||||
|
expect(container.textContent).toContain('Not Started');
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'current',
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('labels restored last-known data as stale with source, version, and age until verified', async () => {
|
||||||
|
// Seed a last-known snapshot fetched five minutes ago; the page must
|
||||||
|
// render it only under an explicit staleness label while the fetch is
|
||||||
|
// still in flight.
|
||||||
|
const restored = acceptSnapshot({
|
||||||
|
value: taskFixtures,
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
previous: null,
|
||||||
|
policy: DEFAULT_FRESHNESS_POLICY,
|
||||||
|
source: 'gateway:/api/tasks',
|
||||||
|
now: Date.now() - 5 * 60_000,
|
||||||
|
});
|
||||||
|
if (restored.outcome !== 'accepted') throw new Error('fixture setup failed');
|
||||||
|
writeSnapshotCache('tasks', restored.snapshot);
|
||||||
|
|
||||||
|
const deferred = createDeferred<typeof taskFixtures>();
|
||||||
|
apiMock.mockReturnValueOnce(deferred.promise);
|
||||||
|
|
||||||
|
await renderTasksPage();
|
||||||
|
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'stale',
|
||||||
|
);
|
||||||
|
const banner = container.querySelector('[role="status"]');
|
||||||
|
expect(banner?.textContent).toContain('last-known');
|
||||||
|
expect(banner?.textContent).toContain('may be out of date');
|
||||||
|
expect(banner?.textContent).toContain('gateway:/api/tasks');
|
||||||
|
expect(banner?.textContent).toContain('snapshot v1');
|
||||||
|
expect(banner?.textContent).toContain('5m ago');
|
||||||
|
|
||||||
|
// Last-known data still renders as situational awareness under the label.
|
||||||
|
expect(container.textContent).toContain('Route /tasks');
|
||||||
|
expect(container.textContent).not.toContain('Loading tasks...');
|
||||||
|
|
||||||
|
// Verification lands: the banner clears and the surface becomes current.
|
||||||
|
await act(async () => {
|
||||||
|
deferred.resolve(taskFixtures);
|
||||||
|
await deferred.promise;
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(container.querySelector('[role="status"]')).toBeNull();
|
||||||
|
expect(container.querySelector('[data-freshness]')?.getAttribute('data-freshness')).toBe(
|
||||||
|
'current',
|
||||||
|
);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -1,45 +1,32 @@
|
|||||||
import { useEffect, useState, type ReactElement } from 'react';
|
import { useState, type ReactElement } from 'react';
|
||||||
import { KanbanBoard } from '@/components/tasks/kanban-board';
|
import { KanbanBoard } from '@/components/tasks/kanban-board';
|
||||||
import { TaskDetailModal } from '@/components/tasks/task-detail-modal';
|
import { TaskDetailModal } from '@/components/tasks/task-detail-modal';
|
||||||
import { TaskListView } from '@/components/tasks/task-list-view';
|
import { TaskListView } from '@/components/tasks/task-list-view';
|
||||||
|
import { StaleDataNotice, UnavailableDataNotice } from '@/components/freshness/freshness-notices';
|
||||||
import { api } from '@/lib/api';
|
import { api } from '@/lib/api';
|
||||||
import { cn } from '@/lib/cn';
|
import { cn } from '@/lib/cn';
|
||||||
import type { Task } from '@/lib/types';
|
import type { Task } from '@/lib/types';
|
||||||
import { getErrorMessage } from './page-errors';
|
import { useFreshCollection, describeFailure } from '@/lib/freshness/use-fresh-collection';
|
||||||
|
import { validateTaskCollection } from '@/lib/freshness/validators';
|
||||||
|
|
||||||
type ViewMode = 'list' | 'kanban';
|
type ViewMode = 'list' | 'kanban';
|
||||||
|
|
||||||
export function TasksPage(): ReactElement {
|
export function TasksPage(): ReactElement {
|
||||||
const [tasks, setTasks] = useState<Task[]>([]);
|
const tasks = useFreshCollection<Task[]>({
|
||||||
|
source: 'gateway:/api/tasks',
|
||||||
|
fetcher: (signal) => api<unknown>('/api/tasks', { signal }),
|
||||||
|
validate: validateTaskCollection,
|
||||||
|
cacheKey: 'tasks',
|
||||||
|
});
|
||||||
const [view, setView] = useState<ViewMode>('kanban');
|
const [view, setView] = useState<ViewMode>('kanban');
|
||||||
const [loading, setLoading] = useState(true);
|
|
||||||
const [error, setError] = useState<string | null>(null);
|
|
||||||
const [selectedTask, setSelectedTask] = useState<Task | null>(null);
|
const [selectedTask, setSelectedTask] = useState<Task | null>(null);
|
||||||
|
|
||||||
useEffect(() => {
|
const retry = (): void => {
|
||||||
let cancelled = false;
|
void tasks.revalidate();
|
||||||
|
};
|
||||||
void api<Task[]>('/api/tasks')
|
|
||||||
.then((response) => {
|
|
||||||
if (cancelled) return;
|
|
||||||
setTasks(response);
|
|
||||||
})
|
|
||||||
.catch((caught: unknown) => {
|
|
||||||
if (cancelled) return;
|
|
||||||
setError(getErrorMessage(caught, 'Failed to load tasks.'));
|
|
||||||
})
|
|
||||||
.finally(() => {
|
|
||||||
if (cancelled) return;
|
|
||||||
setLoading(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
return () => {
|
|
||||||
cancelled = true;
|
|
||||||
};
|
|
||||||
}, []);
|
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="flex min-h-screen flex-col px-4 py-6 sm:px-6">
|
<div data-freshness={tasks.freshness} className="flex min-h-screen flex-col px-4 py-6 sm:px-6">
|
||||||
<header className="mb-6 flex items-center justify-between gap-4 border-b px-1 pb-3">
|
<header className="mb-6 flex items-center justify-between gap-4 border-b px-1 pb-3">
|
||||||
<h1 className="text-2xl font-semibold">Tasks</h1>
|
<h1 className="text-2xl font-semibold">Tasks</h1>
|
||||||
<div className="flex rounded-lg border border-surface-border">
|
<div className="flex rounded-lg border border-surface-border">
|
||||||
@@ -70,18 +57,24 @@ export function TasksPage(): ReactElement {
|
|||||||
</div>
|
</div>
|
||||||
</header>
|
</header>
|
||||||
|
|
||||||
{error ? (
|
{tasks.freshness === 'stale' && tasks.snapshot ? (
|
||||||
<div role="alert" className="mb-6 rounded-lg border border-error/40 px-4 py-3 text-sm">
|
<div className="mb-6">
|
||||||
{error}
|
<StaleDataNotice label={tasks.snapshot} onRetry={retry} />
|
||||||
</div>
|
</div>
|
||||||
) : null}
|
) : null}
|
||||||
|
|
||||||
{loading ? (
|
{tasks.freshness === 'unknown' ? (
|
||||||
<p className="py-8 text-center text-sm text-text-muted">Loading tasks...</p>
|
<p className="py-8 text-center text-sm text-text-muted">Loading tasks...</p>
|
||||||
|
) : tasks.freshness === 'unavailable' ? (
|
||||||
|
<UnavailableDataNotice
|
||||||
|
title="Tasks"
|
||||||
|
detail={describeFailure(tasks.failure)}
|
||||||
|
onRetry={retry}
|
||||||
|
/>
|
||||||
) : view === 'kanban' ? (
|
) : view === 'kanban' ? (
|
||||||
<KanbanBoard tasks={tasks} onTaskClick={setSelectedTask} />
|
<KanbanBoard tasks={tasks.data ?? []} onTaskClick={setSelectedTask} />
|
||||||
) : (
|
) : (
|
||||||
<TaskListView tasks={tasks} onTaskClick={setSelectedTask} />
|
<TaskListView tasks={tasks.data ?? []} onTaskClick={setSelectedTask} />
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{selectedTask ? (
|
{selectedTask ? (
|
||||||
|
|||||||
-35
@@ -1368,38 +1368,3 @@ All work is **alpha** (< 0.1.0) until Jason approves 0.1.0 beta release.
|
|||||||
10. ASSUMPTION: **Conversations and messages get their own PG tables** (not stored in brain's entity model). They follow a chat-specific schema with proper foreign keys to users and projects. Rationale: Chat has different access patterns (streaming, pagination, search) than brain entities.
|
10. ASSUMPTION: **Conversations and messages get their own PG tables** (not stored in brain's entity model). They follow a chat-specific schema with proper foreign keys to users and projects. Rationale: Chat has different access patterns (streaming, pagination, search) than brain entities.
|
||||||
|
|
||||||
11. RESOLVED: **Pi handles all target LLM providers natively.** Anthropic, OpenAI/Codex, Z.ai, Ollama, LM Studio, and llama.cpp are all supported via Pi's built-in providers or `models.json` configuration with `openai-completions` API type. No custom provider adapters needed in @mosaicstack/agent — only configuration management.
|
11. RESOLVED: **Pi handles all target LLM providers natively.** Anthropic, OpenAI/Codex, Z.ai, Ollama, LM Studio, and llama.cpp are all supported via Pi's built-in providers or `models.json` configuration with `openai-completions` API type. No custom provider adapters needed in @mosaicstack/agent — only configuration management.
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Release Integrity Workstream (RI, #1275)
|
|
||||||
|
|
||||||
### Problem and objective
|
|
||||||
|
|
||||||
At `next` 476db12b (review of 2026-08-17), publication from `next` is not bound to the full verification pipeline for the same commit: the publish pipeline's publish steps depend on `build` only, while ordinary push CI excludes `next`. Public Forge/MACP paths contain false-success placeholders: a stub executor that reports `completed` with exit zero, planning/remediation gates that execute literal `true`, a review gate that echoes an approving verdict, and a gate runner that treats empty commands and unimplemented CI-provider gates as passing. Shipping UI surfaces can render a failed fetch as an empty, healthy collection.
|
|
||||||
|
|
||||||
Objective: for alpha 0.0.50, the release cannot publish, report, or display work state that the repository has not actually verified. Decisions SDLC-D-033 through SDLC-D-038 (Jason, 2026-08-17) scope this floor; full decision text and required-behavior lists live in jarvis-brain `docs/plans/2026-08-16_mosaic-stack-sdlc-protocol.md` and `data/decisions/mosaic-stack-sdlc-protocol.json`. This section restates only the normative requirements.
|
|
||||||
|
|
||||||
### Normative requirements
|
|
||||||
|
|
||||||
1. **RI-N1 Exact-commit publication verification (SDLC-D-034).** One canonical terminal verification command performs self-contained re-verification in the publish pipeline against the job's checked-out commit before any external publication effect. The command contains or invokes the complete mandatory verification set (semantic parity with the PR merge gate, including sanitization, upgrade-guard, typecheck, lint, format check, tests, and build); CI and publication do not maintain separate semantic checklists. Every publish step depends on the verification step in the executable pipeline DAG. Provider commit identity and `git rev-parse HEAD` must identify the same commit. Missing, skipped, cancelled, stale, or inconclusive checks fail closed. Documentation-only runs may skip publication but cannot bypass verification when a publication effect will occur. A negative control must prove that a broken check blocks every publish step.
|
|
||||||
|
|
||||||
2. **RI-N2 Fail-closed Forge/MACP with explicit simulation (SDLC-D-035).** Simulation requires explicit caller intent (e.g. `--simulate`) and produces a distinct typed `simulated` state that can never satisfy dependencies, acceptance criteria, gates, merge, or release. Normal execution exits nonzero with a typed capability failure when a required executor, reviewer, command, or CI provider is absent — no stub completion, no literal-`true` gates, no synthetic approvals, no empty-command passes. A manual gate with no automation enters a waiting state; it does not pass. Positive tests prove explicit simulation still works; negative controls prove simulation and every missing-provider case cannot advance lifecycle state.
|
|
||||||
|
|
||||||
3. **RI-N3 One transitional PRD authority (SDLC-D-036).** `@mosaicstack/prdy` structured storage under `docs/prdy/`, driven by `mosaic mission --plan`, is the authoritative PRD representation for the alpha. `mosaic prdy` either routes through the same application service or operates only as an explicit, named Markdown import/export adapter; `docs/PRD.md` is not a peer authority. `mission --plan` must persist the mission↔PRD linkage (mission id/version, PRD id/version, selected requirements). Markdown output is a generated view carrying source identity; editing it cannot mutate authority silently. Import is explicit, validated, and conflict-aware (proposed successor, never overwrite). Structural validity is separate from approval.
|
|
||||||
|
|
||||||
4. **RI-N4 One quality-rails evaluator (SDLC-D-037).** The TypeScript quality-rails package is the sole authoritative evaluator. A complete probe inventory maps every current TypeScript and shell check to one canonical check with disposition (preserve/strengthen/retire, each named). Effective shell enforcement probes are absorbed before their independent paths retire; expected-file presence alone is not parity. The evaluator returns typed results (`passed`/`failed`/`blocked`/`error`/`not-applicable`) with check version, subject, and reason; missing implementation, missing input, unknown check, process error, timeout, or malformed output can never become `passed` or an unqualified skip. Check definitions and policy are versioned and digested. Shell commands become thin adapters with no separate verdict logic. The canonical terminal verification command (RI-N1) invokes this evaluator rather than duplicating its logic. Contract, parity, and negative-control tests are required, plus independent review of probe equivalence.
|
|
||||||
|
|
||||||
5. **RI-N5 Consequence-aware stale UI (SDLC-D-038).** Mission Control distinguishes typed freshness states (`current`, `stale`, `partial`, `unknown`, `unavailable`) rather than inferring from empty arrays or null. A failed fetch never renders as an empty healthy collection. Last-known data may display for situational awareness only with source identity, version, and age visibly labeled; any derived completion/assurance/release verdict whose inputs are stale becomes `unknown`; all state-changing actions are disabled until fresh state loads and is revalidated. With no verified snapshot, surfaces show an explicit unavailable state. Cache corruption, cross-workspace data, schema mismatch, and version regression invalidate the snapshot. Tests cover the failure matrix (network, auth, malformed, partial, corruption, stale age, schema mismatch, recovery, stale-action rejection) with negative controls proving no case yields a current green verdict or enabled mutation.
|
|
||||||
|
|
||||||
### Acceptance criteria
|
|
||||||
|
|
||||||
- AC-RI-1: A push to `next` that fails any mandatory verification step publishes nothing (no npm package, no image), demonstrated by a checked-in negative control and by pipeline evidence on a real `next` publish run where the verification step is green and every publish step depends on it.
|
|
||||||
- AC-RI-2: With no executor/reviewer/CI provider wired, Forge and MACP normal runs exit nonzero with typed capability failures; with `--simulate`, runs complete but every result is typed `simulated` and cannot satisfy any gate, dependency, or completion state — proven by unit tests including negative controls.
|
|
||||||
- AC-RI-3: A PRD created or revised through either `mosaic mission --plan` or `mosaic prdy` resolves to one authority under `docs/prdy/` with stable identities and versions; the mission↔PRD linkage survives restart; a Markdown export is labeled as generated and cannot silently become a second writer; divergent legacy content blocks baseline claims until explicitly resolved — proven by contract tests.
|
|
||||||
- AC-RI-4: `quality-rails check` through any entry point (TS CLI, framework shell adapter) returns the same typed verdict for the same subject; the probe inventory names every legacy check's disposition; a deliberately broken probe fails closed — proven by contract/parity/negative-control tests and independent review of probe equivalence.
|
|
||||||
- AC-RI-5: No shipping surface renders a failed fetch as an empty healthy state; stale/partial/unavailable states are typed, labeled, and mutation-disabled — proven by the failure-matrix tests.
|
|
||||||
- AC-RI-6: All cards merged to `next` via squash PR with terminal-green CI; release evidence for 0.0.50 records commit, verification run, and published artifacts.
|
|
||||||
|
|
||||||
### Out of scope
|
|
||||||
|
|
||||||
The canonical dispatcher/control-plane vertical slice (work graph, execution attempts, fenced leases, typed check-in, independent verifier dispatch) is decided post-alpha (SDLC-D-033, option B). Multi-pipeline verification certificates (SDLC-D-034 option B) are post-alpha. Full AF-1..AF-4 objective matrices and Mission Control portfolio surfaces are post-alpha.
|
|
||||||
|
|||||||
@@ -1,42 +0,0 @@
|
|||||||
# Tasks — Release Integrity Workstream (RI-050, #1275)
|
|
||||||
|
|
||||||
> Single-writer: the RI-050 orchestrator (jarvis, dragon-lin) only. Workers read but never modify.
|
|
||||||
>
|
|
||||||
> **Mission:** alpha 0.0.50 release-integrity floor (decisions SDLC-D-033..038).
|
|
||||||
> **PRD:** [docs/PRD.md § Release Integrity Workstream](../PRD.md#release-integrity-workstream-ri-1275)
|
|
||||||
> **Issue:** #1275 (remains open until RI-V-001 closes)
|
|
||||||
> **Base branch:** `next` (all cards branch from `origin/next`, squash-merge via PR)
|
|
||||||
>
|
|
||||||
> **Execution note:** the `agent` column uses `pi-glm-5.3` — outside the pipeline-cron model
|
|
||||||
> table on purpose. This workstream is executed by jarvis on dragon-lin with local pi workers
|
|
||||||
> (`pi --model zai/glm-5.3:high`); pipeline crons must not auto-claim these rows.
|
|
||||||
>
|
|
||||||
> **Status values:** `not-started` | `in-progress` | `done` | `blocked` | `failed` | `needs-qa`
|
|
||||||
> `done` requires: repo quality gates green, independent review recorded, terminal-green CI on
|
|
||||||
> the PR head, squash merge to `next`, and acceptance evidence in notes.
|
|
||||||
|
|
||||||
| id | status | description | issue | agent | repo | branch | depends_on | estimate | notes |
|
|
||||||
| -------- | ----------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----- | ---------- | ----------------- | --------------------------------- | ---------------------------------------------------------- | -------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
|
|
||||||
| RI-0-001 | in-progress | Bootstrap: issue #1275, PRD section, this DAG, scratchpad (docs only) | #1275 | pi-glm-5.3 | mosaicstack/stack | docs/ri-050-mission-bootstrap | — | 6K | |
|
|
||||||
| RI-1-001 | in-progress | RI-N1: canonical terminal verification command + publish-pipeline exact-commit gate (every publish step depends on verify; commit identity check; fail closed) | #1275 | pi-glm-5.3 | mosaicstack/stack | feat/ri-050-publish-gate | RI-0-001 | 25K | |
|
|
||||||
| RI-1-002 | not-started | RI-N1 negative control: checked-in tests proving a broken mandatory check blocks every publish step and that DAG edges cannot be bypassed | #1275 | pi-glm-5.3 | mosaicstack/stack | test/ri-050-publish-gate-negative | RI-1-001 | 12K | |
|
|
||||||
| RI-2-001 | in-progress | RI-N2 (Forge): remove stub-executor false success; `--simulate` typed `simulated` results that satisfy nothing; literal-`true` gates and echo-review replaced with real gates or typed waiting-for-authority | #1275 | pi-glm-5.3 | mosaicstack/stack | fix/ri-050-forge-fail-closed | RI-0-001 | 20K | Independent review APPROVED 2026-08-17 (Gitea review 172 on PR #1278, head 99b8f6ea; reviewing seat fargo — recorded under shared host principal mos-dt-0, provenance correction posted by fred; wrapper gap filed by fred). Executed at head: forge tests 116/116, lint green, typecheck green after building macp dist (minimal-install artifact, not a defect), workspace typecheck 45/45, no external type consumers of the changed interfaces. CI red = known lane-wide fleet-test failure only, carries no information about this change (fred, log-content analysis, pipelines 2456-2458). Non-blocking finding: README L141-143 + skills/mosaic-forge/SKILL.md document bare forge run/resume, which now fails closed — fast-follow docs touch. Merge queued behind #1270. |
|
|
||||||
| RI-2-002 | in-progress | RI-N2 (MACP): gate runner fails closed on empty commands, stub executors, and unimplemented CI-provider gates unless explicit simulate; typed capability failures | #1275 | pi-glm-5.3 | mosaicstack/stack | fix/ri-050-macp-fail-closed | RI-0-001 | 15K | |
|
|
||||||
| RI-3-001 | not-started | RI-N4: complete probe inventory mapping every TS and shell quality-rail check to one canonical check with disposition (preserve/strengthen/retire, each named) | #1275 | pi-glm-5.3 | mosaicstack/stack | docs/ri-050-qr-probe-inventory | RI-0-001 | 12K | |
|
|
||||||
| RI-3-002 | not-started | RI-N4: TS evaluator absorbs effective shell probes; typed results (passed/failed/blocked/error/not-applicable) with versioned digested check definitions; shell commands become thin adapters; contract/parity/negative-control tests | #1275 | pi-glm-5.3 | mosaicstack/stack | feat/ri-050-qr-evaluator | RI-3-001 | 30K | |
|
|
||||||
| RI-4-001 | in-progress | RI-N3: one PRD application service — `mission --plan` persists mission↔PRD linkage (ids/versions/selected requirements); `mosaic prdy` routes through the service or becomes a named import/export adapter; Markdown is a labeled generated view; explicit conflict-aware import | #1275 | pi-glm-5.3 | mosaicstack/stack | feat/ri-050-prd-authority | RI-0-001 | 35K | |
|
|
||||||
| RI-5-001 | not-started | RI-N5: typed freshness states (current/stale/partial/unknown/unavailable); no failed-fetch-renders-empty; stale derived verdicts → unknown; mutations disabled when stale; failure-matrix tests | #1275 | pi-glm-5.3 | mosaicstack/stack | feat/ri-050-web-stale-safety | RI-0-001 | 25K | |
|
|
||||||
| RI-V-001 | not-started | Final verification + release evidence: all cards verified merged, negative controls demonstrated, real `next` publish run green on exact commit, evidence pack recorded | #1275 | pi-glm-5.3 | mosaicstack/stack | docs/ri-050-release-evidence | RI-1-002, RI-2-001, RI-2-002, RI-3-002, RI-4-001, RI-5-001 | 10K | |
|
|
||||||
|
|
||||||
## Dispatch waves (max 2 parallel workers)
|
|
||||||
|
|
||||||
1. RI-1-001 + RI-2-001
|
|
||||||
2. RI-2-002 + RI-4-001
|
|
||||||
3. RI-3-001 + RI-5-001
|
|
||||||
4. RI-1-002 + RI-3-002
|
|
||||||
5. RI-V-001
|
|
||||||
|
|
||||||
## Budget
|
|
||||||
|
|
||||||
Derived soft cap: 250K tokens (no explicit cap given). Projected total: 190K.
|
|
||||||
Conservative mode (1 worker) above 70% projected; freeze above 90%.
|
|
||||||
@@ -1,242 +0,0 @@
|
|||||||
# Scratchpad — RI-050 orchestrator (jarvis, dragon-lin)
|
|
||||||
|
|
||||||
Mission: alpha 0.0.50 release-integrity floor. Issue #1275. Base `next` @ 476db12b.
|
|
||||||
Design SSOT: jarvis-brain `docs/plans/2026-08-16_mosaic-stack-sdlc-protocol.md` (SDLC-D-033..038).
|
|
||||||
|
|
||||||
## Mode (Jason's directives)
|
|
||||||
|
|
||||||
- Orchestrator: jarvis (this session, dragon-lin). NOT mos-claude; work stays on this host.
|
|
||||||
- Workers: local pi headless — `pi --model zai/glm-5.3:high -p` in the card's worktree, tools read,bash,edit,write.
|
|
||||||
- Delegation override of stack AGENTS.md `agent` column: rows carry `pi-glm-5.3` (outside cron table so no auto-claim).
|
|
||||||
- Target branch: `next`. Cards branch from `origin/next`, squash-merge via PR.
|
|
||||||
|
|
||||||
## Operational constraints (measured this session)
|
|
||||||
|
|
||||||
- Main checkout at `/home/jwoltje/src/mosaic-stack` is a dirty diverged `main` (ahead 1139/behind 711) — NEVER touched. All work in `/home/jwoltje/src/mosaic-stack-worktrees/<branch>`.
|
|
||||||
- Disk: /home 187G free. /tmp only 8.7G — keep pnpm stores/node_modules under /home.
|
|
||||||
- `main` and `next` have DIVERGED; PRs target `next`.
|
|
||||||
- Identity: pin `GITEA_LOGIN=mosaicstack-jarvis` for all wrapper ops. Issue #1275 verified authored by @jarvis.
|
|
||||||
- `ci-queue-wait.sh` on this host is fail-open (board: fix #1032 not installed) — substitute SHA-status checks via `/commits/{sha}/status` and diff failing step names.
|
|
||||||
- CI on PRs runs `pull_request` pipelines (any branch) incl. ci-postgres service. Push CI runs on main only; publish runs on push/tag to next + manual.
|
|
||||||
- Wrapper gaps on this host per board (7 gaps; e.g. no pr-review-list, issue-assign broken, pr-merge makes no trailers): verify outcomes by reading back provider state, never trust rc alone.
|
|
||||||
- Publish pipeline currently: install → build → publish-npm/publish-next-npm (+image). No verify. CI steps: install, sanitization, upgrade-guard, typecheck, lint, format, test, ci-postgres.
|
|
||||||
|
|
||||||
## Budget
|
|
||||||
|
|
||||||
Soft cap 250K. Projected 190K across 10 cards. Track per-card used vs estimate in TASKS.md notes.
|
|
||||||
|
|
||||||
## Progress log
|
|
||||||
|
|
||||||
- 2026-08-16 23:52 — Issue #1275 created (@jarvis verified).
|
|
||||||
- 2026-08-16 23:5x — Bootstrap branch `docs/ri-050-mission-bootstrap` from origin/next@476db12b; PRD section + TASKS.md + this scratchpad written. RI-0-001 in-progress.
|
|
||||||
|
|
||||||
## Wave 1 dispatched (2026-08-17 00:35)
|
|
||||||
|
|
||||||
- RI-1-001 worker: pi glm-5.3:high, pid 2322125, worktree ri-1-001, log /var/tmp/ri-050/ri-1-001-run.log
|
|
||||||
- RI-2-001 worker: pi glm-5.3:high, pid 2322126, worktree ri-2-001, log /var/tmp/ri-050/ri-2-001-run.log
|
|
||||||
- Gotcha recorded: pi has no -f flag (that's pi-do.sh); pass brief as positional message. First launch died "Unknown option: -f" — relaunched.
|
|
||||||
- CI lane: PR #1276 (bootstrap) fails `test` at base like every next PR — fred's green #1270 unblocks (comms sent 2026-08-17T05:21Z, `comms/20260817T052148Z__from-jarvis__650fe8.md`). Merge gate for all RI PRs queues behind #1270.
|
|
||||||
- Live RI-N1 evidence posted to #1275 (comment 22915): pipeline 2439 publish-next-npm SUCCESS beside build-gateway FAILURE.
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
# HANDOFF — RI-050 continuation (written 2026-08-17 ~08:45 UTC, jarvis/dragon-lin)
|
|
||||||
|
|
||||||
You are taking over the alpha 0.0.50 release-integrity workstream in place. Everything you
|
|
||||||
need is on the remote. Read this whole file, then `docs/release-integrity/TASKS.md` (same
|
|
||||||
branch), then the PRD section (`docs/PRD.md` § Release Integrity Workstream, same branch).
|
|
||||||
|
|
||||||
## Identity / mode
|
|
||||||
|
|
||||||
- Orchestrator identity: `jarvis` (dragon-lin). You continue as the RI-050 orchestrator under
|
|
||||||
whatever identity Jason gives you — if you are NOT jarvis, say so in comms and PR bodies.
|
|
||||||
- Jason's standing directives for this mission: work happens on THIS repo (mosaicstack/stack),
|
|
||||||
PRs target `next` (NOT main), workers are local pi headless sessions on
|
|
||||||
`zai/glm-5.3:high`. Do not hand this to mos-claude. Do not borrow other seats' lanes.
|
|
||||||
- All wrapper ops: pin `GITEA_LOGIN=mosaicstack-jarvis` (issue #1275 was verified authored by
|
|
||||||
@jarvis; keep identity consistent or verify yours with issue-view and READ BACK user.login).
|
|
||||||
- CI substitution rule (this host's ci-queue-wait.sh is fail-open; fix #1032 not installed):
|
|
||||||
judge CI by SHA-status via `/api/v1/repos/mosaicstack/stack/commits/{sha}/status` or the
|
|
||||||
woodpecker API (`pipeline-status.sh -r mosaicstack/stack -n N -f json`), and DIFF THE
|
|
||||||
FAILING STEP NAMES rather than trusting rc.
|
|
||||||
|
|
||||||
## Mission state at handoff
|
|
||||||
|
|
||||||
Mission: alpha 0.0.50 release-integrity floor. Issue #1275 (open, has live-evidence comment).
|
|
||||||
Decisions SDLC-D-033..038 live in jarvis-brain
|
|
||||||
`docs/plans/2026-08-16_mosaic-stack-sdlc-protocol.md` (normative text also mirrored in the
|
|
||||||
PRD section on this branch, so this repo is self-sufficient).
|
|
||||||
|
|
||||||
Base: `origin/next` @ 476db12b. NOTE: `main` and `next` have DIVERGED — never base on main.
|
|
||||||
|
|
||||||
Branches (all pushed, all clean trees):
|
|
||||||
|
|
||||||
- `docs/ri-050-mission-bootstrap` @ 5114faa2 → PR #1276 (open, mergeable) — bootstrap docs +
|
|
||||||
this scratchpad + TASKS.md DAG. STATUS: CI red on `test` only, which is the known lane-wide
|
|
||||||
failure (see blocker below); own prettier issue already fixed.
|
|
||||||
- `feat/ri-050-publish-gate` @ 0aa5ed35 → PR #1277 (open, mergeable) — RI-1-001 COMPLETE
|
|
||||||
(worker reported success, orchestrator review PASSED: verify step asserts CI_COMMIT_SHA ==
|
|
||||||
git rev-parse HEAD then runs canonical `pnpm verify:release`; every publish/image step
|
|
||||||
depends_on verify directly, confirmed by parsing the DAG: publish-npm, publish-next-npm,
|
|
||||||
build-gateway/appservice/web all -> [build, verify]; invariant test
|
|
||||||
scripts/verify-release.test.mjs passes 7/7 locally with negative fixtures). CI: same known
|
|
||||||
lane-red `test` step only.
|
|
||||||
- `fix/ri-050-forge-fail-closed` @ 99b8f6ea → PR #1278 (open, mergeable) — RI-2-001 worker
|
|
||||||
reported success (typed `FORGE_*` capability errors, --simulate typed simulated everywhere,
|
|
||||||
vacuous true/echo gates replaced, closed ForgeOutcome set, 116 tests green incl. 16 new).
|
|
||||||
ORCHESTRATOR REVIEW NOT YET DONE — your first job. Review the diff
|
|
||||||
(1391 insertions across forge src), check the fail-closed paths and that simulated
|
|
||||||
results cannot satisfy any consumer, run `pnpm --filter @mosaicstack/forge test`.
|
|
||||||
|
|
||||||
## The one blocker
|
|
||||||
|
|
||||||
Every `next` PR pipeline is red on ONE assertion:
|
|
||||||
`packages/mosaic/framework/tools/fleet/test-start-agent-session.sh:103` ("host provides 'pi'
|
|
||||||
in the system path"). Pre-existing at base; affects PRs #1276/#1277/#1278 identically.
|
|
||||||
fred's PR #1270 ("unblocks every PR on next") is green and open — it is HIS to merge; do not
|
|
||||||
merge it yourself. jarvis sent comms (`comms/20260817T052148Z__from-jarvis__650fe8.md` in
|
|
||||||
jarvis-brain) asking merge timing; no reply yet as of handoff. Merge gates for ALL RI PRs
|
|
||||||
queue behind #1270 landing. Until then: review/develop freely, merge nothing that needs the
|
|
||||||
green gate (docs-only #1276 arguably could merge red-lane with Jason's explicit call — ask,
|
|
||||||
don't assume).
|
|
||||||
|
|
||||||
## Remaining DAG (docs/release-integrity/TASKS.md is canonical)
|
|
||||||
|
|
||||||
Wave 2 (next): RI-2-002 MACP fail-closed (brief pattern: mirror RI-2-001 for
|
|
||||||
packages/macp/src/gate-runner.ts — empty commands, stub executors, unimplemented CI-provider
|
|
||||||
gates fail closed; explicit simulate) and RI-4-001 PRD authority (one PRD service;
|
|
||||||
@mosaicstack/prdy docs/prdy authoritative via `mosaic mission --plan`; `mosaic prdy` routes
|
|
||||||
or becomes named Markdown adapter; mission<->PRD linkage persists — see PRD RI-N3).
|
|
||||||
Wave 3: RI-3-001 probe inventory (docs), RI-5-001 web stale-safety.
|
|
||||||
Wave 4: RI-1-002 negative-control tests, RI-3-002 TS evaluator absorbs shell probes.
|
|
||||||
Final: RI-V-001 evidence pack (real green next publish run post-gate + all cards verified).
|
|
||||||
|
|
||||||
## Worker mechanics (measured, reuse)
|
|
||||||
|
|
||||||
- Dispatch: create worktree `git -C /home/jwoltje/src/mosaic-stack worktree add
|
|
||||||
/home/jwoltje/src/mosaic-stack-worktrees/<id> -b <branch> origin/next`, write a brief to
|
|
||||||
/var/tmp/ri-050/, then run from INSIDE the worktree:
|
|
||||||
`pi -p --no-session --model zai/glm-5.3:high --tools read,bash,edit,write "$(cat brief.md)"`
|
|
||||||
(pi has NO -f flag — pass the brief as a positional message; first dispatch died on that).
|
|
||||||
- Briefs for 1-001/2-001 are at /var/tmp/ri-050/ on dragon-lin (may not survive; the
|
|
||||||
pattern is fully described above and in TASKS.md).
|
|
||||||
- Briefs must carry: worktree path, branch, base, requirements, known base-red list (so the
|
|
||||||
worker doesn't chase it), gates to run, PR creation command with GITEA_LOGIN pin, "do NOT
|
|
||||||
merge, do NOT touch docs/TASKS.md", and the JSON report format.
|
|
||||||
- Verify worker claims: read the PR, run their tests yourself, parse pipeline step names.
|
|
||||||
|
|
||||||
## Do-not-touch
|
|
||||||
|
|
||||||
- Main checkout at /home/jwoltje/src/mosaic-stack (dirty diverged main) — never touch.
|
|
||||||
- fred's open PRs (#1270 and others) — review evidence welcome, merging his is not yours.
|
|
||||||
- Other RI PRs' authors' lanes: #1277/#1278 are yours to gate and merge ONCE lane is green
|
|
||||||
and review is recorded.
|
|
||||||
- Never `--no-verify`; never bypass the wrapper-fails-closed rule (wrapper failure ⇒
|
|
||||||
`blocked + report exact command + stop`).
|
|
||||||
|
|
||||||
## Session-restore command sequence
|
|
||||||
|
|
||||||
1. `git -C /home/jwoltje/src/mosaic-stack-worktrees/ri-050 fetch origin --prune`
|
|
||||||
2. Read this file + `docs/release-integrity/TASKS.md` + PRD section.
|
|
||||||
3. Check PR states (#1270, #1276, #1277, #1278) and lane CI (SHA-status per above).
|
|
||||||
4. Review RI-2-001 (PR #1278) if not yet done; then dispatch wave 2.
|
|
||||||
|
|
||||||
— jarvis, 2026-08-17
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
# CONTINUATION — fargo (sb-it-1-dt)
|
|
||||||
|
|
||||||
Orchestrator seat is now **fargo** on sb-it-1-dt (Jason, 2026-08-17): Claude seat, worktree discipline
|
|
||||||
per fred's ruling (`~/agent-work/<slug>`, create → work → commit → push → remove as one act; the
|
|
||||||
helper's `/src` refusal is a web1 convention, does not bind here). fred supports; lane rulings are
|
|
||||||
his. Workers remain local pi `zai/glm-5.3:high` + limited Claude per Jason.
|
|
||||||
|
|
||||||
## 2026-08-17 — RI-2-001 independent review DONE
|
|
||||||
|
|
||||||
- **PR #1278 APPROVED** (Gitea review 172, pinned to head 99b8f6ea). Executed evidence, not read-only:
|
|
||||||
forge suite 116/116 at head (matches PR claim), forge lint green, forge typecheck green after
|
|
||||||
building `@mosaicstack/macp` dist (TS2307 on bare `pnpm install --frozen-lockfile` is a
|
|
||||||
minimal-install build-order artifact — the macp import is type-only, vitest passes unbuilt; CI
|
|
||||||
installs build workspace deps, hence green there), **workspace typecheck 45/45 at head**,
|
|
||||||
consumer sweep: no external type consumers of RunManifest/StageStatus/ForgeTaskResult/
|
|
||||||
TaskExecutor; only importer of the package is packages/mosaic via registerForgeCommand
|
|
||||||
(smoke test asserts registration/help only — cannot break). Digest gate (shaggy's) before==after
|
|
||||||
with both-arm reactivity controls.
|
|
||||||
- CI red on #1276/#1277/#1278: lane-wide `test` failure only
|
|
||||||
(test-start-agent-session.sh:103, fred's guard mis-wired; #1270 unwires it). Fred measured log
|
|
||||||
content: one real byte-identical failure per pipeline (2456/2457/2458); 13 of ~14 `FAIL` grep
|
|
||||||
hits are passing fail-loud test NAMES. **The red carries no information about the RI changes.**
|
|
||||||
- Non-blocking finding: README L141-143 + skills/mosaic-forge/SKILL.md document bare
|
|
||||||
`mosaic forge run`/`resume`, which now exits 1 FORGE_NO_EXECUTOR — fast-follow docs touch.
|
|
||||||
- **Identity incident, ruled on by fred:** review 172 recorded under shared host principal
|
|
||||||
mos-dt-0, not fargo. Mechanism (measured, wrapper source): pr-review.sh resolves its acting login
|
|
||||||
from the tea login list only; no fargo tea login on this host → silent host-default fallback;
|
|
||||||
MOSAIC_GIT_IDENTITY is only read in detect-platform.sh get_gitea_token's fallback arm, never
|
|
||||||
reached. Exact-id read-back verifies against the writing token, so it passed while attribution
|
|
||||||
was wrong — durable-provenance machinery proves the write, not the seat. Fred's ruling: review
|
|
||||||
172 stands (substance/verdict/pin correct; label wrong); NO re-approval (one approval,
|
|
||||||
annotated, is the stronger record); fred posts the provenance correction under @fred with
|
|
||||||
--login fred-ms (hard-fail path); no fargo tea login ever (freeze + Jason's to authorize);
|
|
||||||
tooling gap filed by fred. Also explains (does not reopen) #1228's mos-dt-0 attribution.
|
|
||||||
- Merge gate: all RI PRs queue behind fred's green #1270 (Jason's call).
|
|
||||||
|
|
||||||
## Next
|
|
||||||
|
|
||||||
1. Wave 2 dispatch: RI-2-002 (MACP fail-closed, mirror RI-2-001 pattern for
|
|
||||||
packages/macp/src/gate-runner.ts) + RI-4-001 (PRD authority). Two parallel workers max.
|
|
||||||
2. Docs fast-follow (README + mosaic-forge skill) — fold into #1276 or a tiny docs card.
|
|
||||||
3. RI-V-001 evidence at the end.
|
|
||||||
|
|
||||||
— fargo, 2026-08-17
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
# RESUMPTION + DAILY-HANDOFF PROTOCOL (Jason, 2026-08-17)
|
|
||||||
|
|
||||||
Orchestrator seat is back with **jarvis** (dragon-lin). Expect daily handoff between jarvis
|
|
||||||
and fargo. Protocol (both seats, every handoff):
|
|
||||||
|
|
||||||
1. **This file is the shared mission log.** Append a dated section per session: state
|
|
||||||
measured, actions taken, PR/review states, next actions. Never rewrite prior sections.
|
|
||||||
2. **TASKS.md stays current within one session** — status, PR number in notes, review
|
|
||||||
evidence. Stale rows are handoff debt.
|
|
||||||
3. **Cross-review rule (SDLC-D-011 in practice):** the reviewing seat must differ from the
|
|
||||||
producing seat. jarvis reviews fargo-dispatched PRs, fargo reviews jarvis-dispatched
|
|
||||||
PRs. Producers are always pi workers; dispatching seats verify before push; the other
|
|
||||||
seat records the Gitea review.
|
|
||||||
4. Handoff = append here + push + (optional) issue #1275 comment if a decision changed.
|
|
||||||
|
|
||||||
## RESUMED — jarvis/dragon-lin, 2026-08-17 (afternoon)
|
|
||||||
|
|
||||||
- Measured: next = 8199261c (#1270 merged — lane unblocked for new PRs). #1293/#1294
|
|
||||||
(fargo, wave 2) CI-green, mergeable, no recorded reviews. #1276/#1277/#1278 still based
|
|
||||||
on 476db12b with stale red CI → need rebase onto 8199261c. #1278 review pinned to old
|
|
||||||
head 99b8f6ea by @mos-dt-0 (fargo's, mis-attributed per his note) — rebase will dismiss
|
|
||||||
it; re-approval must come from fargo/fred (author is @jarvis, cannot self-approve).
|
|
||||||
- Live evidence #2: push pipeline 2462 (the #1270 merge itself) ran publish-next-npm
|
|
||||||
SUCCESS beside build-gateway FAILURE again.
|
|
||||||
- Plan: rebase the three original branches; independently review #1293/#1294; merge order
|
|
||||||
once green+reviewed: #1276 (docs) → #1277 (publish gate) → #1278/#1293/#1294 (code).
|
|
||||||
After #1277 merges, watch the next push pipeline prove the verify gate live.
|
|
||||||
- fargo's non-RI PRs (#1291/#1296/#1297/#1281) stay strictly his lane.
|
|
||||||
|
|
||||||
## jarvis session 2026-08-17 (evening) — reviews, rebases, merge plan
|
|
||||||
|
|
||||||
- Rebased #1276/#1277/#1278 onto 8199261c (heads 59e2c460 / 46784c8d / 4917df1f);
|
|
||||||
invariant tests 7/7 and forge 116/116 re-run green at new heads. #1270 touched
|
|
||||||
test-enumeration-exclusions.txt + package.json, NOT ci.yml — no semantic overlap with
|
|
||||||
#1277's ci.yml changes (checked, was a real concern).
|
|
||||||
- Independent reviews recorded: #1293 APPROVED (review 173; macp 109/109; fail-closed paths
|
|
||||||
+ aggregate state machine verified), #1294 APPROVED (review 174; prdy 20/20 + command
|
|
||||||
specs 9/9; single-writer + linkage persistence + labeled export + conflict-aware import
|
|
||||||
verified). Note: 19 unrelated mosaic suites fail on bare minimal install (known workspace
|
|
||||||
build-order artifact, documented by fargo) — not this change.
|
|
||||||
- Measured: `next` has NO branch protection (API: only main listed). Cross-seat review
|
|
||||||
discipline is protocol-enforced, not Gitea-enforced. Flagged to fargo for Jason: direct
|
|
||||||
pushes to next trigger ungated publishes; protection is Jason's call (#1231 adjacent).
|
|
||||||
- Merge order planned: #1276 (docs-only — no publish run) -> #1277 (first gated publish)
|
|
||||||
-> #1278 -> #1293 -> #1294. Sent fargo review requests with pinned head SHAs
|
|
||||||
(comms/20260818T011932Z__from-jarvis__a9c02b.md). Not merging #1293/#1294 before my three
|
|
||||||
clear fargo's review — order optimality beats speed; every pre-#1277 merge publishes ungated.
|
|
||||||
- CI on the three rebased heads: pending at time of this entry.
|
|
||||||
@@ -9,7 +9,6 @@
|
|||||||
"preflight": "node scripts/preflight.mjs",
|
"preflight": "node scripts/preflight.mjs",
|
||||||
"clean:generated": "node scripts/clean-generated.mjs",
|
"clean:generated": "node scripts/clean-generated.mjs",
|
||||||
"typecheck": "pnpm preflight && turbo run typecheck",
|
"typecheck": "pnpm preflight && turbo run typecheck",
|
||||||
"verify:release": "node scripts/verify-release.mjs",
|
|
||||||
"test:checkout": "node --test scripts/*.test.mjs",
|
"test:checkout": "node --test scripts/*.test.mjs",
|
||||||
"test": "pnpm test:checkout && turbo run test && pnpm run test:installer",
|
"test": "pnpm test:checkout && turbo run test && pnpm run test:installer",
|
||||||
"test:installer": "bash tools/install-next-lane.test.sh",
|
"test:installer": "bash tools/install-next-lane.test.sh",
|
||||||
|
|||||||
@@ -12,33 +12,6 @@ The default tmux socket is `mosaic-fleet` so fleet commands do not touch the
|
|||||||
default tmux server. The roster is the desired-state authority; generated environment files are
|
default tmux server. The roster is the desired-state authority; generated environment files are
|
||||||
rebuildable projections, never a second source of configuration.
|
rebuildable projections, never a second source of configuration.
|
||||||
|
|
||||||
## Brain-home split (fleet state vs framework templates)
|
|
||||||
|
|
||||||
When a mosaic-brain clone is present, fleet **state** resolves from the brain
|
|
||||||
home while framework templates and dispatch state stay in the config home
|
|
||||||
(three-tree model, canon `docs/STRUCTURE-CANON.md` §2):
|
|
||||||
|
|
||||||
| Path | Without brain (legacy) | With brain |
|
|
||||||
| ------------------------------------------------------------------------------- | ------------------------------------- | ------------------------------ |
|
|
||||||
| `fleet/agents/<seat>.env.*` | `~/.config/mosaic/fleet/agents/` | `~/.mosaic/fleet/agents/` |
|
|
||||||
| `fleet/roles.local/` (overrides) | `~/.config/mosaic/fleet/roles.local/` | `~/.mosaic/fleet/roles.local/` |
|
|
||||||
| `fleet/profiles/` (working copies) | `~/.config/mosaic/fleet/profiles/` | `~/.mosaic/fleet/profiles/` |
|
|
||||||
| `fleet/roster.yaml`, `fleet/roles/` (baseline), `fleet/run/`, `fleet/services/` | `~/.config/mosaic/fleet/…` | unchanged (config home) |
|
|
||||||
|
|
||||||
Activation (`packages/mosaic/src/fleet/brain-home.ts`, mirrored in
|
|
||||||
`tools/fleet/start-agent-session.sh`):
|
|
||||||
|
|
||||||
1. `MOSAIC_BRAIN_HOME` env var — explicit, always wins.
|
|
||||||
2. Canonical `~/.mosaic` — adopted only when `MOSAIC_HOME` is the default
|
|
||||||
`~/.config/mosaic` AND `~/.mosaic/fleet/agents` exists. Custom
|
|
||||||
`--mosaic-home` values (tests, sandboxes, canaries) never adopt, keeping
|
|
||||||
them hermetic.
|
|
||||||
3. Otherwise the config home (legacy single-tree behavior).
|
|
||||||
|
|
||||||
Seat env dirs under a brain are subject to the same privacy boundary (0700
|
|
||||||
dirs, 0600 files); `.env.generated` files are structure-valuable and tracked
|
|
||||||
in the brain repo, hand-maintained `.env`/`.env.local` stay ignored and private.
|
|
||||||
|
|
||||||
## Examples
|
## Examples
|
||||||
|
|
||||||
- `examples/minimal.yaml` starts one local canary slot.
|
- `examples/minimal.yaml` starts one local canary slot.
|
||||||
|
|||||||
@@ -80,26 +80,6 @@ safe_path "$MOSAIC_HOME" || fail_env unsafe-path MOSAIC_HOME "$MOSAIC_HOME"
|
|||||||
|
|
||||||
FLEET_DIR="$MOSAIC_HOME/fleet"
|
FLEET_DIR="$MOSAIC_HOME/fleet"
|
||||||
AGENT_ENV_DIR="$FLEET_DIR/agents"
|
AGENT_ENV_DIR="$FLEET_DIR/agents"
|
||||||
|
|
||||||
# Brain-home split (canon docs/STRUCTURE-CANON.md §2): seat launch envs live
|
|
||||||
# under the brain home's fleet/agents when a brain is active; roster, roles
|
|
||||||
# baseline, and runtime state (fleet/run) stay under MOSAIC_HOME.
|
|
||||||
# Resolution mirrors packages/mosaic/src/fleet/brain-home.ts:
|
|
||||||
# 1. MOSAIC_BRAIN_HOME env (explicit, always wins)
|
|
||||||
# 2. ~/.mosaic — adopted only when MOSAIC_HOME is the default config home AND
|
|
||||||
# ~/.mosaic/fleet/agents exists
|
|
||||||
# 3. MOSAIC_HOME (legacy single-tree)
|
|
||||||
BRAIN_HOME="${MOSAIC_BRAIN_HOME:-}"
|
|
||||||
if [ -z "$BRAIN_HOME" ]; then
|
|
||||||
BRAIN_HOME="$MOSAIC_HOME"
|
|
||||||
if [ "$(cd "$MOSAIC_HOME" 2>/dev/null && pwd -P)" = "$HOME/.config/mosaic" ] \
|
|
||||||
&& [ -d "$HOME/.mosaic/fleet/agents" ]; then
|
|
||||||
BRAIN_HOME="$HOME/.mosaic"
|
|
||||||
fi
|
|
||||||
fi
|
|
||||||
if [ "$BRAIN_HOME" != "$MOSAIC_HOME" ]; then
|
|
||||||
AGENT_ENV_DIR="$BRAIN_HOME/fleet/agents"
|
|
||||||
fi
|
|
||||||
assert_managed_directory "$MOSAIC_HOME"
|
assert_managed_directory "$MOSAIC_HOME"
|
||||||
assert_managed_directory "$FLEET_DIR"
|
assert_managed_directory "$FLEET_DIR"
|
||||||
assert_private_directory "$AGENT_ENV_DIR"
|
assert_private_directory "$AGENT_ENV_DIR"
|
||||||
|
|||||||
@@ -167,54 +167,6 @@ if echo "$valid_args" | grep -qF 'bash -c'; then
|
|||||||
fail "launcher constructed a shell command payload"
|
fail "launcher constructed a shell command payload"
|
||||||
fi
|
fi
|
||||||
|
|
||||||
# ── Brain-home split (canon §2) ─────────────────────────────────────────
|
|
||||||
# When MOSAIC_HOME is the default config home under $HOME and the host carries
|
|
||||||
# $HOME/.mosaic/fleet/agents, seat envs resolve from the brain tree; the config
|
|
||||||
# home still owns fleet/run (holder-owner) and remains a managed boundary.
|
|
||||||
: > "$TMUX_CALLS"
|
|
||||||
HOME_BRAIN="$ROOT/brain-home"
|
|
||||||
CONFIG_HOME="$HOME_BRAIN/.config/mosaic"
|
|
||||||
BRAIN="$HOME_BRAIN/.mosaic"
|
|
||||||
mkdir -p "$CONFIG_HOME/fleet/run" "$BRAIN/fleet/agents" "$HOME_BRAIN/work"
|
|
||||||
chmod 700 "$CONFIG_HOME" "$CONFIG_HOME/fleet" "$CONFIG_HOME/fleet/run" \
|
|
||||||
"$BRAIN/fleet/agents" "$HOME_BRAIN/work"
|
|
||||||
printf '123e4567-e89b-12d3-a456-426614174000\n' > "$CONFIG_HOME/fleet/run/holder-owner"
|
|
||||||
chmod 600 "$CONFIG_HOME/fleet/run/holder-owner"
|
|
||||||
cat > "$BRAIN/fleet/agents/coder-brain.env.generated" <<EOF
|
|
||||||
MOSAIC_AGENT_NAME=coder-brain
|
|
||||||
MOSAIC_AGENT_CLASS=code
|
|
||||||
MOSAIC_AGENT_RUNTIME=pi
|
|
||||||
MOSAIC_AGENT_MODEL=openai-codex/gpt-5.6-sol
|
|
||||||
MOSAIC_AGENT_REASONING=high
|
|
||||||
MOSAIC_AGENT_TOOL_POLICY=code
|
|
||||||
MOSAIC_AGENT_WORKDIR=$HOME_BRAIN/work
|
|
||||||
MOSAIC_TMUX_SOCKET=mosaic-test
|
|
||||||
EOF
|
|
||||||
chmod 600 "$BRAIN/fleet/agents/coder-brain.env.generated"
|
|
||||||
install_pane_binaries "$HOME_BRAIN"
|
|
||||||
HOME="$HOME_BRAIN" PATH="$FAKE_BIN:$PATH" MOSAIC_TEST_TMUX_CALLS="$TMUX_CALLS" \
|
|
||||||
MOSAIC_TEST_PANE_PID=$$ MOSAIC_TEST_HOME="$HOME_BRAIN" \
|
|
||||||
MOSAIC_TEST_FLEET_OWNER=123e4567-e89b-12d3-a456-426614174000 \
|
|
||||||
MOSAIC_HOME="$CONFIG_HOME" "$START" coder-brain
|
|
||||||
brain_args=$(tr '\0' '\n' < "$TMUX_CALLS")
|
|
||||||
echo "$brain_args" | grep -qF new-session || fail "brain-home generated projection did not reach tmux"
|
|
||||||
echo "$brain_args" | grep -qF 'coder-brain' || fail "brain-home agent env was not the launch source"
|
|
||||||
[ -f "$BRAIN/fleet/agents/coder-brain.env.generated" ] || fail "brain generated env vanished"
|
|
||||||
|
|
||||||
# Negative control: the SAME default-config-home shape but without
|
|
||||||
# ~/.mosaic/fleet/agents — the config-home env tree is used directly (legacy).
|
|
||||||
: > "$TMUX_CALLS"
|
|
||||||
HOME_NOBRAIN="$ROOT/brainless-home"
|
|
||||||
CONFIG_HOME_NOBRAIN="$HOME_NOBRAIN/.config/mosaic"
|
|
||||||
write_generated "$CONFIG_HOME_NOBRAIN" "coder-legacy"
|
|
||||||
install_pane_binaries "$HOME_NOBRAIN"
|
|
||||||
HOME="$HOME_NOBRAIN" PATH="$FAKE_BIN:$PATH" MOSAIC_TEST_TMUX_CALLS="$TMUX_CALLS" \
|
|
||||||
MOSAIC_TEST_PANE_PID=$$ MOSAIC_TEST_HOME="$HOME_NOBRAIN" \
|
|
||||||
MOSAIC_TEST_FLEET_OWNER=123e4567-e89b-12d3-a456-426614174000 \
|
|
||||||
MOSAIC_HOME="$CONFIG_HOME_NOBRAIN" "$START" coder-legacy
|
|
||||||
legacy_args=$(tr '\0' '\n' < "$TMUX_CALLS")
|
|
||||||
echo "$legacy_args" | grep -qF new-session || fail "legacy single-tree launch regressed"
|
|
||||||
|
|
||||||
# The pane must start through an absolute clean-environment boundary. Its
|
# The pane must start through an absolute clean-environment boundary. Its
|
||||||
# runtime command remains an argv vector, but no holder/session environment
|
# runtime command remains an argv vector, but no holder/session environment
|
||||||
# control variable can pass through the pane command.
|
# control variable can pass through the pane command.
|
||||||
|
|||||||
@@ -1,6 +1,5 @@
|
|||||||
import { readFile } from 'node:fs/promises';
|
import { readFile } from 'node:fs/promises';
|
||||||
import { join, resolve } from 'node:path';
|
import { join, resolve } from 'node:path';
|
||||||
import { fleetAgentEnvDir, fleetRolesLocalDir } from '../fleet/brain-home.js';
|
|
||||||
import type { Command } from 'commander';
|
import type { Command } from 'commander';
|
||||||
import {
|
import {
|
||||||
executeFleetAgentMutation,
|
executeFleetAgentMutation,
|
||||||
@@ -150,9 +149,9 @@ async function executeCommand(
|
|||||||
request,
|
request,
|
||||||
mosaicHome,
|
mosaicHome,
|
||||||
rosterPath,
|
rosterPath,
|
||||||
agentEnvDir: fleetAgentEnvDir(mosaicHome),
|
agentEnvDir: join(mosaicHome, 'fleet', 'agents'),
|
||||||
rolesDir: join(mosaicHome, 'fleet', 'roles'),
|
rolesDir: join(mosaicHome, 'fleet', 'roles'),
|
||||||
overrideDir: fleetRolesLocalDir(mosaicHome),
|
overrideDir: join(mosaicHome, 'fleet', 'roles.local'),
|
||||||
dryRun: forceDryRun || opts.dryRun === true,
|
dryRun: forceDryRun || opts.dryRun === true,
|
||||||
...(deps.projectionApplier === undefined ? {} : { projectionApplier: deps.projectionApplier }),
|
...(deps.projectionApplier === undefined ? {} : { projectionApplier: deps.projectionApplier }),
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -1,6 +1,5 @@
|
|||||||
import { readFile } from 'node:fs/promises';
|
import { readFile } from 'node:fs/promises';
|
||||||
import { join } from 'node:path';
|
import { join } from 'node:path';
|
||||||
import { fleetAgentEnvDir, fleetRolesLocalDir } from '../fleet/brain-home.js';
|
|
||||||
import type { Command } from 'commander';
|
import type { Command } from 'commander';
|
||||||
import {
|
import {
|
||||||
parseV1MigrationObservations,
|
parseV1MigrationObservations,
|
||||||
@@ -121,11 +120,11 @@ export function registerFleetMigrationCommand(
|
|||||||
observations,
|
observations,
|
||||||
personaDirs: {
|
personaDirs: {
|
||||||
rolesDir: deps.rolesDir ?? join(mosaicHome, 'fleet', 'roles'),
|
rolesDir: deps.rolesDir ?? join(mosaicHome, 'fleet', 'roles'),
|
||||||
overrideDir: deps.overrideDir ?? fleetRolesLocalDir(mosaicHome),
|
overrideDir: deps.overrideDir ?? join(mosaicHome, 'fleet', 'roles.local'),
|
||||||
},
|
},
|
||||||
environment: {
|
environment: {
|
||||||
mosaicHome,
|
mosaicHome,
|
||||||
agentEnvDir: fleetAgentEnvDir(mosaicHome),
|
agentEnvDir: join(mosaicHome, 'fleet', 'agents'),
|
||||||
},
|
},
|
||||||
});
|
});
|
||||||
printJson(preview);
|
printJson(preview);
|
||||||
|
|||||||
@@ -30,21 +30,19 @@ import { lstat, readFile, readdir, stat } from 'node:fs/promises';
|
|||||||
import { homedir } from 'node:os';
|
import { homedir } from 'node:os';
|
||||||
import { basename, isAbsolute, join, sep } from 'node:path';
|
import { basename, isAbsolute, join, sep } from 'node:path';
|
||||||
import type { Command } from 'commander';
|
import type { Command } from 'commander';
|
||||||
import { fleetRolesLocalDir } from '../fleet/brain-home.js';
|
|
||||||
|
|
||||||
function defaultMosaicHome(): string {
|
function defaultMosaicHome(): string {
|
||||||
return process.env['MOSAIC_HOME'] ?? join(homedir(), '.config', 'mosaic');
|
return process.env['MOSAIC_HOME'] ?? join(homedir(), '.config', 'mosaic');
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Baseline persona role contracts (reseeded on update; config home — framework). */
|
/** Baseline persona role contracts (reseeded on update). */
|
||||||
export function defaultRolesDir(mosaicHome = defaultMosaicHome()): string {
|
export function defaultRolesDir(mosaicHome = defaultMosaicHome()): string {
|
||||||
return join(mosaicHome, 'fleet', 'roles');
|
return join(mosaicHome, 'fleet', 'roles');
|
||||||
}
|
}
|
||||||
|
|
||||||
/** PRESERVE-protected override layer (survives update; wins on merge).
|
/** PRESERVE-protected override layer (survives update; wins on merge). */
|
||||||
* Brain home (`~/.mosaic/fleet/roles.local`) when a brain is active. */
|
|
||||||
export function defaultOverrideDir(mosaicHome = defaultMosaicHome()): string {
|
export function defaultOverrideDir(mosaicHome = defaultMosaicHome()): string {
|
||||||
return fleetRolesLocalDir(mosaicHome);
|
return join(mosaicHome, 'fleet', 'roles.local');
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|||||||
@@ -25,7 +25,6 @@ import { homedir } from 'node:os';
|
|||||||
import { basename, join } from 'node:path';
|
import { basename, join } from 'node:path';
|
||||||
import type { Command } from 'commander';
|
import type { Command } from 'commander';
|
||||||
import YAML from 'yaml';
|
import YAML from 'yaml';
|
||||||
import { fleetProfilesDir } from '../fleet/brain-home.js';
|
|
||||||
import {
|
import {
|
||||||
defaultOverrideDir,
|
defaultOverrideDir,
|
||||||
extractClassesFromDir,
|
extractClassesFromDir,
|
||||||
@@ -37,10 +36,9 @@ function defaultMosaicHome(): string {
|
|||||||
return process.env['MOSAIC_HOME'] ?? join(homedir(), '.config', 'mosaic');
|
return process.env['MOSAIC_HOME'] ?? join(homedir(), '.config', 'mosaic');
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Directory holding the seeded profile yaml files — brain home when active
|
/** Directory holding the seeded profile yaml files. */
|
||||||
* (user working copies, committed), else the config home seed. */
|
|
||||||
export function defaultProfilesDir(mosaicHome = defaultMosaicHome()): string {
|
export function defaultProfilesDir(mosaicHome = defaultMosaicHome()): string {
|
||||||
return fleetProfilesDir(mosaicHome);
|
return join(mosaicHome, 'fleet', 'profiles');
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Directory holding the persona role contracts. */
|
/** Directory holding the persona role contracts. */
|
||||||
|
|||||||
@@ -3,7 +3,6 @@ import { homedir } from 'node:os';
|
|||||||
import { join, relative, resolve } from 'node:path';
|
import { join, relative, resolve } from 'node:path';
|
||||||
import type { Command } from 'commander';
|
import type { Command } from 'commander';
|
||||||
import type { CommandRunner } from './fleet.js';
|
import type { CommandRunner } from './fleet.js';
|
||||||
import { fleetAgentEnvDir } from '../fleet/brain-home.js';
|
|
||||||
import {
|
import {
|
||||||
applyPreparedGeneratedAgentEnvironmentProjection,
|
applyPreparedGeneratedAgentEnvironmentProjection,
|
||||||
prepareGeneratedAgentEnvironmentProjection,
|
prepareGeneratedAgentEnvironmentProjection,
|
||||||
@@ -154,7 +153,7 @@ export async function executeFleetRegen(
|
|||||||
options: FleetRegenOptions,
|
options: FleetRegenOptions,
|
||||||
): Promise<FleetRegenResult> {
|
): Promise<FleetRegenResult> {
|
||||||
const mosaicHome = defaultMosaicHome(deps);
|
const mosaicHome = defaultMosaicHome(deps);
|
||||||
const agentEnvDir = fleetAgentEnvDir(mosaicHome);
|
const agentEnvDir = join(mosaicHome, 'fleet', 'agents');
|
||||||
const rosterPath = join(mosaicHome, 'fleet', 'roster.yaml');
|
const rosterPath = join(mosaicHome, 'fleet', 'roster.yaml');
|
||||||
const readRoster = deps.readRoster ?? defaultReadRoster(deps, mosaicHome);
|
const readRoster = deps.readRoster ?? defaultReadRoster(deps, mosaicHome);
|
||||||
const prepare = deps.prepareProjection ?? prepareGeneratedAgentEnvironmentProjection;
|
const prepare = deps.prepareProjection ?? prepareGeneratedAgentEnvironmentProjection;
|
||||||
|
|||||||
@@ -13,7 +13,6 @@ import {
|
|||||||
import { randomUUID } from 'node:crypto';
|
import { randomUUID } from 'node:crypto';
|
||||||
import { homedir, hostname, userInfo } from 'node:os';
|
import { homedir, hostname, userInfo } from 'node:os';
|
||||||
import { dirname, join, resolve } from 'node:path';
|
import { dirname, join, resolve } from 'node:path';
|
||||||
import { fleetAgentEnvDir } from '../fleet/brain-home.js';
|
|
||||||
import { fileURLToPath } from 'node:url';
|
import { fileURLToPath } from 'node:url';
|
||||||
import { spawn } from 'node:child_process';
|
import { spawn } from 'node:child_process';
|
||||||
import * as readline from 'node:readline';
|
import * as readline from 'node:readline';
|
||||||
@@ -159,7 +158,7 @@ export function resolveFleetPaths(mosaicHome = defaultMosaicHome()): FleetPaths
|
|||||||
fleetToolsDir: join(mosaicHome, 'tools', 'fleet'),
|
fleetToolsDir: join(mosaicHome, 'tools', 'fleet'),
|
||||||
tmuxToolsDir: join(mosaicHome, 'tools', 'tmux'),
|
tmuxToolsDir: join(mosaicHome, 'tools', 'tmux'),
|
||||||
systemdUserDir: join(homedir(), '.config', 'systemd', 'user'),
|
systemdUserDir: join(homedir(), '.config', 'systemd', 'user'),
|
||||||
agentEnvDir: fleetAgentEnvDir(mosaicHome),
|
agentEnvDir: join(mosaicHome, 'fleet', 'agents'),
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -349,90 +349,3 @@ describe('registerRuntimeLaunchers — claudex (EXPERIMENTAL overlay)', () => {
|
|||||||
expect(mockExit).not.toHaveBeenCalled();
|
expect(mockExit).not.toHaveBeenCalled();
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
// ─── Seat harness homes (MOSAIC-D-002, brain-home split) ────────────────────
|
|
||||||
|
|
||||||
import { activeSeatDir, seatPersonaOverlay } from './launch.js';
|
|
||||||
|
|
||||||
describe('activeSeatDir — per-agent harness home resolution', () => {
|
|
||||||
let root: string;
|
|
||||||
const savedAgentName = process.env['MOSAIC_AGENT_NAME'];
|
|
||||||
const savedBrainHome = process.env['MOSAIC_BRAIN_HOME'];
|
|
||||||
|
|
||||||
beforeEach(() => {
|
|
||||||
root = mkdtempSync(join(tmpdir(), 'mosaic-seat-home-'));
|
|
||||||
delete process.env['MOSAIC_BRAIN_HOME'];
|
|
||||||
});
|
|
||||||
|
|
||||||
afterEach(() => {
|
|
||||||
rmSync(root, { recursive: true, force: true });
|
|
||||||
if (savedAgentName === undefined) {
|
|
||||||
delete process.env['MOSAIC_AGENT_NAME'];
|
|
||||||
} else {
|
|
||||||
process.env['MOSAIC_AGENT_NAME'] = savedAgentName;
|
|
||||||
}
|
|
||||||
if (savedBrainHome !== undefined) {
|
|
||||||
process.env['MOSAIC_BRAIN_HOME'] = savedBrainHome;
|
|
||||||
} else {
|
|
||||||
delete process.env['MOSAIC_BRAIN_HOME'];
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
it('resolves the seat dir when MOSAIC_BRAIN_HOME carries the seat', () => {
|
|
||||||
const seat = join(root, 'brain', 'fleet', 'agents', 'coder0');
|
|
||||||
mkdirSync(seat, { recursive: true });
|
|
||||||
process.env['MOSAIC_AGENT_NAME'] = 'coder0';
|
|
||||||
process.env['MOSAIC_BRAIN_HOME'] = join(root, 'brain');
|
|
||||||
|
|
||||||
expect(activeSeatDir(join(root, 'config', 'mosaic'))).toBe(seat);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('returns undefined without an agent name (bare launches stay shared)', () => {
|
|
||||||
delete process.env['MOSAIC_AGENT_NAME'];
|
|
||||||
expect(activeSeatDir(join(root, 'config', 'mosaic'))).toBeUndefined();
|
|
||||||
});
|
|
||||||
|
|
||||||
it('returns undefined when the seat dir does not exist in the brain', () => {
|
|
||||||
process.env['MOSAIC_AGENT_NAME'] = 'ghost';
|
|
||||||
process.env['MOSAIC_BRAIN_HOME'] = join(root, 'brain');
|
|
||||||
mkdirSync(join(root, 'brain', 'fleet', 'agents'), { recursive: true });
|
|
||||||
|
|
||||||
expect(activeSeatDir(join(root, 'config', 'mosaic'))).toBeUndefined();
|
|
||||||
});
|
|
||||||
|
|
||||||
it.each(['../escape', 'a/b', '.hidden-start', '', 'spaced name'])(
|
|
||||||
'rejects unsafe agent name %j (path traversal cannot leave the seat store)',
|
|
||||||
(name: string) => {
|
|
||||||
process.env['MOSAIC_AGENT_NAME'] = name;
|
|
||||||
process.env['MOSAIC_BRAIN_HOME'] = join(root, 'brain');
|
|
||||||
|
|
||||||
expect(activeSeatDir(join(root, 'config', 'mosaic'))).toBeUndefined();
|
|
||||||
},
|
|
||||||
);
|
|
||||||
|
|
||||||
it('seatPersonaOverlay renders the seat SOUL.md as an overlay block', () => {
|
|
||||||
const seat = join(root, 'brain', 'fleet', 'agents', 'coder0');
|
|
||||||
mkdirSync(seat, { recursive: true });
|
|
||||||
writeFileSync(join(seat, 'SOUL.md'), '# coder0 — code seat persona\n\nShips tested code.\n');
|
|
||||||
process.env['MOSAIC_AGENT_NAME'] = 'coder0';
|
|
||||||
process.env['MOSAIC_BRAIN_HOME'] = join(root, 'brain');
|
|
||||||
|
|
||||||
const overlay = seatPersonaOverlay(join(root, 'config', 'mosaic'));
|
|
||||||
expect(overlay).toContain('## Seat Persona');
|
|
||||||
expect(overlay).toContain('coder0 — code seat persona');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('seatPersonaOverlay is empty when the seat carries no SOUL.md', () => {
|
|
||||||
const seat = join(root, 'brain', 'fleet', 'agents', 'coder0');
|
|
||||||
mkdirSync(seat, { recursive: true });
|
|
||||||
process.env['MOSAIC_AGENT_NAME'] = 'coder0';
|
|
||||||
process.env['MOSAIC_BRAIN_HOME'] = join(root, 'brain');
|
|
||||||
|
|
||||||
expect(seatPersonaOverlay(join(root, 'config', 'mosaic'))).toBe('');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('seatPersonaOverlay is empty when no agent name is set', () => {
|
|
||||||
delete process.env['MOSAIC_AGENT_NAME'];
|
|
||||||
expect(seatPersonaOverlay(join(root, 'config', 'mosaic'))).toBe('');
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|||||||
@@ -19,7 +19,7 @@ import {
|
|||||||
import { createHash, randomBytes } from 'node:crypto';
|
import { createHash, randomBytes } from 'node:crypto';
|
||||||
import { createRequire } from 'node:module';
|
import { createRequire } from 'node:module';
|
||||||
import { homedir, hostname } from 'node:os';
|
import { homedir, hostname } from 'node:os';
|
||||||
import { join, dirname, resolve } from 'node:path';
|
import { join, dirname } from 'node:path';
|
||||||
import type { Command } from 'commander';
|
import type { Command } from 'commander';
|
||||||
import {
|
import {
|
||||||
buildResolvedFleetCommsBlock,
|
buildResolvedFleetCommsBlock,
|
||||||
@@ -29,7 +29,6 @@ import {
|
|||||||
import { readRegularFileSecure } from '../fleet/secure-file.js';
|
import { readRegularFileSecure } from '../fleet/secure-file.js';
|
||||||
import { readPersonaContractBlock } from '../fleet/persona-contract.js';
|
import { readPersonaContractBlock } from '../fleet/persona-contract.js';
|
||||||
import { canonicalizeRoleClass } from './fleet-personas.js';
|
import { canonicalizeRoleClass } from './fleet-personas.js';
|
||||||
import { resolveBrainHome } from '../fleet/brain-home.js';
|
|
||||||
import { launchClaudex, type ClaudexHarnessAdapter } from './claudex.js';
|
import { launchClaudex, type ClaudexHarnessAdapter } from './claudex.js';
|
||||||
import { runLeaseEnforcementDoctorCheck } from './lease-doctor-check.js';
|
import { runLeaseEnforcementDoctorCheck } from './lease-doctor-check.js';
|
||||||
|
|
||||||
@@ -65,46 +64,9 @@ const HARNESS_HOME_ENV: Record<RuntimeName, string> = {
|
|||||||
opencode: 'XDG_CONFIG_HOME',
|
opencode: 'XDG_CONFIG_HOME',
|
||||||
};
|
};
|
||||||
|
|
||||||
/** Dedicated mosaic-owned home for a runtime: ~/.config/mosaic/.<runtime>.
|
/** Dedicated mosaic-owned home for a runtime: ~/.config/mosaic/.<runtime> */
|
||||||
* With an active brain seat (MOSAIC_AGENT_NAME + seat dir in the brain home)
|
function harnessHome(runtime: RuntimeName): string {
|
||||||
* the home is per-agent instead: <brainHome>/fleet/agents/<seat>/.<runtime> —
|
return join(MOSAIC_HOME, `.${runtime}`);
|
||||||
* per-agent sessions, settings, and auth inside the seat dir (canon §2,
|
|
||||||
* MOSAIC-D-002). Seat runtime dirs are dot-named so the brain's ignore policy
|
|
||||||
* (per-seat .pi/.claude/.codex dirs) keeps credential material untracked. */
|
|
||||||
const SEAT_AGENT_NAME_RE = /^[a-zA-Z0-9][a-zA-Z0-9._-]*$/;
|
|
||||||
|
|
||||||
export function activeSeatDir(mosaicHome: string = MOSAIC_HOME): string | undefined {
|
|
||||||
const agent = process.env['MOSAIC_AGENT_NAME']?.trim();
|
|
||||||
if (
|
|
||||||
agent === undefined ||
|
|
||||||
agent === '' ||
|
|
||||||
!SEAT_AGENT_NAME_RE.test(agent) ||
|
|
||||||
agent.includes('..')
|
|
||||||
) {
|
|
||||||
return undefined;
|
|
||||||
}
|
|
||||||
const brain = resolveBrainHome(mosaicHome);
|
|
||||||
if (resolve(brain) === resolve(mosaicHome)) return undefined; // no brain
|
|
||||||
const seat = join(brain, 'fleet', 'agents', agent);
|
|
||||||
return existsSync(seat) ? seat : undefined;
|
|
||||||
}
|
|
||||||
|
|
||||||
function harnessHome(runtime: RuntimeName, mosaicHome: string = MOSAIC_HOME): string {
|
|
||||||
const seat = activeSeatDir(mosaicHome);
|
|
||||||
if (seat !== undefined) return join(seat, `.${runtime}`);
|
|
||||||
return join(mosaicHome, `.${runtime}`);
|
|
||||||
}
|
|
||||||
|
|
||||||
/** Seat persona block: with an active brain seat, <seat>/SOUL.md layers
|
|
||||||
* persona on the root generic base (canon invariant; MOSAIC-D-002). The base
|
|
||||||
* SOUL stays load-on-demand — only the seat delta is injected by value.
|
|
||||||
* Empty string when no seat is active or the seat carries no SOUL.md. */
|
|
||||||
export function seatPersonaOverlay(mosaicHome: string = MOSAIC_HOME): string {
|
|
||||||
const seatDir = activeSeatDir(mosaicHome);
|
|
||||||
if (seatDir === undefined) return '';
|
|
||||||
const seatSoul = readOptional(join(seatDir, 'SOUL.md'));
|
|
||||||
if (!seatSoul.trim()) return '';
|
|
||||||
return '## Seat Persona\n\n' + seatSoul.trim();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -220,8 +182,6 @@ function recordLaunch(runtime: RuntimeName, cliArgs: string[], yolo: boolean): v
|
|||||||
cli_version: CLI_VERSION,
|
cli_version: CLI_VERSION,
|
||||||
config_home: harnessHome(runtime),
|
config_home: harnessHome(runtime),
|
||||||
config_home_isolated: true,
|
config_home_isolated: true,
|
||||||
config_home_kind: activeSeatDir() !== undefined ? 'seat' : 'runtime-shared',
|
|
||||||
agent_name: process.env['MOSAIC_AGENT_NAME']?.trim() || null,
|
|
||||||
config_home_env: HARNESS_HOME_ENV[runtime] ?? null,
|
config_home_env: HARNESS_HOME_ENV[runtime] ?? null,
|
||||||
argv: redactArgv(cliArgs),
|
argv: redactArgv(cliArgs),
|
||||||
normative_fragments: normativeFragmentDigests(runtime),
|
normative_fragments: normativeFragmentDigests(runtime),
|
||||||
@@ -609,11 +569,6 @@ For required push/merge/issue-close/release actions, execute without routine con
|
|||||||
if (soulLocal.trim()) {
|
if (soulLocal.trim()) {
|
||||||
overlayBlocks.push('## Persona Overlay (SOUL.local.md)\n\n' + soulLocal.trim());
|
overlayBlocks.push('## Persona Overlay (SOUL.local.md)\n\n' + soulLocal.trim());
|
||||||
}
|
}
|
||||||
// Seat persona (MOSAIC-D-002): per-seat SOUL.md layers on the generic base.
|
|
||||||
const seatPersona = seatPersonaOverlay(mosaicHome);
|
|
||||||
if (seatPersona !== '') {
|
|
||||||
overlayBlocks.push(seatPersona);
|
|
||||||
}
|
|
||||||
const standardsLocal = readOptional(join(mosaicHome, 'STANDARDS.local.md'));
|
const standardsLocal = readOptional(join(mosaicHome, 'STANDARDS.local.md'));
|
||||||
if (standardsLocal.trim()) {
|
if (standardsLocal.trim()) {
|
||||||
overlayBlocks.push('## Standards Overlay (STANDARDS.local.md)\n\n' + standardsLocal.trim());
|
overlayBlocks.push('## Standards Overlay (STANDARDS.local.md)\n\n' + standardsLocal.trim());
|
||||||
|
|||||||
@@ -1,114 +0,0 @@
|
|||||||
import { mkdir, mkdtemp, rm } from 'node:fs/promises';
|
|
||||||
import { homedir, tmpdir } from 'node:os';
|
|
||||||
import { join } from 'node:path';
|
|
||||||
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
||||||
import {
|
|
||||||
brainHomeIsActive,
|
|
||||||
fleetAgentEnvDir,
|
|
||||||
fleetProfilesDir,
|
|
||||||
fleetRolesLocalDir,
|
|
||||||
fleetStateDir,
|
|
||||||
resolveBrainHome,
|
|
||||||
type BrainHomeOptions,
|
|
||||||
} from './brain-home.js';
|
|
||||||
|
|
||||||
describe('fleet brain-home resolution', (): void => {
|
|
||||||
let cleanup: string | undefined;
|
|
||||||
|
|
||||||
const savedBrainEnv = process.env['MOSAIC_BRAIN_HOME'];
|
|
||||||
|
|
||||||
beforeEach((): void => {
|
|
||||||
delete process.env['MOSAIC_BRAIN_HOME'];
|
|
||||||
});
|
|
||||||
|
|
||||||
afterEach(async (): Promise<void> => {
|
|
||||||
if (savedBrainEnv === undefined) {
|
|
||||||
delete process.env['MOSAIC_BRAIN_HOME'];
|
|
||||||
} else {
|
|
||||||
process.env['MOSAIC_BRAIN_HOME'] = savedBrainEnv;
|
|
||||||
}
|
|
||||||
if (cleanup !== undefined) {
|
|
||||||
await rm(cleanup, { recursive: true, force: true });
|
|
||||||
cleanup = undefined;
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
async function makeTmp(): Promise<string> {
|
|
||||||
const root = await mkdtemp(join(tmpdir(), 'mosaic-brain-home-'));
|
|
||||||
cleanup = root;
|
|
||||||
return root;
|
|
||||||
}
|
|
||||||
|
|
||||||
it('MOSAIC_BRAIN_HOME env wins over every other signal', (): void => {
|
|
||||||
process.env['MOSAIC_BRAIN_HOME'] = '/explicit/brain';
|
|
||||||
expect(resolveBrainHome('/any/mosaic-home')).toBe('/explicit/brain');
|
|
||||||
expect(fleetAgentEnvDir('/any/mosaic-home')).toBe('/explicit/brain/fleet/agents');
|
|
||||||
expect(brainHomeIsActive('/any/mosaic-home')).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('injected envBrainHome wins identically (test seam)', (): void => {
|
|
||||||
const opts: BrainHomeOptions = { envBrainHome: '/injected/brain' };
|
|
||||||
expect(resolveBrainHome('/any/mosaic-home', opts)).toBe('/injected/brain');
|
|
||||||
expect(fleetAgentEnvDir('/any/mosaic-home', opts)).toBe('/injected/brain/fleet/agents');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('a non-default mosaicHome never adopts the canonical brain (hermetic legacy)', (): void => {
|
|
||||||
const mosaicHome = '/tmp/not-the-default-config-home';
|
|
||||||
expect(resolveBrainHome(mosaicHome)).toBe(mosaicHome);
|
|
||||||
expect(brainHomeIsActive(mosaicHome)).toBe(false);
|
|
||||||
expect(fleetAgentEnvDir(mosaicHome)).toBe(join(mosaicHome, 'fleet', 'agents'));
|
|
||||||
});
|
|
||||||
|
|
||||||
it('the default config home adopts the brain when it carries fleet/agents', async (): Promise<void> => {
|
|
||||||
const root = await makeTmp();
|
|
||||||
const brain = join(root, 'brain');
|
|
||||||
await mkdir(join(brain, 'fleet', 'agents'), { recursive: true });
|
|
||||||
const configHome = join(root, 'config', 'mosaic');
|
|
||||||
const opts: BrainHomeOptions = { homes: { brain, configDefault: configHome } };
|
|
||||||
|
|
||||||
expect(resolveBrainHome(configHome, opts)).toBe(brain);
|
|
||||||
expect(fleetAgentEnvDir(configHome, opts)).toBe(join(brain, 'fleet', 'agents'));
|
|
||||||
expect(fleetRolesLocalDir(configHome, opts)).toBe(join(brain, 'fleet', 'roles.local'));
|
|
||||||
expect(fleetProfilesDir(configHome, opts)).toBe(join(brain, 'fleet', 'profiles'));
|
|
||||||
expect(fleetStateDir(configHome, opts)).toBe(join(brain, 'fleet'));
|
|
||||||
expect(brainHomeIsActive(configHome, opts)).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('the default config home stays legacy when no brain exists', async (): Promise<void> => {
|
|
||||||
const root = await makeTmp();
|
|
||||||
const configHome = join(root, 'config', 'mosaic');
|
|
||||||
const opts: BrainHomeOptions = {
|
|
||||||
homes: { brain: join(root, 'brain'), configDefault: configHome },
|
|
||||||
};
|
|
||||||
|
|
||||||
expect(resolveBrainHome(configHome, opts)).toBe(configHome);
|
|
||||||
expect(brainHomeIsActive(configHome, opts)).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('an empty MOSAIC_BRAIN_HOME is ignored, not treated as set', (): void => {
|
|
||||||
process.env['MOSAIC_BRAIN_HOME'] = ' ';
|
|
||||||
expect(resolveBrainHome('/tmp/legacy-home')).toBe('/tmp/legacy-home');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('adoption requires fleet/agents specifically, not any brain content', async (): Promise<void> => {
|
|
||||||
const root = await makeTmp();
|
|
||||||
const brain = join(root, 'brain');
|
|
||||||
await mkdir(join(brain, 'fleet'), { recursive: true }); // fleet without agents
|
|
||||||
const configHome = join(root, 'config', 'mosaic');
|
|
||||||
const opts: BrainHomeOptions = { homes: { brain, configDefault: configHome } };
|
|
||||||
|
|
||||||
expect(resolveBrainHome(configHome, opts)).toBe(configHome);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('real-home control: a host brain is adopted only through the default home', (): void => {
|
|
||||||
// Control on the un-injected path: this host carries ~/.mosaic/fleet/agents,
|
|
||||||
// so the default config home resolves to the brain or legacy — both valid
|
|
||||||
// canonical endpoints — while a non-default home never adopts.
|
|
||||||
const defaultHome = join(homedir(), '.config', 'mosaic');
|
|
||||||
const resolved = resolveBrainHome(defaultHome);
|
|
||||||
expect([defaultHome, join(homedir(), '.mosaic')]).toContain(resolved);
|
|
||||||
expect(resolveBrainHome(join(homedir(), 'elsewhere', 'mosaic'))).toBe(
|
|
||||||
join(homedir(), 'elsewhere', 'mosaic'),
|
|
||||||
);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
@@ -1,76 +0,0 @@
|
|||||||
import { existsSync } from 'node:fs';
|
|
||||||
import { homedir } from 'node:os';
|
|
||||||
import { join, resolve } from 'node:path';
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Overridable resolution inputs (tests inject tmp homes; production reads
|
|
||||||
* the environment and the real home directory).
|
|
||||||
*/
|
|
||||||
export interface BrainHomeOptions {
|
|
||||||
/** Explicit brain home; defaults to `MOSAIC_BRAIN_HOME`. */
|
|
||||||
readonly envBrainHome?: string;
|
|
||||||
/**
|
|
||||||
* Canonical homes used for adoption. Defaults derive from the real
|
|
||||||
* `homedir()`: `{ brain: ~/.mosaic, configDefault: ~/.config/mosaic }`.
|
|
||||||
*/
|
|
||||||
readonly homes?: { readonly brain: string; readonly configDefault: string };
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Brain-home resolution — the three-tree fleet split (stack canon
|
|
||||||
* `docs/STRUCTURE-CANON.md` §2, first carried by the USC estate brain):
|
|
||||||
*
|
|
||||||
* config home (~/.config/mosaic) framework templates + dispatch state:
|
|
||||||
* fleet/roles (baseline), fleet/roster.yaml,
|
|
||||||
* fleet/run (heartbeats), fleet/services
|
|
||||||
* brain home (~/.mosaic) user-owned fleet state, committed:
|
|
||||||
* fleet/agents/<seat>.env.*, fleet/roles.local,
|
|
||||||
* fleet/profiles working copies
|
|
||||||
*
|
|
||||||
* Resolution order:
|
|
||||||
* 1. `MOSAIC_BRAIN_HOME` env (explicit, always wins)
|
|
||||||
* 2. canonical `~/.mosaic` — adopted ONLY when mosaicHome is the real
|
|
||||||
* default config home AND `~/.mosaic/fleet/agents` exists. Custom
|
|
||||||
* `--mosaic-home` values (tests, sandboxes, canaries) never trigger
|
|
||||||
* adoption, keeping them hermetic and deterministic.
|
|
||||||
* 3. mosaicHome itself (legacy single-tree behavior).
|
|
||||||
*/
|
|
||||||
export function resolveBrainHome(mosaicHome: string, options: BrainHomeOptions = {}): string {
|
|
||||||
const explicit = options.envBrainHome ?? process.env['MOSAIC_BRAIN_HOME'];
|
|
||||||
if (explicit !== undefined && explicit.trim() !== '') {
|
|
||||||
return explicit;
|
|
||||||
}
|
|
||||||
const homes = options.homes ?? {
|
|
||||||
brain: join(homedir(), '.mosaic'),
|
|
||||||
configDefault: join(homedir(), '.config', 'mosaic'),
|
|
||||||
};
|
|
||||||
if (resolve(mosaicHome) !== resolve(homes.configDefault)) {
|
|
||||||
return mosaicHome;
|
|
||||||
}
|
|
||||||
return existsSync(join(homes.brain, 'fleet', 'agents')) ? homes.brain : mosaicHome;
|
|
||||||
}
|
|
||||||
|
|
||||||
/** True when fleet state resolves somewhere other than the config home. */
|
|
||||||
export function brainHomeIsActive(mosaicHome: string, options: BrainHomeOptions = {}): boolean {
|
|
||||||
return resolve(resolveBrainHome(mosaicHome, options)) !== resolve(mosaicHome);
|
|
||||||
}
|
|
||||||
|
|
||||||
/** Fleet state root (brain home when active, else the config home). */
|
|
||||||
export function fleetStateDir(mosaicHome: string, options: BrainHomeOptions = {}): string {
|
|
||||||
return join(resolveBrainHome(mosaicHome, options), 'fleet');
|
|
||||||
}
|
|
||||||
|
|
||||||
/** Seat launch envs — `<brainHome>/fleet/agents` when a brain is active. */
|
|
||||||
export function fleetAgentEnvDir(mosaicHome: string, options: BrainHomeOptions = {}): string {
|
|
||||||
return join(fleetStateDir(mosaicHome, options), 'agents');
|
|
||||||
}
|
|
||||||
|
|
||||||
/** PRESERVE-protected persona override layer — `<brainHome>/fleet/roles.local`. */
|
|
||||||
export function fleetRolesLocalDir(mosaicHome: string, options: BrainHomeOptions = {}): string {
|
|
||||||
return join(fleetStateDir(mosaicHome, options), 'roles.local');
|
|
||||||
}
|
|
||||||
|
|
||||||
/** System-type profiles (user working copies) — `<brainHome>/fleet/profiles`. */
|
|
||||||
export function fleetProfilesDir(mosaicHome: string, options: BrainHomeOptions = {}): string {
|
|
||||||
return join(fleetStateDir(mosaicHome, options), 'profiles');
|
|
||||||
}
|
|
||||||
@@ -3,7 +3,6 @@ import { lstat, open, readFile, unlink, type FileHandle } from 'node:fs/promises
|
|||||||
import { randomUUID } from 'node:crypto';
|
import { randomUUID } from 'node:crypto';
|
||||||
import { homedir } from 'node:os';
|
import { homedir } from 'node:os';
|
||||||
import { join } from 'node:path';
|
import { join } from 'node:path';
|
||||||
import { fleetAgentEnvDir } from './brain-home.js';
|
|
||||||
import {
|
import {
|
||||||
applyPreparedAgentEnvironmentProjection,
|
applyPreparedAgentEnvironmentProjection,
|
||||||
prepareAgentEnvironmentProjection,
|
prepareAgentEnvironmentProjection,
|
||||||
@@ -618,7 +617,7 @@ function defaultPrepareProjections(
|
|||||||
(agent: FleetRosterV2Agent): Promise<PreparedAgentEnvironmentProjection> =>
|
(agent: FleetRosterV2Agent): Promise<PreparedAgentEnvironmentProjection> =>
|
||||||
prepareAgentEnvironmentProjection({
|
prepareAgentEnvironmentProjection({
|
||||||
mosaicHome,
|
mosaicHome,
|
||||||
agentEnvDir: fleetAgentEnvDir(mosaicHome),
|
agentEnvDir: join(mosaicHome, 'fleet', 'agents'),
|
||||||
agentName: agent.name,
|
agentName: agent.name,
|
||||||
generated: projectRosterV2AgentGeneratedEnv(roster, agent),
|
generated: projectRosterV2AgentGeneratedEnv(roster, agent),
|
||||||
}),
|
}),
|
||||||
|
|||||||
@@ -176,52 +176,6 @@ describe('generated fleet agent environment boundary', (): void => {
|
|||||||
expect((await stat(result.generatedPath)).mode & 0o777).toBe(0o600);
|
expect((await stat(result.generatedPath)).mode & 0o777).toBe(0o600);
|
||||||
});
|
});
|
||||||
|
|
||||||
it('brain home: accepts and writes projections under MOSAIC_BRAIN_HOME/fleet/agents', async (): Promise<void> => {
|
|
||||||
const savedBrainHome = process.env['MOSAIC_BRAIN_HOME'];
|
|
||||||
try {
|
|
||||||
cleanup = await mkdtemp(join(tmpdir(), 'mosaic-generated-env-'));
|
|
||||||
const mosaicHome = join(cleanup, 'config-home');
|
|
||||||
const brainHome = join(cleanup, 'brain');
|
|
||||||
const agentEnvDir = join(brainHome, 'fleet', 'agents');
|
|
||||||
process.env['MOSAIC_BRAIN_HOME'] = brainHome;
|
|
||||||
|
|
||||||
const result = await writeAgentEnvironmentProjection({
|
|
||||||
mosaicHome,
|
|
||||||
agentEnvDir,
|
|
||||||
agentName: 'coder0',
|
|
||||||
generated: generatedValues,
|
|
||||||
});
|
|
||||||
|
|
||||||
// Projection landed in the brain tree, not under the config home.
|
|
||||||
expect(result.generatedPath).toBe(join(agentEnvDir, 'coder0.env.generated'));
|
|
||||||
expect((await stat(join(brainHome, 'fleet'))).mode & 0o777).toBe(0o700);
|
|
||||||
expect((await stat(agentEnvDir)).mode & 0o777).toBe(0o700);
|
|
||||||
expect((await stat(result.generatedPath)).mode & 0o777).toBe(0o600);
|
|
||||||
await expect(stat(join(mosaicHome, 'fleet'))).rejects.toThrow();
|
|
||||||
|
|
||||||
// A config-home agentEnvDir is now REJECTED while the brain is active —
|
|
||||||
// the boundary must not silently split state across two trees.
|
|
||||||
let rejected: unknown;
|
|
||||||
try {
|
|
||||||
await writeAgentEnvironmentProjection({
|
|
||||||
mosaicHome,
|
|
||||||
agentEnvDir: join(mosaicHome, 'fleet', 'agents'),
|
|
||||||
agentName: 'coder1',
|
|
||||||
generated: { ...generatedValues, MOSAIC_AGENT_NAME: 'coder1' },
|
|
||||||
});
|
|
||||||
} catch (caught: unknown) {
|
|
||||||
rejected = caught;
|
|
||||||
}
|
|
||||||
expect(rejected).toBeInstanceOf(AgentEnvBoundaryError);
|
|
||||||
} finally {
|
|
||||||
if (savedBrainHome === undefined) {
|
|
||||||
delete process.env['MOSAIC_BRAIN_HOME'];
|
|
||||||
} else {
|
|
||||||
process.env['MOSAIC_BRAIN_HOME'] = savedBrainHome;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
it('regenerates desired keys, relocates safe legacy local data, and quarantines forbidden legacy input', async (): Promise<void> => {
|
it('regenerates desired keys, relocates safe legacy local data, and quarantines forbidden legacy input', async (): Promise<void> => {
|
||||||
cleanup = await mkdtemp(join(tmpdir(), 'mosaic-generated-env-'));
|
cleanup = await mkdtemp(join(tmpdir(), 'mosaic-generated-env-'));
|
||||||
const mosaicHome = join(cleanup, 'mosaic');
|
const mosaicHome = join(cleanup, 'mosaic');
|
||||||
|
|||||||
@@ -2,7 +2,6 @@ import { createHash, randomUUID } from 'node:crypto';
|
|||||||
import { chmod, lstat, mkdir, readFile, rename, unlink, writeFile } from 'node:fs/promises';
|
import { chmod, lstat, mkdir, readFile, rename, unlink, writeFile } from 'node:fs/promises';
|
||||||
import { homedir } from 'node:os';
|
import { homedir } from 'node:os';
|
||||||
import { dirname, join, resolve } from 'node:path';
|
import { dirname, join, resolve } from 'node:path';
|
||||||
import { fleetAgentEnvDir, resolveBrainHome } from './brain-home.js';
|
|
||||||
import { compareCodePoints } from './deterministic-order.js';
|
import { compareCodePoints } from './deterministic-order.js';
|
||||||
|
|
||||||
export type AgentEnvironmentKind = 'generated' | 'local';
|
export type AgentEnvironmentKind = 'generated' | 'local';
|
||||||
@@ -529,15 +528,12 @@ async function validatePrivateProjectionDirectory(
|
|||||||
mosaicHome: string,
|
mosaicHome: string,
|
||||||
agentEnvDir: string,
|
agentEnvDir: string,
|
||||||
): Promise<void> {
|
): Promise<void> {
|
||||||
// Brain-home split (canon §2): seat envs live under the brain home's
|
const fleetDir = join(mosaicHome, 'fleet');
|
||||||
// fleet/agents when a brain is active; roster + templates stay config-home.
|
const expectedAgentEnvDir = join(fleetDir, 'agents');
|
||||||
const expectedAgentEnvDir = fleetAgentEnvDir(mosaicHome);
|
|
||||||
if (resolve(agentEnvDir) !== resolve(expectedAgentEnvDir)) {
|
if (resolve(agentEnvDir) !== resolve(expectedAgentEnvDir)) {
|
||||||
throw new AgentEnvBoundaryError('unsafe-directory', '(directory)', agentEnvDir);
|
throw new AgentEnvBoundaryError('unsafe-directory', '(directory)', agentEnvDir);
|
||||||
}
|
}
|
||||||
const stateHome = resolveBrainHome(mosaicHome);
|
await assertManagedDirectoryIfPresent(mosaicHome, false);
|
||||||
const fleetDir = join(stateHome, 'fleet');
|
|
||||||
await assertManagedDirectoryIfPresent(stateHome, false);
|
|
||||||
await assertManagedDirectoryIfPresent(fleetDir, false);
|
await assertManagedDirectoryIfPresent(fleetDir, false);
|
||||||
await assertManagedDirectoryIfPresent(agentEnvDir, true);
|
await assertManagedDirectoryIfPresent(agentEnvDir, true);
|
||||||
}
|
}
|
||||||
@@ -547,9 +543,8 @@ async function ensurePrivateProjectionDirectory(
|
|||||||
agentEnvDir: string,
|
agentEnvDir: string,
|
||||||
): Promise<void> {
|
): Promise<void> {
|
||||||
await validatePrivateProjectionDirectory(mosaicHome, agentEnvDir);
|
await validatePrivateProjectionDirectory(mosaicHome, agentEnvDir);
|
||||||
const stateHome = resolveBrainHome(mosaicHome);
|
const fleetDir = join(mosaicHome, 'fleet');
|
||||||
const fleetDir = join(stateHome, 'fleet');
|
await ensureManagedDirectory(mosaicHome, false);
|
||||||
await ensureManagedDirectory(stateHome, false);
|
|
||||||
await ensureManagedDirectory(fleetDir, false);
|
await ensureManagedDirectory(fleetDir, false);
|
||||||
await ensureManagedDirectory(agentEnvDir, true);
|
await ensureManagedDirectory(agentEnvDir, true);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,166 +0,0 @@
|
|||||||
#!/usr/bin/env node
|
|
||||||
// verify-release.mjs — the ONE canonical terminal verification command
|
|
||||||
// (SDLC-D-034, `pnpm verify:release`).
|
|
||||||
//
|
|
||||||
// Publication (.woodpecker/publish.yml `verify` step) is bound to terminal
|
|
||||||
// verification of the exact commit through this command, which is composed
|
|
||||||
// from the SAME commands the PR CI pipeline (.woodpecker/ci.yml) runs — CI and
|
|
||||||
// publish share one semantic checklist:
|
|
||||||
//
|
|
||||||
// stage | mirrors ci.yml step | commands
|
|
||||||
// --------------|---------------------|------------------------------------------
|
|
||||||
// sanitization | sanitization | verify-sanitized.sh, check-resident-
|
|
||||||
// | | budget.sh (--self-test + run),
|
|
||||||
// | | check-test-enumeration.sh
|
|
||||||
// upgrade-guard | upgrade-guard | test-upgrade-manifest-guard.sh,
|
|
||||||
// | | test-upgrade-rollback.sh,
|
|
||||||
// | | test-upgrade-durable-snapshot.sh,
|
|
||||||
// | | test-install-migration.sh
|
|
||||||
// typecheck | typecheck | pnpm typecheck (runs the checkout
|
|
||||||
// | | preflight, then turbo typecheck)
|
|
||||||
// lint | lint | pnpm lint
|
|
||||||
// format | format | pnpm format:check
|
|
||||||
// test | test | pnpm test
|
|
||||||
// build | publish.yml build | pnpm build
|
|
||||||
//
|
|
||||||
// Caller-provided prerequisites (kept at the pipeline level — see the comments
|
|
||||||
// in .woodpecker/ci.yml): `bash` + `rsync` for the guard stages, `openssl` and
|
|
||||||
// the pinned @earendil-works/pi-coding-agent for the test stage, and — on the
|
|
||||||
// postgres path only — the ci-postgres service plus
|
|
||||||
// `pnpm --filter @mosaicstack/db run db:migrate` before the test stage.
|
|
||||||
//
|
|
||||||
// This command works with DATABASE_URL set (CI postgres path) or unset (local
|
|
||||||
// PGlite path); it never sets, exports, or requires a database itself.
|
|
||||||
//
|
|
||||||
// scripts/verify-release.test.mjs enforces that this stage table keeps
|
|
||||||
// matching .woodpecker/ci.yml step-for-step, so the two surfaces cannot drift
|
|
||||||
// apart silently.
|
|
||||||
|
|
||||||
import { spawnSync } from 'node:child_process';
|
|
||||||
import path from 'node:path';
|
|
||||||
import { fileURLToPath } from 'node:url';
|
|
||||||
|
|
||||||
export const STAGES = [
|
|
||||||
{
|
|
||||||
name: 'sanitization',
|
|
||||||
// Mirror of the .woodpecker/ci.yml `sanitization` step (minus its
|
|
||||||
// `apk add` environment prep). Kept as direct command strings here: the
|
|
||||||
// #1017 test-enumeration guard audits these paths through the ci.yml
|
|
||||||
// surface, so indirection from ci.yml into this file is not possible.
|
|
||||||
commands: [
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/verify-sanitized.sh',
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/check-resident-budget.sh --self-test',
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/check-resident-budget.sh',
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/check-test-enumeration.sh',
|
|
||||||
],
|
|
||||||
},
|
|
||||||
{
|
|
||||||
name: 'upgrade-guard',
|
|
||||||
// Mirror of the .woodpecker/ci.yml `upgrade-guard` step (minus its
|
|
||||||
// `apk add` environment prep).
|
|
||||||
commands: [
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-manifest-guard.sh',
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-rollback.sh',
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-durable-snapshot.sh',
|
|
||||||
'bash packages/mosaic/framework/tools/quality/scripts/test-install-migration.sh',
|
|
||||||
],
|
|
||||||
},
|
|
||||||
{
|
|
||||||
// `pnpm typecheck` is `pnpm preflight && turbo run typecheck`, so the
|
|
||||||
// checkout preflight (scripts/preflight.mjs) is part of this stage exactly
|
|
||||||
// as it is part of the ci.yml `typecheck` step.
|
|
||||||
name: 'typecheck',
|
|
||||||
commands: ['pnpm typecheck'],
|
|
||||||
},
|
|
||||||
{
|
|
||||||
name: 'lint',
|
|
||||||
commands: ['pnpm lint'],
|
|
||||||
},
|
|
||||||
{
|
|
||||||
name: 'format',
|
|
||||||
commands: ['pnpm format:check'],
|
|
||||||
},
|
|
||||||
{
|
|
||||||
// Requires `openssl` and the pinned `pi` binary on the pipeline path; see
|
|
||||||
// the caller-provided prerequisites above.
|
|
||||||
name: 'test',
|
|
||||||
commands: ['pnpm test'],
|
|
||||||
},
|
|
||||||
{
|
|
||||||
name: 'build',
|
|
||||||
commands: ['pnpm build'],
|
|
||||||
},
|
|
||||||
];
|
|
||||||
|
|
||||||
export function stageByName(name) {
|
|
||||||
return STAGES.find((stage) => stage.name === name);
|
|
||||||
}
|
|
||||||
|
|
||||||
function missingBinaries(bins) {
|
|
||||||
return bins.filter(
|
|
||||||
(bin) => spawnSync('sh', ['-c', `command -v ${bin} >/dev/null 2>&1`]).status !== 0,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
function runCommand(command) {
|
|
||||||
const result = spawnSync(command, { shell: true, stdio: 'inherit' });
|
|
||||||
if (result.error) {
|
|
||||||
console.error(`[verify:release] failed to launch '${command}': ${result.error.message}`);
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
if (result.status !== 0) {
|
|
||||||
const reason = result.signal ? `terminated by ${result.signal}` : `exited ${result.status}`;
|
|
||||||
console.error(`[verify:release] command '${command}' ${reason}`);
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Runs the complete mandatory verification set (or, with --stage <name>, the
|
|
||||||
// single named stage — used for wiring/smoke-testing, not for gating: only a
|
|
||||||
// run of every stage is a terminal verification). Fails fast: the first
|
|
||||||
// failing command aborts with a non-zero exit code. Returns the exit code.
|
|
||||||
export function verifyRelease({ stages = STAGES } = {}) {
|
|
||||||
const missing = missingBinaries(['bash', 'rsync']);
|
|
||||||
if (missing.length > 0) {
|
|
||||||
console.error(
|
|
||||||
`[verify:release] FATAL: required binaries missing from PATH: ${missing.join(', ')}. ` +
|
|
||||||
'The caller provides them (ci-base bakes bash; pipelines apk add rsync).',
|
|
||||||
);
|
|
||||||
return 1;
|
|
||||||
}
|
|
||||||
for (const stage of stages) {
|
|
||||||
console.log(`\n[verify:release] === stage: ${stage.name} ===`);
|
|
||||||
for (const command of stage.commands) {
|
|
||||||
console.log(`[verify:release] $ ${command}`);
|
|
||||||
if (!runCommand(command)) {
|
|
||||||
console.error(
|
|
||||||
`[verify:release] FATAL: stage '${stage.name}' failed — verification inconclusive`,
|
|
||||||
);
|
|
||||||
return 1;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
console.log(`\n[verify:release] all ${stages.length} stage(s) passed`);
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
function main(argv) {
|
|
||||||
const stageFlagIndex = argv.indexOf('--stage');
|
|
||||||
if (stageFlagIndex !== -1) {
|
|
||||||
const name = argv[stageFlagIndex + 1];
|
|
||||||
const stage = stageByName(name);
|
|
||||||
if (!stage) {
|
|
||||||
console.error(
|
|
||||||
`[verify:release] unknown stage '${name ?? ''}' — expected one of: ${STAGES.map((entry) => entry.name).join(', ')}`,
|
|
||||||
);
|
|
||||||
process.exit(2);
|
|
||||||
}
|
|
||||||
process.exit(verifyRelease({ stages: [stage] }));
|
|
||||||
}
|
|
||||||
process.exit(verifyRelease());
|
|
||||||
}
|
|
||||||
|
|
||||||
if (process.argv[1] && path.resolve(process.argv[1]) === fileURLToPath(import.meta.url)) {
|
|
||||||
main(process.argv.slice(2));
|
|
||||||
}
|
|
||||||
@@ -1,277 +0,0 @@
|
|||||||
import assert from 'node:assert/strict';
|
|
||||||
import { readFile } from 'node:fs/promises';
|
|
||||||
import { createRequire } from 'node:module';
|
|
||||||
import path from 'node:path';
|
|
||||||
import test from 'node:test';
|
|
||||||
|
|
||||||
import { STAGES } from './verify-release.mjs';
|
|
||||||
|
|
||||||
// SDLC-D-034 checkout invariant: publication in .woodpecker/publish.yml is
|
|
||||||
// bound to exact-commit terminal verification. This suite parses the real
|
|
||||||
// pipeline files and fails red when the gate is bypassed, weakened, or drifts
|
|
||||||
// out of sync with the canonical `pnpm verify:release` command.
|
|
||||||
|
|
||||||
// Reuse the monorepo's existing YAML parser (@mosaicstack/mosaic's direct
|
|
||||||
// dependency) instead of adding a root dependency or vendoring a parser.
|
|
||||||
const mosaicRequire = createRequire(
|
|
||||||
path.resolve(process.cwd(), 'packages', 'mosaic', 'package.json'),
|
|
||||||
);
|
|
||||||
const { parse: parseYaml } = mosaicRequire('yaml');
|
|
||||||
|
|
||||||
const publishYmlPath = path.join(process.cwd(), '.woodpecker', 'publish.yml');
|
|
||||||
const ciYmlPath = path.join(process.cwd(), '.woodpecker', 'ci.yml');
|
|
||||||
|
|
||||||
async function readPublishPipeline() {
|
|
||||||
return parseYaml(await readFile(publishYmlPath, 'utf8'));
|
|
||||||
}
|
|
||||||
|
|
||||||
// A step has an external publication effect when its name starts with
|
|
||||||
// `publish` or when any command pushes an image to a registry.
|
|
||||||
function pushesImage(step) {
|
|
||||||
return (step.commands ?? []).some((command) =>
|
|
||||||
/(^|\s)(\/kaniko\/executor|docker push)\b|--destination/.test(command),
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
function publishEffectSteps(pipeline) {
|
|
||||||
return Object.entries(pipeline.steps ?? {})
|
|
||||||
.filter(([name, step]) => name.startsWith('publish') || pushesImage(step))
|
|
||||||
.map(([name]) => name);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Transitive closure of a step's depends_on graph.
|
|
||||||
function dependencyClosure(pipeline, stepName, seen = new Set()) {
|
|
||||||
const dependencies = pipeline.steps?.[stepName]?.depends_on ?? [];
|
|
||||||
for (const dependency of dependencies) {
|
|
||||||
if (seen.has(dependency)) continue;
|
|
||||||
seen.add(dependency);
|
|
||||||
dependencyClosure(pipeline, dependency, seen);
|
|
||||||
}
|
|
||||||
return seen;
|
|
||||||
}
|
|
||||||
|
|
||||||
function verifyCommands(pipeline) {
|
|
||||||
const verify = pipeline.steps?.verify;
|
|
||||||
assert.ok(verify, 'publish pipeline must define a `verify` step');
|
|
||||||
assert.ok(Array.isArray(verify.commands), '`verify` step must have commands');
|
|
||||||
return verify.commands;
|
|
||||||
}
|
|
||||||
|
|
||||||
function assertCommitIdentityAssertion(commands) {
|
|
||||||
const text = commands.join('\n');
|
|
||||||
assert.match(
|
|
||||||
text,
|
|
||||||
/CI_COMMIT_SHA/,
|
|
||||||
'`verify` must compare the provider commit identity (CI_COMMIT_SHA)',
|
|
||||||
);
|
|
||||||
assert.match(text, /git rev-parse HEAD/, '`verify` must compare against git rev-parse HEAD');
|
|
||||||
assert.match(
|
|
||||||
text,
|
|
||||||
/exit 1/,
|
|
||||||
'`verify` must fail closed (exit 1) on identity mismatch or emptiness',
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
function assertCanonicalCommand(commands) {
|
|
||||||
assert.ok(
|
|
||||||
commands.some((command) => /^pnpm verify:release\b/.test(command.trim())),
|
|
||||||
'`verify` must run the canonical terminal verification command `pnpm verify:release`',
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
function assertPublishGate(pipeline) {
|
|
||||||
assert.ok(pipeline.steps, 'publish pipeline must define steps');
|
|
||||||
|
|
||||||
const commands = verifyCommands(pipeline);
|
|
||||||
assertCommitIdentityAssertion(commands);
|
|
||||||
assertCanonicalCommand(commands);
|
|
||||||
|
|
||||||
const effects = publishEffectSteps(pipeline);
|
|
||||||
assert.ok(effects.length > 0, 'publish pipeline must contain publish effect steps to guard');
|
|
||||||
|
|
||||||
for (const stepName of effects) {
|
|
||||||
const step = pipeline.steps[stepName];
|
|
||||||
assert.ok(
|
|
||||||
Array.isArray(step.depends_on) && step.depends_on.includes('verify'),
|
|
||||||
`publish effect '${stepName}' must depend DIRECTLY on the verify step (SDLC-D-034: transitively through build is not enough)`,
|
|
||||||
);
|
|
||||||
assert.ok(
|
|
||||||
dependencyClosure(pipeline, stepName).has('verify'),
|
|
||||||
`publish effect '${stepName}' must depend on a chain that includes verify`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
return effects;
|
|
||||||
}
|
|
||||||
|
|
||||||
test('the publish pipeline gates every publish effect behind exact-commit verification', async () => {
|
|
||||||
const pipeline = await readPublishPipeline();
|
|
||||||
const effects = assertPublishGate(pipeline);
|
|
||||||
assert.deepEqual(effects.sort(), [
|
|
||||||
'build-appservice',
|
|
||||||
'build-gateway',
|
|
||||||
'build-web',
|
|
||||||
'publish-next-npm',
|
|
||||||
'publish-npm',
|
|
||||||
]);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('the verify step carries no path/event short-circuit of its own', async () => {
|
|
||||||
const pipeline = await readPublishPipeline();
|
|
||||||
// A `when` filter on `verify` would let a publish effect fire on an event
|
|
||||||
// class that skipped verification — the gate must be unconditional.
|
|
||||||
assert.equal(pipeline.steps.verify.when, undefined);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('a publish step that bypasses verify fails the gate checker', () => {
|
|
||||||
// Negative fixture: a plausible publish pipeline where `publish-npm` hangs
|
|
||||||
// off `build` only and `build` never chains to `verify` — the exact bypass
|
|
||||||
// class SDLC-D-034 closes. The checker must go red on it.
|
|
||||||
const bypassingPipeline = `
|
|
||||||
steps:
|
|
||||||
install:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm install --frozen-lockfile
|
|
||||||
verify:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- |
|
|
||||||
if [ -z "$CI_COMMIT_SHA" ] || [ "$CI_COMMIT_SHA" != "$(git rev-parse HEAD)" ]; then
|
|
||||||
echo "identity mismatch" >&2
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
- pnpm verify:release
|
|
||||||
depends_on:
|
|
||||||
- install
|
|
||||||
build:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm build
|
|
||||||
depends_on:
|
|
||||||
- install
|
|
||||||
publish-npm:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm publish
|
|
||||||
depends_on:
|
|
||||||
- build
|
|
||||||
`;
|
|
||||||
assert.throws(
|
|
||||||
() => assertPublishGate(parseYaml(bypassingPipeline)),
|
|
||||||
/publish-npm.*DIRECTLY.*verify/s,
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('a publish step chained to verify only transitively fails the gate checker', () => {
|
|
||||||
// Negative fixture: `build` depends on verify but `publish-npm` does not
|
|
||||||
// carry the direct edge — weaker than SDLC-D-034 requires of the real DAG.
|
|
||||||
const transitiveOnlyPipeline = `
|
|
||||||
steps:
|
|
||||||
install:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm install --frozen-lockfile
|
|
||||||
verify:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- |
|
|
||||||
if [ -z "$CI_COMMIT_SHA" ] || [ "$CI_COMMIT_SHA" != "$(git rev-parse HEAD)" ]; then
|
|
||||||
echo "identity mismatch" >&2
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
- pnpm verify:release
|
|
||||||
depends_on:
|
|
||||||
- install
|
|
||||||
build:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm build
|
|
||||||
depends_on:
|
|
||||||
- install
|
|
||||||
- verify
|
|
||||||
publish-npm:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm publish
|
|
||||||
depends_on:
|
|
||||||
- build
|
|
||||||
`;
|
|
||||||
assert.throws(
|
|
||||||
() => assertPublishGate(parseYaml(transitiveOnlyPipeline)),
|
|
||||||
/publish-npm.*DIRECTLY.*verify/s,
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('a verify step without the commit-identity assertion fails the gate checker', () => {
|
|
||||||
const noIdentityPipeline = `
|
|
||||||
steps:
|
|
||||||
verify:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm verify:release
|
|
||||||
publish-npm:
|
|
||||||
image: node:24-alpine
|
|
||||||
commands:
|
|
||||||
- pnpm publish
|
|
||||||
depends_on:
|
|
||||||
- verify
|
|
||||||
`;
|
|
||||||
assert.throws(() => assertPublishGate(parseYaml(noIdentityPipeline)), /CI_COMMIT_SHA/);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('the canonical verify:release stages mirror the PR CI pipeline one-for-one', async () => {
|
|
||||||
const ci = parseYaml(await readFile(ciYmlPath, 'utf8'));
|
|
||||||
const canonical = Object.fromEntries(STAGES.map((stage) => [stage.name, stage.commands]));
|
|
||||||
|
|
||||||
// The complete mandatory set, in gate order.
|
|
||||||
assert.deepEqual(
|
|
||||||
STAGES.map((stage) => stage.name),
|
|
||||||
['sanitization', 'upgrade-guard', 'typecheck', 'lint', 'format', 'test', 'build'],
|
|
||||||
);
|
|
||||||
|
|
||||||
// Guard stages: ci.yml commands minus its `apk add` environment prep must be
|
|
||||||
// exactly the canonical stage commands (order included).
|
|
||||||
for (const stageName of ['sanitization', 'upgrade-guard']) {
|
|
||||||
assert.deepEqual(
|
|
||||||
ci.steps[stageName].commands.filter((command) => !command.startsWith('apk add')),
|
|
||||||
canonical[stageName],
|
|
||||||
`canonical '${stageName}' stage must match the ci.yml step`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
// pnpm stages: ci.yml commands minus `corepack enable` must be exactly the
|
|
||||||
// canonical stage commands.
|
|
||||||
for (const stepName of ['typecheck', 'lint', 'format']) {
|
|
||||||
assert.deepEqual(
|
|
||||||
ci.steps[stepName].commands.filter((command) => command !== 'corepack enable'),
|
|
||||||
canonical[stepName],
|
|
||||||
`canonical '${stepName}' stage must match the ci.yml step`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
// The test stage is shared, but ci.yml wraps it in pipeline-level
|
|
||||||
// prerequisites the canonical command expects its caller to provide
|
|
||||||
// (SDLC-D-034): the postgres service + readiness wait + db:migrate, openssl,
|
|
||||||
// and the pinned pi runtime. None of those may be dropped silently.
|
|
||||||
for (const command of canonical.test) {
|
|
||||||
assert.ok(
|
|
||||||
ci.steps.test.commands.includes(command),
|
|
||||||
`ci.yml test step must run the canonical test stage command '${command}'`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
for (const fragment of [
|
|
||||||
'pg_isready -h ci-postgres',
|
|
||||||
'pnpm --filter @mosaicstack/db run db:migrate',
|
|
||||||
'npm install -g @earendil-works/[email protected]',
|
|
||||||
]) {
|
|
||||||
assert.ok(
|
|
||||||
ci.steps.test.commands.some((command) => command.includes(fragment)),
|
|
||||||
`ci.yml test step must keep its pipeline-level prerequisite '${fragment}'`,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
test('the root package.json exposes verify:release as the canonical command', async () => {
|
|
||||||
const packageJson = JSON.parse(await readFile(path.join(process.cwd(), 'package.json'), 'utf8'));
|
|
||||||
assert.match(packageJson.scripts['verify:release'], /scripts\/verify-release\.mjs/);
|
|
||||||
});
|
|
||||||
Reference in New Issue
Block a user