fix(store): refuse unmarked targets by default; reclaim only under --reclaim (W-F4 review)

Resolves the review finding on c23a71d7: 'store add' silently deleted a markerless target directory and reported it as recovered-partial, but the code cannot distinguish its own interrupted-write debris from content the operator placed by hand — and the USER root's entire contract is that tooling never destroys operator content. - addStoreEntry now throws typed STORE_TARGET_UNMARKED on an unmarked target; deletion happens only when the caller passes { reclaim: true }. - CLI: 'store add' gains --reclaim ('replace an existing UNMARKED target directory; refuses without this flag'). - Status renamed recovered-partial -> reclaimed-unmarked so even the opted-in path names what it did (fix 2 folded into fix 1). - Spec: default-refusal test asserts operator content SURVIVES; opt-in test asserts replacement; two CLI tests cover exit codes. - Ordering test (second review round): 'reclaim can never destroy a marked, vetted entry' — adds a vetted entry, re-adds with reclaim:true, asserts STORE_ALREADY_PRESENT AND the original content + marker survive on disk. Pins marker-check-before-reclaim-check against the guard-clause-migrates-upward refactor; discrimination proven by sabotaging the order (1 failed, exactly this test) and restoring (49/49). - TOCTOU note added at assertSourceTreeHasNoSymlinks per review (known check-then-use window, accepted for a local operator-run CLI). Gates (settled set, rc-honest): store spec 49/49; package vitest 87 files / 1596 tests; package build+lint rc0; root build 25/25 + typecheck 45/45; prettier --check rc0 on all four touched files. c23a71d7 remains the reviewed object, untouched.
feat(mosaic): vetted user store — mosaic store add|list (W-F4)
2026-08-17 13:16:23 -05:00 · 2026-08-17 13:09:24 -05:00
31 changed files with 1038 additions and 1370 deletions
@@ -30,19 +30,6 @@ steps:
      # the baked pnpm store.
      - pnpm install --frozen-lockfile --prefer-offline
  # ---------------------------------------------------------------------------
  # The steps below (sanitization, upgrade-guard, typecheck, lint, format,
  # test) are the COMPLETE mandatory verification set. SDLC-D-034 mirrors them
  # one-for-one in the canonical terminal verification command — root
  # `pnpm verify:release` (scripts/verify-release.mjs) — which the publish
  # pipeline (.woodpecker/publish.yml `verify` step) runs before ANY publish
  # effect. These lines stay direct (not routed through the runner) because the
  # #1017 test-enumeration guard audits framework tool paths through THIS
  # surface; scripts/verify-release.test.mjs enforces that the runner's stage
  # table keeps matching these commands exactly, so the two cannot drift.
  # ---------------------------------------------------------------------------
  # Canonical verify:release stage `sanitization`.
  # Blocking gate: public framework package must contain no operator-specific
  # personal data or private $HOME defaults. Runs early (no node_modules needed).
  sanitization:
@@ -60,7 +47,6 @@ steps:
      # with everything it guards; this direct line keeps one instrument running.
      - bash packages/mosaic/framework/tools/quality/scripts/check-test-enumeration.sh
  # Canonical verify:release stage `upgrade-guard`.
  # Blocking gate (#791): a framework upgrade must never write or delete an
  # operator-owned path. The HARD GATE proves an unanticipated operator sentinel
  # survives a keep-mode reseed byte-identical (with rsync present AND absent —
@@ -82,8 +68,6 @@ steps:
      - bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-durable-snapshot.sh
      - bash packages/mosaic/framework/tools/quality/scripts/test-install-migration.sh
  # Canonical verify:release stage `typecheck` — the same `pnpm typecheck`
  # invocation (which runs the checkout preflight first, then turbo).
  typecheck:
    image: *node_image
    commands:
@@ -94,8 +78,7 @@ steps:
      - sanitization
      - upgrade-guard
-  # lint, format, and test are independent — run in parallel after typecheck.
+  # lint, format, and test are independent — run in parallel after typecheck
  # Each runs exactly its canonical verify:release stage command.
  lint:
    image: *node_image
    commands:
@@ -112,12 +95,6 @@ steps:
    depends_on:
      - typecheck
  # Canonical verify:release stage `test` — the `pnpm test` line below is the
  # shared command; everything else in this step is PIPELINE-LEVEL
  # prerequisite the canonical command expects its caller to provide (SDLC-D-034):
  # the ci-postgres service + pg_isready wait + db:migrate (postgres path),
  # `apk add openssl`, and the pinned pi install. None of those can move into
  # the runner (it must also work locally on the PGlite path with no database).
  test:
    image: *node_image
    environment:
@@ -1,19 +1,5 @@
 # Build, publish npm packages, and push Docker images
 # Runs on main for stable publishes and on next for integration-line prereleases/images
 #
 # SDLC-D-034 publish gate: every publish effect (publish-npm, publish-next-npm,
 # and every image build/push step) depends DIRECTLY on the `verify` step below.
 # `verify` (a) asserts the provider's commit identity matches the actual
 # checkout (CI_COMMIT_SHA == git rev-parse HEAD, fail closed on mismatch or
 # emptiness) and (b) runs the canonical terminal verification command
 # (`pnpm verify:release`), which mirrors the PR CI pipeline's complete
 # mandatory set (sanitization, upgrade-guard, preflight+typecheck, lint,
 # format:check, test, build) — see scripts/verify-release.mjs. A missing,
 # failed, skipped, cancelled, or inconclusive verification therefore skips the
 # dependent publish effects (fail closed). Path-filtered short-circuits may
 # skip publish EFFECTS (e.g. docs-only merges) but never bypass `verify` for a
 # publish that does run: `verify` itself carries no path filter.
 # scripts/verify-release.test.mjs enforces this DAG invariant at checkout time.
 variables:
  # Pre-baked CI base (see .woodpecker/ci-image.yml): node:24-alpine +
@@ -62,45 +48,6 @@ steps:
      # Resolve from the baked pnpm store instead of a cold network fetch.
      - pnpm install --frozen-lockfile --prefer-offline
  # SDLC-D-034 exact-commit publish gate. No `when`/path filter on purpose: it
  # runs for every event this pipeline serves so no publish effect can ever
  # start without it. Fails closed on commit-identity mismatch (or either SHA
  # being empty) and on any incomplete verification.
  verify:
    image: *node_image
    commands:
      - *enable_pnpm
      # (a) Commit identity: the provider's claimed SHA must equal the actual
      # checkout HEAD — verification of anything else must never authorize a
      # publish of this commit.
      - |
        if [ -z "$CI_COMMIT_SHA" ]; then
          echo "[verify] FATAL: CI_COMMIT_SHA is empty — cannot certify commit identity" >&2
          exit 1
        fi
        CHECKOUT_SHA="$(git rev-parse HEAD 2>/dev/null || true)"
        if [ -z "$CHECKOUT_SHA" ]; then
          echo "[verify] FATAL: git rev-parse HEAD returned nothing — cannot certify commit identity" >&2
          exit 1
        fi
        if [ "$CI_COMMIT_SHA" != "$CHECKOUT_SHA" ]; then
          echo "[verify] FATAL: provider commit ($CI_COMMIT_SHA) != checkout HEAD ($CHECKOUT_SHA)" >&2
          exit 1
        fi
        echo "[verify] commit identity confirmed: $CHECKOUT_SHA"
      # (b) Canonical terminal verification. Caller-provided prerequisites the
      # runner expects (see .woodpecker/ci.yml comments): bash/rsync for the
      # guard stages, openssl + the pinned pi binary for the test stage. git is
      # baked into ci-base but re-asserted here so the identity check above can
      # never silently depend on a stale baked image. DATABASE_URL is
      # deliberately NOT set: the canonical command must hold on the PGlite
      # path too and never sets or requires a database itself.
      - apk add --no-cache bash rsync openssl git
      - npm install -g @earendil-works/[email protected]
      - pnpm verify:release
    depends_on:
      - install
  build:
    image: *node_image
    commands:
@@ -108,7 +55,6 @@ steps:
      - pnpm build
    depends_on:
      - install
      - verify
  publish-npm:
    image: *node_image
@@ -168,7 +114,6 @@ steps:
        exit 1
    depends_on:
      - build
      - verify
  publish-next-npm:
    image: *node_image
@@ -247,7 +192,6 @@ steps:
        echo "[publish-next] @mosaicstack/mosaic@next resolves to $RESOLVED_VERSION"
    depends_on:
      - build
      - verify
  # TODO: Uncomment when ready to publish to npmjs.org
  # publish-npmjs:
@@ -261,7 +205,6 @@ steps:
  #     - bash scripts/publish-npmjs.sh
  #   depends_on:
  #     - build
  #     - verify
  #   when:
  #     - event: [tag]
@@ -299,7 +242,6 @@ steps:
        /kaniko/executor --context . --dockerfile docker/gateway.Dockerfile $DESTINATIONS
    depends_on:
      - build
      - verify
  build-appservice:
    image: gcr.io/kaniko-project/executor:debug
@@ -326,7 +268,6 @@ steps:
        /kaniko/executor --context . --dockerfile docker/appservice.Dockerfile $DESTINATIONS
    depends_on:
      - build
      - verify
  build-web:
    image: gcr.io/kaniko-project/executor:debug
@@ -353,4 +294,3 @@ steps:
        /kaniko/executor --context . --dockerfile docker/web.Dockerfile $DESTINATIONS
    depends_on:
      - build
      - verify
@@ -190,13 +190,7 @@ beforeEach((ctx) => {
 });
 afterAll(async () => {
-  // Cleanup only when the fixture actually installed rows. `handle` is set
+  if (!handle) return;
  // before the first query (createDb connects lazily), so on an unreachable
  // database `handle` is truthy while nothing was inserted — cleanup must
  // honor `dbAvailable` or the skip path fails the file with ECONNREFUSED in
  // afterAll (caught live by the publish pipeline's no-DATABASE_URL verify
  // step, pipeline 2486).
  if (!handle || !dbAvailable) return;
  const db = handle.db;
  // Delete in dependency order (FK constraints)
@@ -1368,38 +1368,3 @@ All work is **alpha** (< 0.1.0) until Jason approves 0.1.0 beta release.
 10. ASSUMPTION: **Conversations and messages get their own PG tables** (not stored in brain's entity model). They follow a chat-specific schema with proper foreign keys to users and projects. Rationale: Chat has different access patterns (streaming, pagination, search) than brain entities.
 11. RESOLVED: **Pi handles all target LLM providers natively.** Anthropic, OpenAI/Codex, Z.ai, Ollama, LM Studio, and llama.cpp are all supported via Pi's built-in providers or `models.json` configuration with `openai-completions` API type. No custom provider adapters needed in @mosaicstack/agent — only configuration management.
 ---
 ## Release Integrity Workstream (RI, #1275)
 ### Problem and objective
 At `next` 476db12b (review of 2026-08-17), publication from `next` is not bound to the full verification pipeline for the same commit: the publish pipeline's publish steps depend on `build` only, while ordinary push CI excludes `next`. Public Forge/MACP paths contain false-success placeholders: a stub executor that reports `completed` with exit zero, planning/remediation gates that execute literal `true`, a review gate that echoes an approving verdict, and a gate runner that treats empty commands and unimplemented CI-provider gates as passing. Shipping UI surfaces can render a failed fetch as an empty, healthy collection.
 Objective: for alpha 0.0.50, the release cannot publish, report, or display work state that the repository has not actually verified. Decisions SDLC-D-033 through SDLC-D-038 (Jason, 2026-08-17) scope this floor; full decision text and required-behavior lists live in jarvis-brain `docs/plans/2026-08-16_mosaic-stack-sdlc-protocol.md` and `data/decisions/mosaic-stack-sdlc-protocol.json`. This section restates only the normative requirements.
 ### Normative requirements
 1. **RI-N1 Exact-commit publication verification (SDLC-D-034).** One canonical terminal verification command performs self-contained re-verification in the publish pipeline against the job's checked-out commit before any external publication effect. The command contains or invokes the complete mandatory verification set (semantic parity with the PR merge gate, including sanitization, upgrade-guard, typecheck, lint, format check, tests, and build); CI and publication do not maintain separate semantic checklists. Every publish step depends on the verification step in the executable pipeline DAG. Provider commit identity and `git rev-parse HEAD` must identify the same commit. Missing, skipped, cancelled, stale, or inconclusive checks fail closed. Documentation-only runs may skip publication but cannot bypass verification when a publication effect will occur. A negative control must prove that a broken check blocks every publish step.
 2. **RI-N2 Fail-closed Forge/MACP with explicit simulation (SDLC-D-035).** Simulation requires explicit caller intent (e.g. `--simulate`) and produces a distinct typed `simulated` state that can never satisfy dependencies, acceptance criteria, gates, merge, or release. Normal execution exits nonzero with a typed capability failure when a required executor, reviewer, command, or CI provider is absent — no stub completion, no literal-`true` gates, no synthetic approvals, no empty-command passes. A manual gate with no automation enters a waiting state; it does not pass. Positive tests prove explicit simulation still works; negative controls prove simulation and every missing-provider case cannot advance lifecycle state.
 3. **RI-N3 One transitional PRD authority (SDLC-D-036).** `@mosaicstack/prdy` structured storage under `docs/prdy/`, driven by `mosaic mission --plan`, is the authoritative PRD representation for the alpha. `mosaic prdy` either routes through the same application service or operates only as an explicit, named Markdown import/export adapter; `docs/PRD.md` is not a peer authority. `mission --plan` must persist the mission↔PRD linkage (mission id/version, PRD id/version, selected requirements). Markdown output is a generated view carrying source identity; editing it cannot mutate authority silently. Import is explicit, validated, and conflict-aware (proposed successor, never overwrite). Structural validity is separate from approval.
 4. **RI-N4 One quality-rails evaluator (SDLC-D-037).** The TypeScript quality-rails package is the sole authoritative evaluator. A complete probe inventory maps every current TypeScript and shell check to one canonical check with disposition (preserve/strengthen/retire, each named). Effective shell enforcement probes are absorbed before their independent paths retire; expected-file presence alone is not parity. The evaluator returns typed results (`passed`/`failed`/`blocked`/`error`/`not-applicable`) with check version, subject, and reason; missing implementation, missing input, unknown check, process error, timeout, or malformed output can never become `passed` or an unqualified skip. Check definitions and policy are versioned and digested. Shell commands become thin adapters with no separate verdict logic. The canonical terminal verification command (RI-N1) invokes this evaluator rather than duplicating its logic. Contract, parity, and negative-control tests are required, plus independent review of probe equivalence.
 5. **RI-N5 Consequence-aware stale UI (SDLC-D-038).** Mission Control distinguishes typed freshness states (`current`, `stale`, `partial`, `unknown`, `unavailable`) rather than inferring from empty arrays or null. A failed fetch never renders as an empty healthy collection. Last-known data may display for situational awareness only with source identity, version, and age visibly labeled; any derived completion/assurance/release verdict whose inputs are stale becomes `unknown`; all state-changing actions are disabled until fresh state loads and is revalidated. With no verified snapshot, surfaces show an explicit unavailable state. Cache corruption, cross-workspace data, schema mismatch, and version regression invalidate the snapshot. Tests cover the failure matrix (network, auth, malformed, partial, corruption, stale age, schema mismatch, recovery, stale-action rejection) with negative controls proving no case yields a current green verdict or enabled mutation.
 ### Acceptance criteria
 - AC-RI-1: A push to `next` that fails any mandatory verification step publishes nothing (no npm package, no image), demonstrated by a checked-in negative control and by pipeline evidence on a real `next` publish run where the verification step is green and every publish step depends on it.
 - AC-RI-2: With no executor/reviewer/CI provider wired, Forge and MACP normal runs exit nonzero with typed capability failures; with `--simulate`, runs complete but every result is typed `simulated` and cannot satisfy any gate, dependency, or completion state — proven by unit tests including negative controls.
 - AC-RI-3: A PRD created or revised through either `mosaic mission --plan` or `mosaic prdy` resolves to one authority under `docs/prdy/` with stable identities and versions; the mission↔PRD linkage survives restart; a Markdown export is labeled as generated and cannot silently become a second writer; divergent legacy content blocks baseline claims until explicitly resolved — proven by contract tests.
 - AC-RI-4: `quality-rails check` through any entry point (TS CLI, framework shell adapter) returns the same typed verdict for the same subject; the probe inventory names every legacy check's disposition; a deliberately broken probe fails closed — proven by contract/parity/negative-control tests and independent review of probe equivalence.
 - AC-RI-5: No shipping surface renders a failed fetch as an empty healthy state; stale/partial/unavailable states are typed, labeled, and mutation-disabled — proven by the failure-matrix tests.
 - AC-RI-6: All cards merged to `next` via squash PR with terminal-green CI; release evidence for 0.0.50 records commit, verification run, and published artifacts.
 ### Out of scope
 The canonical dispatcher/control-plane vertical slice (work graph, execution attempts, fenced leases, typed check-in, independent verifier dispatch) is decided post-alpha (SDLC-D-033, option B). Multi-pipeline verification certificates (SDLC-D-034 option B) are post-alpha. Full AF-1..AF-4 objective matrices and Mission Control portfolio surfaces are post-alpha.
@@ -1,42 +0,0 @@
 # Tasks — Release Integrity Workstream (RI-050, #1275)
 > Single-writer: the RI-050 orchestrator (jarvis, dragon-lin) only. Workers read but never modify.
 >
 > **Mission:** alpha 0.0.50 release-integrity floor (decisions SDLC-D-033..038).
 > **PRD:** [docs/PRD.md § Release Integrity Workstream](../PRD.md#release-integrity-workstream-ri-1275)
 > **Issue:** #1275 (remains open until RI-V-001 closes)
 > **Base branch:** `next` (all cards branch from `origin/next`, squash-merge via PR)
 >
 > **Execution note:** the `agent` column uses `pi-glm-5.3` — outside the pipeline-cron model
 > table on purpose. This workstream is executed by jarvis on dragon-lin with local pi workers
 > (`pi --model zai/glm-5.3:high`); pipeline crons must not auto-claim these rows.
 >
 > **Status values:** `not-started` | `in-progress` | `done` | `blocked` | `failed` | `needs-qa`
 > `done` requires: repo quality gates green, independent review recorded, terminal-green CI on
 > the PR head, squash merge to `next`, and acceptance evidence in notes.
 | id       | status      | description                                                                                                                                                                                                                                                                      | issue | agent      | repo              | branch                            | depends_on                                                 | estimate | notes                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              |
 | -------- | ----------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----- | ---------- | ----------------- | --------------------------------- | ---------------------------------------------------------- | -------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | RI-0-001 | in-progress | Bootstrap: issue #1275, PRD section, this DAG, scratchpad (docs only)                                                                                                                                                                                                            | #1275 | pi-glm-5.3 | mosaicstack/stack | docs/ri-050-mission-bootstrap     | —                                                          | 6K       |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
 | RI-1-001 | in-progress | RI-N1: canonical terminal verification command + publish-pipeline exact-commit gate (every publish step depends on verify; commit identity check; fail closed)                                                                                                                   | #1275 | pi-glm-5.3 | mosaicstack/stack | feat/ri-050-publish-gate          | RI-0-001                                                   | 25K      |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
 | RI-1-002 | not-started | RI-N1 negative control: checked-in tests proving a broken mandatory check blocks every publish step and that DAG edges cannot be bypassed                                                                                                                                        | #1275 | pi-glm-5.3 | mosaicstack/stack | test/ri-050-publish-gate-negative | RI-1-001                                                   | 12K      |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
 | RI-2-001 | in-progress | RI-N2 (Forge): remove stub-executor false success; `--simulate` typed `simulated` results that satisfy nothing; literal-`true` gates and echo-review replaced with real gates or typed waiting-for-authority                                                                     | #1275 | pi-glm-5.3 | mosaicstack/stack | fix/ri-050-forge-fail-closed      | RI-0-001                                                   | 20K      | Independent review APPROVED 2026-08-17 (Gitea review 172 on PR #1278, head 99b8f6ea; reviewing seat fargo — recorded under shared host principal mos-dt-0, provenance correction posted by fred; wrapper gap filed by fred). Executed at head: forge tests 116/116, lint green, typecheck green after building macp dist (minimal-install artifact, not a defect), workspace typecheck 45/45, no external type consumers of the changed interfaces. CI red = known lane-wide fleet-test failure only, carries no information about this change (fred, log-content analysis, pipelines 2456-2458). Non-blocking finding: README L141-143 + skills/mosaic-forge/SKILL.md document bare forge run/resume, which now fails closed — fast-follow docs touch. Merge queued behind #1270. |
 | RI-2-002 | in-progress | RI-N2 (MACP): gate runner fails closed on empty commands, stub executors, and unimplemented CI-provider gates unless explicit simulate; typed capability failures                                                                                                                | #1275 | pi-glm-5.3 | mosaicstack/stack | fix/ri-050-macp-fail-closed       | RI-0-001                                                   | 15K      |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
 | RI-3-001 | not-started | RI-N4: complete probe inventory mapping every TS and shell quality-rail check to one canonical check with disposition (preserve/strengthen/retire, each named)                                                                                                                   | #1275 | pi-glm-5.3 | mosaicstack/stack | docs/ri-050-qr-probe-inventory    | RI-0-001                                                   | 12K      |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
 | RI-3-002 | not-started | RI-N4: TS evaluator absorbs effective shell probes; typed results (passed/failed/blocked/error/not-applicable) with versioned digested check definitions; shell commands become thin adapters; contract/parity/negative-control tests                                            | #1275 | pi-glm-5.3 | mosaicstack/stack | feat/ri-050-qr-evaluator          | RI-3-001                                                   | 30K      |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
 | RI-4-001 | in-progress | RI-N3: one PRD application service — `mission --plan` persists mission↔PRD linkage (ids/versions/selected requirements); `mosaic prdy` routes through the service or becomes a named import/export adapter; Markdown is a labeled generated view; explicit conflict-aware import | #1275 | pi-glm-5.3 | mosaicstack/stack | feat/ri-050-prd-authority         | RI-0-001                                                   | 35K      |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
 | RI-5-001 | not-started | RI-N5: typed freshness states (current/stale/partial/unknown/unavailable); no failed-fetch-renders-empty; stale derived verdicts → unknown; mutations disabled when stale; failure-matrix tests                                                                                  | #1275 | pi-glm-5.3 | mosaicstack/stack | feat/ri-050-web-stale-safety      | RI-0-001                                                   | 25K      |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
 | RI-V-001 | not-started | Final verification + release evidence: all cards verified merged, negative controls demonstrated, real `next` publish run green on exact commit, evidence pack recorded                                                                                                          | #1275 | pi-glm-5.3 | mosaicstack/stack | docs/ri-050-release-evidence      | RI-1-002, RI-2-001, RI-2-002, RI-3-002, RI-4-001, RI-5-001 | 10K      |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
 ## Dispatch waves (max 2 parallel workers)
 1. RI-1-001 + RI-2-001
 2. RI-2-002 + RI-4-001
 3. RI-3-001 + RI-5-001
 4. RI-1-002 + RI-3-002
 5. RI-V-001
 ## Budget
 Derived soft cap: 250K tokens (no explicit cap given). Projected total: 190K.
 Conservative mode (1 worker) above 70% projected; freeze above 90%.
@@ -1,242 +0,0 @@
 # Scratchpad — RI-050 orchestrator (jarvis, dragon-lin)
 Mission: alpha 0.0.50 release-integrity floor. Issue #1275. Base `next` @ 476db12b.
 Design SSOT: jarvis-brain `docs/plans/2026-08-16_mosaic-stack-sdlc-protocol.md` (SDLC-D-033..038).
 ## Mode (Jason's directives)
 - Orchestrator: jarvis (this session, dragon-lin). NOT mos-claude; work stays on this host.
 - Workers: local pi headless — `pi --model zai/glm-5.3:high -p` in the card's worktree, tools read,bash,edit,write.
 - Delegation override of stack AGENTS.md `agent` column: rows carry `pi-glm-5.3` (outside cron table so no auto-claim).
 - Target branch: `next`. Cards branch from `origin/next`, squash-merge via PR.
 ## Operational constraints (measured this session)
 - Main checkout at `/home/jwoltje/src/mosaic-stack` is a dirty diverged `main` (ahead 1139/behind 711) — NEVER touched. All work in `/home/jwoltje/src/mosaic-stack-worktrees/<branch>`.
 - Disk: /home 187G free. /tmp only 8.7G — keep pnpm stores/node_modules under /home.
 - `main` and `next` have DIVERGED; PRs target `next`.
 - Identity: pin `GITEA_LOGIN=mosaicstack-jarvis` for all wrapper ops. Issue #1275 verified authored by @jarvis.
 - `ci-queue-wait.sh` on this host is fail-open (board: fix #1032 not installed) — substitute SHA-status checks via `/commits/{sha}/status` and diff failing step names.
 - CI on PRs runs `pull_request` pipelines (any branch) incl. ci-postgres service. Push CI runs on main only; publish runs on push/tag to next + manual.
 - Wrapper gaps on this host per board (7 gaps; e.g. no pr-review-list, issue-assign broken, pr-merge makes no trailers): verify outcomes by reading back provider state, never trust rc alone.
 - Publish pipeline currently: install → build → publish-npm/publish-next-npm (+image). No verify. CI steps: install, sanitization, upgrade-guard, typecheck, lint, format, test, ci-postgres.
 ## Budget
 Soft cap 250K. Projected 190K across 10 cards. Track per-card used vs estimate in TASKS.md notes.
 ## Progress log
 - 2026-08-16 23:52 — Issue #1275 created (@jarvis verified).
 - 2026-08-16 23:5x — Bootstrap branch `docs/ri-050-mission-bootstrap` from origin/next@476db12b; PRD section + TASKS.md + this scratchpad written. RI-0-001 in-progress.
 ## Wave 1 dispatched (2026-08-17 00:35)
 - RI-1-001 worker: pi glm-5.3:high, pid 2322125, worktree ri-1-001, log /var/tmp/ri-050/ri-1-001-run.log
 - RI-2-001 worker: pi glm-5.3:high, pid 2322126, worktree ri-2-001, log /var/tmp/ri-050/ri-2-001-run.log
 - Gotcha recorded: pi has no -f flag (that's pi-do.sh); pass brief as positional message. First launch died "Unknown option: -f" — relaunched.
 - CI lane: PR #1276 (bootstrap) fails `test` at base like every next PR — fred's green #1270 unblocks (comms sent 2026-08-17T05:21Z, `comms/20260817T052148Z__from-jarvis__650fe8.md`). Merge gate for all RI PRs queues behind #1270.
 - Live RI-N1 evidence posted to #1275 (comment 22915): pipeline 2439 publish-next-npm SUCCESS beside build-gateway FAILURE.
 ---
 # HANDOFF — RI-050 continuation (written 2026-08-17 ~08:45 UTC, jarvis/dragon-lin)
 You are taking over the alpha 0.0.50 release-integrity workstream in place. Everything you
 need is on the remote. Read this whole file, then `docs/release-integrity/TASKS.md` (same
 branch), then the PRD section (`docs/PRD.md` § Release Integrity Workstream, same branch).
 ## Identity / mode
 - Orchestrator identity: `jarvis` (dragon-lin). You continue as the RI-050 orchestrator under
  whatever identity Jason gives you — if you are NOT jarvis, say so in comms and PR bodies.
 - Jason's standing directives for this mission: work happens on THIS repo (mosaicstack/stack),
  PRs target `next` (NOT main), workers are local pi headless sessions on
  `zai/glm-5.3:high`. Do not hand this to mos-claude. Do not borrow other seats' lanes.
 - All wrapper ops: pin `GITEA_LOGIN=mosaicstack-jarvis` (issue #1275 was verified authored by
  @jarvis; keep identity consistent or verify yours with issue-view and READ BACK user.login).
 - CI substitution rule (this host's ci-queue-wait.sh is fail-open; fix #1032 not installed):
  judge CI by SHA-status via `/api/v1/repos/mosaicstack/stack/commits/{sha}/status` or the
  woodpecker API (`pipeline-status.sh -r mosaicstack/stack -n N -f json`), and DIFF THE
  FAILING STEP NAMES rather than trusting rc.
 ## Mission state at handoff
 Mission: alpha 0.0.50 release-integrity floor. Issue #1275 (open, has live-evidence comment).
 Decisions SDLC-D-033..038 live in jarvis-brain
 `docs/plans/2026-08-16_mosaic-stack-sdlc-protocol.md` (normative text also mirrored in the
 PRD section on this branch, so this repo is self-sufficient).
 Base: `origin/next` @ 476db12b. NOTE: `main` and `next` have DIVERGED — never base on main.
 Branches (all pushed, all clean trees):
 - `docs/ri-050-mission-bootstrap` @ 5114faa2 → PR #1276 (open, mergeable) — bootstrap docs +
  this scratchpad + TASKS.md DAG. STATUS: CI red on `test` only, which is the known lane-wide
  failure (see blocker below); own prettier issue already fixed.
 - `feat/ri-050-publish-gate` @ 0aa5ed35 → PR #1277 (open, mergeable) — RI-1-001 COMPLETE
  (worker reported success, orchestrator review PASSED: verify step asserts CI_COMMIT_SHA ==
  git rev-parse HEAD then runs canonical `pnpm verify:release`; every publish/image step
  depends_on verify directly, confirmed by parsing the DAG: publish-npm, publish-next-npm,
  build-gateway/appservice/web all -> [build, verify]; invariant test
  scripts/verify-release.test.mjs passes 7/7 locally with negative fixtures). CI: same known
  lane-red `test` step only.
 - `fix/ri-050-forge-fail-closed` @ 99b8f6ea → PR #1278 (open, mergeable) — RI-2-001 worker
  reported success (typed `FORGE_*` capability errors, --simulate typed simulated everywhere,
  vacuous true/echo gates replaced, closed ForgeOutcome set, 116 tests green incl. 16 new).
  ORCHESTRATOR REVIEW NOT YET DONE — your first job. Review the diff
  (1391 insertions across forge src), check the fail-closed paths and that simulated
  results cannot satisfy any consumer, run `pnpm --filter @mosaicstack/forge test`.
 ## The one blocker
 Every `next` PR pipeline is red on ONE assertion:
 `packages/mosaic/framework/tools/fleet/test-start-agent-session.sh:103` ("host provides 'pi'
 in the system path"). Pre-existing at base; affects PRs #1276/#1277/#1278 identically.
 fred's PR #1270 ("unblocks every PR on next") is green and open — it is HIS to merge; do not
 merge it yourself. jarvis sent comms (`comms/20260817T052148Z__from-jarvis__650fe8.md` in
 jarvis-brain) asking merge timing; no reply yet as of handoff. Merge gates for ALL RI PRs
 queue behind #1270 landing. Until then: review/develop freely, merge nothing that needs the
 green gate (docs-only #1276 arguably could merge red-lane with Jason's explicit call — ask,
 don't assume).
 ## Remaining DAG (docs/release-integrity/TASKS.md is canonical)
 Wave 2 (next): RI-2-002 MACP fail-closed (brief pattern: mirror RI-2-001 for
 packages/macp/src/gate-runner.ts — empty commands, stub executors, unimplemented CI-provider
 gates fail closed; explicit simulate) and RI-4-001 PRD authority (one PRD service;
@mosaicstack/prdy docs/prdy authoritative via `mosaic mission --plan`; `mosaic prdy` routes
 or becomes named Markdown adapter; mission<->PRD linkage persists — see PRD RI-N3).
 Wave 3: RI-3-001 probe inventory (docs), RI-5-001 web stale-safety.
 Wave 4: RI-1-002 negative-control tests, RI-3-002 TS evaluator absorbs shell probes.
 Final: RI-V-001 evidence pack (real green next publish run post-gate + all cards verified).
 ## Worker mechanics (measured, reuse)
 - Dispatch: create worktree `git -C /home/jwoltje/src/mosaic-stack worktree add
 /home/jwoltje/src/mosaic-stack-worktrees/<id> -b <branch> origin/next`, write a brief to
  /var/tmp/ri-050/, then run from INSIDE the worktree:
  `pi -p --no-session --model zai/glm-5.3:high --tools read,bash,edit,write "$(cat brief.md)"`
  (pi has NO -f flag — pass the brief as a positional message; first dispatch died on that).
 - Briefs for 1-001/2-001 are at /var/tmp/ri-050/ on dragon-lin (may not survive; the
  pattern is fully described above and in TASKS.md).
 - Briefs must carry: worktree path, branch, base, requirements, known base-red list (so the
  worker doesn't chase it), gates to run, PR creation command with GITEA_LOGIN pin, "do NOT
  merge, do NOT touch docs/TASKS.md", and the JSON report format.
 - Verify worker claims: read the PR, run their tests yourself, parse pipeline step names.
 ## Do-not-touch
 - Main checkout at /home/jwoltje/src/mosaic-stack (dirty diverged main) — never touch.
 - fred's open PRs (#1270 and others) — review evidence welcome, merging his is not yours.
 - Other RI PRs' authors' lanes: #1277/#1278 are yours to gate and merge ONCE lane is green
  and review is recorded.
 - Never `--no-verify`; never bypass the wrapper-fails-closed rule (wrapper failure ⇒
  `blocked + report exact command + stop`).
 ## Session-restore command sequence
 1. `git -C /home/jwoltje/src/mosaic-stack-worktrees/ri-050 fetch origin --prune`
 2. Read this file + `docs/release-integrity/TASKS.md` + PRD section.
 3. Check PR states (#1270, #1276, #1277, #1278) and lane CI (SHA-status per above).
 4. Review RI-2-001 (PR #1278) if not yet done; then dispatch wave 2.
 — jarvis, 2026-08-17
 ---
 # CONTINUATION — fargo (sb-it-1-dt)
 Orchestrator seat is now **fargo** on sb-it-1-dt (Jason, 2026-08-17): Claude seat, worktree discipline
 per fred's ruling (`~/agent-work/<slug>`, create → work → commit → push → remove as one act; the
 helper's `/src` refusal is a web1 convention, does not bind here). fred supports; lane rulings are
 his. Workers remain local pi `zai/glm-5.3:high` + limited Claude per Jason.
 ## 2026-08-17 — RI-2-001 independent review DONE
 - **PR #1278 APPROVED** (Gitea review 172, pinned to head 99b8f6ea). Executed evidence, not read-only:
  forge suite 116/116 at head (matches PR claim), forge lint green, forge typecheck green after
  building `@mosaicstack/macp` dist (TS2307 on bare `pnpm install --frozen-lockfile` is a
  minimal-install build-order artifact — the macp import is type-only, vitest passes unbuilt; CI
  installs build workspace deps, hence green there), **workspace typecheck 45/45 at head**,
  consumer sweep: no external type consumers of RunManifest/StageStatus/ForgeTaskResult/
  TaskExecutor; only importer of the package is packages/mosaic via registerForgeCommand
  (smoke test asserts registration/help only — cannot break). Digest gate (shaggy's) before==after
  with both-arm reactivity controls.
 - CI red on #1276/#1277/#1278: lane-wide `test` failure only
  (test-start-agent-session.sh:103, fred's guard mis-wired; #1270 unwires it). Fred measured log
  content: one real byte-identical failure per pipeline (2456/2457/2458); 13 of ~14 `FAIL` grep
  hits are passing fail-loud test NAMES. **The red carries no information about the RI changes.**
 - Non-blocking finding: README L141-143 + skills/mosaic-forge/SKILL.md document bare
  `mosaic forge run`/`resume`, which now exits 1 FORGE_NO_EXECUTOR — fast-follow docs touch.
 - **Identity incident, ruled on by fred:** review 172 recorded under shared host principal
  mos-dt-0, not fargo. Mechanism (measured, wrapper source): pr-review.sh resolves its acting login
  from the tea login list only; no fargo tea login on this host → silent host-default fallback;
  MOSAIC_GIT_IDENTITY is only read in detect-platform.sh get_gitea_token's fallback arm, never
  reached. Exact-id read-back verifies against the writing token, so it passed while attribution
  was wrong — durable-provenance machinery proves the write, not the seat. Fred's ruling: review
  172 stands (substance/verdict/pin correct; label wrong); NO re-approval (one approval,
  annotated, is the stronger record); fred posts the provenance correction under @fred with
  --login fred-ms (hard-fail path); no fargo tea login ever (freeze + Jason's to authorize);
  tooling gap filed by fred. Also explains (does not reopen) #1228's mos-dt-0 attribution.
 - Merge gate: all RI PRs queue behind fred's green #1270 (Jason's call).
 ## Next
 1. Wave 2 dispatch: RI-2-002 (MACP fail-closed, mirror RI-2-001 pattern for
   packages/macp/src/gate-runner.ts) + RI-4-001 (PRD authority). Two parallel workers max.
 2. Docs fast-follow (README + mosaic-forge skill) — fold into #1276 or a tiny docs card.
 3. RI-V-001 evidence at the end.
 — fargo, 2026-08-17
 ---
 # RESUMPTION + DAILY-HANDOFF PROTOCOL (Jason, 2026-08-17)
 Orchestrator seat is back with **jarvis** (dragon-lin). Expect daily handoff between jarvis
 and fargo. Protocol (both seats, every handoff):
 1. **This file is the shared mission log.** Append a dated section per session: state
   measured, actions taken, PR/review states, next actions. Never rewrite prior sections.
 2. **TASKS.md stays current within one session** — status, PR number in notes, review
   evidence. Stale rows are handoff debt.
 3. **Cross-review rule (SDLC-D-011 in practice):** the reviewing seat must differ from the
   producing seat. jarvis reviews fargo-dispatched PRs, fargo reviews jarvis-dispatched
   PRs. Producers are always pi workers; dispatching seats verify before push; the other
   seat records the Gitea review.
 4. Handoff = append here + push + (optional) issue #1275 comment if a decision changed.
 ## RESUMED — jarvis/dragon-lin, 2026-08-17 (afternoon)
 - Measured: next = 8199261c (#1270 merged — lane unblocked for new PRs). #1293/#1294
  (fargo, wave 2) CI-green, mergeable, no recorded reviews. #1276/#1277/#1278 still based
  on 476db12b with stale red CI → need rebase onto 8199261c. #1278 review pinned to old
  head 99b8f6ea by @mos-dt-0 (fargo's, mis-attributed per his note) — rebase will dismiss
  it; re-approval must come from fargo/fred (author is @jarvis, cannot self-approve).
 - Live evidence #2: push pipeline 2462 (the #1270 merge itself) ran publish-next-npm
  SUCCESS beside build-gateway FAILURE again.
 - Plan: rebase the three original branches; independently review #1293/#1294; merge order
  once green+reviewed: #1276 (docs) → #1277 (publish gate) → #1278/#1293/#1294 (code).
  After #1277 merges, watch the next push pipeline prove the verify gate live.
 - fargo's non-RI PRs (#1291/#1296/#1297/#1281) stay strictly his lane.
 ## jarvis session 2026-08-17 (evening) — reviews, rebases, merge plan
 - Rebased #1276/#1277/#1278 onto 8199261c (heads 59e2c460 / 46784c8d / 4917df1f);
  invariant tests 7/7 and forge 116/116 re-run green at new heads. #1270 touched
  test-enumeration-exclusions.txt + package.json, NOT ci.yml — no semantic overlap with
  #1277's ci.yml changes (checked, was a real concern).
 - Independent reviews recorded: #1293 APPROVED (review 173; macp 109/109; fail-closed paths
  + aggregate state machine verified), #1294 APPROVED (review 174; prdy 20/20 + command
  specs 9/9; single-writer + linkage persistence + labeled export + conflict-aware import
  verified). Note: 19 unrelated mosaic suites fail on bare minimal install (known workspace
  build-order artifact, documented by fargo) — not this change.
 - Measured: `next` has NO branch protection (API: only main listed). Cross-seat review
  discipline is protocol-enforced, not Gitea-enforced. Flagged to fargo for Jason: direct
  pushes to next trigger ungated publishes; protection is Jason's call (#1231 adjacent).
 - Merge order planned: #1276 (docs-only — no publish run) -> #1277 (first gated publish)
  -> #1278 -> #1293 -> #1294. Sent fargo review requests with pinned head SHAs
  (comms/20260818T011932Z__from-jarvis__a9c02b.md). Not merging #1293/#1294 before my three
  clear fargo's review — order optimality beats speed; every pre-#1277 merge publishes ungated.
 - CI on the three rebased heads: pending at time of this entry.
@@ -9,7 +9,6 @@
    "preflight": "node scripts/preflight.mjs",
    "clean:generated": "node scripts/clean-generated.mjs",
    "typecheck": "pnpm preflight && turbo run typecheck",
    "verify:release": "node scripts/verify-release.mjs",
    "test:checkout": "node --test scripts/*.test.mjs",
    "test": "pnpm test:checkout && turbo run test && pnpm run test:installer",
    "test:installer": "bash tools/install-next-lane.test.sh",
@@ -12,33 +12,6 @@ The default tmux socket is `mosaic-fleet` so fleet commands do not touch the
 default tmux server. The roster is the desired-state authority; generated environment files are
 rebuildable projections, never a second source of configuration.
 ## Brain-home split (fleet state vs framework templates)
 When a mosaic-brain clone is present, fleet **state** resolves from the brain
 home while framework templates and dispatch state stay in the config home
 (three-tree model, canon `docs/STRUCTURE-CANON.md` §2):
 | Path                                                                            | Without brain (legacy)                | With brain                     |
 | ------------------------------------------------------------------------------- | ------------------------------------- | ------------------------------ |
 | `fleet/agents/<seat>.env.*`                                                     | `~/.config/mosaic/fleet/agents/`      | `~/.mosaic/fleet/agents/`      |
 | `fleet/roles.local/` (overrides)                                                | `~/.config/mosaic/fleet/roles.local/` | `~/.mosaic/fleet/roles.local/` |
 | `fleet/profiles/` (working copies)                                              | `~/.config/mosaic/fleet/profiles/`    | `~/.mosaic/fleet/profiles/`    |
 | `fleet/roster.yaml`, `fleet/roles/` (baseline), `fleet/run/`, `fleet/services/` | `~/.config/mosaic/fleet/…`            | unchanged (config home)        |
 Activation (`packages/mosaic/src/fleet/brain-home.ts`, mirrored in
 `tools/fleet/start-agent-session.sh`):
 1. `MOSAIC_BRAIN_HOME` env var — explicit, always wins.
 2. Canonical `~/.mosaic` — adopted only when `MOSAIC_HOME` is the default
   `~/.config/mosaic` AND `~/.mosaic/fleet/agents` exists. Custom
   `--mosaic-home` values (tests, sandboxes, canaries) never adopt, keeping
   them hermetic.
 3. Otherwise the config home (legacy single-tree behavior).
 Seat env dirs under a brain are subject to the same privacy boundary (0700
 dirs, 0600 files); `.env.generated` files are structure-valuable and tracked
 in the brain repo, hand-maintained `.env`/`.env.local` stay ignored and private.
 ## Examples
 - `examples/minimal.yaml` starts one local canary slot.
@@ -80,26 +80,6 @@ safe_path "$MOSAIC_HOME" || fail_env unsafe-path MOSAIC_HOME "$MOSAIC_HOME"
 FLEET_DIR="$MOSAIC_HOME/fleet"
 AGENT_ENV_DIR="$FLEET_DIR/agents"
 # Brain-home split (canon docs/STRUCTURE-CANON.md §2): seat launch envs live
 # under the brain home's fleet/agents when a brain is active; roster, roles
 # baseline, and runtime state (fleet/run) stay under MOSAIC_HOME.
 # Resolution mirrors packages/mosaic/src/fleet/brain-home.ts:
 #   1. MOSAIC_BRAIN_HOME env (explicit, always wins)
 #   2. ~/.mosaic — adopted only when MOSAIC_HOME is the default config home AND
 #      ~/.mosaic/fleet/agents exists
 #   3. MOSAIC_HOME (legacy single-tree)
 BRAIN_HOME="${MOSAIC_BRAIN_HOME:-}"
 if [ -z "$BRAIN_HOME" ]; then
  BRAIN_HOME="$MOSAIC_HOME"
  if [ "$(cd "$MOSAIC_HOME" 2>/dev/null && pwd -P)" = "$HOME/.config/mosaic" ] \
     && [ -d "$HOME/.mosaic/fleet/agents" ]; then
    BRAIN_HOME="$HOME/.mosaic"
  fi
 fi
 if [ "$BRAIN_HOME" != "$MOSAIC_HOME" ]; then
  AGENT_ENV_DIR="$BRAIN_HOME/fleet/agents"
 fi
 assert_managed_directory "$MOSAIC_HOME"
 assert_managed_directory "$FLEET_DIR"
 assert_private_directory "$AGENT_ENV_DIR"
@@ -167,54 +167,6 @@ if echo "$valid_args" | grep -qF 'bash -c'; then
  fail "launcher constructed a shell command payload"
 fi
 # ── Brain-home split (canon §2) ─────────────────────────────────────────
 # When MOSAIC_HOME is the default config home under $HOME and the host carries
 # $HOME/.mosaic/fleet/agents, seat envs resolve from the brain tree; the config
 # home still owns fleet/run (holder-owner) and remains a managed boundary.
 : > "$TMUX_CALLS"
 HOME_BRAIN="$ROOT/brain-home"
 CONFIG_HOME="$HOME_BRAIN/.config/mosaic"
 BRAIN="$HOME_BRAIN/.mosaic"
 mkdir -p "$CONFIG_HOME/fleet/run" "$BRAIN/fleet/agents" "$HOME_BRAIN/work"
 chmod 700 "$CONFIG_HOME" "$CONFIG_HOME/fleet" "$CONFIG_HOME/fleet/run" \
  "$BRAIN/fleet/agents" "$HOME_BRAIN/work"
 printf '123e4567-e89b-12d3-a456-426614174000\n' > "$CONFIG_HOME/fleet/run/holder-owner"
 chmod 600 "$CONFIG_HOME/fleet/run/holder-owner"
 cat > "$BRAIN/fleet/agents/coder-brain.env.generated" <<EOF
 MOSAIC_AGENT_NAME=coder-brain
 MOSAIC_AGENT_CLASS=code
 MOSAIC_AGENT_RUNTIME=pi
 MOSAIC_AGENT_MODEL=openai-codex/gpt-5.6-sol
 MOSAIC_AGENT_REASONING=high
 MOSAIC_AGENT_TOOL_POLICY=code
 MOSAIC_AGENT_WORKDIR=$HOME_BRAIN/work
 MOSAIC_TMUX_SOCKET=mosaic-test
 EOF
 chmod 600 "$BRAIN/fleet/agents/coder-brain.env.generated"
 install_pane_binaries "$HOME_BRAIN"
 HOME="$HOME_BRAIN" PATH="$FAKE_BIN:$PATH" MOSAIC_TEST_TMUX_CALLS="$TMUX_CALLS" \
  MOSAIC_TEST_PANE_PID=$$ MOSAIC_TEST_HOME="$HOME_BRAIN" \
  MOSAIC_TEST_FLEET_OWNER=123e4567-e89b-12d3-a456-426614174000 \
  MOSAIC_HOME="$CONFIG_HOME" "$START" coder-brain
 brain_args=$(tr '\0' '\n' < "$TMUX_CALLS")
 echo "$brain_args" | grep -qF new-session || fail "brain-home generated projection did not reach tmux"
 echo "$brain_args" | grep -qF 'coder-brain' || fail "brain-home agent env was not the launch source"
 [ -f "$BRAIN/fleet/agents/coder-brain.env.generated" ] || fail "brain generated env vanished"
 # Negative control: the SAME default-config-home shape but without
 # ~/.mosaic/fleet/agents — the config-home env tree is used directly (legacy).
 : > "$TMUX_CALLS"
 HOME_NOBRAIN="$ROOT/brainless-home"
 CONFIG_HOME_NOBRAIN="$HOME_NOBRAIN/.config/mosaic"
 write_generated "$CONFIG_HOME_NOBRAIN" "coder-legacy"
 install_pane_binaries "$HOME_NOBRAIN"
 HOME="$HOME_NOBRAIN" PATH="$FAKE_BIN:$PATH" MOSAIC_TEST_TMUX_CALLS="$TMUX_CALLS" \
  MOSAIC_TEST_PANE_PID=$$ MOSAIC_TEST_HOME="$HOME_NOBRAIN" \
  MOSAIC_TEST_FLEET_OWNER=123e4567-e89b-12d3-a456-426614174000 \
  MOSAIC_HOME="$CONFIG_HOME_NOBRAIN" "$START" coder-legacy
 legacy_args=$(tr '\0' '\n' < "$TMUX_CALLS")
 echo "$legacy_args" | grep -qF new-session || fail "legacy single-tree launch regressed"
 # The pane must start through an absolute clean-environment boundary. Its
 # runtime command remains an argv vector, but no holder/session environment
 # control variable can pass through the pane command.
@@ -39,20 +39,3 @@ packages/mosaic/framework/tools/tmux/test-send-message-verdict.sh | requires rea
 # recorded judgement. These lines ARE that judgement, signed.)
 packages/mosaic/framework/tools/orchestrator/smoke-test.sh | behavior smoke checks for coord continue/run workflows, run manually by orchestrator seats; unmeasured in CI; #1017 burndown
 packages/mosaic/framework/tools/wake/validate-973/microtest-wake-assert.sh | #973 instrument self-test, run as a precondition of the validate-973 evidence procedure rather than as a standing CI suite; #1017 burndown candidate
 # --- tools/fleet: precondition is unsatisfiable in the CI image (#1271) ---
 # Signed by fred (sb-it-1-dt, 2026-08-16) at origin/next 476db12.
 # This suite asserts the launcher's behaviour when `mosaic` and `pi` are MISSING.
 # It shims fakes into $FAKE_BIN, but the constructed PANE_PATH always ends in the
 # real system path, so on a host that installs those binaries the missing-binary
 # cases cannot be measured at all. The suite's own guard (line 103) says so and
 # fails rather than reporting a pass it cannot back. That guard is correct.
 # The error was wiring the suite into CI: #1017 (c56483eb) enumerated it and
 # dropped this exclusion, and the CI image provides `pi` in the system path, so
 # it has failed on every pipeline since. Measured 2026-08-16 across pipelines
 # 2444 (#1256), 2438 (#1240) and 2441 (#1017-quality): exactly one FAIL line in
 # each full log, identical, this assertion; control `zzz-not-present-zzz` -> 0.
 # Burn-down and the full measurement are tracked in #1271; unwired by PR #1270.
 # Because test:framework-shell is one && chain and this sat at position 44 of 48,
 # the four suites after it had not run at all since the merge.
 packages/mosaic/framework/tools/fleet/test-start-agent-session.sh | precondition unsatisfiable in the CI image: asserts missing-binary behaviour, but PANE_PATH always ends in the system path and the image provides `pi` there; guard at line 103 fails by design rather than passing unmeasured. Burn down by controlling the tail of PANE_PATH inside the test. NOT by removing `pi` from the image: the CI image installs @earendil-works/[email protected] deliberately (measured in pipeline 2444's test-step log), and other suites depend on that pin. Burn-down tracked in #1271
@@ -25,7 +25,7 @@
    "lint": "eslint src",
    "typecheck": "tsc --noEmit",
    "test": "vitest run --passWithNoTests && pnpm run test:framework-shell",
-    "test:framework-shell": "bash framework/tools/quality/scripts/check-test-enumeration.sh && bash framework/tools/quality/scripts/test-check-test-enumeration.sh && python3 src/lease-broker/daemon_deadline_unittest.py && python3 src/lease-broker/normative_fragments_unittest.py && python3 src/lease-broker/promotion_binding_unittest.py && python3 src/lease-broker/promotion_trigger_unittest.py && python3 src/lease-broker/receipt_challenge_unittest.py && python3 src/lease-broker/context_recovery_unittest.py && python3 src/lease-broker/recovery_runtime_unittest.py && python3 src/lease-broker/recovery_b1_adversarial_unittest.py && python3 src/lease-broker/receipt_observer_client_unittest.py && python3 src/lease-broker/invariant_r_unittest.py && python3 src/lease-broker/framework_skill_portability_unittest.py && python3 src/mutator-gate/runtime_tools_unittest.py && python3 src/mutator-gate/runtime_launch_guard_unittest.py && python3 src/mutator-gate/version_coupling_unittest.py && python3 framework/tools/lease-broker/check-runtime-launches.py --root ../.. && bash framework/tools/codex/test-pr-diff-context.sh && bash framework/tools/qa/test-deps-preflight.sh && bash framework/tools/git/test-pr-review-gitea-comment.sh && bash framework/tools/git/test-pr-review-repo-host-override.sh && bash framework/tools/git/test-ci-queue-wait-branch-absent.sh && bash framework/tools/git/test-ci-queue-wait-tristate.sh && bash framework/tools/git/test-ci-queue-wait-github-checks.sh && bash framework/tools/git/test-pr-merge-queue-branch.sh && bash framework/tools/git/test-pr-merge-head-pin.sh && bash framework/tools/git/test-pr-merge-message-field.sh && bash framework/tools/git/test-git-credential-mosaic.sh && bash framework/tools/git/test-gitea-token-identity.sh && bash framework/tools/woodpecker/test-terminal-green-contract.sh && bash framework/tools/_scripts/test-install-ordering-guard.sh && bash framework/tools/_scripts/test-mosaic-init-rce.sh && bash framework/tools/tmux/agent-send.test.sh && bash framework/tools/wake/test-wake-store-ack.sh && bash framework/tools/wake/test-wake-store-enqueue-race.sh && bash framework/tools/wake/test-wake-digest-hmac.sh && bash framework/tools/wake/test-wake-digest-quarantine.sh && bash framework/tools/wake/test-wake-detector.sh && bash framework/tools/wake/test-wake-fn-oracle.sh && bash framework/tools/wake/test-wake-reconcile.sh && bash framework/tools/wake/test-wake-beacon.sh && bash framework/tools/wake/test-wake-preimage.sh && bash framework/tools/wake/test-wake-install.sh && bash framework/tools/glpi/test-list-http-status.sh && bash framework/tools/orchestrator/test-board-roll.sh && bash framework/tools/woodpecker/test-ci-wait-exit-matrix.sh && bash framework/tools/_scripts/test-fleet-transport-check.sh"
+    "test:framework-shell": "bash framework/tools/quality/scripts/check-test-enumeration.sh && bash framework/tools/quality/scripts/test-check-test-enumeration.sh && python3 src/lease-broker/daemon_deadline_unittest.py && python3 src/lease-broker/normative_fragments_unittest.py && python3 src/lease-broker/promotion_binding_unittest.py && python3 src/lease-broker/promotion_trigger_unittest.py && python3 src/lease-broker/receipt_challenge_unittest.py && python3 src/lease-broker/context_recovery_unittest.py && python3 src/lease-broker/recovery_runtime_unittest.py && python3 src/lease-broker/recovery_b1_adversarial_unittest.py && python3 src/lease-broker/receipt_observer_client_unittest.py && python3 src/lease-broker/invariant_r_unittest.py && python3 src/lease-broker/framework_skill_portability_unittest.py && python3 src/mutator-gate/runtime_tools_unittest.py && python3 src/mutator-gate/runtime_launch_guard_unittest.py && python3 src/mutator-gate/version_coupling_unittest.py && python3 framework/tools/lease-broker/check-runtime-launches.py --root ../.. && bash framework/tools/codex/test-pr-diff-context.sh && bash framework/tools/qa/test-deps-preflight.sh && bash framework/tools/git/test-pr-review-gitea-comment.sh && bash framework/tools/git/test-pr-review-repo-host-override.sh && bash framework/tools/git/test-ci-queue-wait-branch-absent.sh && bash framework/tools/git/test-ci-queue-wait-tristate.sh && bash framework/tools/git/test-ci-queue-wait-github-checks.sh && bash framework/tools/git/test-pr-merge-queue-branch.sh && bash framework/tools/git/test-pr-merge-head-pin.sh && bash framework/tools/git/test-pr-merge-message-field.sh && bash framework/tools/git/test-git-credential-mosaic.sh && bash framework/tools/git/test-gitea-token-identity.sh && bash framework/tools/woodpecker/test-terminal-green-contract.sh && bash framework/tools/_scripts/test-install-ordering-guard.sh && bash framework/tools/_scripts/test-mosaic-init-rce.sh && bash framework/tools/tmux/agent-send.test.sh && bash framework/tools/wake/test-wake-store-ack.sh && bash framework/tools/wake/test-wake-store-enqueue-race.sh && bash framework/tools/wake/test-wake-digest-hmac.sh && bash framework/tools/wake/test-wake-digest-quarantine.sh && bash framework/tools/wake/test-wake-detector.sh && bash framework/tools/wake/test-wake-fn-oracle.sh && bash framework/tools/wake/test-wake-reconcile.sh && bash framework/tools/wake/test-wake-beacon.sh && bash framework/tools/wake/test-wake-preimage.sh && bash framework/tools/wake/test-wake-install.sh && bash framework/tools/fleet/test-start-agent-session.sh && bash framework/tools/glpi/test-list-http-status.sh && bash framework/tools/orchestrator/test-board-roll.sh && bash framework/tools/woodpecker/test-ci-wait-exit-matrix.sh && bash framework/tools/_scripts/test-fleet-transport-check.sh"
  },
  "dependencies": {
    "@mosaicstack/brain": "workspace:*",
@@ -20,6 +20,7 @@ import { registerMissionCommand } from './commands/mission.js';
 import { registerUninstallCommand } from './commands/uninstall.js';
 import { registerRestoreCommand } from './commands/restore.js';
 import { registerSkillCommand } from './commands/skill.js';
 import { registerStoreCommand } from './commands/store.js';
 // prdy is registered via launch.ts
 import { registerLaunchCommands } from './commands/launch.js';
 import { registerLeaseCapabilityProbe } from './commands/lease-activation-probe.js';
@@ -425,6 +426,10 @@ registerRestoreCommand(program);
 registerSkillCommand(program);
 // ─── store ───────────────────────────────────────────────────────────────────
 registerStoreCommand(program);
 // ─── telemetry ───────────────────────────────────────────────────────────────
 registerTelemetryCommand(program);
@@ -1,6 +1,5 @@
 import { readFile } from 'node:fs/promises';
 import { join, resolve } from 'node:path';
 import { fleetAgentEnvDir, fleetRolesLocalDir } from '../fleet/brain-home.js';
 import type { Command } from 'commander';
 import {
  executeFleetAgentMutation,
@@ -150,9 +149,9 @@ async function executeCommand(
    request,
    mosaicHome,
    rosterPath,
-    agentEnvDir: fleetAgentEnvDir(mosaicHome),
+    agentEnvDir: join(mosaicHome, 'fleet', 'agents'),
    rolesDir: join(mosaicHome, 'fleet', 'roles'),
-    overrideDir: fleetRolesLocalDir(mosaicHome),
+    overrideDir: join(mosaicHome, 'fleet', 'roles.local'),
    dryRun: forceDryRun || opts.dryRun === true,
    ...(deps.projectionApplier === undefined ? {} : { projectionApplier: deps.projectionApplier }),
  });
@@ -1,6 +1,5 @@
 import { readFile } from 'node:fs/promises';
 import { join } from 'node:path';
 import { fleetAgentEnvDir, fleetRolesLocalDir } from '../fleet/brain-home.js';
 import type { Command } from 'commander';
 import {
  parseV1MigrationObservations,
@@ -121,11 +120,11 @@ export function registerFleetMigrationCommand(
          observations,
          personaDirs: {
            rolesDir: deps.rolesDir ?? join(mosaicHome, 'fleet', 'roles'),
-            overrideDir: deps.overrideDir ?? fleetRolesLocalDir(mosaicHome),
+            overrideDir: deps.overrideDir ?? join(mosaicHome, 'fleet', 'roles.local'),
          },
          environment: {
            mosaicHome,
-            agentEnvDir: fleetAgentEnvDir(mosaicHome),
+            agentEnvDir: join(mosaicHome, 'fleet', 'agents'),
          },
        });
        printJson(preview);
@@ -30,21 +30,19 @@ import { lstat, readFile, readdir, stat } from 'node:fs/promises';
 import { homedir } from 'node:os';
 import { basename, isAbsolute, join, sep } from 'node:path';
 import type { Command } from 'commander';
 import { fleetRolesLocalDir } from '../fleet/brain-home.js';
 function defaultMosaicHome(): string {
  return process.env['MOSAIC_HOME'] ?? join(homedir(), '.config', 'mosaic');
 }
-/** Baseline persona role contracts (reseeded on update; config home — framework). */
+/** Baseline persona role contracts (reseeded on update). */
 export function defaultRolesDir(mosaicHome = defaultMosaicHome()): string {
  return join(mosaicHome, 'fleet', 'roles');
 }
-/** PRESERVE-protected override layer (survives update; wins on merge).
+/** PRESERVE-protected override layer (survives update; wins on merge). */
 * Brain home (`~/.mosaic/fleet/roles.local`) when a brain is active. */
 export function defaultOverrideDir(mosaicHome = defaultMosaicHome()): string {
-  return fleetRolesLocalDir(mosaicHome);
+  return join(mosaicHome, 'fleet', 'roles.local');
 }
 /**
@@ -25,7 +25,6 @@ import { homedir } from 'node:os';
 import { basename, join } from 'node:path';
 import type { Command } from 'commander';
 import YAML from 'yaml';
 import { fleetProfilesDir } from '../fleet/brain-home.js';
 import {
  defaultOverrideDir,
  extractClassesFromDir,
@@ -37,10 +36,9 @@ function defaultMosaicHome(): string {
  return process.env['MOSAIC_HOME'] ?? join(homedir(), '.config', 'mosaic');
 }
-/** Directory holding the seeded profile yaml files — brain home when active
+/** Directory holding the seeded profile yaml files. */
 * (user working copies, committed), else the config home seed. */
 export function defaultProfilesDir(mosaicHome = defaultMosaicHome()): string {
-  return fleetProfilesDir(mosaicHome);
+  return join(mosaicHome, 'fleet', 'profiles');
 }
 /** Directory holding the persona role contracts. */
@@ -3,7 +3,6 @@ import { homedir } from 'node:os';
 import { join, relative, resolve } from 'node:path';
 import type { Command } from 'commander';
 import type { CommandRunner } from './fleet.js';
 import { fleetAgentEnvDir } from '../fleet/brain-home.js';
 import {
  applyPreparedGeneratedAgentEnvironmentProjection,
  prepareGeneratedAgentEnvironmentProjection,
@@ -154,7 +153,7 @@ export async function executeFleetRegen(
  options: FleetRegenOptions,
 ): Promise<FleetRegenResult> {
  const mosaicHome = defaultMosaicHome(deps);
-  const agentEnvDir = fleetAgentEnvDir(mosaicHome);
+  const agentEnvDir = join(mosaicHome, 'fleet', 'agents');
  const rosterPath = join(mosaicHome, 'fleet', 'roster.yaml');
  const readRoster = deps.readRoster ?? defaultReadRoster(deps, mosaicHome);
  const prepare = deps.prepareProjection ?? prepareGeneratedAgentEnvironmentProjection;
@@ -13,7 +13,6 @@ import {
 import { randomUUID } from 'node:crypto';
 import { homedir, hostname, userInfo } from 'node:os';
 import { dirname, join, resolve } from 'node:path';
 import { fleetAgentEnvDir } from '../fleet/brain-home.js';
 import { fileURLToPath } from 'node:url';
 import { spawn } from 'node:child_process';
 import * as readline from 'node:readline';
@@ -159,7 +158,7 @@ export function resolveFleetPaths(mosaicHome = defaultMosaicHome()): FleetPaths
    fleetToolsDir: join(mosaicHome, 'tools', 'fleet'),
    tmuxToolsDir: join(mosaicHome, 'tools', 'tmux'),
    systemdUserDir: join(homedir(), '.config', 'systemd', 'user'),
-    agentEnvDir: fleetAgentEnvDir(mosaicHome),
+    agentEnvDir: join(mosaicHome, 'fleet', 'agents'),
  };
 }
@@ -349,90 +349,3 @@ describe('registerRuntimeLaunchers — claudex (EXPERIMENTAL overlay)', () => {
    expect(mockExit).not.toHaveBeenCalled();
  });
 });
 // ─── Seat harness homes (MOSAIC-D-002, brain-home split) ────────────────────
 import { activeSeatDir, seatPersonaOverlay } from './launch.js';
 describe('activeSeatDir — per-agent harness home resolution', () => {
  let root: string;
  const savedAgentName = process.env['MOSAIC_AGENT_NAME'];
  const savedBrainHome = process.env['MOSAIC_BRAIN_HOME'];
  beforeEach(() => {
    root = mkdtempSync(join(tmpdir(), 'mosaic-seat-home-'));
    delete process.env['MOSAIC_BRAIN_HOME'];
  });
  afterEach(() => {
    rmSync(root, { recursive: true, force: true });
    if (savedAgentName === undefined) {
      delete process.env['MOSAIC_AGENT_NAME'];
    } else {
      process.env['MOSAIC_AGENT_NAME'] = savedAgentName;
    }
    if (savedBrainHome !== undefined) {
      process.env['MOSAIC_BRAIN_HOME'] = savedBrainHome;
    } else {
      delete process.env['MOSAIC_BRAIN_HOME'];
    }
  });
  it('resolves the seat dir when MOSAIC_BRAIN_HOME carries the seat', () => {
    const seat = join(root, 'brain', 'fleet', 'agents', 'coder0');
    mkdirSync(seat, { recursive: true });
    process.env['MOSAIC_AGENT_NAME'] = 'coder0';
    process.env['MOSAIC_BRAIN_HOME'] = join(root, 'brain');
    expect(activeSeatDir(join(root, 'config', 'mosaic'))).toBe(seat);
  });
  it('returns undefined without an agent name (bare launches stay shared)', () => {
    delete process.env['MOSAIC_AGENT_NAME'];
    expect(activeSeatDir(join(root, 'config', 'mosaic'))).toBeUndefined();
  });
  it('returns undefined when the seat dir does not exist in the brain', () => {
    process.env['MOSAIC_AGENT_NAME'] = 'ghost';
    process.env['MOSAIC_BRAIN_HOME'] = join(root, 'brain');
    mkdirSync(join(root, 'brain', 'fleet', 'agents'), { recursive: true });
    expect(activeSeatDir(join(root, 'config', 'mosaic'))).toBeUndefined();
  });
  it.each(['../escape', 'a/b', '.hidden-start', '', 'spaced name'])(
    'rejects unsafe agent name %j (path traversal cannot leave the seat store)',
    (name: string) => {
      process.env['MOSAIC_AGENT_NAME'] = name;
      process.env['MOSAIC_BRAIN_HOME'] = join(root, 'brain');
      expect(activeSeatDir(join(root, 'config', 'mosaic'))).toBeUndefined();
    },
  );
  it('seatPersonaOverlay renders the seat SOUL.md as an overlay block', () => {
    const seat = join(root, 'brain', 'fleet', 'agents', 'coder0');
    mkdirSync(seat, { recursive: true });
    writeFileSync(join(seat, 'SOUL.md'), '# coder0 — code seat persona\n\nShips tested code.\n');
    process.env['MOSAIC_AGENT_NAME'] = 'coder0';
    process.env['MOSAIC_BRAIN_HOME'] = join(root, 'brain');
    const overlay = seatPersonaOverlay(join(root, 'config', 'mosaic'));
    expect(overlay).toContain('## Seat Persona');
    expect(overlay).toContain('coder0 — code seat persona');
  });
  it('seatPersonaOverlay is empty when the seat carries no SOUL.md', () => {
    const seat = join(root, 'brain', 'fleet', 'agents', 'coder0');
    mkdirSync(seat, { recursive: true });
    process.env['MOSAIC_AGENT_NAME'] = 'coder0';
    process.env['MOSAIC_BRAIN_HOME'] = join(root, 'brain');
    expect(seatPersonaOverlay(join(root, 'config', 'mosaic'))).toBe('');
  });
  it('seatPersonaOverlay is empty when no agent name is set', () => {
    delete process.env['MOSAIC_AGENT_NAME'];
    expect(seatPersonaOverlay(join(root, 'config', 'mosaic'))).toBe('');
  });
 });
@@ -19,7 +19,7 @@ import {
 import { createHash, randomBytes } from 'node:crypto';
 import { createRequire } from 'node:module';
 import { homedir, hostname } from 'node:os';
-import { join, dirname, resolve } from 'node:path';
+import { join, dirname } from 'node:path';
 import type { Command } from 'commander';
 import {
  buildResolvedFleetCommsBlock,
@@ -29,7 +29,6 @@ import {
 import { readRegularFileSecure } from '../fleet/secure-file.js';
 import { readPersonaContractBlock } from '../fleet/persona-contract.js';
 import { canonicalizeRoleClass } from './fleet-personas.js';
 import { resolveBrainHome } from '../fleet/brain-home.js';
 import { launchClaudex, type ClaudexHarnessAdapter } from './claudex.js';
 import { runLeaseEnforcementDoctorCheck } from './lease-doctor-check.js';
@@ -65,46 +64,9 @@ const HARNESS_HOME_ENV: Record<RuntimeName, string> = {
  opencode: 'XDG_CONFIG_HOME',
 };
-/** Dedicated mosaic-owned home for a runtime: ~/.config/mosaic/.<runtime>.
+/** Dedicated mosaic-owned home for a runtime: ~/.config/mosaic/.<runtime> */
- * With an active brain seat (MOSAIC_AGENT_NAME + seat dir in the brain home)
+function harnessHome(runtime: RuntimeName): string {
- * the home is per-agent instead: <brainHome>/fleet/agents/<seat>/.<runtime> —
+  return join(MOSAIC_HOME, `.${runtime}`);
 * per-agent sessions, settings, and auth inside the seat dir (canon §2,
 * MOSAIC-D-002). Seat runtime dirs are dot-named so the brain's ignore policy
 * (per-seat .pi/.claude/.codex dirs) keeps credential material untracked. */
 const SEAT_AGENT_NAME_RE = /^[a-zA-Z0-9][a-zA-Z0-9._-]*$/;
 export function activeSeatDir(mosaicHome: string = MOSAIC_HOME): string | undefined {
  const agent = process.env['MOSAIC_AGENT_NAME']?.trim();
  if (
    agent === undefined ||
    agent === '' ||
    !SEAT_AGENT_NAME_RE.test(agent) ||
    agent.includes('..')
  ) {
    return undefined;
  }
  const brain = resolveBrainHome(mosaicHome);
  if (resolve(brain) === resolve(mosaicHome)) return undefined; // no brain
  const seat = join(brain, 'fleet', 'agents', agent);
  return existsSync(seat) ? seat : undefined;
 }
 function harnessHome(runtime: RuntimeName, mosaicHome: string = MOSAIC_HOME): string {
  const seat = activeSeatDir(mosaicHome);
  if (seat !== undefined) return join(seat, `.${runtime}`);
  return join(mosaicHome, `.${runtime}`);
 }
 /** Seat persona block: with an active brain seat, <seat>/SOUL.md layers
 * persona on the root generic base (canon invariant; MOSAIC-D-002). The base
 * SOUL stays load-on-demand — only the seat delta is injected by value.
 * Empty string when no seat is active or the seat carries no SOUL.md. */
 export function seatPersonaOverlay(mosaicHome: string = MOSAIC_HOME): string {
  const seatDir = activeSeatDir(mosaicHome);
  if (seatDir === undefined) return '';
  const seatSoul = readOptional(join(seatDir, 'SOUL.md'));
  if (!seatSoul.trim()) return '';
  return '## Seat Persona\n\n' + seatSoul.trim();
 }
 /**
@@ -220,8 +182,6 @@ function recordLaunch(runtime: RuntimeName, cliArgs: string[], yolo: boolean): v
      cli_version: CLI_VERSION,
      config_home: harnessHome(runtime),
      config_home_isolated: true,
      config_home_kind: activeSeatDir() !== undefined ? 'seat' : 'runtime-shared',
      agent_name: process.env['MOSAIC_AGENT_NAME']?.trim() || null,
      config_home_env: HARNESS_HOME_ENV[runtime] ?? null,
      argv: redactArgv(cliArgs),
      normative_fragments: normativeFragmentDigests(runtime),
@@ -609,11 +569,6 @@ For required push/merge/issue-close/release actions, execute without routine con
  if (soulLocal.trim()) {
    overlayBlocks.push('## Persona Overlay (SOUL.local.md)\n\n' + soulLocal.trim());
  }
  // Seat persona (MOSAIC-D-002): per-seat SOUL.md layers on the generic base.
  const seatPersona = seatPersonaOverlay(mosaicHome);
  if (seatPersona !== '') {
    overlayBlocks.push(seatPersona);
  }
  const standardsLocal = readOptional(join(mosaicHome, 'STANDARDS.local.md'));
  if (standardsLocal.trim()) {
    overlayBlocks.push('## Standards Overlay (STANDARDS.local.md)\n\n' + standardsLocal.trim());
@@ -0,0 +1,458 @@
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
 import { Command } from 'commander';
 import {
  existsSync,
  lstatSync,
  mkdirSync,
  mkdtempSync,
  readFileSync,
  readdirSync,
  rmSync,
  symlinkSync,
  writeFileSync,
 } from 'node:fs';
 import { tmpdir } from 'node:os';
 import { join } from 'node:path';
 import {
  addStoreEntry,
  getDefaultStorePaths,
  listStoreEntries,
  registerStoreCommand,
  StoreError,
  storeKindDir,
  validateStoreKind,
  validateStoreName,
  validateStoreVersion,
  type StorePaths,
 } from './store.js';
 /** Assert a typed StoreError with exactly the expected code. */
 function expectStoreError(run: () => unknown, code: string): void {
  try {
    run();
  } catch (error) {
    expect(error).toBeInstanceOf(StoreError);
    expect((error as StoreError).code).toBe(code);
    return;
  }
  throw new Error(`expected StoreError ${code}, but nothing threw`);
 }
 describe('vetted user store (W-F4)', () => {
  let root: string;
  let paths: StorePaths;
  let sourceRoot: string;
  beforeEach(() => {
    root = mkdtempSync(join(tmpdir(), 'mosaic-store-cli-'));
    paths = { userRoot: join(root, '.mosaic') };
    sourceRoot = join(root, 'sources');
    mkdirSync(sourceRoot, { recursive: true });
  });
  afterEach(() => {
    rmSync(root, { recursive: true, force: true });
  });
  function createSource(name: string): string {
    const dir = join(sourceRoot, name);
    mkdirSync(dir, { recursive: true });
    writeFileSync(join(dir, 'SKILL.md'), `# ${name}\n`);
    return dir;
  }
  describe('name and version validation (before any filesystem call)', () => {
    const invalidNames = [
      '../../etc',
      '/abs/path',
      'a/b',
      String.raw`a\b`,
      '-rf',
      '..',
      'safe.',
      'space name',
      'line\nbreak',
      'escape\u001B[31m',
    ];
    for (const name of invalidNames) {
      it(`rejects name ${JSON.stringify(name)}`, () => {
        expect(() => validateStoreName(name)).toThrow(StoreError);
      });
    }
    const invalidVersions = ['', '-1', '1..0', 'a/b', '..', '1.0 beta', '/x'];
    for (const version of invalidVersions) {
      it(`rejects version ${JSON.stringify(version)}`, () => {
        expect(() => validateStoreVersion(version)).toThrow(StoreError);
      });
    }
    it('accepts semver-shaped versions including prerelease and build metadata', () => {
      expect(() => validateStoreVersion('0.1.0-beta.1')).not.toThrow();
      expect(() => validateStoreVersion('1.2.3+build.7')).not.toThrow();
    });
    it('rejects plural and unknown kinds', () => {
      expectStoreError(() => validateStoreKind('plugins'), 'STORE_INVALID_KIND');
      expectStoreError(() => validateStoreKind('widget'), 'STORE_INVALID_KIND');
    });
    it('accepts the two spec kinds', () => {
      expect(() => validateStoreKind('plugin')).not.toThrow();
      expect(() => validateStoreKind('skill')).not.toThrow();
    });
  });
  describe('addStoreEntry', () => {
    it('copies content into a versioned directory and writes the marker last', () => {
      const result = addStoreEntry(
        'skill',
        'demo',
        '1.0.0',
        createSource('demo'),
        'op',
        undefined,
        paths,
      );
      expect(result.status).toBe('added');
      const entryPath = join(paths.userRoot, 'skills', 'demo', '1.0.0');
      expect(result.entryPath).toBe(entryPath);
      expect(existsSync(join(entryPath, 'SKILL.md'))).toBe(true);
      expect(existsSync(join(entryPath, 'store-entry.json'))).toBe(true);
      const meta = JSON.parse(readFileSync(join(entryPath, 'store-entry.json'), 'utf-8'));
      expect(meta).toMatchObject({
        schema: 1,
        kind: 'skill',
        name: 'demo',
        version: '1.0.0',
        vettedBy: 'op',
      });
      expect(typeof meta['vettedAt']).toBe('string');
    });
    it('writes plugins under plugins/ and skills under skills/', () => {
      addStoreEntry('plugin', 'alpha', '0.1.0', createSource('alpha'), 'op', undefined, paths);
      addStoreEntry('skill', 'beta', '2.0.0', createSource('beta'), 'op', undefined, paths);
      expect(existsSync(join(paths.userRoot, 'plugins', 'alpha', '0.1.0'))).toBe(true);
      expect(existsSync(join(paths.userRoot, 'skills', 'beta', '2.0.0'))).toBe(true);
    });
    it('is append-only: an existing version with a marker is refused, not overwritten', () => {
      const sourceA = createSource('demo');
      const sourceB = join(sourceRoot, 'demo-other');
      mkdirSync(sourceB, { recursive: true });
      writeFileSync(join(sourceB, 'SKILL.md'), '# changed\n');
      addStoreEntry('skill', 'demo', '1.0.0', sourceA, 'op', undefined, paths);
      expectStoreError(
        () => addStoreEntry('skill', 'demo', '1.0.0', sourceB, 'op', undefined, paths),
        'STORE_ALREADY_PRESENT',
      );
      expect(
        readFileSync(join(paths.userRoot, 'skills', 'demo', '1.0.0', 'SKILL.md'), 'utf-8'),
      ).toBe('# demo\n');
    });
    it('allows a second version alongside the first', () => {
      addStoreEntry('skill', 'demo', '1.0.0', createSource('demo'), 'op', undefined, paths);
      const result = addStoreEntry(
        'skill',
        'demo',
        '1.1.0',
        createSource('demo'),
        'op',
        undefined,
        paths,
      );
      expect(result.status).toBe('added');
      expect(readdirSync(join(paths.userRoot, 'skills', 'demo')).sort()).toEqual([
        '1.0.0',
        '1.1.0',
      ]);
    });
    it('refuses an unmarked target directory by default and preserves its content', () => {
      const unmarked = join(paths.userRoot, 'skills', 'demo', '1.0.0');
      mkdirSync(unmarked, { recursive: true });
      writeFileSync(join(unmarked, 'SKILL.md'), '# operator content\n');
      expectStoreError(
        () => addStoreEntry('skill', 'demo', '1.0.0', createSource('demo'), 'op', undefined, paths),
        'STORE_TARGET_UNMARKED',
      );
      // The operator's hand-placed content survives the refusal.
      expect(readFileSync(join(unmarked, 'SKILL.md'), 'utf-8')).toBe('# operator content\n');
    });
    it('reclaims an unmarked target only under explicit reclaim opt-in', () => {
      const unmarked = join(paths.userRoot, 'skills', 'demo', '1.0.0');
      mkdirSync(unmarked, { recursive: true });
      writeFileSync(join(unmarked, 'SKILL.md'), '# torn write\n');
      const result = addStoreEntry(
        'skill',
        'demo',
        '1.0.0',
        createSource('demo'),
        'op',
        undefined,
        paths,
        { reclaim: true },
      );
      expect(result.status).toBe('reclaimed-unmarked');
      expect(readFileSync(join(unmarked, 'SKILL.md'), 'utf-8')).toBe('# demo\n');
    });
    it('reclaim can never destroy a marked, vetted entry (append-only holds under --reclaim)', () => {
      addStoreEntry('skill', 'demo', '1.0.0', createSource('demo'), 'op', undefined, paths);
      const marked = join(paths.userRoot, 'skills', 'demo', '1.0.0');
      const vettedContent = readFileSync(join(marked, 'SKILL.md'), 'utf-8');
      expectStoreError(
        () =>
          addStoreEntry('skill', 'demo', '1.0.0', createSource('demo'), 'op', undefined, paths, {
            reclaim: true,
          }),
        'STORE_ALREADY_PRESENT',
      );
      // Load-bearing half: the throw alone does not prove nothing was deleted
      // before it. Pins the marker-check-before-reclaim-check ordering against
      // the guard-clause-migrates-upward refactor (review finding on b2124c6).
      expect(readFileSync(join(marked, 'SKILL.md'), 'utf-8')).toBe(vettedContent);
      expect(existsSync(join(marked, 'store-entry.json'))).toBe(true);
    });
    it('refuses a missing source with a typed error', () => {
      expectStoreError(
        () =>
          addStoreEntry('skill', 'demo', '1.0.0', join(sourceRoot, 'nope'), 'op', undefined, paths),
        'STORE_SOURCE_MISSING',
      );
    });
    it('refuses a file (non-directory) source with a typed error', () => {
      const filePath = join(sourceRoot, 'file.txt');
      writeFileSync(filePath, 'x');
      expectStoreError(
        () => addStoreEntry('skill', 'demo', '1.0.0', filePath, 'op', undefined, paths),
        'STORE_SOURCE_NOT_DIR',
      );
    });
    it('refuses a symlinked source with a typed error and writes nothing', () => {
      const real = createSource('demo');
      const link = join(sourceRoot, 'demo-link');
      symlinkSync(real, link);
      expectStoreError(
        () => addStoreEntry('skill', 'demo', '1.0.0', link, 'op', undefined, paths),
        'STORE_SOURCE_SYMLINK',
      );
      expect(existsSync(join(paths.userRoot, 'skills', 'demo'))).toBe(false);
    });
    it('refuses a source tree containing nested symlinks and writes nothing', () => {
      const src = createSource('demo');
      const target = join(sourceRoot, 'elsewhere');
      mkdirSync(target, { recursive: true });
      symlinkSync(target, join(src, 'escape'));
      expectStoreError(
        () => addStoreEntry('skill', 'demo', '1.0.0', src, 'op', undefined, paths),
        'STORE_SOURCE_SYMLINK',
      );
      expect(existsSync(join(paths.userRoot, 'skills', 'demo'))).toBe(false);
    });
    it('refuses adding from inside the store itself', () => {
      const first = addStoreEntry(
        'skill',
        'demo',
        '1.0.0',
        createSource('demo'),
        'op',
        undefined,
        paths,
      );
      expectStoreError(
        () => addStoreEntry('skill', 'copy', '1.0.0', first.entryPath, 'op', undefined, paths),
        'STORE_SOURCE_INSIDE_STORE',
      );
    });
    it('refuses a symlinked user root ancestor', () => {
      const linkedRoot = join(sourceRoot, 'linked-mosaic');
      symlinkSync(paths.userRoot, linkedRoot);
      expectStoreError(
        () =>
          addStoreEntry('skill', 'demo', '1.0.0', createSource('demo'), 'op', undefined, {
            userRoot: linkedRoot,
          }),
        'STORE_SYMLINK_ROOT',
      );
    });
    it('requires a non-empty vetting attribution', () => {
      expectStoreError(
        () => addStoreEntry('skill', 'demo', '1.0.0', createSource('demo'), '  ', undefined, paths),
        'STORE_INVALID_VETTER',
      );
    });
  });
  describe('listStoreEntries', () => {
    it('returns empty for an absent store without creating it', () => {
      expect(listStoreEntries(paths)).toEqual([]);
      expect(existsSync(paths.userRoot)).toBe(false);
    });
    it('lists entries deterministically with vetting metadata', () => {
      addStoreEntry('plugin', 'alpha', '0.1.0', createSource('alpha'), 'fred', undefined, paths);
      addStoreEntry('skill', 'beta', '2.0.0', createSource('beta'), 'fargo', 'looked fine', paths);
      addStoreEntry('skill', 'beta', '2.1.0', createSource('beta'), 'fargo', undefined, paths);
      const entries = listStoreEntries(paths);
      expect(entries.map((e) => `${e.kind}:${e.name}:${e.version}`)).toEqual([
        'plugin:alpha:0.1.0',
        'skill:beta:2.0.0',
        'skill:beta:2.1.0',
      ]);
      expect(entries[0]?.meta?.vettedBy).toBe('fred');
      expect(entries[1]?.meta?.notes).toBe('looked fine');
    });
    it('classifies markerless version directories as incomplete', () => {
      addStoreEntry('skill', 'demo', '1.0.0', createSource('demo'), 'op', undefined, paths);
      mkdirSync(join(paths.userRoot, 'skills', 'demo', '2.0.0'), { recursive: true });
      const entries = listStoreEntries(paths, { kind: 'skill', name: 'demo' });
      expect(entries.find((e) => e.version === '1.0.0')?.status).toBe('vetted');
      expect(entries.find((e) => e.version === '2.0.0')?.status).toBe('incomplete');
    });
    it('classifies malformed marker JSON as invalid-metadata, not vetted', () => {
      addStoreEntry('skill', 'demo', '1.0.0', createSource('demo'), 'op', undefined, paths);
      writeFileSync(
        join(paths.userRoot, 'skills', 'demo', '1.0.0', 'store-entry.json'),
        '{not json',
      );
      const entries = listStoreEntries(paths);
      expect(entries[0]?.status).toBe('invalid-metadata');
    });
    it('surfaces foreign files (never mutates them)', () => {
      mkdirSync(join(paths.userRoot, 'skills'), { recursive: true });
      writeFileSync(join(paths.userRoot, 'skills', 'stray.txt'), 'x');
      const entries = listStoreEntries(paths);
      expect(entries[0]?.status).toBe('foreign');
      expect(existsSync(join(paths.userRoot, 'skills', 'stray.txt'))).toBe(true);
    });
    it('filters by kind and name', () => {
      addStoreEntry('plugin', 'alpha', '0.1.0', createSource('alpha'), 'op', undefined, paths);
      addStoreEntry('skill', 'beta', '1.0.0', createSource('beta'), 'op', undefined, paths);
      expect(listStoreEntries(paths, { kind: 'plugin' }).map((e) => e.name)).toEqual(['alpha']);
      expect(listStoreEntries(paths, { name: 'beta' }).map((e) => e.name)).toEqual(['beta']);
      expect(() => listStoreEntries(paths, { name: '../escape' })).toThrow(StoreError);
    });
  });
  describe('default paths seam', () => {
    it('honors MOSAIC_USER_HOME', () => {
      const previous = process.env['MOSAIC_USER_HOME'];
      try {
        process.env['MOSAIC_USER_HOME'] = join(root, 'custom-user-home');
        expect(getDefaultStorePaths().userRoot).toBe(join(root, 'custom-user-home'));
        expect(storeKindDir('plugin')).toBe(join(root, 'custom-user-home', 'plugins'));
      } finally {
        if (previous === undefined) delete process.env['MOSAIC_USER_HOME'];
        else process.env['MOSAIC_USER_HOME'] = previous;
      }
    });
  });
  describe('CLI', () => {
    let previousExitCode: string | number | null | undefined;
    beforeEach(() => {
      previousExitCode = process.exitCode;
      process.exitCode = undefined;
    });
    afterEach(() => {
      process.exitCode = previousExitCode;
    });
    const parse = (args: string[]) => {
      const program = new Command().exitOverride();
      registerStoreCommand(program, paths);
      return program.parseAsync(['node', 'mosaic', 'store', ...args]);
    };
    it('registers on the parent program and renders help', () => {
      const program = new Command().exitOverride();
      registerStoreCommand(program, paths);
      const cmd = program.commands.find((c) => c.name() === 'store');
      expect(cmd).toBeDefined();
      expect(() => cmd?.helpInformation()).not.toThrow();
    });
    it('add exits nonzero with a typed code for an invalid name', async () => {
      await parse([
        'add',
        'skill',
        '../../etc',
        '1.0.0',
        '--from',
        createSource('x'),
        '--by',
        'op',
      ]);
      expect(process.exitCode).toBe(1);
    });
    it('add exits nonzero when the kind is plural', async () => {
      await parse(['add', 'skills', 'demo', '1.0.0', '--from', createSource('demo'), '--by', 'op']);
      expect(process.exitCode).toBe(1);
    });
    it('add succeeds and creates the entry directory', async () => {
      await parse(['add', 'skill', 'demo', '1.0.0', '--from', createSource('demo'), '--by', 'op']);
      expect(process.exitCode).toBeUndefined();
      expect(lstatSync(join(paths.userRoot, 'skills', 'demo', '1.0.0')).isDirectory()).toBe(true);
    });
    it('add requires --by (commander requiredOption)', async () => {
      await expect(
        parse(['add', 'skill', 'demo', '1.0.0', '--from', createSource('demo')]),
      ).rejects.toThrow(/--by/);
    });
    it('add exits nonzero on an unmarked target without --reclaim, preserving content', async () => {
      const unmarked = join(paths.userRoot, 'skills', 'demo', '1.0.0');
      mkdirSync(unmarked, { recursive: true });
      writeFileSync(join(unmarked, 'SKILL.md'), '# operator\n');
      await parse(['add', 'skill', 'demo', '1.0.0', '--from', createSource('demo'), '--by', 'op']);
      expect(process.exitCode).toBe(1);
      expect(readFileSync(join(unmarked, 'SKILL.md'), 'utf-8')).toBe('# operator\n');
    });
    it('add --reclaim replaces the unmarked target and succeeds', async () => {
      const unmarked = join(paths.userRoot, 'skills', 'demo', '1.0.0');
      mkdirSync(unmarked, { recursive: true });
      writeFileSync(join(unmarked, 'SKILL.md'), '# torn\n');
      await parse([
        'add',
        'skill',
        'demo',
        '1.0.0',
        '--from',
        createSource('demo'),
        '--by',
        'op',
        '--reclaim',
      ]);
      expect(process.exitCode).toBeUndefined();
      expect(readFileSync(join(unmarked, 'SKILL.md'), 'utf-8')).toBe('# demo\n');
    });
    it('list exits 0 on an empty store', async () => {
      await parse(['list']);
      expect(process.exitCode).toBeUndefined();
    });
  });
 });
@@ -0,0 +1,544 @@
 import {
  cpSync,
  existsSync,
  lstatSync,
  mkdirSync,
  readdirSync,
  readFileSync,
  rmSync,
  writeFileSync,
  type Dirent,
  type Stats,
 } from 'node:fs';
 import { isAbsolute, join, parse, relative, resolve, sep } from 'node:path';
 import type { Command } from 'commander';
 import { DEFAULT_MOSAIC_USER_HOME } from '../constants.js';
 /**
 * `mosaic store` — the vetted user store under `~/.mosaic/{plugins,skills}` (W-F4).
 *
 * Two roots with distinct ownership (HARNESS-HOMES design, frozen REV3):
 * - `~/.config/mosaic/` is the SYSTEM root: update-owned, replaceable wholesale.
 * - `~/.mosaic/` is the USER root: never touched by installs or updates.
 *
 * This module only ever writes under the USER root. The store is the vetting
 * boundary: content lands here only through an explicit `store add` carrying a
 * named vetting attribution, and every entry is versioned
 * (`store/<kind>s/<name>/<version>/`) with a `store-entry.json` marker written
 * LAST — a version directory without its marker is never a usable entry, and
 * an unmarked target is REFUSED by default: it may be this tool's own debris
 * from an interrupted add, or content the operator placed by hand, and the
 * code cannot tell those apart — so deletion happens only under an explicit
 * `--reclaim` opt-in, and the result status names what was done.
 *
 * Deferred by design (W-F6 and later): activation/symlink-install into agent
 * homes, `current`-pointer pinning, network acquisition. `add` accepts a local
 * source path only — no network, no credentials, ever.
 */
 export type StoreKind = 'plugin' | 'skill';
 export const STORE_KINDS: readonly StoreKind[] = ['plugin', 'skill'];
 /** On-disk metadata marker; written last so its presence commits an entry. */
 export const STORE_ENTRY_MARKER = 'store-entry.json';
 export interface StorePaths {
  /** User data root, e.g. `~/.mosaic`. */
  userRoot: string;
 }
 export interface StoreEntryMeta {
  schema: 1;
  kind: StoreKind;
  name: string;
  version: string;
  /** Absolute source path the content was vetted from, as resolved at add time. */
  sourcePath: string;
  /** Operator who vouched for the content — required, non-empty. */
  vettedBy: string;
  /** ISO timestamp of the add. */
  vettedAt: string;
  /** Free-form vetting notes, if any. */
  notes?: string;
 }
 export type StoreAddStatus = 'added' | 'reclaimed-unmarked';
 export interface StoreAddResult {
  kind: StoreKind;
  name: string;
  version: string;
  status: StoreAddStatus;
  entryPath: string;
  sourcePath: string;
 }
 export type StoreEntryStatus = 'vetted' | 'incomplete' | 'invalid-metadata' | 'foreign';
 export interface StoreListEntry {
  kind: StoreKind;
  name: string;
  /** Undefined for name-level foreign files (not a directory at all). */
  version?: string;
  status: StoreEntryStatus;
  entryPath: string;
  meta?: StoreEntryMeta;
 }
 const SAFE_STORE_NAME = /^[A-Za-z0-9][A-Za-z0-9._-]*$/;
 const SAFE_STORE_VERSION = /^[A-Za-z0-9][A-Za-z0-9._+-]*$/;
 export class StoreError extends Error {
  public readonly code: string;
  public constructor(code: string, message: string) {
    super(message);
    this.name = 'StoreError';
    this.code = code;
  }
 }
 /** Resolve the user store root while keeping tests injectable. */
 export function getDefaultStorePaths(): StorePaths {
  const userRoot = process.env['MOSAIC_USER_HOME'] ?? DEFAULT_MOSAIC_USER_HOME;
  return { userRoot };
 }
 /**
 * Reject a user-supplied name before any filesystem operation.
 * A store name identifies one directory under `store/<kind>s/`.
 */
 export function validateStoreName(name: string): void {
  if (
    name.length === 0 ||
    name.startsWith('-') ||
    name.endsWith('.') ||
    name.includes('..') ||
    name.includes('/') ||
    name.includes('\\') ||
    isAbsolute(name) ||
    !SAFE_STORE_NAME.test(name)
  ) {
    throw new StoreError(
      'STORE_INVALID_NAME',
      `Invalid store name ${JSON.stringify(name)}: use letters, numbers, dots, underscores, or hyphens; start with a letter or number; and do not use paths, "..", or a leading "-".`,
    );
  }
 }
 /** Versions share the name discipline plus `+` (semver build metadata). */
 export function validateStoreVersion(version: string): void {
  if (
    version.length === 0 ||
    version.startsWith('-') ||
    version.endsWith('.') ||
    version.includes('..') ||
    version.includes('/') ||
    version.includes('\\') ||
    isAbsolute(version) ||
    !SAFE_STORE_VERSION.test(version)
  ) {
    throw new StoreError(
      'STORE_INVALID_VERSION',
      `Invalid version ${JSON.stringify(version)}: use letters, numbers, dots, underscores, hyphens, or plus; start with a letter or number; and do not use paths, "..", or a leading "-".`,
    );
  }
 }
 export function validateStoreKind(kind: string): asserts kind is StoreKind {
  if (!(STORE_KINDS as readonly string[]).includes(kind)) {
    throw new StoreError(
      'STORE_INVALID_KIND',
      `Invalid store kind ${JSON.stringify(kind)}: expected one of ${STORE_KINDS.map((k) => `"${k}"`).join(', ')}.`,
    );
  }
 }
 function validateVettedBy(vettedBy: string): void {
  if (vettedBy.trim().length === 0 || vettedBy.includes('\n') || vettedBy.length > 80) {
    throw new StoreError(
      'STORE_INVALID_VETTER',
      'Invalid --by value: name the operator vouching for this content (single line, at most 80 characters).',
    );
  }
 }
 function lstatIfPresent(path: string): Stats | undefined {
  try {
    return lstatSync(path);
  } catch (error: unknown) {
    if (error instanceof Error && 'code' in error && error.code === 'ENOENT') return undefined;
    throw error;
  }
 }
 function assertNoSymlinkAncestors(path: string): void {
  const absolute = resolve(path);
  const pathRoot = parse(absolute).root;
  let current = pathRoot;
  for (const segment of relative(pathRoot, absolute).split(sep)) {
    if (segment.length === 0) continue;
    current = join(current, segment);
    const entry = lstatIfPresent(current);
    if (!entry) break;
    if (entry.isSymbolicLink()) {
      throw new StoreError(
        'STORE_SYMLINK_ROOT',
        `Refusing symlink ancestor at ${current}; the user store root must resolve without symlink traversal.`,
      );
    }
  }
 }
 /** `plugins` for plugin, `skills` for skill — plural on disk per the layout. */
 function kindDirName(kind: StoreKind): string {
  return kind === 'plugin' ? 'plugins' : 'skills';
 }
 export function storeKindDir(kind: StoreKind, paths: StorePaths = getDefaultStorePaths()): string {
  return join(paths.userRoot, kindDirName(kind));
 }
 function entryDir(kind: StoreKind, name: string, version: string, paths: StorePaths): string {
  return join(storeKindDir(kind, paths), name, version);
 }
 function isInsideRoot(candidate: string, root: string): boolean {
  const rel = relative(resolve(root), resolve(candidate));
  return rel.length > 0 && rel !== '..' && !rel.startsWith(`..${sep}`) && !isAbsolute(rel);
 }
 /**
 * Refuse any symlink in the source tree — the vetting boundary copies real
 * content only, so a vetted entry can never carry a link that escapes it.
 *
 * NOTE: known check-then-use window between this walk and the `cpSync` below:
 * a symlink created concurrently with the add could slip through. Accepted
 * for a local, operator-run CLI; revisit before any unattended or networked
 * acquisition path exists.
 */
 function assertSourceTreeHasNoSymlinks(sourcePath: string): void {
  const stack: string[] = [sourcePath];
  while (stack.length > 0) {
    const current = stack.pop()!;
    for (const dirent of readdirSync(current, { withFileTypes: true })) {
      const child = join(current, dirent.name);
      if (dirent.isSymbolicLink()) {
        throw new StoreError(
          'STORE_SOURCE_SYMLINK',
          `Refusing to vet content containing a symlink: ${child}. Resolve or remove symlinks before adding to the store.`,
        );
      }
      if (dirent.isDirectory()) stack.push(child);
    }
  }
 }
 /**
 * Vet and add one versioned entry to the user store.
 *
 * Copies the source directory (real content, no symlinks) to
 * `<userRoot>/<kind>s/<name>/<version>/` and writes the `store-entry.json`
 * marker LAST: a crash mid-copy leaves at most a recoverable partial, never a
 * half-vetted entry that lists as present.
 */
 export function addStoreEntry(
  kind: StoreKind,
  name: string,
  version: string,
  sourcePath: string,
  vettedBy: string,
  notes: string | undefined,
  paths: StorePaths = getDefaultStorePaths(),
  options: { reclaim?: boolean } = {},
 ): StoreAddResult {
  validateStoreKind(kind);
  validateStoreName(name);
  validateStoreVersion(version);
  validateVettedBy(vettedBy);
  assertNoSymlinkAncestors(paths.userRoot);
  const resolvedSource = resolve(sourcePath);
  const source = lstatIfPresent(resolvedSource);
  if (!source) {
    throw new StoreError('STORE_SOURCE_MISSING', `Source path does not exist: ${resolvedSource}`);
  }
  if (source.isSymbolicLink()) {
    throw new StoreError(
      'STORE_SOURCE_SYMLINK',
      `Refusing to vet a symlink as store content: ${resolvedSource} (points at ${resolve(sourcePath)}). Add the real directory.`,
    );
  }
  if (!source.isDirectory()) {
    throw new StoreError(
      'STORE_SOURCE_NOT_DIR',
      `Source path is not a directory: ${resolvedSource}`,
    );
  }
  if (isInsideRoot(resolvedSource, paths.userRoot)) {
    throw new StoreError(
      'STORE_SOURCE_INSIDE_STORE',
      `Refusing to add store content from inside the store itself: ${resolvedSource}`,
    );
  }
  assertSourceTreeHasNoSymlinks(resolvedSource);
  const target = entryDir(kind, name, version, paths);
  const existing = lstatIfPresent(target);
  let status: StoreAddStatus = 'added';
  if (existing) {
    if (existsSync(join(target, STORE_ENTRY_MARKER))) {
      throw new StoreError(
        'STORE_ALREADY_PRESENT',
        `${kind} "${name}" version "${version}" is already present at ${target}; stores are append-only — add a new version instead.`,
      );
    }
    // Unmarked target: either this tool's own debris from an interrupted add,
    // or content the operator placed by hand — indistinguishable on disk. The
    // USER root's contract is that tooling never destroys operator content,
    // so deletion requires the explicit --reclaim opt-in (review finding on
    // c23a71d7: silent rmSync under a benign-sounding status).
    if (!options.reclaim) {
      throw new StoreError(
        'STORE_TARGET_UNMARKED',
        `Target exists without ${STORE_ENTRY_MARKER}: ${target}. Refusing to delete unmarked content — if this is debris from an interrupted add, re-run with --reclaim to replace it.`,
      );
    }
    rmSync(target, { recursive: true, force: true });
    status = 'reclaimed-unmarked';
  }
  mkdirSync(target, { recursive: true });
  cpSync(resolvedSource, target, { recursive: true });
  const meta: StoreEntryMeta = {
    schema: 1,
    kind,
    name,
    version,
    sourcePath: resolvedSource,
    vettedBy: vettedBy.trim(),
    vettedAt: new Date().toISOString(),
    ...(notes === undefined ? {} : { notes }),
  };
  writeFileSync(join(target, STORE_ENTRY_MARKER), `${JSON.stringify(meta, null, 2)}\n`);
  return { kind, name, version, status, entryPath: target, sourcePath: resolvedSource };
 }
 function readEntryMeta(markerPath: string): { meta?: StoreEntryMeta; status: StoreEntryStatus } {
  let raw: string;
  try {
    raw = readFileSync(markerPath, 'utf-8');
  } catch {
    return { status: 'invalid-metadata' };
  }
  try {
    const parsed = JSON.parse(raw) as StoreEntryMeta;
    if (
      parsed?.schema === 1 &&
      (STORE_KINDS as readonly string[]).includes(parsed.kind) &&
      typeof parsed.name === 'string' &&
      typeof parsed.version === 'string' &&
      typeof parsed.vettedBy === 'string' &&
      typeof parsed.vettedAt === 'string'
    ) {
      return { meta: parsed, status: 'vetted' };
    }
  } catch {
    // fall through
  }
  return { status: 'invalid-metadata' };
 }
 /**
 * Enumerate every store entry deterministically (kind, then name, then
 * version). Version directories without a marker list as `incomplete`; files
 * where directories were expected list as `foreign` — surfaced, never mutated.
 */
 export function listStoreEntries(
  paths: StorePaths = getDefaultStorePaths(),
  filter: { kind?: StoreKind; name?: string } = {},
 ): StoreListEntry[] {
  if (filter.name !== undefined) validateStoreName(filter.name);
  assertNoSymlinkAncestors(paths.userRoot);
  const kinds = filter.kind ? [filter.kind] : [...STORE_KINDS];
  const entries: StoreListEntry[] = [];
  for (const kind of kinds) {
    const kindRoot = lstatIfPresent(storeKindDir(kind, paths));
    if (!kindRoot) continue;
    if (!kindRoot.isDirectory()) {
      entries.push({
        kind,
        name: kindDirName(kind),
        status: 'foreign',
        entryPath: storeKindDir(kind, paths),
      });
      continue;
    }
    for (const nameDirent of readdirSync(storeKindDir(kind, paths), {
      withFileTypes: true,
    }).sort(byName) as Dirent[]) {
      if (filter.name !== undefined && nameDirent.name !== filter.name) continue;
      const namePath = join(storeKindDir(kind, paths), nameDirent.name);
      if (!nameDirent.isDirectory()) {
        entries.push({ kind, name: nameDirent.name, status: 'foreign', entryPath: namePath });
        continue;
      }
      const versionDirents = readdirSync(namePath, { withFileTypes: true }).sort(byName);
      if (versionDirents.length === 0) {
        entries.push({ kind, name: nameDirent.name, status: 'incomplete', entryPath: namePath });
        continue;
      }
      for (const versionDirent of versionDirents) {
        const versionPath = join(namePath, versionDirent.name);
        if (!versionDirent.isDirectory()) {
          entries.push({
            kind,
            name: nameDirent.name,
            version: versionDirent.name,
            status: 'foreign',
            entryPath: versionPath,
          });
          continue;
        }
        const markerPath = join(versionPath, STORE_ENTRY_MARKER);
        if (!existsSync(markerPath)) {
          entries.push({
            kind,
            name: nameDirent.name,
            version: versionDirent.name,
            status: 'incomplete',
            entryPath: versionPath,
          });
          continue;
        }
        const { meta, status } = readEntryMeta(markerPath);
        entries.push({
          kind,
          name: nameDirent.name,
          version: versionDirent.name,
          status,
          entryPath: versionPath,
          ...(meta === undefined ? {} : { meta }),
        });
      }
    }
  }
  return entries;
 }
 function byName(a: Dirent, b: Dirent): number {
  return a.name < b.name ? -1 : a.name > b.name ? 1 : 0;
 }
 function reportCommandError(error: unknown): void {
  if (error instanceof StoreError) {
    console.error(`store: ${error.code}: ${error.message}`);
  } else {
    console.error(error instanceof Error ? error.message : String(error));
  }
  process.exitCode = 1;
 }
 function displayStoreName(name: string): string {
  return SAFE_STORE_NAME.test(name) ? name : JSON.stringify(name);
 }
 /** Register the `mosaic store` command group (W-F4). */
 export function registerStoreCommand(
  program: Command,
  paths: StorePaths = getDefaultStorePaths(),
 ): void {
  const store = program
    .command('store')
    .description('Manage the vetted user store under ~/.mosaic (plugins, skills)')
    .configureHelp({ sortSubcommands: true });
  store
    .command('add <kind> <name> <version>')
    .description(
      'Vet and add a local plugin/skill directory to the user store (versioned, append-only)',
    )
    .requiredOption('--from <path>', 'Local source directory to vet (no network acquisition)')
    .requiredOption('--by <operator>', 'Name of the operator vouching for this content')
    .option('--notes <notes>', 'Vetting notes recorded in the entry metadata')
    .option(
      '--reclaim',
      'Replace an existing UNMARKED target directory (e.g. debris from an interrupted add); refuses without this flag',
    )
    .action(
      async (
        kind: string,
        name: string,
        version: string,
        opts: {
          from: string;
          by: string;
          notes?: string;
          reclaim: boolean;
        },
      ) => {
        try {
          const result = addStoreEntry(
            kind as StoreKind,
            name,
            version,
            opts.from,
            opts.by,
            opts.notes,
            paths,
            { reclaim: opts.reclaim },
          );
          const suffix =
            result.status === 'reclaimed-unmarked' ? ' (replaced unmarked directory)' : '';
          console.log(
            `${result.kind} ${displayStoreName(result.name)} ${result.version}: added${suffix}`,
          );
          console.log(`  entry: ${result.entryPath}`);
          console.log(`  vetted by ${opts.by.trim()}`);
        } catch (error: unknown) {
          reportCommandError(error);
        }
      },
    );
  store
    .command('list')
    .description('List store entries with vetting status')
    .option('--kind <kind>', 'Filter by kind (plugin | skill)')
    .option('--name <name>', 'Filter by entry name')
    .action((opts: { kind?: string; name?: string }) => {
      try {
        let kind: StoreKind | undefined;
        if (opts.kind !== undefined) {
          validateStoreKind(opts.kind);
          kind = opts.kind;
        }
        const entries = listStoreEntries(paths, {
          ...(kind === undefined ? {} : { kind }),
          ...(opts.name === undefined ? {} : { name: opts.name }),
        });
        if (entries.length === 0) {
          console.log('No store entries found.');
          return;
        }
        for (const entry of entries) {
          const version = entry.version ?? '-';
          const vetter = entry.meta?.vettedBy ?? '-';
          console.log(
            `${entry.status.padEnd(17)}${entry.kind.padEnd(8)}${displayStoreName(entry.name).padEnd(24)}${version.padEnd(16)}${vetter}`,
          );
        }
      } catch (error: unknown) {
        reportCommandError(error);
      }
    });
 }
@@ -5,6 +5,13 @@ export const VERSION = '0.0.2';
 export const DEFAULT_MOSAIC_HOME = join(homedir(), '.config', 'mosaic');
 /**
 * USER data root (HARNESS-HOMES two-root split): everything under here is user
 * content — never replaced or removed by installs, updates, or uninstallers.
 * Distinct from the SYSTEM root above, which is update-owned.
 */
 export const DEFAULT_MOSAIC_USER_HOME = join(homedir(), '.mosaic');
 export const DEFAULTS = {
  agentName: 'Assistant',
  roleDescription: 'execution partner and visibility engine',
@@ -1,114 +0,0 @@
 import { mkdir, mkdtemp, rm } from 'node:fs/promises';
 import { homedir, tmpdir } from 'node:os';
 import { join } from 'node:path';
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
 import {
  brainHomeIsActive,
  fleetAgentEnvDir,
  fleetProfilesDir,
  fleetRolesLocalDir,
  fleetStateDir,
  resolveBrainHome,
  type BrainHomeOptions,
 } from './brain-home.js';
 describe('fleet brain-home resolution', (): void => {
  let cleanup: string | undefined;
  const savedBrainEnv = process.env['MOSAIC_BRAIN_HOME'];
  beforeEach((): void => {
    delete process.env['MOSAIC_BRAIN_HOME'];
  });
  afterEach(async (): Promise<void> => {
    if (savedBrainEnv === undefined) {
      delete process.env['MOSAIC_BRAIN_HOME'];
    } else {
      process.env['MOSAIC_BRAIN_HOME'] = savedBrainEnv;
    }
    if (cleanup !== undefined) {
      await rm(cleanup, { recursive: true, force: true });
      cleanup = undefined;
    }
  });
  async function makeTmp(): Promise<string> {
    const root = await mkdtemp(join(tmpdir(), 'mosaic-brain-home-'));
    cleanup = root;
    return root;
  }
  it('MOSAIC_BRAIN_HOME env wins over every other signal', (): void => {
    process.env['MOSAIC_BRAIN_HOME'] = '/explicit/brain';
    expect(resolveBrainHome('/any/mosaic-home')).toBe('/explicit/brain');
    expect(fleetAgentEnvDir('/any/mosaic-home')).toBe('/explicit/brain/fleet/agents');
    expect(brainHomeIsActive('/any/mosaic-home')).toBe(true);
  });
  it('injected envBrainHome wins identically (test seam)', (): void => {
    const opts: BrainHomeOptions = { envBrainHome: '/injected/brain' };
    expect(resolveBrainHome('/any/mosaic-home', opts)).toBe('/injected/brain');
    expect(fleetAgentEnvDir('/any/mosaic-home', opts)).toBe('/injected/brain/fleet/agents');
  });
  it('a non-default mosaicHome never adopts the canonical brain (hermetic legacy)', (): void => {
    const mosaicHome = '/tmp/not-the-default-config-home';
    expect(resolveBrainHome(mosaicHome)).toBe(mosaicHome);
    expect(brainHomeIsActive(mosaicHome)).toBe(false);
    expect(fleetAgentEnvDir(mosaicHome)).toBe(join(mosaicHome, 'fleet', 'agents'));
  });
  it('the default config home adopts the brain when it carries fleet/agents', async (): Promise<void> => {
    const root = await makeTmp();
    const brain = join(root, 'brain');
    await mkdir(join(brain, 'fleet', 'agents'), { recursive: true });
    const configHome = join(root, 'config', 'mosaic');
    const opts: BrainHomeOptions = { homes: { brain, configDefault: configHome } };
    expect(resolveBrainHome(configHome, opts)).toBe(brain);
    expect(fleetAgentEnvDir(configHome, opts)).toBe(join(brain, 'fleet', 'agents'));
    expect(fleetRolesLocalDir(configHome, opts)).toBe(join(brain, 'fleet', 'roles.local'));
    expect(fleetProfilesDir(configHome, opts)).toBe(join(brain, 'fleet', 'profiles'));
    expect(fleetStateDir(configHome, opts)).toBe(join(brain, 'fleet'));
    expect(brainHomeIsActive(configHome, opts)).toBe(true);
  });
  it('the default config home stays legacy when no brain exists', async (): Promise<void> => {
    const root = await makeTmp();
    const configHome = join(root, 'config', 'mosaic');
    const opts: BrainHomeOptions = {
      homes: { brain: join(root, 'brain'), configDefault: configHome },
    };
    expect(resolveBrainHome(configHome, opts)).toBe(configHome);
    expect(brainHomeIsActive(configHome, opts)).toBe(false);
  });
  it('an empty MOSAIC_BRAIN_HOME is ignored, not treated as set', (): void => {
    process.env['MOSAIC_BRAIN_HOME'] = '   ';
    expect(resolveBrainHome('/tmp/legacy-home')).toBe('/tmp/legacy-home');
  });
  it('adoption requires fleet/agents specifically, not any brain content', async (): Promise<void> => {
    const root = await makeTmp();
    const brain = join(root, 'brain');
    await mkdir(join(brain, 'fleet'), { recursive: true }); // fleet without agents
    const configHome = join(root, 'config', 'mosaic');
    const opts: BrainHomeOptions = { homes: { brain, configDefault: configHome } };
    expect(resolveBrainHome(configHome, opts)).toBe(configHome);
  });
  it('real-home control: a host brain is adopted only through the default home', (): void => {
    // Control on the un-injected path: this host carries ~/.mosaic/fleet/agents,
    // so the default config home resolves to the brain or legacy — both valid
    // canonical endpoints — while a non-default home never adopts.
    const defaultHome = join(homedir(), '.config', 'mosaic');
    const resolved = resolveBrainHome(defaultHome);
    expect([defaultHome, join(homedir(), '.mosaic')]).toContain(resolved);
    expect(resolveBrainHome(join(homedir(), 'elsewhere', 'mosaic'))).toBe(
      join(homedir(), 'elsewhere', 'mosaic'),
    );
  });
 });
@@ -1,76 +0,0 @@
 import { existsSync } from 'node:fs';
 import { homedir } from 'node:os';
 import { join, resolve } from 'node:path';
 /**
 * Overridable resolution inputs (tests inject tmp homes; production reads
 * the environment and the real home directory).
 */
 export interface BrainHomeOptions {
  /** Explicit brain home; defaults to `MOSAIC_BRAIN_HOME`. */
  readonly envBrainHome?: string;
  /**
   * Canonical homes used for adoption. Defaults derive from the real
   * `homedir()`: `{ brain: ~/.mosaic, configDefault: ~/.config/mosaic }`.
   */
  readonly homes?: { readonly brain: string; readonly configDefault: string };
 }
 /**
 * Brain-home resolution — the three-tree fleet split (stack canon
 * `docs/STRUCTURE-CANON.md` §2, first carried by the USC estate brain):
 *
 *   config home (~/.config/mosaic)  framework templates + dispatch state:
 *                                   fleet/roles (baseline), fleet/roster.yaml,
 *                                   fleet/run (heartbeats), fleet/services
 *   brain home  (~/.mosaic)         user-owned fleet state, committed:
 *                                   fleet/agents/<seat>.env.*, fleet/roles.local,
 *                                   fleet/profiles working copies
 *
 * Resolution order:
 *   1. `MOSAIC_BRAIN_HOME` env (explicit, always wins)
 *   2. canonical `~/.mosaic` — adopted ONLY when mosaicHome is the real
 *      default config home AND `~/.mosaic/fleet/agents` exists. Custom
 *      `--mosaic-home` values (tests, sandboxes, canaries) never trigger
 *      adoption, keeping them hermetic and deterministic.
 *   3. mosaicHome itself (legacy single-tree behavior).
 */
 export function resolveBrainHome(mosaicHome: string, options: BrainHomeOptions = {}): string {
  const explicit = options.envBrainHome ?? process.env['MOSAIC_BRAIN_HOME'];
  if (explicit !== undefined && explicit.trim() !== '') {
    return explicit;
  }
  const homes = options.homes ?? {
    brain: join(homedir(), '.mosaic'),
    configDefault: join(homedir(), '.config', 'mosaic'),
  };
  if (resolve(mosaicHome) !== resolve(homes.configDefault)) {
    return mosaicHome;
  }
  return existsSync(join(homes.brain, 'fleet', 'agents')) ? homes.brain : mosaicHome;
 }
 /** True when fleet state resolves somewhere other than the config home. */
 export function brainHomeIsActive(mosaicHome: string, options: BrainHomeOptions = {}): boolean {
  return resolve(resolveBrainHome(mosaicHome, options)) !== resolve(mosaicHome);
 }
 /** Fleet state root (brain home when active, else the config home). */
 export function fleetStateDir(mosaicHome: string, options: BrainHomeOptions = {}): string {
  return join(resolveBrainHome(mosaicHome, options), 'fleet');
 }
 /** Seat launch envs — `<brainHome>/fleet/agents` when a brain is active. */
 export function fleetAgentEnvDir(mosaicHome: string, options: BrainHomeOptions = {}): string {
  return join(fleetStateDir(mosaicHome, options), 'agents');
 }
 /** PRESERVE-protected persona override layer — `<brainHome>/fleet/roles.local`. */
 export function fleetRolesLocalDir(mosaicHome: string, options: BrainHomeOptions = {}): string {
  return join(fleetStateDir(mosaicHome, options), 'roles.local');
 }
 /** System-type profiles (user working copies) — `<brainHome>/fleet/profiles`. */
 export function fleetProfilesDir(mosaicHome: string, options: BrainHomeOptions = {}): string {
  return join(fleetStateDir(mosaicHome, options), 'profiles');
 }
@@ -3,7 +3,6 @@ import { lstat, open, readFile, unlink, type FileHandle } from 'node:fs/promises
 import { randomUUID } from 'node:crypto';
 import { homedir } from 'node:os';
 import { join } from 'node:path';
 import { fleetAgentEnvDir } from './brain-home.js';
 import {
  applyPreparedAgentEnvironmentProjection,
  prepareAgentEnvironmentProjection,
@@ -618,7 +617,7 @@ function defaultPrepareProjections(
        (agent: FleetRosterV2Agent): Promise<PreparedAgentEnvironmentProjection> =>
          prepareAgentEnvironmentProjection({
            mosaicHome,
-            agentEnvDir: fleetAgentEnvDir(mosaicHome),
+            agentEnvDir: join(mosaicHome, 'fleet', 'agents'),
            agentName: agent.name,
            generated: projectRosterV2AgentGeneratedEnv(roster, agent),
          }),
@@ -176,52 +176,6 @@ describe('generated fleet agent environment boundary', (): void => {
    expect((await stat(result.generatedPath)).mode & 0o777).toBe(0o600);
  });
  it('brain home: accepts and writes projections under MOSAIC_BRAIN_HOME/fleet/agents', async (): Promise<void> => {
    const savedBrainHome = process.env['MOSAIC_BRAIN_HOME'];
    try {
      cleanup = await mkdtemp(join(tmpdir(), 'mosaic-generated-env-'));
      const mosaicHome = join(cleanup, 'config-home');
      const brainHome = join(cleanup, 'brain');
      const agentEnvDir = join(brainHome, 'fleet', 'agents');
      process.env['MOSAIC_BRAIN_HOME'] = brainHome;
      const result = await writeAgentEnvironmentProjection({
        mosaicHome,
        agentEnvDir,
        agentName: 'coder0',
        generated: generatedValues,
      });
      // Projection landed in the brain tree, not under the config home.
      expect(result.generatedPath).toBe(join(agentEnvDir, 'coder0.env.generated'));
      expect((await stat(join(brainHome, 'fleet'))).mode & 0o777).toBe(0o700);
      expect((await stat(agentEnvDir)).mode & 0o777).toBe(0o700);
      expect((await stat(result.generatedPath)).mode & 0o777).toBe(0o600);
      await expect(stat(join(mosaicHome, 'fleet'))).rejects.toThrow();
      // A config-home agentEnvDir is now REJECTED while the brain is active —
      // the boundary must not silently split state across two trees.
      let rejected: unknown;
      try {
        await writeAgentEnvironmentProjection({
          mosaicHome,
          agentEnvDir: join(mosaicHome, 'fleet', 'agents'),
          agentName: 'coder1',
          generated: { ...generatedValues, MOSAIC_AGENT_NAME: 'coder1' },
        });
      } catch (caught: unknown) {
        rejected = caught;
      }
      expect(rejected).toBeInstanceOf(AgentEnvBoundaryError);
    } finally {
      if (savedBrainHome === undefined) {
        delete process.env['MOSAIC_BRAIN_HOME'];
      } else {
        process.env['MOSAIC_BRAIN_HOME'] = savedBrainHome;
      }
    }
  });
  it('regenerates desired keys, relocates safe legacy local data, and quarantines forbidden legacy input', async (): Promise<void> => {
    cleanup = await mkdtemp(join(tmpdir(), 'mosaic-generated-env-'));
    const mosaicHome = join(cleanup, 'mosaic');
@@ -2,7 +2,6 @@ import { createHash, randomUUID } from 'node:crypto';
 import { chmod, lstat, mkdir, readFile, rename, unlink, writeFile } from 'node:fs/promises';
 import { homedir } from 'node:os';
 import { dirname, join, resolve } from 'node:path';
 import { fleetAgentEnvDir, resolveBrainHome } from './brain-home.js';
 import { compareCodePoints } from './deterministic-order.js';
 export type AgentEnvironmentKind = 'generated' | 'local';
@@ -529,15 +528,12 @@ async function validatePrivateProjectionDirectory(
  mosaicHome: string,
  agentEnvDir: string,
 ): Promise<void> {
-  // Brain-home split (canon §2): seat envs live under the brain home's
+  const fleetDir = join(mosaicHome, 'fleet');
-  // fleet/agents when a brain is active; roster + templates stay config-home.
+  const expectedAgentEnvDir = join(fleetDir, 'agents');
  const expectedAgentEnvDir = fleetAgentEnvDir(mosaicHome);
  if (resolve(agentEnvDir) !== resolve(expectedAgentEnvDir)) {
    throw new AgentEnvBoundaryError('unsafe-directory', '(directory)', agentEnvDir);
  }
-  const stateHome = resolveBrainHome(mosaicHome);
+  await assertManagedDirectoryIfPresent(mosaicHome, false);
  const fleetDir = join(stateHome, 'fleet');
  await assertManagedDirectoryIfPresent(stateHome, false);
  await assertManagedDirectoryIfPresent(fleetDir, false);
  await assertManagedDirectoryIfPresent(agentEnvDir, true);
 }
@@ -547,9 +543,8 @@ async function ensurePrivateProjectionDirectory(
  agentEnvDir: string,
 ): Promise<void> {
  await validatePrivateProjectionDirectory(mosaicHome, agentEnvDir);
-  const stateHome = resolveBrainHome(mosaicHome);
+  const fleetDir = join(mosaicHome, 'fleet');
-  const fleetDir = join(stateHome, 'fleet');
+  await ensureManagedDirectory(mosaicHome, false);
  await ensureManagedDirectory(stateHome, false);
  await ensureManagedDirectory(fleetDir, false);
  await ensureManagedDirectory(agentEnvDir, true);
 }
@@ -1,166 +0,0 @@
 #!/usr/bin/env node
 // verify-release.mjs — the ONE canonical terminal verification command
 // (SDLC-D-034, `pnpm verify:release`).
 //
 // Publication (.woodpecker/publish.yml `verify` step) is bound to terminal
 // verification of the exact commit through this command, which is composed
 // from the SAME commands the PR CI pipeline (.woodpecker/ci.yml) runs — CI and
 // publish share one semantic checklist:
 //
 //   stage         | mirrors ci.yml step | commands
 //   --------------|---------------------|------------------------------------------
 //   sanitization  | sanitization        | verify-sanitized.sh, check-resident-
 //                |                     | budget.sh (--self-test + run),
 //                |                     | check-test-enumeration.sh
 //   upgrade-guard | upgrade-guard       | test-upgrade-manifest-guard.sh,
 //                |                     | test-upgrade-rollback.sh,
 //                |                     | test-upgrade-durable-snapshot.sh,
 //                |                     | test-install-migration.sh
 //   typecheck     | typecheck           | pnpm typecheck (runs the checkout
 //                |                     | preflight, then turbo typecheck)
 //   lint          | lint                | pnpm lint
 //   format        | format              | pnpm format:check
 //   test          | test                | pnpm test
 //   build         | publish.yml build   | pnpm build
 //
 // Caller-provided prerequisites (kept at the pipeline level — see the comments
 // in .woodpecker/ci.yml): `bash` + `rsync` for the guard stages, `openssl` and
 // the pinned @earendil-works/pi-coding-agent for the test stage, and — on the
 // postgres path only — the ci-postgres service plus
 // `pnpm --filter @mosaicstack/db run db:migrate` before the test stage.
 //
 // This command works with DATABASE_URL set (CI postgres path) or unset (local
 // PGlite path); it never sets, exports, or requires a database itself.
 //
 // scripts/verify-release.test.mjs enforces that this stage table keeps
 // matching .woodpecker/ci.yml step-for-step, so the two surfaces cannot drift
 // apart silently.
 import { spawnSync } from 'node:child_process';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
 export const STAGES = [
  {
    name: 'sanitization',
    // Mirror of the .woodpecker/ci.yml `sanitization` step (minus its
    // `apk add` environment prep). Kept as direct command strings here: the
    // #1017 test-enumeration guard audits these paths through the ci.yml
    // surface, so indirection from ci.yml into this file is not possible.
    commands: [
      'bash packages/mosaic/framework/tools/quality/scripts/verify-sanitized.sh',
      'bash packages/mosaic/framework/tools/quality/scripts/check-resident-budget.sh --self-test',
      'bash packages/mosaic/framework/tools/quality/scripts/check-resident-budget.sh',
      'bash packages/mosaic/framework/tools/quality/scripts/check-test-enumeration.sh',
    ],
  },
  {
    name: 'upgrade-guard',
    // Mirror of the .woodpecker/ci.yml `upgrade-guard` step (minus its
    // `apk add` environment prep).
    commands: [
      'bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-manifest-guard.sh',
      'bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-rollback.sh',
      'bash packages/mosaic/framework/tools/quality/scripts/test-upgrade-durable-snapshot.sh',
      'bash packages/mosaic/framework/tools/quality/scripts/test-install-migration.sh',
    ],
  },
  {
    // `pnpm typecheck` is `pnpm preflight && turbo run typecheck`, so the
    // checkout preflight (scripts/preflight.mjs) is part of this stage exactly
    // as it is part of the ci.yml `typecheck` step.
    name: 'typecheck',
    commands: ['pnpm typecheck'],
  },
  {
    name: 'lint',
    commands: ['pnpm lint'],
  },
  {
    name: 'format',
    commands: ['pnpm format:check'],
  },
  {
    // Requires `openssl` and the pinned `pi` binary on the pipeline path; see
    // the caller-provided prerequisites above.
    name: 'test',
    commands: ['pnpm test'],
  },
  {
    name: 'build',
    commands: ['pnpm build'],
  },
 ];
 export function stageByName(name) {
  return STAGES.find((stage) => stage.name === name);
 }
 function missingBinaries(bins) {
  return bins.filter(
    (bin) => spawnSync('sh', ['-c', `command -v ${bin} >/dev/null 2>&1`]).status !== 0,
  );
 }
 function runCommand(command) {
  const result = spawnSync(command, { shell: true, stdio: 'inherit' });
  if (result.error) {
    console.error(`[verify:release] failed to launch '${command}': ${result.error.message}`);
    return false;
  }
  if (result.status !== 0) {
    const reason = result.signal ? `terminated by ${result.signal}` : `exited ${result.status}`;
    console.error(`[verify:release] command '${command}' ${reason}`);
    return false;
  }
  return true;
 }
 // Runs the complete mandatory verification set (or, with --stage <name>, the
 // single named stage — used for wiring/smoke-testing, not for gating: only a
 // run of every stage is a terminal verification). Fails fast: the first
 // failing command aborts with a non-zero exit code. Returns the exit code.
 export function verifyRelease({ stages = STAGES } = {}) {
  const missing = missingBinaries(['bash', 'rsync']);
  if (missing.length > 0) {
    console.error(
      `[verify:release] FATAL: required binaries missing from PATH: ${missing.join(', ')}. ` +
        'The caller provides them (ci-base bakes bash; pipelines apk add rsync).',
    );
    return 1;
  }
  for (const stage of stages) {
    console.log(`\n[verify:release] === stage: ${stage.name} ===`);
    for (const command of stage.commands) {
      console.log(`[verify:release] $ ${command}`);
      if (!runCommand(command)) {
        console.error(
          `[verify:release] FATAL: stage '${stage.name}' failed — verification inconclusive`,
        );
        return 1;
      }
    }
  }
  console.log(`\n[verify:release] all ${stages.length} stage(s) passed`);
  return 0;
 }
 function main(argv) {
  const stageFlagIndex = argv.indexOf('--stage');
  if (stageFlagIndex !== -1) {
    const name = argv[stageFlagIndex + 1];
    const stage = stageByName(name);
    if (!stage) {
      console.error(
        `[verify:release] unknown stage '${name ?? ''}' — expected one of: ${STAGES.map((entry) => entry.name).join(', ')}`,
      );
      process.exit(2);
    }
    process.exit(verifyRelease({ stages: [stage] }));
  }
  process.exit(verifyRelease());
 }
 if (process.argv[1] && path.resolve(process.argv[1]) === fileURLToPath(import.meta.url)) {
  main(process.argv.slice(2));
 }
@@ -1,277 +0,0 @@
 import assert from 'node:assert/strict';
 import { readFile } from 'node:fs/promises';
 import { createRequire } from 'node:module';
 import path from 'node:path';
 import test from 'node:test';
 import { STAGES } from './verify-release.mjs';
 // SDLC-D-034 checkout invariant: publication in .woodpecker/publish.yml is
 // bound to exact-commit terminal verification. This suite parses the real
 // pipeline files and fails red when the gate is bypassed, weakened, or drifts
 // out of sync with the canonical `pnpm verify:release` command.
 // Reuse the monorepo's existing YAML parser (@mosaicstack/mosaic's direct
 // dependency) instead of adding a root dependency or vendoring a parser.
 const mosaicRequire = createRequire(
  path.resolve(process.cwd(), 'packages', 'mosaic', 'package.json'),
 );
 const { parse: parseYaml } = mosaicRequire('yaml');
 const publishYmlPath = path.join(process.cwd(), '.woodpecker', 'publish.yml');
 const ciYmlPath = path.join(process.cwd(), '.woodpecker', 'ci.yml');
 async function readPublishPipeline() {
  return parseYaml(await readFile(publishYmlPath, 'utf8'));
 }
 // A step has an external publication effect when its name starts with
 // `publish` or when any command pushes an image to a registry.
 function pushesImage(step) {
  return (step.commands ?? []).some((command) =>
    /(^|\s)(\/kaniko\/executor|docker push)\b|--destination/.test(command),
  );
 }
 function publishEffectSteps(pipeline) {
  return Object.entries(pipeline.steps ?? {})
    .filter(([name, step]) => name.startsWith('publish') || pushesImage(step))
    .map(([name]) => name);
 }
 // Transitive closure of a step's depends_on graph.
 function dependencyClosure(pipeline, stepName, seen = new Set()) {
  const dependencies = pipeline.steps?.[stepName]?.depends_on ?? [];
  for (const dependency of dependencies) {
    if (seen.has(dependency)) continue;
    seen.add(dependency);
    dependencyClosure(pipeline, dependency, seen);
  }
  return seen;
 }
 function verifyCommands(pipeline) {
  const verify = pipeline.steps?.verify;
  assert.ok(verify, 'publish pipeline must define a `verify` step');
  assert.ok(Array.isArray(verify.commands), '`verify` step must have commands');
  return verify.commands;
 }
 function assertCommitIdentityAssertion(commands) {
  const text = commands.join('\n');
  assert.match(
    text,
    /CI_COMMIT_SHA/,
    '`verify` must compare the provider commit identity (CI_COMMIT_SHA)',
  );
  assert.match(text, /git rev-parse HEAD/, '`verify` must compare against git rev-parse HEAD');
  assert.match(
    text,
    /exit 1/,
    '`verify` must fail closed (exit 1) on identity mismatch or emptiness',
  );
 }
 function assertCanonicalCommand(commands) {
  assert.ok(
    commands.some((command) => /^pnpm verify:release\b/.test(command.trim())),
    '`verify` must run the canonical terminal verification command `pnpm verify:release`',
  );
 }
 function assertPublishGate(pipeline) {
  assert.ok(pipeline.steps, 'publish pipeline must define steps');
  const commands = verifyCommands(pipeline);
  assertCommitIdentityAssertion(commands);
  assertCanonicalCommand(commands);
  const effects = publishEffectSteps(pipeline);
  assert.ok(effects.length > 0, 'publish pipeline must contain publish effect steps to guard');
  for (const stepName of effects) {
    const step = pipeline.steps[stepName];
    assert.ok(
      Array.isArray(step.depends_on) && step.depends_on.includes('verify'),
      `publish effect '${stepName}' must depend DIRECTLY on the verify step (SDLC-D-034: transitively through build is not enough)`,
    );
    assert.ok(
      dependencyClosure(pipeline, stepName).has('verify'),
      `publish effect '${stepName}' must depend on a chain that includes verify`,
    );
  }
  return effects;
 }
 test('the publish pipeline gates every publish effect behind exact-commit verification', async () => {
  const pipeline = await readPublishPipeline();
  const effects = assertPublishGate(pipeline);
  assert.deepEqual(effects.sort(), [
    'build-appservice',
    'build-gateway',
    'build-web',
    'publish-next-npm',
    'publish-npm',
  ]);
 });
 test('the verify step carries no path/event short-circuit of its own', async () => {
  const pipeline = await readPublishPipeline();
  // A `when` filter on `verify` would let a publish effect fire on an event
  // class that skipped verification — the gate must be unconditional.
  assert.equal(pipeline.steps.verify.when, undefined);
 });
 test('a publish step that bypasses verify fails the gate checker', () => {
  // Negative fixture: a plausible publish pipeline where `publish-npm` hangs
  // off `build` only and `build` never chains to `verify` — the exact bypass
  // class SDLC-D-034 closes. The checker must go red on it.
  const bypassingPipeline = `
 steps:
  install:
    image: node:24-alpine
    commands:
      - pnpm install --frozen-lockfile
  verify:
    image: node:24-alpine
    commands:
      - |
        if [ -z "$CI_COMMIT_SHA" ] || [ "$CI_COMMIT_SHA" != "$(git rev-parse HEAD)" ]; then
          echo "identity mismatch" >&2
          exit 1
        fi
      - pnpm verify:release
    depends_on:
      - install
  build:
    image: node:24-alpine
    commands:
      - pnpm build
    depends_on:
      - install
  publish-npm:
    image: node:24-alpine
    commands:
      - pnpm publish
    depends_on:
      - build
 `;
  assert.throws(
    () => assertPublishGate(parseYaml(bypassingPipeline)),
    /publish-npm.*DIRECTLY.*verify/s,
  );
 });
 test('a publish step chained to verify only transitively fails the gate checker', () => {
  // Negative fixture: `build` depends on verify but `publish-npm` does not
  // carry the direct edge — weaker than SDLC-D-034 requires of the real DAG.
  const transitiveOnlyPipeline = `
 steps:
  install:
    image: node:24-alpine
    commands:
      - pnpm install --frozen-lockfile
  verify:
    image: node:24-alpine
    commands:
      - |
        if [ -z "$CI_COMMIT_SHA" ] || [ "$CI_COMMIT_SHA" != "$(git rev-parse HEAD)" ]; then
          echo "identity mismatch" >&2
          exit 1
        fi
      - pnpm verify:release
    depends_on:
      - install
  build:
    image: node:24-alpine
    commands:
      - pnpm build
    depends_on:
      - install
      - verify
  publish-npm:
    image: node:24-alpine
    commands:
      - pnpm publish
    depends_on:
      - build
 `;
  assert.throws(
    () => assertPublishGate(parseYaml(transitiveOnlyPipeline)),
    /publish-npm.*DIRECTLY.*verify/s,
  );
 });
 test('a verify step without the commit-identity assertion fails the gate checker', () => {
  const noIdentityPipeline = `
 steps:
  verify:
    image: node:24-alpine
    commands:
      - pnpm verify:release
  publish-npm:
    image: node:24-alpine
    commands:
      - pnpm publish
    depends_on:
      - verify
 `;
  assert.throws(() => assertPublishGate(parseYaml(noIdentityPipeline)), /CI_COMMIT_SHA/);
 });
 test('the canonical verify:release stages mirror the PR CI pipeline one-for-one', async () => {
  const ci = parseYaml(await readFile(ciYmlPath, 'utf8'));
  const canonical = Object.fromEntries(STAGES.map((stage) => [stage.name, stage.commands]));
  // The complete mandatory set, in gate order.
  assert.deepEqual(
    STAGES.map((stage) => stage.name),
    ['sanitization', 'upgrade-guard', 'typecheck', 'lint', 'format', 'test', 'build'],
  );
  // Guard stages: ci.yml commands minus its `apk add` environment prep must be
  // exactly the canonical stage commands (order included).
  for (const stageName of ['sanitization', 'upgrade-guard']) {
    assert.deepEqual(
      ci.steps[stageName].commands.filter((command) => !command.startsWith('apk add')),
      canonical[stageName],
      `canonical '${stageName}' stage must match the ci.yml step`,
    );
  }
  // pnpm stages: ci.yml commands minus `corepack enable` must be exactly the
  // canonical stage commands.
  for (const stepName of ['typecheck', 'lint', 'format']) {
    assert.deepEqual(
      ci.steps[stepName].commands.filter((command) => command !== 'corepack enable'),
      canonical[stepName],
      `canonical '${stepName}' stage must match the ci.yml step`,
    );
  }
  // The test stage is shared, but ci.yml wraps it in pipeline-level
  // prerequisites the canonical command expects its caller to provide
  // (SDLC-D-034): the postgres service + readiness wait + db:migrate, openssl,
  // and the pinned pi runtime. None of those may be dropped silently.
  for (const command of canonical.test) {
    assert.ok(
      ci.steps.test.commands.includes(command),
      `ci.yml test step must run the canonical test stage command '${command}'`,
    );
  }
  for (const fragment of [
    'pg_isready -h ci-postgres',
    'pnpm --filter @mosaicstack/db run db:migrate',
    'npm install -g @earendil-works/[email protected]',
  ]) {
    assert.ok(
      ci.steps.test.commands.some((command) => command.includes(fragment)),
      `ci.yml test step must keep its pipeline-level prerequisite '${fragment}'`,
    );
  }
 });
 test('the root package.json exposes verify:release as the canonical command', async () => {
  const packageJson = JSON.parse(await readFile(path.join(process.cwd(), 'package.json'), 'utf8'));
  assert.match(packageJson.scripts['verify:release'], /scripts\/verify-release\.mjs/);
 });