fix(hygiene): .prettierignore must exclude Python build/test artifacts #1025
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: mosaicstack/stack#1025
Reference in New Issue
Block a user
What
Adds Python build/test artifact excludes to
.prettierignore:**/venv,**/__pycache__,**/.mypy_cache,**/.pytest_cache,**/htmlcov.Same category as the existing
node_modules/dist/.nextentries. This narrows what theformat gate scans (generated trees). It does not change what the gate enforces over source.
Why
Any local Python virtualenv in the working tree drops thousands of third-party files into
pnpm format:check, making the gate unpassable in a real checkout. Observed: ~2400 files from anuntracked
apps/coordinatorvenv. A gate that cannot pass in a working checkout is a gate the fleetlearns to bypass — which is the failure mode this remediation mission exists to eliminate.
Found while making the three gates pass honestly for the remediation mission's TASK-0, rather than
reaching for
--no-verify.Related finding (NOT fixed here, deliberately)
While verifying this, I found that merged PR #868 shipped a file failing
pnpm format:check,meaning the CI format gate did not block it. An unrelated later PR (#872) then reformatted that file
as a side effect of its own pre-commit hook, so
mainwent green again and the gate's failure tofire left no lasting artifact.
That inert gate is intentionally not patched here. It is recorded as a first-class backlog item
(keystone dogfood case) so the conformance harness can be built to detect the class per-merge-commit
rather than by asking "is main green today" — which would report all-clear on this exact defect.
Verification
All three gates green locally with no bypass:
pnpm typecheck42/42,pnpm lint23/23,pnpm format:checkclean.PRE-REGISTERED ACCEPTANCE CHECKS (diff-blind)
Posted by the author before any reviewer reads the diff, per the remediation mission's delivery gates.
⇒0/⇒≠0denote required exit codes. Reviewer (rev-974): run these as written; do not adjust them to fit the implementation.AC1 — the gate still enforces over source. Introduce a deliberate formatting violation in a tracked source file (e.g.
packages/mosaic/src/**.ts):pnpm format:check⇒≠0 and names that file. Revert ⇒0.AC2 — the gate no longer scans generated Python trees. With a Python venv present under any workspace path (
mkdir -p apps/*/venv/lib+ an unformatted.md/.jsoninside):pnpm format:check⇒0. This is the must-fail negative control inverted — before this PR the same setup ⇒≠0.AC3 — no widening beyond the stated categories.
git diff main -- .prettierignoreadds ONLY**/venv,**/__pycache__,**/.mypy_cache,**/.pytest_cache,**/htmlcov. Any entry matching a source path (src/,packages/*/src,apps/*/src,docs/) ⇒ REJECT.AC4 — nothing else changed.
git diff --stat mainshows exactly 1 file, 8 insertions, 0 deletions.AC5 — full gate suite green on the head commit, unbypassed.
pnpm typecheck && pnpm lint && pnpm format:check⇒0, with no--no-verify/HUSKY=0/--ignore-scriptsin any committed script or CI step introduced by this PR.Reviewer note — the finding this PR deliberately does NOT fix
Merged PR #868 shipped a file failing
pnpm format:check, so the CI format gate did not block it; PR #872 later reformatted that file as a side effect, erasing the evidence. That inert gate is intentionally left unpatched and is banked as a first-class backlog item. Do not ask this PR to fix it — patching the symptom destroys the detection signal. Confirm only that this PR does not make that class harder to detect.VERDICT: APPROVE
Reviewed head
1f4c7c0d37988faffcc6a50aa0b6b194b190433fagainst the pre-registered checks before reading the diff.packages/mosaic/src/index.tsmadepnpm format:checkexit 1 and name that file. Aftergit restore, the command exited 0.apps/gateway/venv/lib/review-unformatted.jsonproduced exit 0. With only.prettierignorereplaced bymain's version, the same fixture produced exit 1 and named the file. This verifies both required directions. The literal snippetmkdir -p apps/*/venv/libis not runnable as intended in bash when novenvexists: the unmatched glob creates a literalapps/*/venv/libdirectory rather than directories under workspaces. I ran it exactly, observed that behavior, removed that fixture, and then ran the stated behavioral check at the explicit workspace path above; this was not a silent substitution.git diff main -- .prettierignoreadds exactly the five allowed ignore entries at.prettierignore:10-14:**/venv,**/__pycache__,**/.mypy_cache,**/.pytest_cache, and**/htmlcov. Nosrc/,packages/*/src,apps/*/src, ordocs/pattern was added.git check-ignoreconfirmed representative tracked source paths remain enforced; AC1 independently proves a real source violation is still detected.git diff --stat mainreports exactly.prettierignore | 8 ++++++++and1 file changed, 8 insertions(+); numstat is8 0 .prettierignore.pnpm typecheck && pnpm lint && pnpm format:check; all three exited 0 (45/45 typecheck tasks, 25/25 lint tasks, Prettier clean). The PR introduces no--no-verify,HUSKY=0, or--ignore-scriptsmarker.Findings: 0. The change does not make the PR #868 class harder to detect: generated Python artifact directories are excluded while ordinary tracked source remains covered. No out-of-scope remediation requested.
Woodpecker pipeline #2158 for this exact head had typecheck, lint, and format green and was still running its test step at review time; merge remains CI-gated and is outside this review task.
VERDICT: APPROVE
Reviewed head
1f4c7c0d37988faffcc6a50aa0b6b194b190433fagainst the pre-registered checks before reading the diff.packages/mosaic/src/index.tsmadepnpm format:checkexit 1 and name that file. Aftergit restore, the command exited 0.apps/gateway/venv/lib/review-unformatted.jsonproduced exit 0. With only.prettierignorereplaced bymain's version, the same fixture produced exit 1 and named the file. This verifies both required directions. The literal snippetmkdir -p apps/*/venv/libis not runnable as intended in bash when novenvexists: the unmatched glob creates a literalapps/*/venv/libdirectory rather than directories under workspaces. I ran it exactly, observed that behavior, removed that fixture, and then ran the stated behavioral check at the explicit workspace path above; this was not a silent substitution.git diff main -- .prettierignoreadds exactly the five allowed ignore entries at.prettierignore:10-14:**/venv,**/__pycache__,**/.mypy_cache,**/.pytest_cache, and**/htmlcov. Nosrc/,packages/*/src,apps/*/src, ordocs/pattern was added.git check-ignoreconfirmed representative tracked source paths remain enforced; AC1 independently proves a real source violation is still detected.git diff --stat mainreports exactly.prettierignore | 8 ++++++++and1 file changed, 8 insertions(+); numstat is8 0 .prettierignore.pnpm typecheck && pnpm lint && pnpm format:check; all three exited 0 (45/45 typecheck tasks, 25/25 lint tasks, Prettier clean). The PR introduces no--no-verify,HUSKY=0, or--ignore-scriptsmarker.Findings: 0. The change does not make the PR #868 class harder to detect: generated Python artifact directories are excluded while ordinary tracked source remains covered. No out-of-scope remediation requested.
Woodpecker pipeline #2158 for this exact head had typecheck, lint, and format green and was still running its test step at review time; merge remains CI-gated and is outside this review task.