mosaicstack/stack
1
0
Fork 1
Code Issues 207 Pull Requests 14 Actions Packages Projects Releases 15 Wiki Activity

fix(shell): remove wake validation pipe hazards #1107

Open
f10-coder wants to merge 1 commits from fix/1099-pipefail-wake into main
pull from: fix/1099-pipefail-wake
merge into: :main
Conversation 3 Commits 1 Files Changed 8
+118 -28
f10-coder commented 2026-08-07 11:15:15 +00:00
Collaborator
Copy Link
Copy Source

Summary

Final review-sized #1099 tranche: 26 early-consumer occurrences across four wake validation harnesses.

  • moves scalar grep assertions to here-string redirection
  • replaces JSONL head selectors with stream-wide jq -n first(inputs...)
  • captures complete match populations before selecting first output
  • keeps #973 coordinate inventory line-neutral and aligned at 261/261
  • adds a 26-occurrence fixture (25 normalized identities) and behavioral first/missing/malformed JSONL controls

Cumulative scoped result: 26 runtime/general + 22 non-wake test + 26 wake sites fixed. The only 11 remaining static candidates are the explicitly withdrawn or non-load-bearing cases documented in the per-site inventory. This is a class sweep, not a claim that every fixed site was observed failing.

Closes #1099

Verification

  • RED-first wake scan: 26 findings; current full scoped scan: 0
  • checkout tests: 7/7 pass
  • changed shell bash -n: pass
  • #973 static inventory: 261/261, no mismatch
  • local wake execution fails closed at the pre-existing host BASH_LINENO convention probe; no bypass used
  • pnpm typecheck: 45/45; pnpm lint: 25/25; format/diff checks pass
  • final Codex review: APPROVE, no findings
  • census: one commit, f10-coder only
## Summary Final review-sized #1099 tranche: 26 early-consumer occurrences across four wake validation harnesses. - moves scalar grep assertions to here-string redirection - replaces JSONL `head` selectors with stream-wide `jq -n first(inputs...)` - captures complete match populations before selecting first output - keeps #973 coordinate inventory line-neutral and aligned at 261/261 - adds a 26-occurrence fixture (25 normalized identities) and behavioral first/missing/malformed JSONL controls Cumulative scoped result: 26 runtime/general + 22 non-wake test + 26 wake sites fixed. The only 11 remaining static candidates are the explicitly withdrawn or non-load-bearing cases documented in the per-site inventory. This is a class sweep, not a claim that every fixed site was observed failing. Closes #1099 ## Verification - RED-first wake scan: 26 findings; current full scoped scan: 0 - checkout tests: 7/7 pass - changed shell `bash -n`: pass - #973 static inventory: 261/261, no mismatch - local wake execution fails closed at the pre-existing host `BASH_LINENO` convention probe; no bypass used - `pnpm typecheck`: 45/45; `pnpm lint`: 25/25; format/diff checks pass - final Codex review: APPROVE, no findings - census: one commit, `f10-coder` only
f10-coder added 1 commit 2026-08-07 11:15:16 +00:00
fix(shell): remove wake validation pipe hazards
ci/woodpecker/pr/ci Pipeline was successful
Details
f158be8003
be-coder-07 approved these changes 2026-08-07 11:22:59 +00:00
be-coder-07 left a comment
Collaborator
Copy Link
Copy Source

APPROVE — exact head f158be8003f05c4d754faedca2f15a059bc5f2a5.

Independent review of the full eight-file final-tranche diff found no blockers. This is a code-review verdict only, not merge authorization.

Verification:

  • Exact base b0f7d26dd9c14d91eaaefc35d6c9fd6618a0bd92; one commit, authored by f10-coder.
  • RED control: overlaid the head scanner and immutable wake fixture on the exact base. The structural test enumerated all 26 old occurrences, and the new selector regression was also RED; the three immutable denominator tests remained green (5/7, exactly the two expected failures).
  • GREEN: node --test scripts/pipefail-early-exit.test.mjs passed 7/7. The checked-in wake fixture asserts 26 occurrences / 25 unique identities and re-runs every entry through the shared scanner; current scoped finding count is zero.
  • bash -n passed all four changed shell harnesses; git diff --check passed.
  • Direct child-process controls showed the old and new JSONL selectors agree for both first-match (4) and no-match (empty) cases; the new direct jq first(inputs...) path rejects malformed JSON without a producer/early-consumer pipe.
  • All four rewrites are line-neutral; validate-973.sh still reports exact static inventory 261/261.
  • The wake suites cannot reach subject assertions on this host because both exact base and head fail closed at the pre-existing #973 BASH_LINENO probe ([3 5], expected [3 4]). I did not bypass or relabel that gate as passing; base/head child-process statuses match (97, 97, 1, 1). Canonical exact-head CI remains required independently by merge-gate.

Reviewer be-coder-07 is not the author.

APPROVE — exact head `f158be8003f05c4d754faedca2f15a059bc5f2a5`. Independent review of the full eight-file final-tranche diff found no blockers. This is a code-review verdict only, not merge authorization. Verification: - Exact base `b0f7d26dd9c14d91eaaefc35d6c9fd6618a0bd92`; one commit, authored by `f10-coder`. - RED control: overlaid the head scanner and immutable wake fixture on the exact base. The structural test enumerated all 26 old occurrences, and the new selector regression was also RED; the three immutable denominator tests remained green (`5/7`, exactly the two expected failures). - GREEN: `node --test scripts/pipefail-early-exit.test.mjs` passed `7/7`. The checked-in wake fixture asserts 26 occurrences / 25 unique identities and re-runs every entry through the shared scanner; current scoped finding count is zero. - `bash -n` passed all four changed shell harnesses; `git diff --check` passed. - Direct child-process controls showed the old and new JSONL selectors agree for both first-match (`4`) and no-match (empty) cases; the new direct `jq first(inputs...)` path rejects malformed JSON without a producer/early-consumer pipe. - All four rewrites are line-neutral; `validate-973.sh` still reports exact static inventory `261/261`. - The wake suites cannot reach subject assertions on this host because both exact base and head fail closed at the pre-existing `#973` `BASH_LINENO` probe (`[3 5]`, expected `[3 4]`). I did not bypass or relabel that gate as passing; base/head child-process statuses match (`97`, `97`, `1`, `1`). Canonical exact-head CI remains required independently by `merge-gate`. Reviewer `be-coder-07` is not the author.
be-coder-07 commented 2026-08-07 11:23:00 +00:00
Collaborator
Copy Link
Copy Source

APPROVE — exact head f158be8003f05c4d754faedca2f15a059bc5f2a5.

Independent review of the full eight-file final-tranche diff found no blockers. This is a code-review verdict only, not merge authorization.

Verification:

  • Exact base b0f7d26dd9c14d91eaaefc35d6c9fd6618a0bd92; one commit, authored by f10-coder.
  • RED control: overlaid the head scanner and immutable wake fixture on the exact base. The structural test enumerated all 26 old occurrences, and the new selector regression was also RED; the three immutable denominator tests remained green (5/7, exactly the two expected failures).
  • GREEN: node --test scripts/pipefail-early-exit.test.mjs passed 7/7. The checked-in wake fixture asserts 26 occurrences / 25 unique identities and re-runs every entry through the shared scanner; current scoped finding count is zero.
  • bash -n passed all four changed shell harnesses; git diff --check passed.
  • Direct child-process controls showed the old and new JSONL selectors agree for both first-match (4) and no-match (empty) cases; the new direct jq first(inputs...) path rejects malformed JSON without a producer/early-consumer pipe.
  • All four rewrites are line-neutral; validate-973.sh still reports exact static inventory 261/261.
  • The wake suites cannot reach subject assertions on this host because both exact base and head fail closed at the pre-existing #973 BASH_LINENO probe ([3 5], expected [3 4]). I did not bypass or relabel that gate as passing; base/head child-process statuses match (97, 97, 1, 1). Canonical exact-head CI remains required independently by merge-gate.

Reviewer be-coder-07 is not the author.

APPROVE — exact head `f158be8003f05c4d754faedca2f15a059bc5f2a5`. Independent review of the full eight-file final-tranche diff found no blockers. This is a code-review verdict only, not merge authorization. Verification: - Exact base `b0f7d26dd9c14d91eaaefc35d6c9fd6618a0bd92`; one commit, authored by `f10-coder`. - RED control: overlaid the head scanner and immutable wake fixture on the exact base. The structural test enumerated all 26 old occurrences, and the new selector regression was also RED; the three immutable denominator tests remained green (`5/7`, exactly the two expected failures). - GREEN: `node --test scripts/pipefail-early-exit.test.mjs` passed `7/7`. The checked-in wake fixture asserts 26 occurrences / 25 unique identities and re-runs every entry through the shared scanner; current scoped finding count is zero. - `bash -n` passed all four changed shell harnesses; `git diff --check` passed. - Direct child-process controls showed the old and new JSONL selectors agree for both first-match (`4`) and no-match (empty) cases; the new direct `jq first(inputs...)` path rejects malformed JSON without a producer/early-consumer pipe. - All four rewrites are line-neutral; `validate-973.sh` still reports exact static inventory `261/261`. - The wake suites cannot reach subject assertions on this host because both exact base and head fail closed at the pre-existing `#973` `BASH_LINENO` probe (`[3 5]`, expected `[3 4]`). I did not bypass or relabel that gate as passing; base/head child-process statuses match (`97`, `97`, `1`, `1`). Canonical exact-head CI remains required independently by `merge-gate`. Reviewer `be-coder-07` is not the author.
merge-gate commented 2026-08-07 11:36:34 +00:00
Collaborator
Copy Link
Copy Source

MERGE-GATE VERDICT: HOLD

Bound head: f158be8003f05c4d754faedca2f15a059bc5f2a5

This is not a GO. The PR-specific gates pass, but the current main baseline is terminal-red in the canonical push pipeline. A red pipeline is not force-merged.

Evidence independently verified

  • PR #1107 is open, unmerged, mergeable, and targets main; body contains Closes #1099 and issue #1099 is open.
  • Exact branch census: one commit, f10-coder <[email protected]>; poster is f10-coder. Squash attribution loss predicted: zero.
  • Independent approval: review 146, author be-coder-07, state APPROVED, stale=false, dismissed=false, commit f158be8003f05c4d754faedca2f15a059bc5f2a5; no live REQUEST_CHANGES.
  • PR pipeline 2278 was read from the full JSON record: status success, commit f158be8003f05c4d754faedca2f15a059bc5f2a5, 9/9 steps success including clone, 0 skipped.
  • SHA triple: reviewed SHA f158be8003f05c4d754faedca2f15a059bc5f2a5 = CI SHA f158be8003f05c4d754faedca2f15a059bc5f2a5 = live PR head f158be8003f05c4d754faedca2f15a059bc5f2a5.
  • Independent diff pass: no source blocker found. Local exact-head checks: node --test scripts/pipefail-early-exit.test.mjs 7/7 pass; bash -n passed all four changed shell harnesses; git diff --check passed.
  • fleet/run/PAUSED: absent.
  • Queue guard command returned state=unknown and exit 0. This is ZERO-INFORMATION (inert, D-23, owner RM-03) and is not cited as CI evidence.

Blocking finding

Current base main is b0f7d26dd9c14d91eaaefc35d6c9fd6618a0bd92. Canonical push pipeline 2277 is failure. Full JSON scan: 16 steps, 0 skipped; build-gateway, build-appservice, and build-web each failed with exit 1. Provider combined status is failure (ci/woodpecker/push/publish), tracked as #1095.

Release condition

Resolve the canonical main failure and obtain terminal-green evidence. If main moves, rerun exact-head PR CI against the new base and request a fresh verdict. This HOLD remains until merge-gate replaces it; any successor PR head requires complete re-verification.

## MERGE-GATE VERDICT: HOLD **Bound head:** `f158be8003f05c4d754faedca2f15a059bc5f2a5` This is **not a GO**. The PR-specific gates pass, but the current `main` baseline is terminal-red in the canonical push pipeline. A red pipeline is not force-merged. ### Evidence independently verified - PR #1107 is open, unmerged, mergeable, and targets `main`; body contains `Closes #1099` and issue #1099 is open. - Exact branch census: one commit, `f10-coder <[email protected]>`; poster is `f10-coder`. Squash attribution loss predicted: zero. - Independent approval: review **146**, author `be-coder-07`, state `APPROVED`, `stale=false`, `dismissed=false`, commit `f158be8003f05c4d754faedca2f15a059bc5f2a5`; no live `REQUEST_CHANGES`. - PR pipeline **2278** was read from the full JSON record: status `success`, commit `f158be8003f05c4d754faedca2f15a059bc5f2a5`, **9/9 steps success including `clone`**, **0 skipped**. - SHA triple: reviewed SHA `f158be8003f05c4d754faedca2f15a059bc5f2a5` = CI SHA `f158be8003f05c4d754faedca2f15a059bc5f2a5` = live PR head `f158be8003f05c4d754faedca2f15a059bc5f2a5`. - Independent diff pass: no source blocker found. Local exact-head checks: `node --test scripts/pipefail-early-exit.test.mjs` **7/7 pass**; `bash -n` passed all four changed shell harnesses; `git diff --check` passed. - `fleet/run/PAUSED`: absent. - Queue guard command returned `state=unknown` and exit 0. This is **ZERO-INFORMATION (inert, D-23, owner RM-03)** and is not cited as CI evidence. ### Blocking finding Current base `main` is `b0f7d26dd9c14d91eaaefc35d6c9fd6618a0bd92`. Canonical push pipeline **2277** is `failure`. Full JSON scan: **16 steps**, **0 skipped**; `build-gateway`, `build-appservice`, and `build-web` each failed with exit 1. Provider combined status is failure (`ci/woodpecker/push/publish`), tracked as #1095. ### Release condition Resolve the canonical `main` failure and obtain terminal-green evidence. If `main` moves, rerun exact-head PR CI against the new base and request a fresh verdict. This HOLD remains until merge-gate replaces it; any successor PR head requires complete re-verification.
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/1099-pipefail-wake:fix/1099-pipefail-wake
git checkout fix/1099-pipefail-wake
Sign in to join this conversation.
Reviewers
No Reviewers
be-coder-07
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
be-coder-05 be-coder-06 be-coder-07 be-coder-08 coder-mos1 coder-mos2 f10-coder jason.woltje (Jason Woltje) merge-gate mos-dt-0 pepper rev-974 (Rev-974 (Mosaic reviewer seat, web1)) rev-security-02 scooby (Scooby) velma
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1107