mosaicstack/stack
16
0
Fork 1
Code Issues 330 Pull Requests 11 Actions Packages Projects Releases 15 Wiki Activity

#1156-C: exact legacy provider, agent, route and model selection #1181

New Issue
Open
opened 2026-08-13 00:29:56 +00:00 by Ghost · 0 comments
Ghost commented 2026-08-13 00:29:56 +00:00
Copy Link
Copy Source

Child of #1156. Remove remaining exact-selection substitution/no-op success in legacy surfaces.

Adjudicated findings

  • FL-04: partial/ambiguous supplied selection and duplicate model-only lookup can silently choose another provider. Truly absent selection may remain a separately typed legacy automatic-routing mode, but it requires an explicit deterministic policy rather than accidental available[0] selection.
  • FL-05: supplied unresolved agentConfigId is ignored; execution proceeds under default agent/provider/model behavior.
  • FL-12: legacy /model <free text> is production-reachable, lacks catalog validation, changes metadata rather than reconstructing the active runtime, and can report success without confirmed runtime application.
  • Dead RoutingEngineService still encodes unconditional cross-provider fallback; it must stay mechanically unreachable or be removed/rewritten.

Dropped after independent adjudication: FL-06. /api/providers/route accepts a documented legacy preferred criterion under automatic score-routing; preferred is not a binding exact tuple. A future binding-selection API must be separately typed and must never reuse this fallback contract.

Binding outcome

  • Supplied provider/model/agent choices are exact and binding. Partial, ambiguous, unknown or unavailable supplied choices fail typed with no session/provider creation.
  • A truly absent selection, if retained, enters only an explicit automatic-routing mode with a deterministic reviewed default policy—never incidental first-array choice.
  • Unresolved supplied agent config fails before model/prompt/tool resolution.
  • Legacy /model is disabled pending catalog-qualified semantics, or accepts only a catalog-qualified tuple and reports success only after confirmed runtime application.
  • Add a mechanical no-production-consumer fence for any retained dead fallback engine.
  • Red-first boundary matrix, full Gateway tests/typecheck/lint/build, independent exact-head verifier and focused code/security review.

This child binds before native stage, not W-F1. Preserve owner-tracked legacy continuity boundaries. Split AgentService resolution and /model retirement if the candidate crosses a bounded exact-selection packet.

Child of #1156. Remove remaining exact-selection substitution/no-op success in legacy surfaces. ## Adjudicated findings - FL-04: **partial/ambiguous supplied selection** and duplicate model-only lookup can silently choose another provider. Truly absent selection may remain a separately typed legacy automatic-routing mode, but it requires an explicit deterministic policy rather than accidental `available[0]` selection. - FL-05: supplied unresolved `agentConfigId` is ignored; execution proceeds under default agent/provider/model behavior. - FL-12: legacy `/model <free text>` is production-reachable, lacks catalog validation, changes metadata rather than reconstructing the active runtime, and can report success without confirmed runtime application. - Dead `RoutingEngineService` still encodes unconditional cross-provider fallback; it must stay mechanically unreachable or be removed/rewritten. **Dropped after independent adjudication:** FL-06. `/api/providers/route` accepts a documented legacy *preferred* criterion under automatic score-routing; preferred is not a binding exact tuple. A future binding-selection API must be separately typed and must never reuse this fallback contract. ## Binding outcome - Supplied provider/model/agent choices are exact and binding. Partial, ambiguous, unknown or unavailable supplied choices fail typed with no session/provider creation. - A truly absent selection, if retained, enters only an explicit automatic-routing mode with a deterministic reviewed default policy—never incidental first-array choice. - Unresolved supplied agent config fails before model/prompt/tool resolution. - Legacy `/model` is disabled pending catalog-qualified semantics, or accepts only a catalog-qualified tuple and reports success only after confirmed runtime application. - Add a mechanical no-production-consumer fence for any retained dead fallback engine. - Red-first boundary matrix, full Gateway tests/typecheck/lint/build, independent exact-head verifier and focused code/security review. This child binds before native stage, not W-F1. Preserve owner-tracked legacy continuity boundaries. Split AgentService resolution and `/model` retirement if the candidate crosses a bounded exact-selection packet.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-infra-01 (Mosaic fleet seat code-infra-01) fargo fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) pepper rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) sanity scooby (Scooby) scrappy shaggy tiny velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1181