mosaicstack/stack
1
0
Fork 1
Code Issues 246 Pull Requests 7 Actions Packages Projects Releases 15 Wiki Activity

test(mosaic): isolate background update notice from CLI smoke stderr assertions #1190

New Issue
Open
opened 2026-08-13 01:13:00 +00:00 by be-coder-06 · 0 comments
be-coder-06 commented 2026-08-13 01:13:00 +00:00
Collaborator
Copy Link
Copy Source

Defect

packages/mosaic/src/cli-smoke.spec.ts asserts that stderr is empty for the production CLI's bare --source, --decisions, and --observations blocked-JSON cases. The production CLI also starts a background update check that writes an update notice to the same stderr stream, so these tests depend on shared cached/update state they do not own.

Reproduction

At stack branch fix/1182-fail-closed-launch based on origin/next 216cd72226cd9ee17eea461cfe7cd0e010a22f02, after a full repository build:

pnpm --filter @mosaicstack/mosaic exec vitest run src/cli-smoke.spec.ts --reporter=verbose

Reproduced 3/3 production CLI cases failing at src/cli-smoke.spec.ts:72:

AssertionError: expected update-notice stderr to be ''
Update available: 0.0.48 → 0.0.49
Tests  3 failed | 19 passed (22)

The JSON behavior and exit status remain correct; only the unowned stderr assertion fails.

Required outcome

Make production CLI smoke tests deterministic without suppressing a real update-check failure globally. Bound or inject the update-check/notification dependency for these cases, or assert only the stderr contract each command owns. Add a negative control proving an unrelated background notice cannot make blocked JSON coverage red or disappear.

Scope

Separate from #1182. Do not fold this into fail-closed runtime/storage/launcher work.

## Defect `packages/mosaic/src/cli-smoke.spec.ts` asserts that stderr is empty for the production CLI's bare `--source`, `--decisions`, and `--observations` blocked-JSON cases. The production CLI also starts a background update check that writes an update notice to the same stderr stream, so these tests depend on shared cached/update state they do not own. ## Reproduction At stack branch `fix/1182-fail-closed-launch` based on `origin/next` `216cd72226cd9ee17eea461cfe7cd0e010a22f02`, after a full repository build: ```bash pnpm --filter @mosaicstack/mosaic exec vitest run src/cli-smoke.spec.ts --reporter=verbose ``` Reproduced 3/3 production CLI cases failing at `src/cli-smoke.spec.ts:72`: ```text AssertionError: expected update-notice stderr to be '' Update available: 0.0.48 → 0.0.49 Tests 3 failed | 19 passed (22) ``` The JSON behavior and exit status remain correct; only the unowned stderr assertion fails. ## Required outcome Make production CLI smoke tests deterministic without suppressing a real update-check failure globally. Bound or inject the update-check/notification dependency for these cases, or assert only the stderr contract each command owns. Add a negative control proving an unrelated background notice cannot make blocked JSON coverage red or disappear. ## Scope Separate from #1182. Do not fold this into fail-closed runtime/storage/launcher work.
be-coder-06 added the bug label 2026-08-13 01:13:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
be-coder-05 be-coder-06 be-coder-07 be-coder-08 coder-mos1 coder-mos2 coder2 coder3 f10-coder fred happy jason.woltje (Jason Woltje) merge-gate mos-dt-0 pepper rev-974 (Rev-974 (Mosaic reviewer seat, web1)) rev-security-02 rev0 sanity scooby (Scooby) scrappy shaggy tess velma
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1190