mosaicstack/stack
16
0
Fork 1
Code Issues 330 Pull Requests 11 Actions Packages Projects Releases 15 Wiki Activity

test(gateway): cross-user isolation teardown retries DB after setup failure #1193

New Issue
Open
opened 2026-08-13 01:58:28 +00:00 by Ghost · 0 comments
Ghost commented 2026-08-13 01:58:28 +00:00
Copy Link
Copy Source

Defect

apps/gateway/src/__tests__/cross-user-isolation.test.ts intends to skip when PostgreSQL is unavailable, but beforeAll assigns handle = createDb() before the first query. If connection/authentication then fails, dbAvailable remains false and tests skip, while afterAll sees a truthy handle and performs the full cleanup query sequence anyway.

Observed during an isolated exact-head review: an inherited ambient DATABASE_URL had invalid credentials. Setup caught the authentication failure as designed, then teardown retried DELETE and failed the entire Gateway suite. This also means an ad-hoc test shell can unexpectedly attempt whatever database its ambient environment names.

Required behavior

  • An unavailable/unauthorized setup leaves teardown with zero database queries.
  • Cleanup runs only after fixture creation reached a proven state.
  • A partially-created fixture cleans only safely-known state and closes the handle.
  • Tests never infer permission to use an ambient database silently; the required test database route is explicit and documented.
  • Connection/auth failures remain credential-safe and do not echo DSNs.

Acceptance

  1. Behavior-first regression reproduces setup failure after handle construction and proves zero teardown query attempts.
  2. Success path still cleans all fixed fixture rows and closes exactly once.
  3. Partial-setup failure has deterministic cleanup/close semantics.
  4. Full Gateway CI remains terminal green with the canonical disposable CI PostgreSQL service.
  5. Independent review verifies no production code or isolation assertions were weakened.

This issue records a test-harness safety/reliability defect. It does not authorize connecting to a host, daemon, shared, or production database.

## Defect `apps/gateway/src/__tests__/cross-user-isolation.test.ts` intends to skip when PostgreSQL is unavailable, but `beforeAll` assigns `handle = createDb()` before the first query. If connection/authentication then fails, `dbAvailable` remains false and tests skip, while `afterAll` sees a truthy handle and performs the full cleanup query sequence anyway. Observed during an isolated exact-head review: an inherited ambient `DATABASE_URL` had invalid credentials. Setup caught the authentication failure as designed, then teardown retried `DELETE` and failed the entire Gateway suite. This also means an ad-hoc test shell can unexpectedly attempt whatever database its ambient environment names. ## Required behavior - An unavailable/unauthorized setup leaves teardown with zero database queries. - Cleanup runs only after fixture creation reached a proven state. - A partially-created fixture cleans only safely-known state and closes the handle. - Tests never infer permission to use an ambient database silently; the required test database route is explicit and documented. - Connection/auth failures remain credential-safe and do not echo DSNs. ## Acceptance 1. Behavior-first regression reproduces setup failure after handle construction and proves zero teardown query attempts. 2. Success path still cleans all fixed fixture rows and closes exactly once. 3. Partial-setup failure has deterministic cleanup/close semantics. 4. Full Gateway CI remains terminal green with the canonical disposable CI PostgreSQL service. 5. Independent review verifies no production code or isolation assertions were weakened. This issue records a test-harness safety/reliability defect. It does not authorize connecting to a host, daemon, shared, or production database.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-infra-01 (Mosaic fleet seat code-infra-01) fargo fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) pepper rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) sanity scooby (Scooby) scrappy shaggy tiny velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1193