mosaicstack/stack
6
0
Fork 1
Code Issues 298 Pull Requests 18 Actions Packages Projects Releases 15 Wiki Activity

guides: three guides fail prettier 3.9.6 and will break the format gate when the pin moves past 3.8.1 #1317

New Issue
Open
opened 2026-08-19 16:03:37 +00:00 by fred · 0 comments
fred commented 2026-08-19 16:03:37 +00:00
Collaborator
Copy Link
Copy Source

Tracking issue requested by rev-code-02 in its review of #1316, so the flag survives that PR's merge.

The problem

packages/mosaic/framework/guides/ contains three files that are green today only because the lockfile pins prettier 3.8.1:

  • CI-CD-PIPELINES.md
  • ORCHESTRATOR-PROTOCOL.md
  • VAULT-SECRETS.md

Under prettier 3.9.6 all three fail --check. The day the pin moves past 3.8.1, the format step goes red on a change that touches none of them.

Why it was not fixed in #1316

Not deferred for convenience — fixing it today breaks CI as it currently runs. rev-code-02 established this by running 3.9.6 --write on copies and then checking the result with the pinned 3.8.1: ORCHESTRATOR-PROTOCOL.md then fails the current gate.

So the two formats are mutually exclusive. There is no edit that satisfies 3.8.1 and 3.9.6 at once for that file, which means the reformat cannot land before the pin moves.

The sound fix point

The same PR that bumps the prettier pin. That PR should:

  1. Move the pin in package.json and the lockfile.
  2. Reformat these three files with the new version in the same commit.
  3. Confirm the format step is green at the new pin.

Doing it in that order keeps the gate green at every commit.

Related

  • #1316 adds review rules 13 and 14 about running the pinned tool version and reporting a formatting failure with the version that produced it. This issue is the concrete instance those rules were derived from.
  • Declared range is ^3.0.0, which is what allows the resolved version to drift. Pinning exactly would make the gate's verdict reproducible over time rather than dependent on when the lockfile was last resolved — worth considering as part of the same change.
Tracking issue requested by rev-code-02 in its review of #1316, so the flag survives that PR's merge. ## The problem `packages/mosaic/framework/guides/` contains three files that are green today only because the lockfile pins prettier 3.8.1: - `CI-CD-PIPELINES.md` - `ORCHESTRATOR-PROTOCOL.md` - `VAULT-SECRETS.md` Under prettier 3.9.6 all three fail `--check`. The day the pin moves past 3.8.1, the format step goes red on a change that touches none of them. ## Why it was not fixed in #1316 Not deferred for convenience — **fixing it today breaks CI as it currently runs.** rev-code-02 established this by running 3.9.6 `--write` on copies and then checking the result with the pinned 3.8.1: `ORCHESTRATOR-PROTOCOL.md` then **fails the current gate**. So the two formats are mutually exclusive. There is no edit that satisfies 3.8.1 and 3.9.6 at once for that file, which means the reformat cannot land before the pin moves. ## The sound fix point The same PR that bumps the prettier pin. That PR should: 1. Move the pin in `package.json` and the lockfile. 2. Reformat these three files with the new version in the same commit. 3. Confirm the format step is green at the new pin. Doing it in that order keeps the gate green at every commit. ## Related - #1316 adds review rules 13 and 14 about running the pinned tool version and reporting a formatting failure with the version that produced it. This issue is the concrete instance those rules were derived from. - Declared range is `^3.0.0`, which is what allows the resolved version to drift. Pinning exactly would make the gate's verdict reproducible over time rather than dependent on when the lockfile was last resolved — worth considering as part of the same change.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
fargo fred happy jason.woltje (Jason Woltje) merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) pepper rev-code-01 rev-code-02 rev-security-01 rev-security-02 sanity scooby (Scooby) scrappy shaggy tiny velma vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1317