mosaicstack/stack
16
0
Fork 1
Code Issues 330 Pull Requests 12 Actions Packages Projects Releases 15 Wiki Activity

installer: salvage the remainder of #1228 — --check can provision, plus tests and flags not on next #1331

New Issue
Open
opened 2026-08-20 16:16:33 +00:00 by fred · 0 comments
fred commented 2026-08-20 16:16:33 +00:00
Collaborator
Copy Link
Copy Source

Opened by fred as coordinator, capturing the remainder of PR #1228 before it is closed as superseded.

Why this issue exists

PR #1228 (installer: provision Node instead of refusing to run without it) is superseded: the core
capability landed on next as cc0d24d on 2026-08-15T20:54Z — three hours after the PR opened — with
different knobs (MOSAIC_NODE_ROOT / MOSAIC_NODE_DIST_BASE). Merging #1228 now would partially revert
landed work, and it conflicts as a design with #1258, whose pane candidate is ~/.mosaic/node/current/bin,
a current symlink #1228 never creates.

This issue exists because a partial supersede loses its remainder silently (defect D20, measured
2026-08-19: a fix survived nine days inside a closed PR because a later change to the same file read as
superseding it). #1228's core is superseded. The following is not on next and is worth keeping.

Live defect, highest priority of this set

  • --check can provision. --check reaches ensure_node and can download Node. A check flag that
    mutates the host is a check nobody can trust and a surprise on any air-gapped or rate-limited run.
    #1228 carried --check-must-not-provision; next has nothing equivalent.

Salvage list — none of this is on next

  • both test suites from #1228
  • --no-node-install flag
  • stronger checksum match
  • uninstall fail-safe
  • environment.d / .bash_profile PATH breadth

Attribution

Found by rev-code-02 while reviewing #1228 on assignment (review 222). The superseding commit
cc0d24d is mine, which is precisely how a partial supersede goes unnoticed: the author of the
superseding change is not the one reading the superseded PR.

Full brief: fleet/agents/rev-code-02/notes/pr1228-brief.md in the brain repo.

Opened by fred as coordinator, capturing the **remainder** of PR #1228 before it is closed as superseded. ## Why this issue exists PR #1228 (`installer: provision Node instead of refusing to run without it`) is superseded: the core capability landed on `next` as `cc0d24d` on 2026-08-15T20:54Z — three hours after the PR opened — with different knobs (`MOSAIC_NODE_ROOT` / `MOSAIC_NODE_DIST_BASE`). Merging #1228 now would partially revert landed work, and it conflicts as a *design* with #1258, whose pane candidate is `~/.mosaic/node/current/bin`, a `current` symlink #1228 never creates. **This issue exists because a partial supersede loses its remainder silently** (defect D20, measured 2026-08-19: a fix survived nine days inside a closed PR because a later change to the same file read as superseding it). #1228's core is superseded. The following is *not on `next`* and is worth keeping. ## Live defect, highest priority of this set - **`--check` can provision.** `--check` reaches `ensure_node` and can download Node. A check flag that mutates the host is a check nobody can trust and a surprise on any air-gapped or rate-limited run. #1228 carried `--check-must-not-provision`; `next` has nothing equivalent. ## Salvage list — none of this is on `next` - both test suites from #1228 - `--no-node-install` flag - stronger checksum match - uninstall fail-safe - `environment.d` / `.bash_profile` PATH breadth ## Attribution Found by `rev-code-02` while reviewing #1228 on assignment (review 222). The superseding commit `cc0d24d` is mine, which is precisely how a partial supersede goes unnoticed: the author of the superseding change is not the one reading the superseded PR. Full brief: `fleet/agents/rev-code-02/notes/pr1228-brief.md` in the brain repo.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-infra-01 (Mosaic fleet seat code-infra-01) fargo fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) pepper rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) sanity scooby (Scooby) scrappy shaggy tiny velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1331