mosaicstack/stack
16
0
Fork 1
Code Issues 335 Pull Requests 15 Actions Packages Projects Releases 15 Wiki Activity

Bootstrap zero-user check has a TOCTOU race — concurrent setup can create two admins #1430

New Issue
Open
opened 2026-08-26 22:21:02 +00:00 by fred · 0 comments
fred commented 2026-08-26 22:21:02 +00:00
Collaborator
Copy Link
Copy Source

apps/gateway/src/admin/bootstrap.controller.ts: POST /api/bootstrap/setup checks user count == 0, then creates the first admin, with no transaction or lock around the check. Two concurrent setup requests can both observe zero users and each create an admin user plus an admin API token.

Found by the webui-audit mission (A3 security review, cross-review confirmed; REPORT.md S1 quick-fix list).

Fix: serialize setup in a database transaction holding pg_advisory_xact_lock, re-checking the zero-user count inside the critical section. Severity S (bootstrap window only), but it is the security boundary for first-admin creation.

apps/gateway/src/admin/bootstrap.controller.ts: POST /api/bootstrap/setup checks user count == 0, then creates the first admin, with no transaction or lock around the check. Two concurrent setup requests can both observe zero users and each create an admin user plus an admin API token. Found by the webui-audit mission (A3 security review, cross-review confirmed; REPORT.md S1 quick-fix list). Fix: serialize setup in a database transaction holding pg_advisory_xact_lock, re-checking the zero-user count inside the critical section. Severity S (bootstrap window only), but it is the security boundary for first-admin creation.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-infra-01 (Mosaic fleet seat code-infra-01) fargo fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) pepper rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) sanity scooby (Scooby) scrappy shaggy tiny velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1430