mosaicstack/stack
16
0
Fork 1
Code Issues 335 Pull Requests 15 Actions Packages Projects Releases 15 Wiki Activity

CI flake: nondeterministic mass TS2786 typecheck failures from duplicate @types/react majors in lockfile #1449

New Issue
Open
opened 2026-08-27 07:29:23 +00:00 by fred · 0 comments
fred commented 2026-08-27 07:29:23 +00:00
Collaborator
Copy Link
Copy Source

Summary

CI typecheck fails nondeterministically with mass TS2786 errors ("'X' cannot be used as a JSX component ... Property 'children' is missing in type 'ReactPortal'") across apps/web, on diffs that cannot cause it (docs-only). This is a distinct flake class from #1448 (SPA spec timeouts) and #1349 (slow-node test timing).

Evidence

  • Pipeline 2869 (branch contract/custody-schema, head f8ac64f5, docs-only diff vs next): typecheck PASS. Real run — turbo cache-miss lines present in the log.
  • Pipeline 2870 (branch contract/onboarding-wizard, head 3824fc6a, docs-only diff vs next): typecheck FAIL with mass TS2786, minutes later on the same base (a3b0770205bf84146d3921d75b17b9fe3ab52afb). Also a real run (cache miss).
  • Same lockfile in both runs. Both diffs add a single file under docs/requirements/ — nothing that can change type resolution.

Root cause hypothesis

pnpm-lock.yaml legitimately contains two @types/react majors: @types/[email protected] (10 refs, pulled by transitive deps) and @types/[email protected] (declared by apps/web as ^19.0.0). The CI install is pnpm install --frozen-lockfile --prefer-offline from a baked store. Under load, hoisting/resolution nondeterministically lets the 18.x types win for apps/web's typecheck, producing the ReactPortal/children mismatch (React 18 vs 19 type shape).

Suggested fixes (either closes the class)

  1. Add a pnpm override pinning @types/react (and @types/react-dom) to the 19.x version workspace-wide, so only one major exists in the resolution graph.
  2. Or scope the 18.x consumers with packageExtensions/peerDependencyRules so their types never hoist into apps/web.

Impact

Red pipelines on unrelated PRs; each occurrence costs a full CI re-run (~4h queue under current load). Observed on 2870 (2026-08-27).

## Summary CI typecheck fails nondeterministically with mass TS2786 errors ("'X' cannot be used as a JSX component ... Property 'children' is missing in type 'ReactPortal'") across `apps/web`, on diffs that cannot cause it (docs-only). This is a distinct flake class from #1448 (SPA spec timeouts) and #1349 (slow-node test timing). ## Evidence - Pipeline 2869 (branch `contract/custody-schema`, head `f8ac64f5`, docs-only diff vs `next`): typecheck PASS. Real run — turbo cache-miss lines present in the log. - Pipeline 2870 (branch `contract/onboarding-wizard`, head `3824fc6a`, docs-only diff vs `next`): typecheck FAIL with mass TS2786, minutes later on the same base (`a3b0770205bf84146d3921d75b17b9fe3ab52afb`). Also a real run (cache miss). - Same lockfile in both runs. Both diffs add a single file under `docs/requirements/` — nothing that can change type resolution. ## Root cause hypothesis `pnpm-lock.yaml` legitimately contains two `@types/react` majors: `@types/[email protected]` (10 refs, pulled by transitive deps) and `@types/[email protected]` (declared by `apps/web` as `^19.0.0`). The CI install is `pnpm install --frozen-lockfile --prefer-offline` from a baked store. Under load, hoisting/resolution nondeterministically lets the 18.x types win for `apps/web`'s typecheck, producing the ReactPortal/children mismatch (React 18 vs 19 type shape). ## Suggested fixes (either closes the class) 1. Add a pnpm override pinning `@types/react` (and `@types/react-dom`) to the 19.x version workspace-wide, so only one major exists in the resolution graph. 2. Or scope the 18.x consumers with `packageExtensions`/`peerDependencyRules` so their types never hoist into `apps/web`. ## Impact Red pipelines on unrelated PRs; each occurrence costs a full CI re-run (~4h queue under current load). Observed on 2870 (2026-08-27).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-infra-01 (Mosaic fleet seat code-infra-01) fargo fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) pepper rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) sanity scooby (Scooby) scrappy shaggy tiny velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1449