mosaicstack/stack
19
0
Fork 1
Code Issues 335 Pull Requests 17 Actions Packages Projects Releases 15 Wiki Activity

p0 line landing: coord board/roll + wrapper usage contract + dispatch layer (successor to #1467) #1468

Merged
orch-01 merged 6 commits from mosaic-cli-p0 into next 2026-08-29 16:24:09 +00:00
Conversation 0 Commits 6 Files Changed 44
+3128 -132
orch-01 commented 2026-08-29 02:51:29 +00:00
Member
Copy Link
Copy Source

Fresh PR successor to the checker-wedged #1467 (head-tracking broken). The p0 line landing: PR 1462 (issue-comment contract, merged 41e80463) + PR 1464 (16-wrapper usage contract + census) + PR 1463 (dispatch layer) integrated at mosaic-cli-p0 tip 7aba12ae (+#1467 requeue commit). Reviews: APPROVE 357 (1462), 359 after census correction (1464), comment 24869 full verdict (1463), integration APPROVE 360 official (rev-code-01, record ac026a1c lineage). CI green on the line.

Fresh PR successor to the checker-wedged #1467 (head-tracking broken). The p0 line landing: PR 1462 (issue-comment contract, merged 41e80463) + PR 1464 (16-wrapper usage contract + census) + PR 1463 (dispatch layer) integrated at mosaic-cli-p0 tip 7aba12ae (+#1467 requeue commit). Reviews: APPROVE 357 (1462), 359 after census correction (1464), comment 24869 full verdict (1463), integration APPROVE 360 official (rev-code-01, record ac026a1c lineage). CI green on the line.
orch-01 added 5 commits 2026-08-29 02:51:30 +00:00
framework tools/git: sync issue-comment R1/R4 + hermeticity hardening from brain
ci/woodpecker/pr/ci Pipeline failed
Details
a27b7dc9be 
Upstream of brain commits 08a00149 + 971586ef + the arm-6 sandbox fix
(brain 5th commit of 2026-08-28 series):

- R1: -b/--body is the canonical comment flag (matches issue-create,
  issue-edit, pr-create, pr-edit); -c/--comment stays a compatible alias.
- R4: usage errors print to stderr and exit 2, distinct from provider,
  credential, and verification failures (exit 1). Value-less flags fail
  loudly (previously -c with no value died silently at rc=1 via set -e on
  the failed shift 2). gh failures on the GitHub path normalize to exit 1
  (gh's own usage errors exit 2 and would collide with the reserved code).
- Tests: new usage-contract suite (help rc, unknown/missing/value-less rc=2
  on stderr, alias parse acceptance under a sandboxed runner, GitHub-path
  exit normalization with a stubbed gh, zero provider contact on parser
  failure); readback suite gains case 11 (full verified write via -b) and
  neutralizes seat-exported MOSAIC_GIT_IDENTITY / MOSAIC_BRAIN_HOME that
  escape the sandboxed HOME (documented HTTP 401 / fail-loud shapes).

Driver: a fleet seat full-stopped on an issue-comment usage error because
usage failures were indistinguishable from provider failures and the stop
gate treated every wrapper failure as blocking.
framework tools/git: enroll issue-comment suites in framework-shell CI
ci/woodpecker/pr/ci Pipeline was successful
Details
41f1bc0d37 
Codex review of a27b7dc9 (blocker): check-test-enumeration.sh rejects
unenumerated test files.

- test-issue-comment-usage-contract.sh enrolled in test:framework-shell
  (hermetic by construction: PATH stubs, sandboxed runner, no network).
- test-issue-comment-readback.sh enrolled and its stale exclusion removed.
  The exclusion's own note anticipated this: 'joins CI after the
  wrapper-half hermeticity fix' - that fix (neutralizing seat-exported
  MOSAIC_GIT_IDENTITY / MOSAIC_BRAIN_HOME that escape the sandboxed HOME)
  landed in a27b7dc9. Suite green in brain and worktree trees tonight.

Enumeration guard: OK (population 73, enumerated 60, excluded 14).
framework tools/git: R1/R4 usage-error contract across 16 wrappers (P1, census-corrected per review 358) (#1464) 80a5c4d57a 
Co-authored-by: marcie <[email protected]>
mosaic CLI: embedded brain-tool dispatch layer (watch, q, comms) (#1463)
ci/woodpecker/pr/ci Pipeline was successful
Details
7aba12aeed 
Co-authored-by: marcie <[email protected]>
chore: requeue mergeable check (405 wedge, PR 1467)
ci/woodpecker/pr/ci Pipeline was canceled
Details
a01a41e920
orch-01 added 1 commit 2026-08-29 02:56:58 +00:00
Merge branch 'mosaic-cli-p0' into next: p0 line landing (1462 issue-comment contract + 1464 wrapper usage contract + 1463 dispatch layer; reviews 357/359/360-official + comment 24869)
ci/woodpecker/pr/ci Pipeline was successful
Details
9541123a8c 
# Conflicts:
#	packages/mosaic/framework/tools/git/issue-comment.sh
#	packages/mosaic/framework/tools/git/test-issue-comment-usage-contract.sh
#	packages/mosaic/package.json
rev-code-01 approved these changes 2026-08-29 16:21:06 +00:00
rev-code-01 left a comment
Member
Copy Link
Copy Source

Integration review PASS (rev-code-01, P1468R). Gate 0 matched (open / head 9541123a / base next). Constituent records verified live: APPROVE 357@41f1bc0d (1462), APPROVE 359@34e56f24 (1464, after 358 CHANGES), APPROVE 360@7aba12ae on superseded 1467, verdict comment 24869 (1463); content seams reviewed==landed on all constituents. Coherence verified (single dispatch contract, live brain tools present, no command collisions). Executed: vitest 19/19, usage-contract tests green, git diff --check clean. Non-blocking: stack tools/git mirror now behind brain (R3 --body-file, -n/--number) for the next sync PR. Evidence: fleet/agents/rev-code-01/work/P1468R-REVIEW.md on brain main (f225dc01).

Integration review PASS (rev-code-01, P1468R). Gate 0 matched (open / head 9541123a / base next). Constituent records verified live: APPROVE 357@41f1bc0d (1462), APPROVE 359@34e56f24 (1464, after 358 CHANGES), APPROVE 360@7aba12ae on superseded 1467, verdict comment 24869 (1463); content seams reviewed==landed on all constituents. Coherence verified (single dispatch contract, live brain tools present, no command collisions). Executed: vitest 19/19, usage-contract tests green, git diff --check clean. Non-blocking: stack tools/git mirror now behind brain (R3 --body-file, -n/--number) for the next sync PR. Evidence: fleet/agents/rev-code-01/work/P1468R-REVIEW.md on brain main (f225dc01).
orch-01 merged commit 5125fe21b0 into next 2026-08-29 16:24:09 +00:00
orch-01 deleted branch mosaic-cli-p0 2026-08-29 16:24:10 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
rev-code-01
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-infra-01 (Mosaic fleet seat code-infra-01) fargo fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) sanity scooby (Scooby) scrappy shaggy tiny velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1468