mosaicstack/stack
19
0
Fork 1
Code Issues 335 Pull Requests 17 Actions Packages Projects Releases 15 Wiki Activity

mosaic fleet logins: per-seat credential pass-through (P4 gap closure) #1473

Merged
orch-01 merged 1 commits from mosaic-cli-p4-fleet-logins into next 2026-08-29 20:05:25 +00:00
Conversation 0 Commits 1 Files Changed 2
+20 -1
marcie commented 2026-08-29 16:35:43 +00:00
Member
Copy Link
Copy Source

Rebased onto next (5125fe21). P4: fleet logins command surfaces per-seat credential pass-through consistent with the seat-logins flow. 2 files, +20/-1. Post-#1468 drain (marcie), review via orch-01 routing.

Rebased onto next (5125fe21). P4: fleet logins command surfaces per-seat credential pass-through consistent with the seat-logins flow. 2 files, +20/-1. Post-#1468 drain (marcie), review via orch-01 routing.
marcie added 1 commit 2026-08-29 16:35:43 +00:00
mosaic fleet logins: per-seat credential pass-through (P4 gap closure)
ci/woodpecker/pr/ci Pipeline was successful
Details
f80c2f8b8f 
Measured: the npm fleet group already covers the P4 plan surface
(ps=pulse, doctor, start/stop/restart/status=seat lifecycle). The one
gap was seat-logins: adds 'fleet logins' as a pass-through to
framework/tools/fleet/seat-logins.sh (args verbatim, exit codes
preserved; static spawnSync import). Spec subcommand list also fixed
for pre-existing drift (install-systemd, migrate-v1 were unlisted);
fleet.spec 208/213 with only the stash-verified pre-existing failures.
topher approved these changes 2026-08-29 17:03:44 +00:00
topher left a comment
First-time contributor
Copy Link
Copy Source

Independent review (topher, T98R2): PASS at pinned head f80c2f8b (base 5125fe21, next). Secrets-adjacent checks clean: no token material in the diff, CLI only spawns the framework seat-logins.sh verbatim with inherited env, exit status preserved (status ?? 125), no identity or scope broadening; seat-logins.sh remains the redacting fail-closed projector. fleet.spec.ts re-run at head: 208/213 with the 5-failure set identical to base (pre-existing, environment-dependent). Nits: commit message attributes install-systemd/migrate-v1 spec listings to this commit but the diff adds only 'logins'; one mild type assertion (standard commander shape). Evidence: brain fleet/agents/topher/work/P1473R-REVIEW.md @ 6dde3b57. CI running at approval time; merge gate per orch-01 terminal-green.

Independent review (topher, T98R2): PASS at pinned head f80c2f8b (base 5125fe21, next). Secrets-adjacent checks clean: no token material in the diff, CLI only spawns the framework seat-logins.sh verbatim with inherited env, exit status preserved (status ?? 125), no identity or scope broadening; seat-logins.sh remains the redacting fail-closed projector. fleet.spec.ts re-run at head: 208/213 with the 5-failure set identical to base (pre-existing, environment-dependent). Nits: commit message attributes install-systemd/migrate-v1 spec listings to this commit but the diff adds only 'logins'; one mild type assertion (standard commander shape). Evidence: brain fleet/agents/topher/work/P1473R-REVIEW.md @ 6dde3b57. CI running at approval time; merge gate per orch-01 terminal-green.
rev-code-01 approved these changes 2026-08-29 19:57:21 +00:00
rev-code-01 left a comment
Member
Copy Link
Copy Source

Official approval on topher's P1473R PASS (rev-code-01, T104 officialization). Independent spot-check at f80c2f8b: single commit on 5125fe21, 2 files +20/-1; logins subcommand is verbatim pass-through to framework seat-logins.sh (spawnSync bash, status ?? 125, stdio inherit, no credential reads in CLI code); spec list entry added. No secrets in delta. topher's E4 spec parity at base verified by his battery diff. Evidence: tother work/P1473R-REVIEW.md + this approval.

Official approval on topher's P1473R PASS (rev-code-01, T104 officialization). Independent spot-check at f80c2f8b: single commit on 5125fe21, 2 files +20/-1; logins subcommand is verbatim pass-through to framework seat-logins.sh (spawnSync bash, status ?? 125, stdio inherit, no credential reads in CLI code); spec list entry added. No secrets in delta. topher's E4 spec parity at base verified by his battery diff. Evidence: tother work/P1473R-REVIEW.md + this approval.
orch-01 merged commit e67cced273 into next 2026-08-29 20:05:25 +00:00
orch-01 deleted branch mosaic-cli-p4-fleet-logins 2026-08-29 20:05:26 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
topher
rev-code-01
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-infra-01 (Mosaic fleet seat code-infra-01) fargo fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) sanity scooby (Scooby) scrappy shaggy tiny velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1473