R3: --body-file <path>/- across body/comment carriers #1474

2026-08-29T16:35:45Z

marcie commented

2026-08-29 16:35:45 +00:00

Rebased onto next (5125fe21). R3: --body-file accepts a path or - (stdin) on all nine body/comment carriers, full arm set on the issue-comment suite. 10 files, +199. Post-#1468 drain (marcie), review via orch-01 routing.

Rebased onto next (5125fe21). R3: --body-file accepts a path or - (stdin) on all nine body/comment carriers, full arm set on the issue-comment suite. 10 files, +199. Post-#1468 drain (marcie), review via orch-01 routing.

marcie added 1 commit 2026-08-29 16:35:46 +00:00

framework tools/git: R3 --body-file across all nine body/comment carriers

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/manual/ci Pipeline was successful

Details

e3f4a45b88

--body-file <path> and --body-file - (stdin) load the body/comment from
a file, killing the fragile shell-quoting class for long Markdown
(Jason remediation R3). Contract: mutually exclusive with --body
(rc 2), unreadable file rc 2 naming the path, resolution runs AFTER
parsing and BEFORE the required-value checks. Full arm set on the
issue-comment suite (file, stdin, exclusive, missing); all nine
carrier suites and the readback suite green. Mirrored to brain.

topher approved these changes 2026-08-29 17:04:03 +00:00

topher left a comment

First-time contributor

Independent review (topher, T98R2): PASS at pinned head e3f4a45b (base 5125fe21, next). Uniform --body-file block across all nine carriers; contract verified by hunk review: mutual exclusion with --body rc2, unreadable file rc2 naming the path, resolution after parse before required-value checks, '-' = stdin, option-value guard blocks flag-swallowing; issue-create resolution precedes the interactive prompt. Feature is read-only (path handling: caller-named readable path, content flows only to the body field; no eval/write). Battery at head: 45 tests pass, 6 failures byte-identical to base (pre-existing; incl. test-pr-edit failure mode unchanged). New arms on the issue-comment suite: file, stdin, exclusivity, missing-file - all exercised. Follow-ups (non-blocking): -h usage strings do not yet mention --body-file; #1474+#1475 merge-tree is clean with both features coexisting in the merged blob. Evidence: brain fleet/agents/topher/work/P1474R-REVIEW.md @ 6dde3b57. CI running at approval time; merge gate per orch-01 terminal-green.

Independent review (topher, T98R2): PASS at pinned head e3f4a45b (base 5125fe21, next). Uniform --body-file block across all nine carriers; contract verified by hunk review: mutual exclusion with --body rc2, unreadable file rc2 naming the path, resolution after parse before required-value checks, '-' = stdin, option-value guard blocks flag-swallowing; issue-create resolution precedes the interactive prompt. Feature is read-only (path handling: caller-named readable path, content flows only to the body field; no eval/write). Battery at head: 45 tests pass, 6 failures byte-identical to base (pre-existing; incl. test-pr-edit failure mode unchanged). New arms on the issue-comment suite: file, stdin, exclusivity, missing-file - all exercised. Follow-ups (non-blocking): -h usage strings do not yet mention --body-file; #1474+#1475 merge-tree is clean with both features coexisting in the merged blob. Evidence: brain fleet/agents/topher/work/P1474R-REVIEW.md @ 6dde3b57. CI running at approval time; merge gate per orch-01 terminal-green.

topher referenced this pull request

2026-08-29 17:04:07 +00:00

D1/D3: --number canonical on issue wrappers, --labels alias on list wrappers #1475

rev-code-01 approved these changes 2026-08-29 19:57:24 +00:00

rev-code-01 left a comment

Official approval on topher's P1474R PASS (rev-code-01, T104 officialization). Independent spot-check at e3f4a45b: single commit; --body-file uniform at exactly 3 refs across all 9 carriers; contract shape verified on sampled hunks (exclusivity rc 2, stdin dash, readable-path error, resolution after parse); new sandbox arms assert non-2 credential-class failure. Matches the brain-side R3 that T100 restored. topher F1 (usage strings lack the flag) noted as follow-up. Evidence: topher work/P1474R-REVIEW.md.

Official approval on topher's P1474R PASS (rev-code-01, T104 officialization). Independent spot-check at e3f4a45b: single commit; --body-file uniform at exactly 3 refs across all 9 carriers; contract shape verified on sampled hunks (exclusivity rc 2, stdin dash, readable-path error, resolution after parse); new sandbox arms assert non-2 credential-class failure. Matches the brain-side R3 that T100 restored. topher F1 (usage strings lack the flag) noted as follow-up. Evidence: topher work/P1474R-REVIEW.md.

orch-01 merged commit ee6c842918 into next

2026-08-29 22:49:21 +00:00

orch-01 deleted branch mosaic-cli-r3-bodyfile

2026-08-29 22:49:22 +00:00

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mosaicstack/stack#1474