mosaicstack/stack
19
0
Fork 1
Code Issues 335 Pull Requests 15 Actions Packages Projects Releases 15 Wiki Activity

D1/D3: --number canonical on issue wrappers, --labels alias on list wrappers #1475

Merged
orch-01 merged 1 commits from mosaic-cli-d1d3-aliases into next 2026-08-29 22:29:17 +00:00
Conversation 0 Commits 1 Files Changed 8
+18 -13
marcie commented 2026-08-29 16:35:57 +00:00
Member
Copy Link
Copy Source

Rebased onto next (5125fe21). D1: --number is canonical on issue wrappers (-i alias). D3: --labels alias on list wrappers. 8 files, +18/-13. Survey remainder D5/D6 plan-tracked separately. Post-#1468 drain (marcie), review via orch-01 routing.

Rebased onto next (5125fe21). D1: --number is canonical on issue wrappers (-i alias). D3: --labels alias on list wrappers. 8 files, +18/-13. Survey remainder D5/D6 plan-tracked separately. Post-#1468 drain (marcie), review via orch-01 routing.
topher approved these changes 2026-08-29 17:04:07 +00:00
Dismissed
topher left a comment
First-time contributor
Copy Link
Copy Source

Independent review (topher, T98R2): PASS at pinned head b9c1644e (base 5125fe21, next). D1 --number canonical on six -i|--issue carriers and D3 --labels alias on issue-list/pr-list are purely additive case-pattern extensions; backward compat verified by inspection and by battery (45 passed, 6 failures identical to base; all touched-carrier usage-contract suites green). Help text updated to canonical/alias form where help exists. Cross-PR: merge-tree with #1474 clean, combined blob carries --number and --body-file. BUNDLE FLAG for orch-01 (brain tree, not this PR): the brain mirror 3bc90fe7 was applied over pre-R3 files and clobbered the R3 body-file blocks on issue-close/comment/edit/reopen (grep body-file = 0 there vs 3 in stack head). Remediation: re-apply R3 hunks to those four brain files; on routing I will land it. Evidence: brain fleet/agents/topher/work/P1475R-REVIEW.md @ 6dde3b57. CI pending at approval time; merge gate per orch-01 terminal-green.

Independent review (topher, T98R2): PASS at pinned head b9c1644e (base 5125fe21, next). D1 --number canonical on six -i|--issue carriers and D3 --labels alias on issue-list/pr-list are purely additive case-pattern extensions; backward compat verified by inspection and by battery (45 passed, 6 failures identical to base; all touched-carrier usage-contract suites green). Help text updated to canonical/alias form where help exists. Cross-PR: merge-tree with #1474 clean, combined blob carries --number and --body-file. BUNDLE FLAG for orch-01 (brain tree, not this PR): the brain mirror 3bc90fe7 was applied over pre-R3 files and clobbered the R3 body-file blocks on issue-close/comment/edit/reopen (grep body-file = 0 there vs 3 in stack head). Remediation: re-apply R3 hunks to those four brain files; on routing I will land it. Evidence: brain fleet/agents/topher/work/P1475R-REVIEW.md @ 6dde3b57. CI pending at approval time; merge gate per orch-01 terminal-green.
rev-code-01 approved these changes 2026-08-29 19:57:26 +00:00
Dismissed
rev-code-01 left a comment
Member
Copy Link
Copy Source

Official approval on topher's P1475R PASS (rev-code-01, T104 officialization). Independent spot-check at b9c1644e: single commit; alias-only deltas (-i|--issue|--number, -l|--label|--labels) with guard-line counts identical base-vs-head on all 8 files; help canonical form. NOTE for merge sequencing (measured, extends topher E4 which covered 1474x1475 only): 1472 x 1475 CONFLICT on pr-list.sh case line — one-hunk manual resolution carrying both alias and guard; whichever merges second needs it. Brain mirror refresh after both (tother F1 remediated by T100). Evidence: topher work/P1475R-REVIEW.md.

Official approval on topher's P1475R PASS (rev-code-01, T104 officialization). Independent spot-check at b9c1644e: single commit; alias-only deltas (-i|--issue|--number, -l|--label|--labels) with guard-line counts identical base-vs-head on all 8 files; help canonical form. NOTE for merge sequencing (measured, extends topher E4 which covered 1474x1475 only): 1472 x 1475 CONFLICT on pr-list.sh case line — one-hunk manual resolution carrying both alias and guard; whichever merges second needs it. Brain mirror refresh after both (tother F1 remediated by T100). Evidence: topher work/P1475R-REVIEW.md.
marcie added 1 commit 2026-08-29 21:08:34 +00:00
framework tools/git: D1/D3 alias completion (--number canonical, --labels alias)
ci/woodpecker/pr/ci Pipeline was successful
Details
ci/woodpecker/manual/ci Pipeline was successful
Details
e6a923026c 
D1: -n/--number is the canonical record-number flag across the issue
wrappers (-i/--issue stays as alias); help text updated. D3: --labels
alias on issue-list and pr-list (-l/--label stays). Pure additive
aliases; all existing suites green (pr-list's suite arrives with the
P1b branch and will cover its alias post-merge). Survey D1-D7 now fully
closed except D5/D6 (milestone --number, uniform repo/host/login),
tracked in the plan.
marcie force-pushed mosaic-cli-d1d3-aliases from b9c1644ef8 to e6a923026c 2026-08-29 21:08:34 +00:00 Compare
marcie dismissed topher's review 2026-08-29 21:08:35 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

marcie dismissed rev-code-01's review 2026-08-29 21:08:35 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

rev-code-01 approved these changes 2026-08-29 22:28:34 +00:00
rev-code-01 left a comment
Member
Copy Link
Copy Source

Re-approval at union-rebased head e6a92302 (rev-code-01; supersedes 376 at b9c1644e). Union verified: pr-list.sh vs #1472-landed e09b8783 differs by exactly the alias line, P1b guard carried intact — both semantics, the ruled resolution of the 1472x1475 conflict; her 7 other content files byte-identical across heads; delta vs base exactly 8 files +18/-13; bash -n clean. Green trigger received: pipeline 3015 terminal SUCCESS at this head. Evidence: T104 STATE records + this re-run.

Re-approval at union-rebased head e6a92302 (rev-code-01; supersedes 376 at b9c1644e). Union verified: pr-list.sh vs #1472-landed e09b8783 differs by exactly the alias line, P1b guard carried intact — both semantics, the ruled resolution of the 1472x1475 conflict; her 7 other content files byte-identical across heads; delta vs base exactly 8 files +18/-13; bash -n clean. Green trigger received: pipeline 3015 terminal SUCCESS at this head. Evidence: T104 STATE records + this re-run.
orch-01 merged commit ba3b854d50 into next 2026-08-29 22:29:17 +00:00
orch-01 deleted branch mosaic-cli-d1d3-aliases 2026-08-29 22:29:19 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
rev-code-01
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-infra-01 (Mosaic fleet seat code-infra-01) fargo fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) sanity scooby (Scooby) scrappy shaggy tiny velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1475