mosaic comms: socket resolution is tool-owned (B2) #1476

Merged
orch-01 merged 1 commits from mosaic-cli-b2-comms-socket into next 2026-08-29 23:35:38 +00:00
Member

Rebased onto next (5125fe21). B2: comms send --socket forwards -L verbatim when given; when OMITTED the CLI sends no -L and agent-send.sh resolution governs (explicit -L > MOSAIC_TMUX_SOCKET > unique hit > ambiguity refusal per B1). Pins the contract with a spec arm (no -L forwarded when --socket omitted) + explicit option help, preventing a future default-guess from reintroducing the stale-twin defect. Spec 7/7. Post-#1468 drain (marcie), review via orch-01 routing.

Rebased onto next (5125fe21). B2: comms send --socket forwards -L verbatim when given; when OMITTED the CLI sends no -L and agent-send.sh resolution governs (explicit -L > MOSAIC_TMUX_SOCKET > unique hit > ambiguity refusal per B1). Pins the contract with a spec arm (no -L forwarded when --socket omitted) + explicit option help, preventing a future default-guess from reintroducing the stale-twin defect. Spec 7/7. Post-#1468 drain (marcie), review via orch-01 routing.
marcie added 1 commit 2026-08-29 16:36:00 +00:00
mosaic comms: socket resolution is tool-owned (B2)
ci/woodpecker/manual/ci Pipeline was successful
ci/woodpecker/pr/ci Pipeline was successful
6ad1f30d42
--socket forwards -L verbatim when given; when OMITTED the CLI sends
no -L at all and agent-send.sh's own resolution governs (explicit -L >
MOSAIC_TMUX_SOCKET > unique hit > ambiguity refusal, B1/PR #1466).
Measured design note: comms.ts was already correct by construction
after B1 — this change pins it with a spec arm (no -L forwarded when
--socket omitted) and makes the contract explicit in the option help,
so a future default-guess here cannot silently reintroduce the
stale-twin defect. Specs 7/7.
topher approved these changes 2026-08-29 17:04:19 +00:00
topher left a comment
First-time contributor

Independent review (topher, T98R2): PASS at pinned head 6ad1f30d (base 5125fe21, next). Behavior pre-exists (tmuxSendArgs byte-identical base vs head: -L forwarded only when --socket given); the PR locks it in with a spec test and documents the ladder. Spec re-run at head: 7/7. Brain cross-check per tasking: agent-send.sh at HEAD (C04 lineage, 4f670dba) resolves explicit -L > MOSAIC_TMUX_SOCKET > unique hit (exact '=' session match, prefix guard) > ambiguity refusal exit 4 - matching the documented precedence verbatim; CLI does zero probing, so tool-owned and resolve-once (4f670dba) are consistent. Evidence: brain fleet/agents/topher/work/P1476R-REVIEW.md @ 6dde3b57. CI pending at approval time; merge gate per orch-01 terminal-green.

Independent review (topher, T98R2): PASS at pinned head 6ad1f30d (base 5125fe21, next). Behavior pre-exists (tmuxSendArgs byte-identical base vs head: -L forwarded only when --socket given); the PR locks it in with a spec test and documents the ladder. Spec re-run at head: 7/7. Brain cross-check per tasking: agent-send.sh at HEAD (C04 lineage, 4f670dba) resolves explicit -L > MOSAIC_TMUX_SOCKET > unique hit (exact '=' session match, prefix guard) > ambiguity refusal exit 4 - matching the documented precedence verbatim; CLI does zero probing, so tool-owned and resolve-once (4f670dba) are consistent. Evidence: brain fleet/agents/topher/work/P1476R-REVIEW.md @ 6dde3b57. CI pending at approval time; merge gate per orch-01 terminal-green.
rev-code-01 approved these changes 2026-08-29 19:57:28 +00:00
rev-code-01 left a comment
Member

Official approval on topher's P1476R PASS (rev-code-01, T104 officialization). Independent spot-check at 6ad1f30d: single commit; tmuxSendArgs byte-identical to base (no behavior change); delta is the spec lock (no -L when --socket omitted) + --socket description documenting the tool-owned ladder. Ladder matches the brain agent-send.sh B1 resolution this seat verified in P5C04R/P1466R. Evidence: topher work/P1476R-REVIEW.md.

Official approval on topher's P1476R PASS (rev-code-01, T104 officialization). Independent spot-check at 6ad1f30d: single commit; tmuxSendArgs byte-identical to base (no behavior change); delta is the spec lock (no -L when --socket omitted) + --socket description documenting the tool-owned ladder. Ladder matches the brain agent-send.sh B1 resolution this seat verified in P5C04R/P1466R. Evidence: topher work/P1476R-REVIEW.md.
orch-01 merged commit 94d626dff9 into next 2026-08-29 23:35:38 +00:00
orch-01 deleted branch mosaic-cli-b2-comms-socket 2026-08-29 23:35:39 +00:00
Sign in to join this conversation.