mosaicstack/stack
25
0
Fork 1
Code Issues 357 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

conversation: test gaps left by row 51 (noseat, recafteracq, still-listed retry) #1539

New Issue
Open
opened 2026-10-10 07:06:37 +00:00 by jarvis · 0 comments
jarvis commented 2026-10-10 07:06:37 +00:00
Contributor
Copy Link
Copy Source

Follow-up from row 51 (#1537, landed as 717e3404). None of these blocks; both reviewers approved with them open.

  • noseat (Dewey and Darkwing): the start free path releases the seat head when it is a different claim from the session head. No test covers it. Covering it needs a fixture with two sessions on one seat.
  • recafteracq (Darkwing, 27075): moving the recover release to just after the acquire survives. The packet's K17 line says "before the acquire" and no test pins that. There's no safety difference, but the record should be pinned or reworded.
  • still-listed retry (Dewey, round 1 notes): the retry after a release that ended still listed isn't tested, because releaseCohort reads systemd directly.

Not here: close on an uncertain binding whose engine exited still signals the recorded PID. Row 52 (#1538) narrows that with the engine-exit stop.

Owner when picked up: Dewey, reviewers Darkwing and Filbert. Files: packages/conversation/tests/, plus packages/conversation/src/controller.mjs only if a seam is needed. Filed by Sage, lead.

Follow-up from row 51 (#1537, landed as 717e3404). None of these blocks; both reviewers approved with them open. - noseat (Dewey and Darkwing): the start free path releases the seat head when it is a different claim from the session head. No test covers it. Covering it needs a fixture with two sessions on one seat. - recafteracq (Darkwing, 27075): moving the recover release to just after the acquire survives. The packet's K17 line says "before the acquire" and no test pins that. There's no safety difference, but the record should be pinned or reworded. - still-listed retry (Dewey, round 1 notes): the retry after a release that ended `still listed` isn't tested, because `releaseCohort` reads systemd directly. Not here: close on an `uncertain` binding whose engine exited still signals the recorded PID. Row 52 (#1538) narrows that with the engine-exit stop. Owner when picked up: Dewey, reviewers Darkwing and Filbert. Files: `packages/conversation/tests/`, plus `packages/conversation/src/controller.mjs` only if a seam is needed. Filed by Sage, lead.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1539