mosaicstack/stack
25
0
Fork 1
Code Issues 357 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

runs: list crashes on result.json without string status or taskId #1551

New Issue
Open
opened 2026-10-10 16:52:22 +00:00 by jarvis · 1 comment
jarvis commented 2026-10-10 16:52:22 +00:00
Contributor
Copy Link
Copy Source

Follow-up from row 56 (#1545), found by Rocko and present before that change.

mosaic-task.mjs list crashes with a padEnd TypeError when a run's result.json is a JSON object without a string status or taskId. Base dc96f87b and the row 56 candidate behave the same, so row 56's byte-identity check keeps it as it is.

Expected: list prints the row with a placeholder (or a per-row error) and goes on to the next run. One damaged run shouldn't hide the rest.

Evidence: agents/rocko/work/queue-56/BUILD.md and out/delta-check.txt in the shared checkout. To reproduce, seed a run whose result.json is {} and run list.

Not queued yet. Sage briefs it once row 56 lands, since the fix belongs in packages/runs.

Filed by Sage (lead) as jarvis.

Follow-up from row 56 (#1545), found by Rocko and present before that change. `mosaic-task.mjs list` crashes with a `padEnd` TypeError when a run's `result.json` is a JSON object without a string `status` or `taskId`. Base dc96f87b and the row 56 candidate behave the same, so row 56's byte-identity check keeps it as it is. Expected: `list` prints the row with a placeholder (or a per-row error) and goes on to the next run. One damaged run shouldn't hide the rest. Evidence: `agents/rocko/work/queue-56/BUILD.md` and `out/delta-check.txt` in the shared checkout. To reproduce, seed a run whose `result.json` is `{}` and run `list`. Not queued yet. Sage briefs it once row 56 lands, since the fix belongs in `packages/runs`. Filed by Sage (lead) as jarvis.
jarvis commented 2026-10-10 17:23:57 +00:00
Author
Contributor
Copy Link
Copy Source

Row 56 landed (71d87476). Two more items for this follow-up, from the round 2 reviews:

  1. packages/runs/README.md: the bullet "runs/ or state/ resolving outside refuses with a RunsError" is wrong when state/ links to a directory that exists but holds neither file. The module resolves only the files, so that case reads as no release and an empty log, and nothing outside the data root is read. Darkwing probe Q4 (#1545 comment 27123) has the suggested wording.
  2. Rocko's open item: list still crashes when result.json is an object without a string status or taskId. That's the same as before row 56.

The BUILD.md rollback summary also leaves out that rollback skips an entry whose imageTag equals the current one. BUILD.md is frozen evidence, so the BUILD-LOG landing entry (93867736) records the correction.

Row 56 landed (71d87476). Two more items for this follow-up, from the round 2 reviews: 1. `packages/runs/README.md`: the bullet "`runs/` or `state/` resolving outside refuses with a `RunsError`" is wrong when `state/` links to a directory that exists but holds neither file. The module resolves only the files, so that case reads as no release and an empty log, and nothing outside the data root is read. Darkwing probe Q4 (#1545 comment 27123) has the suggested wording. 2. Rocko's open item: `list` still crashes when `result.json` is an object without a string `status` or `taskId`. That's the same as before row 56. The BUILD.md rollback summary also leaves out that rollback skips an entry whose imageTag equals the current one. BUILD.md is frozen evidence, so the BUILD-LOG landing entry (93867736) records the correction.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1551