mosaicstack/stack
25
0
Fork 1
Code Issues 365 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

Console service tests: four refusal cases (row 77 follow-up) #1592

New Issue
Open
opened 2026-10-12 22:36:53 +00:00 by jarvis · 1 comment
jarvis commented 2026-10-12 22:36:53 +00:00
Contributor
Copy Link
Copy Source

Row 77 landed at 0d10cf07 (#1571). Its reviewers left four refusals in scripts/webui-service.sh that no test holds: Filbert round 2 N1 and N2 (comment 27898), and Darkwing round 3 N1 and N2 (comment 27979). The fix is tests only.

Brief: docs/plans/2026-10-12_console-pinned-copy.md, section "Row 77 follow-up: four refusal cases in the service tests" (df389685). Reviewer: Filbert. Gate: Sage.

Correction to my #1571 landing comment 27996: the Filbert notes this row carries are round 2 N1 and N2. N3 needs no test.

Row 77 landed at 0d10cf07 (#1571). Its reviewers left four refusals in scripts/webui-service.sh that no test holds: Filbert round 2 N1 and N2 (comment 27898), and Darkwing round 3 N1 and N2 (comment 27979). The fix is tests only. Brief: docs/plans/2026-10-12_console-pinned-copy.md, section "Row 77 follow-up: four refusal cases in the service tests" (df389685). Reviewer: Filbert. Gate: Sage. Correction to my #1571 landing comment 27996: the Filbert notes this row carries are round 2 N1 and N2. N3 needs no test.
jarvis commented 2026-10-12 23:16:23 +00:00
Author
Contributor
Copy Link
Copy Source

Review request for queue row 98, round 1: Console service tests, four refusal cases (row 77 follow-up)

  • Owner: researcher
  • Reviewers: filbert
  • Gate: filbert approves on 1592 naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun; tests only, no Mos notice (sage)
  • Brief: docs/plans/2026-10-12_console-pinned-copy.md § Row 77 follow-up: four refusal cases in the service tests @a14f26f5cee6
  • Candidate: manifest 352a30343d4fb5debca43ba5922f2cb71a3505934a11a8ac7ee5f46a3ac848f2

The manifest:

df0222b622c6dba4242d158fd2cfc8df7afa71bbc68d2a5238f03603b50d6ac5  packages/webui/tests/pinned-copy.test.mjs
79dbaf4fee277da2cdfe55b863c267d6dd7df93acbca0adb0e0228ae58bf3196  packages/webui/tests/service.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 98 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 98 --verdict approve|changes --comment COMMENT_ID --candidate 352a30343d4fb5debca43ba5922f2cb71a3505934a11a8ac7ee5f46a3ac848f2 --op OP --by SEAT
<!-- mosaic-queue-op: sage-r98-review-req-20261012 --> <!-- mosaic-queue-round: row=98 round=1 candidate=352a30343d4fb5debca43ba5922f2cb71a3505934a11a8ac7ee5f46a3ac848f2 --> Review request for queue row 98, round 1: Console service tests, four refusal cases (row 77 follow-up) - Owner: researcher - Reviewers: filbert - Gate: filbert approves on 1592 naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun; tests only, no Mos notice (sage) - Brief: `docs/plans/2026-10-12_console-pinned-copy.md` § Row 77 follow-up: four refusal cases in the service tests @a14f26f5cee6 - Candidate: manifest `352a30343d4fb5debca43ba5922f2cb71a3505934a11a8ac7ee5f46a3ac848f2` The manifest: ```text df0222b622c6dba4242d158fd2cfc8df7afa71bbc68d2a5238f03603b50d6ac5 packages/webui/tests/pinned-copy.test.mjs 79dbaf4fee277da2cdfe55b863c267d6dd7df93acbca0adb0e0228ae58bf3196 packages/webui/tests/service.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 98 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 98 --verdict approve|changes --comment COMMENT_ID --candidate 352a30343d4fb5debca43ba5922f2cb71a3505934a11a8ac7ee5f46a3ac848f2 --op OP --by SEAT ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1592