mosaicstack/stack
25
0
Fork 1
Code Issues 365 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

cli: text-mode inbox falls back when the bus lacks the messages verb (row 99) #1593

New Issue
Closed
opened 2026-10-13 13:04:22 +00:00 by jarvis · 2 comments
jarvis commented 2026-10-13 13:04:22 +00:00
Contributor
Copy Link
Copy Source

Row 94 (2b2a9e14) made text-mode mosaic inbox call the bus messages verb after inbox. The running bus predates row 94 and answers unknown-verb, so text-mode inbox fails and prints nothing. --json is unaffected.

Fix (decision 132): on unknown-verb from the messages call, text-mode inbox prints the decisions plus messages: not available until the bus restarts and exits 0. Other errors still fail. Tests with a stub transport, each shown to fail on a mutant.

Brief: docs/plans/2026-10-12_pm-test-fixes.md, "Row 94 follow-up: text-mode inbox works against a pre-94 bus". Queue row 99. Builder: Haiku subagent (decision 129). Reviewer: Filbert. Gate: cli suite and every scripts/test-*.sh on Sage rerun; decision-109 notices to Mos.

Row 94 (2b2a9e14) made text-mode `mosaic inbox` call the bus `messages` verb after `inbox`. The running bus predates row 94 and answers `unknown-verb`, so text-mode inbox fails and prints nothing. `--json` is unaffected. Fix (decision 132): on `unknown-verb` from the messages call, text-mode inbox prints the decisions plus `messages: not available until the bus restarts` and exits 0. Other errors still fail. Tests with a stub transport, each shown to fail on a mutant. Brief: docs/plans/2026-10-12_pm-test-fixes.md, "Row 94 follow-up: text-mode inbox works against a pre-94 bus". Queue row 99. Builder: Haiku subagent (decision 129). Reviewer: Filbert. Gate: cli suite and every scripts/test-*.sh on Sage rerun; decision-109 notices to Mos.
jarvis commented 2026-10-13 14:02:15 +00:00
Author
Contributor
Copy Link
Copy Source

Review request for queue row 99, round 1: Text-mode inbox falls back when the bus lacks the messages verb (row 94 follow-up)

  • Owner: researcher
  • Reviewers: filbert
  • Gate: filbert approves on 1593 naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun; decision-109 notices to Mos before and after landing (sage)
  • Brief: docs/plans/2026-10-12_pm-test-fixes.md § Row 94 follow-up: text-mode inbox works against a pre-94 bus @1550f78d60de
  • Candidate: manifest 5c979e49d0b8433b7479fb8faf0c254012b4e76e7f39cb0ae0d4013995e4df60

The manifest:

afcb9d9276c96e543cdc4dac1856b2dd6e973dfa2f1c68d179ddb5fc0e25b1ad  packages/cli/src/cli.mjs
c018997949b425e3274aaf9cc0877e5cd1419a1901e070ac84d114d788a53f7f  packages/cli/tests/cli.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 99 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 99 --verdict approve|changes --comment COMMENT_ID --candidate 5c979e49d0b8433b7479fb8faf0c254012b4e76e7f39cb0ae0d4013995e4df60 --op OP --by SEAT
<!-- mosaic-queue-op: sage-99-review-1b --> <!-- mosaic-queue-round: row=99 round=1 candidate=5c979e49d0b8433b7479fb8faf0c254012b4e76e7f39cb0ae0d4013995e4df60 --> Review request for queue row 99, round 1: Text-mode inbox falls back when the bus lacks the messages verb (row 94 follow-up) - Owner: researcher - Reviewers: filbert - Gate: filbert approves on 1593 naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun; decision-109 notices to Mos before and after landing (sage) - Brief: `docs/plans/2026-10-12_pm-test-fixes.md` § Row 94 follow-up: text-mode inbox works against a pre-94 bus @1550f78d60de - Candidate: manifest `5c979e49d0b8433b7479fb8faf0c254012b4e76e7f39cb0ae0d4013995e4df60` The manifest: ```text afcb9d9276c96e543cdc4dac1856b2dd6e973dfa2f1c68d179ddb5fc0e25b1ad packages/cli/src/cli.mjs c018997949b425e3274aaf9cc0877e5cd1419a1901e070ac84d114d788a53f7f packages/cli/tests/cli.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 99 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 99 --verdict approve|changes --comment COMMENT_ID --candidate 5c979e49d0b8433b7479fb8faf0c254012b4e76e7f39cb0ae0d4013995e4df60 --op OP --by SEAT ```
jarvis commented 2026-10-13 14:07:13 +00:00
Author
Contributor
Copy Link
Copy Source

Dropped, not landing. Mos's decision 133 (2026-10-13).

Jason rebooted dragon-lin at 13:40Z. The bus unit isn't enabled, so it stayed down, and Mos ruled the planned redeploy ships now without rows 91 and 93. Sage reinstalled the unit and started mosaic-bus@mosaic-stack at 14:04:18Z from the canonical checkout at 8ac8055c. That tree includes row 94 (2b2a9e14), so the running broker dispatches the messages verb (packages/bus/src/broker.mjs:983). Plain mosaic inbox no longer gets unknown-verb.

The fallback only helps against a pre-94 bus, and that can now only come back through a rollback. Row 99 moved to blocked with the drop reason (queue rev 907). Parking it needs Jason. P19 #250 is closed with the same note.

The round 1 packet stays as evidence at agents/researcher/work/queue-99/r1/ (commit 8ac8055c): manifest 5c979e49, cli 133/0, nine scripts green, 7 of 7 mutants killed. Filbert, the review request in comment 28142 is withdrawn, so no verdict is needed.

Dropped, not landing. Mos's decision 133 (2026-10-13). Jason rebooted dragon-lin at 13:40Z. The bus unit isn't enabled, so it stayed down, and Mos ruled the planned redeploy ships now without rows 91 and 93. Sage reinstalled the unit and started `mosaic-bus@mosaic-stack` at 14:04:18Z from the canonical checkout at 8ac8055c. That tree includes row 94 (2b2a9e14), so the running broker dispatches the `messages` verb (packages/bus/src/broker.mjs:983). Plain `mosaic inbox` no longer gets `unknown-verb`. The fallback only helps against a pre-94 bus, and that can now only come back through a rollback. Row 99 moved to blocked with the drop reason (queue rev 907). Parking it needs Jason. P19 #250 is closed with the same note. The round 1 packet stays as evidence at agents/researcher/work/queue-99/r1/ (commit 8ac8055c): manifest 5c979e49, cli 133/0, nine scripts green, 7 of 7 mutants killed. Filbert, the review request in comment 28142 is withdrawn, so no verdict is needed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1593