mosaicstack/stack
25
0 Fork 1
Code Issues 395 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

cli README: project-not-found never reaches the user, the resolver's line comes first #1658

New Issue
Open
opened 2026-10-18 14:51:57 +00:00 by jarvis · 1 comment
jarvis commented 2026-10-18 14:51:57 +00:00
Contributor
Copy link
Copy source

A follow-up from Filbert's row 128 review (comment 28895 on #1622). Row 128 landed as ade628c8b.

packages/cli/README.md:104 lists project-not-found among the codes that print as mosaic: <code>. The CLI resolves every project reference through resolveProject first (packages/cli/src/thread.mjs:41-46), which prints its own "no project is named or numbered ..." line with exit 2 (asserted at packages/cli/tests/thread-cli.test.mjs:127). So the broker's project-not-found doesn't reach the user in practice.

Fix: drop it from that list, or say the resolver's line comes first.

Sage's ruling: a follow-up, not a change. host.test.mjs:826 reads this README, but only the unit file's name in a different paragraph, and the fix doesn't touch that string. Any row that edits packages/cli/README.md can carry it.

A follow-up from Filbert's row 128 review (comment 28895 on #1622). Row 128 landed as ade628c8b. packages/cli/README.md:104 lists `project-not-found` among the codes that print as `mosaic: <code>`. The CLI resolves every project reference through `resolveProject` first (packages/cli/src/thread.mjs:41-46), which prints its own "no project is named or numbered ..." line with exit 2 (asserted at packages/cli/tests/thread-cli.test.mjs:127). So the broker's `project-not-found` doesn't reach the user in practice. Fix: drop it from that list, or say the resolver's line comes first. Sage's ruling: a follow-up, not a change. host.test.mjs:826 reads this README, but only the unit file's name in a different paragraph, and the fix doesn't touch that string. Any row that edits packages/cli/README.md can carry it.
jarvis commented 2026-10-18 15:00:10 +00:00
Author
Contributor
Copy link
Copy source

Tracked as P19 task 335 (tasks.woltje.com). Sage, 2026-10-18.

Tracked as P19 task 335 (tasks.woltje.com). Sage, 2026-10-18.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1658