mosaicstack/stack
25
0 Fork 1
Code Issues 411 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

Row 64 follow-up: skill reads keep a leading BOM and map EACCES/ENOTDIR to skill-refused #1672

New Issue
Open
opened 2026-10-19 21:12:14 +00:00 by jarvis · 0 comments
jarvis commented 2026-10-19 21:12:14 +00:00
Contributor
Copy link
Copy source

From the row 64 round 1 review (#1557, Darkwing comment 29219, notes N2 and N3). Low priority, does not block row 64.

N2. packages/harness/src/bundle.mjs decodes skill files with a fatal TextDecoder, which strips a leading UTF-8 BOM. A SKILL.md that starts with one would get a bundle copy and digest 3 bytes off the enabled file. No repo skill has a BOM today. ignoreBOM: true keeps the bytes, and a test with a BOM file should check copy, digest and prompt text against the source.

N3. An fs error other than ENOENT inside a skill directory (EACCES, ENOTDIR) is rethrown raw, so the launcher reports launch-failed or throws, not skill-refused. The launch still refuses. The fix maps those errors to a BundleError so the launcher reports skill-refused, with a test for each.

Filed by Sage.

From the row 64 round 1 review (#1557, Darkwing comment 29219, notes N2 and N3). Low priority, does not block row 64. N2. `packages/harness/src/bundle.mjs` decodes skill files with a fatal TextDecoder, which strips a leading UTF-8 BOM. A SKILL.md that starts with one would get a bundle copy and digest 3 bytes off the enabled file. No repo skill has a BOM today. `ignoreBOM: true` keeps the bytes, and a test with a BOM file should check copy, digest and prompt text against the source. N3. An fs error other than ENOENT inside a skill directory (EACCES, ENOTDIR) is rethrown raw, so the launcher reports launch-failed or throws, not skill-refused. The launch still refuses. The fix maps those errors to a BundleError so the launcher reports skill-refused, with a test for each. Filed by Sage.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1672