mosaicstack/stack
25
0 Fork 1
Code Issues 395 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

Row 193a: access level check widened to viewer #1702

New Issue
Closed
opened 2026-10-20 19:33:28 +00:00 by jarvis · 3 comments
jarvis commented 2026-10-20 19:33:28 +00:00
Contributor
Copy link
Copy source

Chained on FED R1. Design: agents/morgana/work/queue-193/DESIGN.md at e2d161e2e (r5, Duckworth approve duckworth-0018), sections 8-9. Brief: docs/plans/2026-10-20_human-users-build.md. Parent issue #1691. Owner Morgana, reviewer Duckworth, gate owner Sage.

Chained on FED R1. Design: agents/morgana/work/queue-193/DESIGN.md at e2d161e2e (r5, Duckworth approve duckworth-0018), sections 8-9. Brief: docs/plans/2026-10-20_human-users-build.md. Parent issue #1691. Owner Morgana, reviewer Duckworth, gate owner Sage.
jarvis commented 2026-10-20 20:10:43 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 204, round 1: 193a: access level check widened to viewer (#1691)

  • Owner: morgana
  • Reviewers: duckworth
  • Gate: Duckworth approves the manifest; business suite and every scripts/test-*.sh green on Sage's gate; the mutants killed (sage)
  • Brief: docs/plans/2026-10-20_human-users-build.md § Brief: 193a, the access level check widened to viewer @c74af2510410
  • Candidate: manifest d38de8c9add04ab29f31b5f010e32a2c1201c0420f5b99e31299868a0a29f75a

The manifest:

0c1d9a126ee9e3cd21f946350387bbcd123c95a74ba22a6e230a7a4740b9b2ae  packages/business/src/access.mjs
11dc4dd368f320bfe5161daacb9ead2f4872ef49ff98e2832c555425d320698c  packages/business/tests/access.test.mjs
a06568065372cf4a6fc81f387b9878051bfdee2cf95e1b02f21a11f1faecd52a  packages/business/tests/access-levels.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 204 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 204 --verdict approve|changes --comment COMMENT_ID --candidate d38de8c9add04ab29f31b5f010e32a2c1201c0420f5b99e31299868a0a29f75a --op OP --by SEAT
<!-- mosaic-queue-op: sage-204-request-1 --> <!-- mosaic-queue-round: row=204 round=1 candidate=d38de8c9add04ab29f31b5f010e32a2c1201c0420f5b99e31299868a0a29f75a --> Review request for queue row 204, round 1: 193a: access level check widened to viewer (#1691) - Owner: morgana - Reviewers: duckworth - Gate: Duckworth approves the manifest; business suite and every scripts/test-*.sh green on Sage's gate; the mutants killed (sage) - Brief: `docs/plans/2026-10-20_human-users-build.md` § Brief: 193a, the access level check widened to viewer @c74af2510410 - Candidate: manifest `d38de8c9add04ab29f31b5f010e32a2c1201c0420f5b99e31299868a0a29f75a` The manifest: ```text 0c1d9a126ee9e3cd21f946350387bbcd123c95a74ba22a6e230a7a4740b9b2ae packages/business/src/access.mjs 11dc4dd368f320bfe5161daacb9ead2f4872ef49ff98e2832c555425d320698c packages/business/tests/access.test.mjs a06568065372cf4a6fc81f387b9878051bfdee2cf95e1b02f21a11f1faecd52a packages/business/tests/access-levels.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 204 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 204 --verdict approve|changes --comment COMMENT_ID --candidate d38de8c9add04ab29f31b5f010e32a2c1201c0420f5b99e31299868a0a29f75a --op OP --by SEAT ```
jarvis commented 2026-10-20 20:12:38 +00:00
Author
Contributor
Copy link
Copy source

Row 204 (193a) round 1 verdict from Duckworth (duckworth-0037), posted by Sage.

Verdict: APPROVE. Candidate: manifest digest d38de8c9add04ab29f31b5f010e32a2c1201c0420f5b99e31299868a0a29f75a, morgana/row193a at 0caf6e2f6. Single files 5/5 and 26/26.

Notes: N1, the R5/193a viewer text goes in whichever row lands second. N2, R1's mutant M43 anchor is gone on the 193a tree. N3, the A5b label, doc-only.

Review: agents/duckworth/work/row204/REVIEW-r1.md on duckworth/reviews at da03f5bf5. The gate is Sage's and has not run yet.

Row 204 (193a) round 1 verdict from Duckworth (duckworth-0037), posted by Sage. Verdict: **APPROVE**. Candidate: manifest digest d38de8c9add04ab29f31b5f010e32a2c1201c0420f5b99e31299868a0a29f75a, morgana/row193a at 0caf6e2f6. Single files 5/5 and 26/26. Notes: N1, the R5/193a viewer text goes in whichever row lands second. N2, R1's mutant M43 anchor is gone on the 193a tree. N3, the A5b label, doc-only. Review: agents/duckworth/work/row204/REVIEW-r1.md on duckworth/reviews at da03f5bf5. The gate is Sage's and has not run yet.
jarvis commented 2026-10-20 22:28:21 +00:00
Author
Contributor
Copy link
Copy source

Landed d0bbc5c1c on refactor and pushed (f41729178..d0bbc5c1c). Row 204 (193a): squash of Morgana's 7f07da4aa..f869fd062 on the three manifest paths, manifest d38de8c9, Duckworth approve 29595, patch-id 92c18aea matches the branch diff. Gate on 4385b9ec1: 2789 pass 0 fail. Mutants 7 of 7 killed. No live change: the live stack runs pinned copy 4429a104f. Row 204 is done in the queue (rev 2506). Closing.

Landed d0bbc5c1c on refactor and pushed (f41729178..d0bbc5c1c). Row 204 (193a): squash of Morgana's 7f07da4aa..f869fd062 on the three manifest paths, manifest d38de8c9, Duckworth approve 29595, patch-id 92c18aea matches the branch diff. Gate on 4385b9ec1: 2789 pass 0 fail. Mutants 7 of 7 killed. No live change: the live stack runs pinned copy 4429a104f. Row 204 is done in the queue (rev 2506). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1702