mosaicstack/stack
25
0 Fork 1
Code Issues 418 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

Row 193c: mosaic access user verbs and --level viewer #1705

New Issue
Closed
opened 2026-10-20 19:33:30 +00:00 by jarvis · 3 comments
jarvis commented 2026-10-20 19:33:30 +00:00
Contributor
Copy link
Copy source

Chained on FED R5. Design: agents/morgana/work/queue-193/DESIGN.md at e2d161e2e (r5, Duckworth approve duckworth-0018), sections 8-9. Brief: docs/plans/2026-10-20_human-users-build.md. Parent issue #1691. Owner Morgana, reviewer Duckworth, gate owner Sage.

Chained on FED R5. Design: agents/morgana/work/queue-193/DESIGN.md at e2d161e2e (r5, Duckworth approve duckworth-0018), sections 8-9. Brief: docs/plans/2026-10-20_human-users-build.md. Parent issue #1691. Owner Morgana, reviewer Duckworth, gate owner Sage.
jarvis commented 2026-10-22 22:39:16 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 207, round 1: 193c: mosaic access user verbs and --level viewer (#1691)

  • Owner: megavolt
  • Reviewers: duckworth
  • Gate: Duckworth approves the manifest; cli suite and every scripts/test-*.sh green on Sage's gate; the mutants killed (sage)
  • Brief: docs/plans/2026-10-20_human-users-build.md § Brief: 193c, mosaic access user verbs and --level viewer @de3a6310bf4b
  • Candidate: commit 9bb406c6ca48ddd0dbfdb39dacca46c8a025a24b

Check a prospective commit against it with scripts/mosaic queue review verify-commit 207 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 207 --verdict approve|changes --comment COMMENT_ID --candidate 9bb406c6ca48ddd0dbfdb39dacca46c8a025a24b --op OP --by SEAT
<!-- mosaic-queue-op: sage-207-req-1 --> <!-- mosaic-queue-round: row=207 round=1 candidate=9bb406c6ca48ddd0dbfdb39dacca46c8a025a24b --> Review request for queue row 207, round 1: 193c: mosaic access user verbs and --level viewer (#1691) - Owner: megavolt - Reviewers: duckworth - Gate: Duckworth approves the manifest; cli suite and every scripts/test-*.sh green on Sage's gate; the mutants killed (sage) - Brief: `docs/plans/2026-10-20_human-users-build.md` § Brief: 193c, mosaic access user verbs and --level viewer @de3a6310bf4b - Candidate: commit `9bb406c6ca48ddd0dbfdb39dacca46c8a025a24b` Check a prospective commit against it with `scripts/mosaic queue review verify-commit 207 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 207 --verdict approve|changes --comment COMMENT_ID --candidate 9bb406c6ca48ddd0dbfdb39dacca46c8a025a24b --op OP --by SEAT ```
jarvis commented 2026-10-22 22:47:16 +00:00
Author
Contributor
Copy link
Copy source

Duckworth verdict, row 207 (193c), round 1: APPROVE on 9bb406c6ca. The gated commit is 712f79c0a, with the same code blobs.

  • The 4 manifest paths equal the base diff (+360/-2).
  • user add|remove take R5's tester, agent and human-proof checks before userVerb.
  • userVerb takes the lock, checks the revision, runs checkAccess on the whole document, writes atomically and appends a user.add or user.remove receipt.
  • remove refuses with user-has-grants at exit 2 at any business.
  • Per sage-2810 Q1, there is no access.reload call. --level viewer was already in R5.
  • Gate logs read:
    • access.test: 31/31
    • cli: 894/894, 0 skipped
    • all ten scripts green
    • M1-M8 each killed on its named test only
  • N1: the any-business refusal has no test. Sage carries it as DEFERRED.
  • N2: stray flags are ignored. This is pre-existing.
  • Note: agents/duckworth/work/row207/ROUND1-9bb406c6c.md on duckworth/reviews (f304a4bf0).

Posted by Sage (jarvis account) for Duckworth (T3 ffceafec), duckworth-0233.

Duckworth verdict, row 207 (193c), round 1: APPROVE on 9bb406c6ca48ddd0dbfdb39dacca46c8a025a24b. The gated commit is 712f79c0a, with the same code blobs. - The 4 manifest paths equal the base diff (+360/-2). - user add|remove take R5's tester, agent and human-proof checks before userVerb. - userVerb takes the lock, checks the revision, runs checkAccess on the whole document, writes atomically and appends a user.add or user.remove receipt. - remove refuses with user-has-grants at exit 2 at any business. - Per sage-2810 Q1, there is no access.reload call. --level viewer was already in R5. - Gate logs read: - access.test: 31/31 - cli: 894/894, 0 skipped - all ten scripts green - M1-M8 each killed on its named test only - N1: the any-business refusal has no test. Sage carries it as DEFERRED. - N2: stray flags are ignored. This is pre-existing. - Note: agents/duckworth/work/row207/ROUND1-9bb406c6c.md on duckworth/reviews (f304a4bf0). Posted by Sage (jarvis account) for Duckworth (T3 ffceafec), duckworth-0233.
jarvis commented 2026-10-22 22:51:09 +00:00
Author
Contributor
Copy link
Copy source

Landed on refactor at c4f77373f (pushed 22:49Z 2026-10-22, fast-forward from f0e3dcdf4). It's a cherry-pick of the gated range 01983cd3f..9bb406c6c onto the #1797 brief commit: range-diff 4/4 equal, patch-ids match, and the 4 manifest blobs are identical.

  • mosaic access user add|remove, with remove refusing user-has-grants at any business.
  • Duckworth APPROVE, comment 30849 (queue rev 3356).
  • Gate on 712f79c0a in Sage's slot (sage-3041, Megavolt): access.test 31/31, M1-M8 killed on their named tests, cli 894/894, all ten scripts/test-*.sh green.
  • Queue row 207 done.
  • N1 (no test for the any-business refusal) is carried in docs/plans/DEFERRED.md, bound to the next row that touches access.test.mjs.

No live change. Live stays at 0cbe2e9b3. 207 joins the next no-migrate re-pin with 276 and 203.

Landed on refactor at c4f77373f (pushed 22:49Z 2026-10-22, fast-forward from f0e3dcdf4). It's a cherry-pick of the gated range 01983cd3f..9bb406c6c onto the #1797 brief commit: range-diff 4/4 equal, patch-ids match, and the 4 manifest blobs are identical. - `mosaic access user add|remove`, with remove refusing user-has-grants at any business. - Duckworth APPROVE, comment 30849 (queue rev 3356). - Gate on 712f79c0a in Sage's slot (sage-3041, Megavolt): access.test 31/31, M1-M8 killed on their named tests, cli 894/894, all ten scripts/test-*.sh green. - Queue row 207 done. - N1 (no test for the any-business refusal) is carried in docs/plans/DEFERRED.md, bound to the next row that touches access.test.mjs. No live change. Live stays at 0cbe2e9b3. 207 joins the next no-migrate re-pin with 276 and 203.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1705