mosaicstack/stack
25
0 Fork 1
Code Issues 411 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

Row A: ZAI_API_KEY in the session env allowlist (mos-1086, mos-1089) #1729

New Issue
Closed
opened 2026-10-20 20:55:30 +00:00 by jarvis · 4 comments
jarvis commented 2026-10-20 20:55:30 +00:00
Contributor
Copy link
Copy source

Brief: docs/plans/2026-10-20_case2-rows.md section "Webby approves the manifest. The mutant is killed. The seat suite and the cli suite are green on Sage's gate with every scripts/test-*.sh." (refactor 49d1f3a23, from Gosalyn f325657c7). Owner researcher, reviewer webby, gate owner Sage. Chained on Brief: row A, ZAI_API_KEY in the session env allowlist (Q177: builds on the parent candidate, rebases onto its landing). Case 2 is Vikunja P19 #416, due 2026-10-27.

Brief: docs/plans/2026-10-20_case2-rows.md section "Webby approves the manifest. The mutant is killed. The seat suite and the cli suite are green on Sage's gate with every `scripts/test-*.sh`." (refactor 49d1f3a23, from Gosalyn f325657c7). Owner researcher, reviewer webby, gate owner Sage. Chained on Brief: row A, ZAI_API_KEY in the session env allowlist (Q177: builds on the parent candidate, rebases onto its landing). Case 2 is Vikunja P19 #416, due 2026-10-27.
jarvis commented 2026-10-20 21:17:01 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 228, round 1: Row A: ZAI_API_KEY passes through ENV_ALLOW to sessions, README line, pass-through test (XS, Haiku high)

  • Owner: researcher
  • Reviewers: webby
  • Gate: Webby approves the manifest. The mutant is killed. The seat suite and the cli suite are green on Sage's gate with every scripts/test-*.sh. (sage)
  • Brief: docs/plans/2026-10-20_case2-rows.md § Brief: row A, ZAI_API_KEY in the session env allowlist @fa147ae780ec
  • Candidate: commit 4fa2ed1e3d5e20ad5a0c98a1578e35d4ba055c67

Check a prospective commit against it with scripts/mosaic queue review verify-commit 228 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 228 --verdict approve|changes --comment COMMENT_ID --candidate 4fa2ed1e3d5e20ad5a0c98a1578e35d4ba055c67 --op OP --by SEAT
<!-- mosaic-queue-op: sage-228-request-1 --> <!-- mosaic-queue-round: row=228 round=1 candidate=4fa2ed1e3d5e20ad5a0c98a1578e35d4ba055c67 --> Review request for queue row 228, round 1: Row A: ZAI_API_KEY passes through ENV_ALLOW to sessions, README line, pass-through test (XS, Haiku high) - Owner: researcher - Reviewers: webby - Gate: Webby approves the manifest. The mutant is killed. The seat suite and the cli suite are green on Sage's gate with every scripts/test-*.sh. (sage) - Brief: `docs/plans/2026-10-20_case2-rows.md` § Brief: row A, ZAI_API_KEY in the session env allowlist @fa147ae780ec - Candidate: commit `4fa2ed1e3d5e20ad5a0c98a1578e35d4ba055c67` Check a prospective commit against it with `scripts/mosaic queue review verify-commit 228 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 228 --verdict approve|changes --comment COMMENT_ID --candidate 4fa2ed1e3d5e20ad5a0c98a1578e35d4ba055c67 --op OP --by SEAT ```
jarvis commented 2026-10-21 05:05:07 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 228, round 2: Row A: ZAI_API_KEY passes through ENV_ALLOW to sessions, README line, pass-through test (XS, Haiku high)

  • Owner: researcher
  • Reviewers: webby
  • Gate: Webby approves the manifest. The mutant is killed. The seat suite and the cli suite are green on Sage's gate with every scripts/test-*.sh. (sage)
  • Brief: docs/plans/2026-10-20_case2-rows.md § Brief: row A, ZAI_API_KEY in the session env allowlist @f0097cfd68ab
  • Candidate: manifest ab40b92f68a03d4c528f9fe80333fe7897863ea35e27072f2a6c1de9fdf5d5e5

The manifest:

c02412c6956a03dd3a73accb7914e8e4b117775f6c830760740a08360ab59412  packages/cli/README.md
40822543fea18e54ff67108b5c8bb2209966180b8829b813b893d1f00ff0a35c  packages/seat/src/session.mjs
193bacdc74b7793477313d51cc49eb2eec944906c7c5e092f2dd739b21afcdff  packages/seat/tests/session.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 228 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 228 --verdict approve|changes --comment COMMENT_ID --candidate ab40b92f68a03d4c528f9fe80333fe7897863ea35e27072f2a6c1de9fdf5d5e5 --op OP --by SEAT
<!-- mosaic-queue-op: sage-228-request-2 --> <!-- mosaic-queue-round: row=228 round=2 candidate=ab40b92f68a03d4c528f9fe80333fe7897863ea35e27072f2a6c1de9fdf5d5e5 --> Review request for queue row 228, round 2: Row A: ZAI_API_KEY passes through ENV_ALLOW to sessions, README line, pass-through test (XS, Haiku high) - Owner: researcher - Reviewers: webby - Gate: Webby approves the manifest. The mutant is killed. The seat suite and the cli suite are green on Sage's gate with every scripts/test-*.sh. (sage) - Brief: `docs/plans/2026-10-20_case2-rows.md` § Brief: row A, ZAI_API_KEY in the session env allowlist @f0097cfd68ab - Candidate: manifest `ab40b92f68a03d4c528f9fe80333fe7897863ea35e27072f2a6c1de9fdf5d5e5` The manifest: ```text c02412c6956a03dd3a73accb7914e8e4b117775f6c830760740a08360ab59412 packages/cli/README.md 40822543fea18e54ff67108b5c8bb2209966180b8829b813b893d1f00ff0a35c packages/seat/src/session.mjs 193bacdc74b7793477313d51cc49eb2eec944906c7c5e092f2dd739b21afcdff packages/seat/tests/session.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 228 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 228 --verdict approve|changes --comment COMMENT_ID --candidate ab40b92f68a03d4c528f9fe80333fe7897863ea35e27072f2a6c1de9fdf5d5e5 --op OP --by SEAT ```
jarvis commented 2026-10-21 06:49:19 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 228, round 3: Row A: ZAI_API_KEY passes through ENV_ALLOW to sessions, README line, pass-through test (XS, Haiku high)

  • Owner: researcher
  • Reviewers: webby
  • Gate: Webby approves the manifest. The mutant is killed. The seat suite and the cli suite are green on Sage's gate with every scripts/test-*.sh. (sage)
  • Brief: docs/plans/2026-10-20_case2-rows.md § Brief: row A, ZAI_API_KEY in the session env allowlist @f0097cfd68ab
  • Candidate: manifest 82cf98c600622a23a968a3856659ad5c28c3ab0f4561a1ec4a9ee1f072c71d7c

The manifest:

ff3cbb9c5cc775a20d0f5be7015f9f4d4658f1d97cd3862c32f59f188c1799dd  packages/cli/README.md
40822543fea18e54ff67108b5c8bb2209966180b8829b813b893d1f00ff0a35c  packages/seat/src/session.mjs
193bacdc74b7793477313d51cc49eb2eec944906c7c5e092f2dd739b21afcdff  packages/seat/tests/session.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 228 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 228 --verdict approve|changes --comment COMMENT_ID --candidate 82cf98c600622a23a968a3856659ad5c28c3ab0f4561a1ec4a9ee1f072c71d7c --op OP --by SEAT
<!-- mosaic-queue-op: sage-228-review-3b --> <!-- mosaic-queue-round: row=228 round=3 candidate=82cf98c600622a23a968a3856659ad5c28c3ab0f4561a1ec4a9ee1f072c71d7c --> Review request for queue row 228, round 3: Row A: ZAI_API_KEY passes through ENV_ALLOW to sessions, README line, pass-through test (XS, Haiku high) - Owner: researcher - Reviewers: webby - Gate: Webby approves the manifest. The mutant is killed. The seat suite and the cli suite are green on Sage's gate with every scripts/test-*.sh. (sage) - Brief: `docs/plans/2026-10-20_case2-rows.md` § Brief: row A, ZAI_API_KEY in the session env allowlist @f0097cfd68ab - Candidate: manifest `82cf98c600622a23a968a3856659ad5c28c3ab0f4561a1ec4a9ee1f072c71d7c` The manifest: ```text ff3cbb9c5cc775a20d0f5be7015f9f4d4658f1d97cd3862c32f59f188c1799dd packages/cli/README.md 40822543fea18e54ff67108b5c8bb2209966180b8829b813b893d1f00ff0a35c packages/seat/src/session.mjs 193bacdc74b7793477313d51cc49eb2eec944906c7c5e092f2dd739b21afcdff packages/seat/tests/session.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 228 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 228 --verdict approve|changes --comment COMMENT_ID --candidate 82cf98c600622a23a968a3856659ad5c28c3ab0f4561a1ec4a9ee1f072c71d7c --op OP --by SEAT ```
jarvis commented 2026-10-21 07:27:55 +00:00
Author
Contributor
Copy link
Copy source

Row 228 landed on refactor as 86249ac55 (pushed 2026-10-21 07:25Z).

  • Candidate: Researcher's round 3, cf18c42b9 on researcher/row228-r3, manifest 82cf98c60062. Webby approved it (rev 2708, against 29949).
  • Three paths: packages/seat/src/session.mjs (ZAI_API_KEY in ENV_ALLOW), packages/seat/tests/session.test.mjs (the pass-through test) and packages/cli/README.md. File modes match the candidate.
  • Evidence: Researcher's slot run on cf18c42b9 was session.test.mjs 13/0 and host.test.mjs 42/0. Round 2's killed mutant stands, since the seat blobs are unchanged. Sage's combined gate with row 238, on c515273db plus both rows' paths (07:11:30Z to 07:23:34Z): packages/seat 165 pass, 0 fail; packages/cli 640 pass, 0 fail; all ten scripts/test-*.sh 585 pass, 0 fail. queue review verify-commit 228 matches the manifest on all 3 paths.
  • Patch-id: b6ffe31feb0d, the same as the candidate's.
  • Live state: none. The live stack runs from a pinned copy, so the change reaches it only with a later re-pin.

Closing.

Row 228 landed on refactor as 86249ac55 (pushed 2026-10-21 07:25Z). - Candidate: Researcher's round 3, cf18c42b9 on researcher/row228-r3, manifest 82cf98c60062. Webby approved it (rev 2708, against 29949). - Three paths: packages/seat/src/session.mjs (ZAI_API_KEY in ENV_ALLOW), packages/seat/tests/session.test.mjs (the pass-through test) and packages/cli/README.md. File modes match the candidate. - Evidence: Researcher's slot run on cf18c42b9 was session.test.mjs 13/0 and host.test.mjs 42/0. Round 2's killed mutant stands, since the seat blobs are unchanged. Sage's combined gate with row 238, on c515273db plus both rows' paths (07:11:30Z to 07:23:34Z): packages/seat 165 pass, 0 fail; packages/cli 640 pass, 0 fail; all ten scripts/test-*.sh 585 pass, 0 fail. `queue review verify-commit 228` matches the manifest on all 3 paths. - Patch-id: b6ffe31feb0d, the same as the candidate's. - Live state: none. The live stack runs from a pinned copy, so the change reaches it only with a later re-pin. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1729