mosaicstack/stack
25
0 Fork 1
Code Issues 413 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

stack: instance_port_holder misses a drop-in ExecStart override (row 190 N4) #1736

New Issue
Open
opened 2026-10-20 23:11:53 +00:00 by jarvis · 0 comments
jarvis commented 2026-10-20 23:11:53 +00:00
Contributor
Copy link
Copy source

Row 190 (#1688) landed as 00d4cc1f6 on refactor. Source: agents/darkwing/work/queue-190/BUILD.md, follow-ups.

instance_port_holder (scripts/instance.sh:118) reads only the unit file's ExecStart=. A systemd drop-in that overrides ExecStart would change the port the Console really binds, and the check would not see it. No Console drop-in on dragon-lin sets one today, so it is moot here. Fix: read the effective ExecStart (systemctl --user show -p ExecStart or merge drop-ins), with a test that puts the port in a drop-in.

Found by Filbert, row 190 round 1 (Gitea 29634), N4. Not blocking.

Row 190 (#1688) landed as 00d4cc1f6 on refactor. Source: agents/darkwing/work/queue-190/BUILD.md, follow-ups. `instance_port_holder` (scripts/instance.sh:118) reads only the unit file's `ExecStart=`. A systemd drop-in that overrides `ExecStart` would change the port the Console really binds, and the check would not see it. No Console drop-in on dragon-lin sets one today, so it is moot here. Fix: read the effective ExecStart (`systemctl --user show -p ExecStart` or merge drop-ins), with a test that puts the port in a drop-in. Found by Filbert, row 190 round 1 (Gitea 29634), N4. Not blocking.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1736