mosaicstack/stack
25
0
Fork 1
Code Issues 409 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

queue: PATH_RE refuses manifest paths with @ (row 190) #1738

New Issue
Open
opened 2026-10-20 23:11:55 +00:00 by jarvis · 0 comments
jarvis commented 2026-10-20 23:11:55 +00:00
Contributor
Copy Link
Copy Source

Row 190 (#1688) landed as 00d4cc1f6 on refactor. Source: agents/darkwing/work/queue-190/BUILD.md, follow-ups.

PATH_RE (packages/queue/src/queue.mjs:37) is /^[A-Za-z0-9._-]+(\/[A-Za-z0-9._-]+)*$/, so a candidate manifest can't name a path with @, such as the systemd template [email protected] files. Row 190 had to review on a seat-branch commit instead of a manifest. Any row that touches an @ template hits the same wall (rows 230 and 226 render [email protected]). Fix: allow @ in a path segment, keep the refusal of .., leading / and empty segments, with tests for both.

Reported by Darkwing, row 190 round 1. Not blocking.

Row 190 (#1688) landed as 00d4cc1f6 on refactor. Source: agents/darkwing/work/queue-190/BUILD.md, follow-ups. `PATH_RE` (packages/queue/src/queue.mjs:37) is `/^[A-Za-z0-9._-]+(\/[A-Za-z0-9._-]+)*$/`, so a candidate manifest can't name a path with `@`, such as the systemd template `[email protected]` files. Row 190 had to review on a seat-branch commit instead of a manifest. Any row that touches an `@` template hits the same wall (rows 230 and 226 render `[email protected]`). Fix: allow `@` in a path segment, keep the refusal of `..`, leading `/` and empty segments, with tests for both. Reported by Darkwing, row 190 round 1. Not blocking.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1738