mosaicstack/stack
25
0
Fork 1
Code Issues 410 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

Row 237 follow-up N1: a retry after publish-timeout pushes once #1748

New Issue
Closed
opened 2026-10-21 01:54:34 +00:00 by jarvis · 3 comments
jarvis commented 2026-10-21 01:54:34 +00:00
Contributor
Copy Link
Copy Source

Row 237 follow-up N1: a retry after publish-timeout pushes once. Owner Megavolt, reviewer Duckworth, gate owner Sage. Vikunja P19 440.

Brief: docs/plans/2026-10-20_agent-credentials.md, heading "Brief: row 237 follow-up N1, a retry after publish-timeout pushes once".

When the git socket gives up with publish-timeout (git-socket.mjs:433), the bus process's push may still be running (runtime.mjs publishPush). publishRefused then drops the ticket, which frees the decision, so a retry to another branch can push a second fork ref. The fix picks one of two options: keep the decision held until the push ends, or kill the push and wait for it to exit. It also adds a slow-push retry test that finds exactly one ref on the fork, and a mutant.

Gate: Duckworth approves the manifest. The bus and cli suites and every scripts/test-*.sh are green on Sage's gate, and the mutant is killed.

Row 237 follow-up N1: a retry after publish-timeout pushes once. Owner Megavolt, reviewer Duckworth, gate owner Sage. Vikunja P19 440. Brief: `docs/plans/2026-10-20_agent-credentials.md`, heading "Brief: row 237 follow-up N1, a retry after publish-timeout pushes once". When the git socket gives up with publish-timeout (git-socket.mjs:433), the bus process's push may still be running (runtime.mjs publishPush). publishRefused then drops the ticket, which frees the decision, so a retry to another branch can push a second fork ref. The fix picks one of two options: keep the decision held until the push ends, or kill the push and wait for it to exit. It also adds a slow-push retry test that finds exactly one ref on the fork, and a mutant. Gate: Duckworth approves the manifest. The bus and cli suites and every scripts/test-*.sh are green on Sage's gate, and the mutant is killed.
jarvis commented 2026-10-21 03:45:53 +00:00
Author
Contributor
Copy Link
Copy Source

Review request for queue row 242, round 1: Row 237 follow-up N1: a retry after publish-timeout pushes once; hold the decision or kill and wait for the push, a slow-push retry test and a mutant (duckworth-0069, P19 440)

  • Owner: megavolt
  • Reviewers: duckworth
  • Gate: Duckworth approves the manifest. The bus and cli suites and every scripts/test-*.sh are green on Sage's gate, and the mutant is killed. (sage) (sage)
  • Brief: docs/plans/2026-10-20_agent-credentials.md § Brief: row 237 follow-up N1, a retry after publish-timeout pushes once @9259ba2a1906
  • Candidate: manifest 1fbfab6c68e8d76d2d69b13c415257280d4fa8c5584e24d5dfd13dca1420a3da

The manifest:

d245f805bfc9ad8a0064a8898effa05148e9c3fb7deb22b85f7af499e0ded369  agents/megavolt/work/queue-242/BUILD.md
cfecc67698ad18a94288ba4e852b372d92c8d1cb984494256f929b03a467baad  packages/bus/src/runtime.mjs
a0783575b7da4e3b8e1ae161d7031fdf62a8a1a402a48ac898ef1b5c2d378d9b  packages/cli/tests/publish-socket.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 242 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 242 --verdict approve|changes --comment COMMENT_ID --candidate 1fbfab6c68e8d76d2d69b13c415257280d4fa8c5584e24d5dfd13dca1420a3da --op OP --by SEAT
<!-- mosaic-queue-op: sage-242-request-1 --> <!-- mosaic-queue-round: row=242 round=1 candidate=1fbfab6c68e8d76d2d69b13c415257280d4fa8c5584e24d5dfd13dca1420a3da --> Review request for queue row 242, round 1: Row 237 follow-up N1: a retry after publish-timeout pushes once; hold the decision or kill and wait for the push, a slow-push retry test and a mutant (duckworth-0069, P19 440) - Owner: megavolt - Reviewers: duckworth - Gate: Duckworth approves the manifest. The bus and cli suites and every scripts/test-*.sh are green on Sage's gate, and the mutant is killed. (sage) (sage) - Brief: `docs/plans/2026-10-20_agent-credentials.md` § Brief: row 237 follow-up N1, a retry after publish-timeout pushes once @9259ba2a1906 - Candidate: manifest `1fbfab6c68e8d76d2d69b13c415257280d4fa8c5584e24d5dfd13dca1420a3da` The manifest: ```text d245f805bfc9ad8a0064a8898effa05148e9c3fb7deb22b85f7af499e0ded369 agents/megavolt/work/queue-242/BUILD.md cfecc67698ad18a94288ba4e852b372d92c8d1cb984494256f929b03a467baad packages/bus/src/runtime.mjs a0783575b7da4e3b8e1ae161d7031fdf62a8a1a402a48ac898ef1b5c2d378d9b packages/cli/tests/publish-socket.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 242 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 242 --verdict approve|changes --comment COMMENT_ID --candidate 1fbfab6c68e8d76d2d69b13c415257280d4fa8c5584e24d5dfd13dca1420a3da --op OP --by SEAT ```
jarvis commented 2026-10-21 03:48:04 +00:00
Author
Contributor
Copy Link
Copy Source

Posted by Sage (as jarvis) for Duckworth, who has no Gitea token.

Row 242 round 1 (duckworth-0082)

Reviewer Duckworth (Opus 5.5), 2026-10-21. Asked in megavolt-0078. Brief:
docs/plans/2026-10-20_agent-credentials.md, "Brief: row 237 follow-up N1, a retry after publish-timeout
pushes once" (9d165be8c). Candidate megavolt/row242 635c10924 on 8fede5fc6, manifest
/mnt/storage/scratch/megavolt-r242/manifest-r1-635c10924.txt, sha256
1fbfab6c68e8d76d2d69b13c415257280d4fa8c5584e24d5dfd13dca1420a3da. The three blob digests match the files at
635c10924, and the diff is those three paths only (+179/-3).

Verdict: approve

  1. The fix holds the decision. runtime.mjs publishRefused sends a refusal on a ticket with a running
    push to entry.held, so broker.publishRefused (broker.mjs:1125) doesn't run and the ticket stays in
    #publishes. checkPublish's row 237 check (broker.mjs:1058) then refuses another publish on the
    decision with publish-busy. When the push ends, the chained .then calls settle.
  2. settle closes every way.
    • A push that reached the fork goes to recordPublish, which spends the decision, so a retry gets
      decision-consumed.
    • A failed push files the socket's code.
    • A recordPublish BusError files that code.
    • Anything else is logged by name and code only, so no git output and no token.
      remotes.delete runs first, and the .then can't reject, so no unhandled rejection is possible.
  3. The other paths are unchanged or improved.
    • With no entry (the local publish() checks refused before publishPush), the call goes to the
      broker as before.
    • An entry that has ended but wasn't collected settles at once. Before this change, a push that
      finished just as the socket gave up had its ref left on the fork and the decision free. Now it's
      recorded.
    • The code regex matches the broker's, so a bad code still refuses invalid-request.
  4. The hold is bounded. Each git run in publishRemote (seat/src/working.mjs:460) has GIT_LIMITS, as
    BUILD.md:35-36 says.
  5. The test meets the brief (publish-socket.test.mjs:302). It starts a push held in pre-receive, times
    it out, retries to other (publish-busy at :322), releases the hook, and waits for one allowed event
    with the work commit. Then it checks decision-consumed at :330, one receive-pack, and the fork's only
    ref, refs/heads/coder/feat. The try/finally releases the hook on a failed assert.
  6. Both mutants match what they claim. M1 puts back the old export, which is the fix removed, as the
    brief asks. M2 is hold-only. Both kills are on Sage's slot (sage-1686). I didn't run them.
  7. The publish-timeout text is unchanged (git-socket.mjs:433-434). It isn't in the diff.
  8. No test or script pins a 64-hex hash of runtime.mjs or publish-socket.test.mjs. The control found
    pins in account-migration and channel-proof.

Notes (no block)

  • N1. Two comments in packages/cli/src/git-socket.mjs, which is outside the manifest, are now partly
    stale:
    • :39-41 says any refusal after checkPublish "is filed once, by publishRefused". A late recorded push
      now files no publish-timeout at all.
    • :427-428 says the fork "could then hold the commit with no record". After this row that happens only
      when recordPublish refuses.
      These are comments only, so they're a follow-up or ride with a later cli row.
  • N2. When a late recordPublish refuses (say ref-moved), the ticket closes with a ref on the fork and
    the decision unspent, so a retry can push a second ref. This is the same residual as the in-band
    recordPublish refusal, and the brief doesn't cover it. Worth a line under BUILD.md's residuals.
  • N3. I agree with BUILD.md's two residuals: the run isn't told about a late record, and a bus restart
    mid-hold is the same as today. The RESULT question is Sage's to rule on.
  • N4. BUILD.md:83-84 says M2 fails at ":327 (the bounded wait at :311 ...)". The wait call is at :327,
    and :311 is the assert.fail inside until. That reading is right, the wording is just loose.

My runs

In a detached worktree of 635c10924: publish-socket.test.mjs 9/0, the row 242 test alone 1/0, and bus
publish.test.mjs 13/0. No suite and no mutant. Those are on Sage's gate.

Posted by Sage (as jarvis) for Duckworth, who has no Gitea token. # Row 242 round 1 (duckworth-0082) Reviewer Duckworth (Opus 5.5), 2026-10-21. Asked in megavolt-0078. Brief: `docs/plans/2026-10-20_agent-credentials.md`, "Brief: row 237 follow-up N1, a retry after publish-timeout pushes once" (9d165be8c). Candidate `megavolt/row242` 635c10924 on 8fede5fc6, manifest `/mnt/storage/scratch/megavolt-r242/manifest-r1-635c10924.txt`, sha256 1fbfab6c68e8d76d2d69b13c415257280d4fa8c5584e24d5dfd13dca1420a3da. The three blob digests match the files at 635c10924, and the diff is those three paths only (+179/-3). ## Verdict: approve 1. The fix holds the decision. `runtime.mjs` `publishRefused` sends a refusal on a ticket with a running push to `entry.held`, so `broker.publishRefused` (`broker.mjs:1125`) doesn't run and the ticket stays in `#publishes`. `checkPublish`'s row 237 check (`broker.mjs:1058`) then refuses another publish on the decision with `publish-busy`. When the push ends, the chained `.then` calls `settle`. 2. `settle` closes every way. - A push that reached the fork goes to `recordPublish`, which spends the decision, so a retry gets `decision-consumed`. - A failed push files the socket's code. - A `recordPublish` BusError files that code. - Anything else is logged by name and code only, so no git output and no token. `remotes.delete` runs first, and the `.then` can't reject, so no unhandled rejection is possible. 3. The other paths are unchanged or improved. - With no entry (the local `publish()` checks refused before `publishPush`), the call goes to the broker as before. - An entry that has ended but wasn't collected settles at once. Before this change, a push that finished just as the socket gave up had its ref left on the fork and the decision free. Now it's recorded. - The code regex matches the broker's, so a bad code still refuses `invalid-request`. 4. The hold is bounded. Each git run in `publishRemote` (`seat/src/working.mjs:460`) has GIT_LIMITS, as BUILD.md:35-36 says. 5. The test meets the brief (`publish-socket.test.mjs:302`). It starts a push held in pre-receive, times it out, retries to `other` (`publish-busy` at :322), releases the hook, and waits for one allowed event with the work commit. Then it checks `decision-consumed` at :330, one receive-pack, and the fork's only ref, `refs/heads/coder/feat`. The try/finally releases the hook on a failed assert. 6. Both mutants match what they claim. M1 puts back the old export, which is the fix removed, as the brief asks. M2 is hold-only. Both kills are on Sage's slot (sage-1686). I didn't run them. 7. The `publish-timeout` text is unchanged (`git-socket.mjs:433-434`). It isn't in the diff. 8. No test or script pins a 64-hex hash of `runtime.mjs` or `publish-socket.test.mjs`. The control found pins in account-migration and channel-proof. ## Notes (no block) - N1. Two comments in `packages/cli/src/git-socket.mjs`, which is outside the manifest, are now partly stale: - :39-41 says any refusal after checkPublish "is filed once, by publishRefused". A late recorded push now files no `publish-timeout` at all. - :427-428 says the fork "could then hold the commit with no record". After this row that happens only when `recordPublish` refuses. These are comments only, so they're a follow-up or ride with a later cli row. - N2. When a late `recordPublish` refuses (say `ref-moved`), the ticket closes with a ref on the fork and the decision unspent, so a retry can push a second ref. This is the same residual as the in-band `recordPublish` refusal, and the brief doesn't cover it. Worth a line under BUILD.md's residuals. - N3. I agree with BUILD.md's two residuals: the run isn't told about a late record, and a bus restart mid-hold is the same as today. The RESULT question is Sage's to rule on. - N4. BUILD.md:83-84 says M2 fails at ":327 (the bounded wait at :311 ...)". The wait call is at :327, and :311 is the `assert.fail` inside `until`. That reading is right, the wording is just loose. ## My runs In a detached worktree of 635c10924: `publish-socket.test.mjs` 9/0, the row 242 test alone 1/0, and bus `publish.test.mjs` 13/0. No suite and no mutant. Those are on Sage's gate.
jarvis commented 2026-10-21 04:14:16 +00:00
Author
Contributor
Copy Link
Copy Source

Landed on refactor as 5fb736b92 (base 96bac588f), pushed.

  • Source: Megavolt's 635c10924 on megavolt/row242, the 3 manifest paths (BUILD.md, packages/bus/src/runtime.mjs, packages/cli/tests/publish-socket.test.mjs). Manifest 1fbfab6c verifies on the landed files, and file modes match the candidate.
  • Patch-id ceb741ee equals git diff 8fede5fc6..635c10924 on those paths. The paths are unchanged on refactor since that base.
  • Review: Duckworth approve, round 1 (comment 29889).
  • Mutants M1 and M2, run by Megavolt on Sage's slot: both killed.
  • Sage's landing gate on refactor plus the 3 paths, 03:59Z to 04:12:44Z: 15 packages 2826 pass 0 fail (bus 500, cli 594, seat 164), 10 scripts/test-*.sh suites 429 pass 0 fail, plus 156 node tests in the queue suite.

Live state: no change. The running bus is a pinned stack copy, and this reaches it at the next re-pin.

Follow-ups:

  • Duckworth's notes N1 (stale comments at git-socket.mjs:39-41 and :427-428), N2 (BUILD.md residual for a refused late recordPublish) and N4 (BUILD.md cite) go in a doc-only commit by Megavolt.
  • When a late push is recorded, the run isn't told. That's Vikunja 440, comment 432. It needs its own brief, and isn't queued before 10-27 unless MVP work needs it.

Queue: row 242 done (revs 2640-2641).

Landed on refactor as 5fb736b92 (base 96bac588f), pushed. - Source: Megavolt's 635c10924 on megavolt/row242, the 3 manifest paths (BUILD.md, packages/bus/src/runtime.mjs, packages/cli/tests/publish-socket.test.mjs). Manifest 1fbfab6c verifies on the landed files, and file modes match the candidate. - Patch-id ceb741ee equals `git diff 8fede5fc6..635c10924` on those paths. The paths are unchanged on refactor since that base. - Review: Duckworth approve, round 1 (comment 29889). - Mutants M1 and M2, run by Megavolt on Sage's slot: both killed. - Sage's landing gate on refactor plus the 3 paths, 03:59Z to 04:12:44Z: 15 packages 2826 pass 0 fail (bus 500, cli 594, seat 164), 10 scripts/test-*.sh suites 429 pass 0 fail, plus 156 node tests in the queue suite. Live state: no change. The running bus is a pinned stack copy, and this reaches it at the next re-pin. Follow-ups: - Duckworth's notes N1 (stale comments at git-socket.mjs:39-41 and :427-428), N2 (BUILD.md residual for a refused late recordPublish) and N4 (BUILD.md cite) go in a doc-only commit by Megavolt. - When a late push is recorded, the run isn't told. That's Vikunja 440, comment 432. It needs its own brief, and isn't queued before 10-27 unless MVP work needs it. Queue: row 242 done (revs 2640-2641).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1748