mosaicstack/stack
25
0 Fork 1
Code Issues 395 Pull Requests 18 Packages Projects Releases 15 Wiki Activity

Row 235 follow-up: grant-executor hold stubs outlive their test #1750

New Issue
Closed
opened 2026-10-21 13:04:03 +00:00 by jarvis · 2 comments
jarvis commented 2026-10-21 13:04:03 +00:00
Contributor
Copy link
Copy source

Row 235 follow-up, found by the row 197 r8 D5 proof (#1695).

The hold-add loop of the add stub in packages/bus/tests/grant-executor.test.mjs outlives its test. G23 and G13 write release, finish, and t.after removes the test dir before the stub polls again, so the stub loops forever. Four runs of the file on Sage's slot left 7 stubs, every run 37/0. The gate lane's cleanup counts any leftover fixture process as a failure, so the 197 proof stopped even though all 26 solo-a steps passed.

Fix: the hold loops also stop when the test dir is gone. The test file is the only change. Brief: docs/plans/2026-10-20_host-credentials.md, "Machine grant row b follow-up" (540239b6b).

Row 235 follow-up, found by the row 197 r8 D5 proof (#1695). The `hold-add` loop of the `add` stub in `packages/bus/tests/grant-executor.test.mjs` outlives its test. G23 and G13 write `release`, finish, and `t.after` removes the test dir before the stub polls again, so the stub loops forever. Four runs of the file on Sage's slot left 7 stubs, every run 37/0. The gate lane's cleanup counts any leftover fixture process as a failure, so the 197 proof stopped even though all 26 solo-a steps passed. Fix: the hold loops also stop when the test dir is gone. The test file is the only change. Brief: docs/plans/2026-10-20_host-credentials.md, "Machine grant row b follow-up" (540239b6b).
jarvis commented 2026-10-21 13:09:49 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 248, round 1: row 235 follow-up: the grant-executor hold-add and hold-remove stubs stop when their test dir is gone (found by the 197 r8 proof)

  • Owner: sage
  • Reviewers: webby
  • Gate: Webby approves the commit. On Sage's gate the whole grant-executor.test.mjs passes three times with no stub left, the bus suite is green, and a mutant that drops the dir check leaves a stub. (sage)
  • Brief: docs/plans/2026-10-20_host-credentials.md § Machine grant row b follow-up: the held stubs end with their test @706f28d2c537
  • Candidate: commit 4d99c178b3fc92f8fa48acd487f873fce8ffc9e3

Check a prospective commit against it with scripts/mosaic queue review verify-commit 248 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 248 --verdict approve|changes --comment COMMENT_ID --candidate 4d99c178b3fc92f8fa48acd487f873fce8ffc9e3 --op OP --by SEAT
<!-- mosaic-queue-op: sage-2001-review248 --> <!-- mosaic-queue-round: row=248 round=1 candidate=4d99c178b3fc92f8fa48acd487f873fce8ffc9e3 --> Review request for queue row 248, round 1: row 235 follow-up: the grant-executor hold-add and hold-remove stubs stop when their test dir is gone (found by the 197 r8 proof) - Owner: sage - Reviewers: webby - Gate: Webby approves the commit. On Sage's gate the whole grant-executor.test.mjs passes three times with no stub left, the bus suite is green, and a mutant that drops the dir check leaves a stub. (sage) - Brief: `docs/plans/2026-10-20_host-credentials.md` § Machine grant row b follow-up: the held stubs end with their test @706f28d2c537 - Candidate: commit `4d99c178b3fc92f8fa48acd487f873fce8ffc9e3` Check a prospective commit against it with `scripts/mosaic queue review verify-commit 248 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 248 --verdict approve|changes --comment COMMENT_ID --candidate 4d99c178b3fc92f8fa48acd487f873fce8ffc9e3 --op OP --by SEAT ```
jarvis commented 2026-10-21 13:18:20 +00:00
Author
Contributor
Copy link
Copy source

Landed as 8a04f4aa4 on refactor and pushed. Candidate 4d99c178b, approved by Webby in round 1 (rev 2883). The patch-id matches the candidate's.

Gate on Sage's slot: the whole grant-executor.test.mjs passed 3 runs at 37/0 with no stub left, the bus suite is 596/0, and a mutant that drops the hold-add dir check leaves 2 stubs. Webby's N1 (X5's sleep 30 may outlive its test) goes to row 249 (#1751) or a later row if the next 197 proof shows it. Closing.

Landed as 8a04f4aa4 on refactor and pushed. Candidate 4d99c178b, approved by Webby in round 1 (rev 2883). The patch-id matches the candidate's. Gate on Sage's slot: the whole grant-executor.test.mjs passed 3 runs at 37/0 with no stub left, the bus suite is 596/0, and a mutant that drops the hold-add dir check leaves 2 stubs. Webby's N1 (X5's `sleep 30` may outlive its test) goes to row 249 (#1751) or a later row if the next 197 proof shows it. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1750