mosaicstack/stack
25
0 Fork 1
Code Issues 413 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

Row 243: tests that depend on the gate umask set their file modes (process, proof-cli, sso, stack-instances) #1754

New Issue
Closed
opened 2026-10-21 19:04:29 +00:00 by jarvis · 2 comments
jarvis commented 2026-10-21 19:04:29 +00:00
Contributor
Copy link
Copy source

Row 243 (Morgana, reviewer Webby; brief docs/plans/2026-10-21_gate-env-rows.md, mos-1162).

Four tests passed or failed depending on the gate's umask, because they took file modes from the process umask instead of setting them:

  • packages/bus/tests/process.test.mjs:76 (startup token refusal)
  • packages/webui/tests/proof-cli.test.mjs:30 (proof startup refuses partial flags)
  • packages/webui/tests/sso.test.mjs:360 (11: the CLI refuses --sso)
  • packages/cli/tests/stack-instances.test.mjs (the 0700 config dir check, plus a new umask 077 subtest)

The fix is test-only and sets each mode explicitly. Candidate morgana/row243 137bda3af (code) and 6581f750e (BUILD.md with results). Singles on Sage's slot: base a36523713 at umask 077 failed only the predicted tests, and the candidate passed all four files whole at umask 022 and at umask 077.

Row 243 (Morgana, reviewer Webby; brief docs/plans/2026-10-21_gate-env-rows.md, mos-1162). Four tests passed or failed depending on the gate's umask, because they took file modes from the process umask instead of setting them: - packages/bus/tests/process.test.mjs:76 (startup token refusal) - packages/webui/tests/proof-cli.test.mjs:30 (proof startup refuses partial flags) - packages/webui/tests/sso.test.mjs:360 (11: the CLI refuses --sso) - packages/cli/tests/stack-instances.test.mjs (the 0700 config dir check, plus a new umask 077 subtest) The fix is test-only and sets each mode explicitly. Candidate morgana/row243 137bda3af (code) and 6581f750e (BUILD.md with results). Singles on Sage's slot: base a36523713 at umask 077 failed only the predicted tests, and the candidate passed all four files whole at umask 022 and at umask 077.
jarvis commented 2026-10-21 19:08:07 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 243, round 1: process.test.mjs startup token refusal sets its file mode (chmod), umask sweep of packages/*/tests

  • Owner: morgana
  • Reviewers: webby
  • Gate: Webby approves the manifest. The test file passes whole under umask 022 and under umask 077 on Sage's slot. (sage)
  • Brief: docs/plans/2026-10-21_gate-env-rows.md § The startup token refusal test sets its file mode @e54049c3ba7b
  • Candidate: manifest 2432c4a7dbb64899be5b371e65f301c3abca9f1c30a3f110f4c252f3a74d4fdb

The manifest:

44022c79b616550c4086bac214de346d0c3243fed0e5fb52f7d599148641dab2  agents/morgana/work/queue-243/BUILD.md
2dce337104d6ae5eecda8d1ec93868a941ebd2706acfa62218a54e97336c2db2  packages/bus/tests/process.test.mjs
0f6de0ace037ac1787aecf8c595512374011fb2e84725c93bcd57597011139a1  packages/cli/tests/stack-instances.test.mjs
a1aff7eec4e2f90533bacaf14e2fdeaba3a6a8a87aae700ec6d68e3bd536af73  packages/webui/tests/proof-cli.test.mjs
67f93deb65b14dc213615e5e674fb908a2d13b253c8c0e4b8c0cd5476157a06a  packages/webui/tests/sso.test.mjs

Check a tree against it with scripts/mosaic queue review verify-commit 243 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 243 --verdict approve|changes --comment COMMENT_ID --candidate 2432c4a7dbb64899be5b371e65f301c3abca9f1c30a3f110f4c252f3a74d4fdb --op OP --by SEAT
<!-- mosaic-queue-op: sage-2078a --> <!-- mosaic-queue-round: row=243 round=1 candidate=2432c4a7dbb64899be5b371e65f301c3abca9f1c30a3f110f4c252f3a74d4fdb --> Review request for queue row 243, round 1: process.test.mjs startup token refusal sets its file mode (chmod), umask sweep of packages/*/tests - Owner: morgana - Reviewers: webby - Gate: Webby approves the manifest. The test file passes whole under umask 022 and under umask 077 on Sage's slot. (sage) - Brief: `docs/plans/2026-10-21_gate-env-rows.md` § The startup token refusal test sets its file mode @e54049c3ba7b - Candidate: manifest `2432c4a7dbb64899be5b371e65f301c3abca9f1c30a3f110f4c252f3a74d4fdb` The manifest: ```text 44022c79b616550c4086bac214de346d0c3243fed0e5fb52f7d599148641dab2 agents/morgana/work/queue-243/BUILD.md 2dce337104d6ae5eecda8d1ec93868a941ebd2706acfa62218a54e97336c2db2 packages/bus/tests/process.test.mjs 0f6de0ace037ac1787aecf8c595512374011fb2e84725c93bcd57597011139a1 packages/cli/tests/stack-instances.test.mjs a1aff7eec4e2f90533bacaf14e2fdeaba3a6a8a87aae700ec6d68e3bd536af73 packages/webui/tests/proof-cli.test.mjs 67f93deb65b14dc213615e5e674fb908a2d13b253c8c0e4b8c0cd5476157a06a packages/webui/tests/sso.test.mjs ``` Check a tree against it with `scripts/mosaic queue review verify-commit 243 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 243 --verdict approve|changes --comment COMMENT_ID --candidate 2432c4a7dbb64899be5b371e65f301c3abca9f1c30a3f110f4c252f3a74d4fdb --op OP --by SEAT ```
jarvis commented 2026-10-21 19:13:42 +00:00
Author
Contributor
Copy link
Copy source

Landed on refactor as 6096b051b (on 9a8c8860d), pushed. Patch-id f9d687dd1d41 equals the candidate a36523713..6581f750e; the 5 paths match the candidate in blob and mode. Webby round 1 APPROVE, queue rev 2939. Slot singles (morgana-0041): candidate green on all 4 files whole at umask 022 and 077; base at umask 077 red only on the predicted tests. Queue row 243 done at rev 2941. Test-only, so no live change.

Landed on refactor as 6096b051b (on 9a8c8860d), pushed. Patch-id f9d687dd1d41 equals the candidate a36523713..6581f750e; the 5 paths match the candidate in blob and mode. Webby round 1 APPROVE, queue rev 2939. Slot singles (morgana-0041): candidate green on all 4 files whole at umask 022 and 077; base at umask 077 red only on the predicted tests. Queue row 243 done at rev 2941. Test-only, so no live change.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1754