mosaicstack/stack
25
0 Fork 1
Code Issues 406 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

P2: plugins harness.test row 65 is red on refactor: first-output.mjs and runner.mjs name a harness in core #1855

New Issue
Open
opened 2026-11-06 22:51:26 +00:00 by jason.woltje · 0 comments
jason.woltje commented 2026-11-06 22:51:26 +00:00
Owner
Copy link
Copy source

Summary

packages/plugins/tests/harness.test.mjs "row 65 no core source outside packages/plugins names a harness, apart from the listed exceptions" fails on origin/refactor. Two core harness lines name a harness, and neither is in the test's exception list. The test has been red since these lines landed.

Found while gating the #1852 fix row. It is not part of that row: the failure is identical on base 3598839e6 and on 03072cc08.

The two lines (read at 3598839e6)

  • packages/harness/src/first-output.mjs:42: if (harness !== 'pi') throw new Error('unknown model event stream'); Added in c7ddc7d31 (fix(harness): mark first streamed model output, #797).
  • packages/harness/src/runner.mjs:406: if (!session.proxyFirstTurn || !['pi', 'claude-code'].includes(session.harness) || /[^\n]/.test(s)) markOutput(s); Added in 478df1cac (fix(harness): preserve adapter text output bytes, #797). At 03072cc08 the same line is runner.mjs:412.

Evidence

  • Base 3598839e6: node --test packages/plugins/tests/harness.test.mjs, 8 pass, 1 fail (row 65). Log: /mnt/storage/scratch/tmp/PKGwA7/base-plugins-harness.log
  • Candidate 542dbe030 (same code as 03072cc08) and 3e03e123f: the same single failure, with the same two lines in actual. Logs: /mnt/storage/scratch/tmp/PKGwA7/gate-readers.log and af-readers.log
  • Node v26.12.1.

Effect

The row 65 rule keeps harness-specific behaviour in packages/plugins so core code doesn't branch on a harness name. These two branches put harness knowledge in core: a new harness gets no first-output stream (first-output throws) and gets different output marking in the runner, unless core is edited again. The red test also hides any later violation in the same file set.

Fix direction

Either move the decision into the harness plugin interface (for example, the plugin exports whether it streams model events, and which first-output reader to use), or, if the owner rules that these two are acceptable, add them to the test's listed exceptions with the reason. The test should pass on refactor after the fix.

## Summary `packages/plugins/tests/harness.test.mjs` "row 65 no core source outside packages/plugins names a harness, apart from the listed exceptions" fails on origin/refactor. Two core harness lines name a harness, and neither is in the test's exception list. The test has been red since these lines landed. Found while gating the #1852 fix row. It is not part of that row: the failure is identical on base 3598839e6 and on 03072cc08. ## The two lines (read at 3598839e6) - `packages/harness/src/first-output.mjs:42`: `if (harness !== 'pi') throw new Error('unknown model event stream');` Added in c7ddc7d31 (fix(harness): mark first streamed model output, #797). - `packages/harness/src/runner.mjs:406`: `if (!session.proxyFirstTurn || !['pi', 'claude-code'].includes(session.harness) || /[^\n]/.test(s)) markOutput(s);` Added in 478df1cac (fix(harness): preserve adapter text output bytes, #797). At 03072cc08 the same line is runner.mjs:412. ## Evidence - Base 3598839e6: `node --test packages/plugins/tests/harness.test.mjs`, 8 pass, 1 fail (row 65). Log: /mnt/storage/scratch/tmp/PKGwA7/base-plugins-harness.log - Candidate 542dbe030 (same code as 03072cc08) and 3e03e123f: the same single failure, with the same two lines in `actual`. Logs: /mnt/storage/scratch/tmp/PKGwA7/gate-readers.log and af-readers.log - Node v26.12.1. ## Effect The row 65 rule keeps harness-specific behaviour in packages/plugins so core code doesn't branch on a harness name. These two branches put harness knowledge in core: a new harness gets no first-output stream (first-output throws) and gets different output marking in the runner, unless core is edited again. The red test also hides any later violation in the same file set. ## Fix direction Either move the decision into the harness plugin interface (for example, the plugin exports whether it streams model events, and which first-output reader to use), or, if the owner rules that these two are acceptable, add them to the test's listed exceptions with the reason. The test should pass on refactor after the fix.
jason.woltje added the bug label 2026-11-06 22:51:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1855